crobibero
95ebb9a55a
Use null coalescing when possible
2020-11-13 11:24:46 -07:00
crobibero
5f52a58e78
Convert NullReferenceException to ResourceNotFoundException
2020-11-13 11:14:44 -07:00
crobibero
7bf320922c
Fix nullability errors in Emby.Server.Implementations
2020-11-13 09:41:18 -07:00
Bond_009
51dd3f1e19
Minor improvements
2020-10-17 16:01:36 +02:00
Bond_009
e653eef44f
Fix some warnings
2020-08-31 22:20:19 +02:00
Bond_009
371a09c60b
MemoryStream optimizations
2020-08-09 14:08:55 +02:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
9cec01d8ce
Switch to using declaration
2020-04-14 15:11:21 -04:00
Patrick Barron
0e8f30f64b
Documented BaseApplicationPath constructor parameters
2020-04-14 15:08:20 -04:00
Mark Monteiro
05ab61200a
Do not call UseContentRoot() on the web host builder
...
This call has nothing to do with static web content and should not have ever been called with the web content path: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/?view=aspnetcore-3.1&tabs=windows#content-root
Since this call is removed, the ContentRoot property is also removed from ApplicationHost as it is no longer needed.
Finally, move validation of the static content path to the DashboardService where it is actually used.
2020-03-15 17:42:57 +01:00
Mark Monteiro
547f248a62
Update XML documentation for WebPath
2020-03-15 12:59:34 +01:00
Mark Monteiro
26af5ea45a
Do not set a static content root if the jellyfin-web directory does not exist or is empty
2020-02-25 16:51:36 +01:00
dkanada
67922dff50
Merge pull request #2041 from Bond-009/warn11
...
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond-009
affb58ef9e
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2019-12-10 16:22:03 +01:00
Bond_009
4a0df15bbd
Fix GetTranscodePath function and cache path update logline
...
* GetTranscodePath returned an empty string after the option was left
blank in the web UI
* Unified the log style for all paths
2019-12-04 22:18:37 +01:00
Bond_009
42ffddc269
Fix more warnings
2019-11-27 16:29:56 +01:00
Joshua M. Boniface
48120d01dc
Merge pull request #1991 from Bond-009/transtemp
...
Don't append transcodes to transcoding temp path
2019-11-24 15:13:50 -05:00
Bond-009
b477b3874e
Fix some warnings
2019-11-22 16:15:31 +01:00
Bond-009
d4b438791f
Don't append transcodes to transcoding temp path
2019-11-21 16:57:49 +01:00
Bond_009
3f7836d9eb
Update deps and add MultiThreading analyzer
2019-11-01 17:55:44 +01:00
Bond_009
9d4ce82ab9
Enable TreatWarningsAsErrors
for MediaBrowser.Common and Emby.Photos
...
Adds `#pragma warning disable CS1591` to all files in
MediaBrowser.Common containing undocumented members.
2019-10-09 17:14:15 +02:00
Bond_009
25917db07a
Fix doc releated warnings
2019-08-09 23:50:40 +02:00
Joshua Boniface
3c4043199a
Implement review feedback
2019-03-12 09:18:45 -04:00
Joshua Boniface
132ce3ece1
Add further resources to complete WebPath
2019-03-10 17:04:18 -04:00
Joshua Boniface
93d15cd969
Add configuration flag for Web directory
2019-03-10 16:17:48 -04:00
Bond_009
77a5617774
Removed remaining self-update code
2019-02-18 16:57:08 +01:00
Bond-009
bdfd042d70
Merge branch 'master' into fields
2019-02-16 17:03:15 +01:00
ploughpuff
a2dd2ddd55
Rewrite rules for determining app paths and use XDG_CONFIG_HOME for configDir ( #781 )
...
Re-write rules for determining dataDir, configDir and logDir. Generally, arguments from command line take precedence, then JELLYFIN env vars, before using XDG names.
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
2019-02-13 16:35:14 +01:00
Joshua Boniface
382b8bb509
Use Path.Combine
2019-02-09 19:14:34 -05:00
Joshua Boniface
74d2698c5f
Fix poor handling of cache directories
2019-02-09 18:37:35 -05:00
Bond_009
a6a4cd5667
Removed some unused fields
2019-02-09 15:57:42 +01:00
Bond_009
8af1e93cd4
Make cache dir configurable
2019-02-01 18:13:18 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Erwin de Haan
838541b825
Removed loose whitespace and one .ToArray() call.
2019-01-28 22:21:14 +01:00
Erwin de Haan
1d1d7e8a37
Fixed inlining local-variable artifact.
2019-01-28 22:10:52 +01:00
Erwin de Haan
b9a111432a
Unwrapped all /(Write|Read)All(Text|Bytes)/ functions.
2019-01-28 22:10:50 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
ffe79c8982
Check if file exists instead of catching exceptions
2019-01-27 17:00:17 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
2019-01-13 20:54:44 +01:00
Erwin de Haan
a5288115a8
Visual Studio Reformat: Emby.Server.Implementations Part A-Da
2019-01-13 20:20:16 +01:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009
2850ff7b8a
Make config path configurable
2019-01-05 20:06:22 +01:00
Bond_009
391b48614d
Remove FireEventIfNotNull
...
It's a pretty useless "helper" class
2019-01-05 01:49:52 +03:00
Bond_009
95a5dd8810
Fix log dir
2019-01-02 02:30:59 +03:00
Bond_009
ea4c914123
Fix exception logging
2018-12-30 22:44:39 +01:00
Bond_009
a8fde5e89c
Readded some stuff
2018-12-30 22:44:38 +01:00