Apply suggestions from code review
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
This commit is contained in:
parent
42ffddc269
commit
affb58ef9e
|
@ -351,7 +351,7 @@ namespace Emby.Server.Implementations.AppBase
|
|||
}
|
||||
|
||||
/// <summary>
|
||||
/// Event handler for when a named configuration got updates.
|
||||
/// Event handler for when a named configuration has been updated.
|
||||
/// </summary>
|
||||
/// <param name="key">The key of the configuration.</param>
|
||||
/// <param name="configuration">The old configuration.</param>
|
||||
|
|
|
@ -150,7 +150,7 @@ namespace Emby.Server.Implementations.Configuration
|
|||
}
|
||||
|
||||
/// <summary>
|
||||
/// Sets all config values to the optimal value.
|
||||
/// Sets all configuration values to their optimal values.
|
||||
/// </summary>
|
||||
/// <returns>If the configuration changed.</returns>
|
||||
public bool SetOptimalValues()
|
||||
|
|
|
@ -16,7 +16,7 @@ namespace Emby.Server.Implementations.Data
|
|||
/// <summary>
|
||||
/// Initializes a new instance of the <see cref="BaseSqliteRepository"/> class.
|
||||
/// </summary>
|
||||
/// <param name="logger">The ogger.</param>
|
||||
/// <param name="logger">The logger.</param>
|
||||
protected BaseSqliteRepository(ILogger logger)
|
||||
{
|
||||
Logger = logger;
|
||||
|
|
|
@ -18,7 +18,7 @@ namespace Emby.Server.Implementations.EntryPoints
|
|||
private readonly ILogger _logger;
|
||||
|
||||
/// <summary>
|
||||
/// The _user manager.
|
||||
/// The user manager.
|
||||
/// </summary>
|
||||
private readonly IUserManager _userManager;
|
||||
|
||||
|
|
|
@ -21,22 +21,22 @@ namespace Emby.Server.Implementations.EntryPoints
|
|||
public class ServerEventNotifier : IServerEntryPoint
|
||||
{
|
||||
/// <summary>
|
||||
/// The _user manager.
|
||||
/// The user manager.
|
||||
/// </summary>
|
||||
private readonly IUserManager _userManager;
|
||||
|
||||
/// <summary>
|
||||
/// The _installation manager.
|
||||
/// The installation manager.
|
||||
/// </summary>
|
||||
private readonly IInstallationManager _installationManager;
|
||||
|
||||
/// <summary>
|
||||
/// The _kernel.
|
||||
/// The kernel.
|
||||
/// </summary>
|
||||
private readonly IServerApplicationHost _appHost;
|
||||
|
||||
/// <summary>
|
||||
/// The _task manager.
|
||||
/// The task manager.
|
||||
/// </summary>
|
||||
private readonly ITaskManager _taskManager;
|
||||
|
||||
|
|
|
@ -13,12 +13,12 @@ namespace Emby.Server.Implementations.EntryPoints
|
|||
public class StartupWizard : IServerEntryPoint
|
||||
{
|
||||
/// <summary>
|
||||
/// The _app host.
|
||||
/// The app host.
|
||||
/// </summary>
|
||||
private readonly IServerApplicationHost _appHost;
|
||||
|
||||
/// <summary>
|
||||
/// The _user manager.
|
||||
/// The user manager.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
|
||||
|
|
|
@ -20,7 +20,7 @@ namespace Emby.Server.Implementations.EntryPoints
|
|||
public const int PortNumber = 7359;
|
||||
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
private readonly ISocketFactory _socketFactory;
|
||||
|
|
|
@ -29,7 +29,7 @@ namespace Emby.Server.Implementations.HttpServer
|
|||
public class HttpResultFactory : IHttpResultFactory
|
||||
{
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
private readonly IFileSystem _fileSystem;
|
||||
|
|
|
@ -15,7 +15,7 @@ namespace Emby.Server.Implementations.HttpServer
|
|||
public class StreamWriter : IAsyncStreamWriter, IHasHeaders
|
||||
{
|
||||
/// <summary>
|
||||
/// The _options.
|
||||
/// The options.
|
||||
/// </summary>
|
||||
private readonly IDictionary<string, string> _options = new Dictionary<string, string>();
|
||||
|
||||
|
|
|
@ -24,12 +24,12 @@ namespace Emby.Server.Implementations.HttpServer
|
|||
private readonly ILogger _logger;
|
||||
|
||||
/// <summary>
|
||||
/// The _json serializer.
|
||||
/// The json serializer.
|
||||
/// </summary>
|
||||
private readonly IJsonSerializer _jsonSerializer;
|
||||
|
||||
/// <summary>
|
||||
/// The _socket.
|
||||
/// The socket.
|
||||
/// </summary>
|
||||
private readonly IWebSocket _socket;
|
||||
|
||||
|
@ -78,7 +78,7 @@ namespace Emby.Server.Implementations.HttpServer
|
|||
public event EventHandler<EventArgs> Closed;
|
||||
|
||||
/// <summary>
|
||||
/// Gets or sets the _remote end point.
|
||||
/// Gets or sets the remote end point.
|
||||
/// </summary>
|
||||
public string RemoteEndPoint { get; private set; }
|
||||
|
||||
|
|
|
@ -43,7 +43,7 @@ namespace Emby.Server.Implementations.Library
|
|||
public class UserManager : IUserManager
|
||||
{
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
|
||||
|
|
|
@ -17,12 +17,12 @@ namespace Emby.Server.Implementations.Library.Validators
|
|||
public class ArtistsValidator
|
||||
{
|
||||
/// <summary>
|
||||
/// The _library manager.
|
||||
/// The library manager.
|
||||
/// </summary>
|
||||
private readonly ILibraryManager _libraryManager;
|
||||
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
private readonly IItemRepository _itemRepo;
|
||||
|
|
|
@ -13,13 +13,13 @@ namespace Emby.Server.Implementations.Library.Validators
|
|||
public class GenresValidator
|
||||
{
|
||||
/// <summary>
|
||||
/// The _library manager.
|
||||
/// The library manager.
|
||||
/// </summary>
|
||||
private readonly ILibraryManager _libraryManager;
|
||||
private readonly IItemRepository _itemRepo;
|
||||
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
|
||||
|
|
|
@ -13,7 +13,7 @@ namespace Emby.Server.Implementations.Library.Validators
|
|||
public class MusicGenresPostScanTask : ILibraryPostScanTask
|
||||
{
|
||||
/// <summary>
|
||||
/// The _library manager.
|
||||
/// The library manager.
|
||||
/// </summary>
|
||||
private readonly ILibraryManager _libraryManager;
|
||||
private readonly ILogger _logger;
|
||||
|
|
|
@ -13,12 +13,12 @@ namespace Emby.Server.Implementations.Library.Validators
|
|||
public class MusicGenresValidator
|
||||
{
|
||||
/// <summary>
|
||||
/// The _library manager.
|
||||
/// The library manager.
|
||||
/// </summary>
|
||||
private readonly ILibraryManager _libraryManager;
|
||||
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
private readonly IItemRepository _itemRepo;
|
||||
|
|
|
@ -15,14 +15,14 @@ namespace Emby.Server.Implementations.Library.Validators
|
|||
public class StudiosValidator
|
||||
{
|
||||
/// <summary>
|
||||
/// The _library manager.
|
||||
/// The library manager.
|
||||
/// </summary>
|
||||
private readonly ILibraryManager _libraryManager;
|
||||
|
||||
private readonly IItemRepository _itemRepo;
|
||||
|
||||
/// <summary>
|
||||
/// The _logger.
|
||||
/// The logger.
|
||||
/// </summary>
|
||||
private readonly ILogger _logger;
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user