Commit Graph

746 Commits

Author SHA1 Message Date
Charles Ewert
55b2ee1831
Fix crash in VideoPlayer.brs (#1067)
* ensure vars are valid - fixes crashlog line 49
* don't use optional chaining operators

---------

Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
2023-03-13 16:16:36 -04:00
Charles Ewert
25f03915ff
Remove optional chaining operators from code (#1085)
* remove optional chaining operators + use isValid() + remove extra white space
* address reviewer feedback
2023-03-09 14:35:29 -05:00
Charles Ewert
4590a79758 dont use optional chaining operators 2023-03-05 13:57:32 -05:00
Charles Ewert
0b76f0279a ensure server setting is valid 2023-03-05 13:37:42 -05:00
Charles Ewert
33c3894638 don't use optional chaining operators + address review comments 2023-03-05 08:28:30 -05:00
Charles Ewert
272efb7ad6 ensure vars are valid - fixes crashlog errors line 336 + 339 2023-03-04 13:46:36 -05:00
Charles Ewert
45209b148e ensure vars are valid - fix crashlog error line 56 +121 2023-03-03 20:21:09 -05:00
Charles Ewert
742c60b910 ensure vars are valid - fixes crashlog line 516 2023-03-02 13:33:54 -05:00
Charles Ewert
a39f52cd51 ensure vars are valid - fixes crashlog lines 491 + 495 2023-03-02 13:23:35 -05:00
Charles Ewert
9638d2410e fix typos + ensure vars are valid - fixes crashlog lines 445 + 468 2023-03-02 13:12:25 -05:00
Charles Ewert
9329c857a2 ensure vars are valid - fixes crashlog line 416 + 433 2023-03-02 13:04:06 -05:00
Charles Ewert
49d0f678e3 ensure vars are valid - fixes crashlog line 404 2023-03-02 12:56:51 -05:00
Charles Ewert
230e1d6a19 ensure vars are valid - fixes crashlog line 230 2023-03-02 12:05:36 -05:00
Charles Ewert
b14bdd019a ensure vars are valid - fixes line 370 + 386 crash 2023-03-02 11:57:31 -05:00
1hitsong
57a4a5cf38
Create global audio player (#1024)
* Create global audio player
* Fix crash when pressing back
2023-02-27 18:51:27 -05:00
1hitsong
2eff1401d8
Add Genres, Parental Ratings, and Years as Movie Filters (#928)
* Add Movie Filters
* Add filter names to translations file.
* Only jump up if content is reloaded
2023-02-25 14:51:36 -05:00
1hitsong
a33ce8bd57
Playlist support & TV Shuffle (#986)
* Add TV Episode Shuffle
* Reuse playback info
* Get Subtitle Popup working
* Get Subtitle Popup working
* Get Resume/Restart popup working
* Playlist poster, bug fixes
* Remove commented out code
* Start from beginning if playing queue
* Fix Playback Info issue
* Remove optional chaining to fix formatter
* Fix playlist content list. Code cleanup.
* Remove commented out code
2023-02-25 11:43:36 -05:00
Jinho Kim
45dc9e5fa0
Merge branch 'unstable' into unstable 2023-02-21 12:42:22 -05:00
Jinho Kim
bd5a05563a Custom subtitles added to options
Custom subtitles can be enabled via * > Settings > Playback > Use Custom Subtitles

Fallback font downloaded only if it is enabled in system settings

Cleaned up various code
2023-02-19 13:30:48 -05:00
candry7731
c6a525fe47
Merge branch 'unstable' into Add-Loading-ux-to-movies-details-screen 2023-02-11 12:59:11 -06:00
candry7731
96593813a1 Stop spinner, from continue watching option 2023-02-10 21:57:46 -06:00
1hitsong
083a83a051
Merge pull request #997 from sevenrats/episode-failure
Graceful episode playback failure
2023-02-08 20:40:30 -05:00
sevenrats
fe1f21341c address comments 2023-02-08 19:58:05 -05:00
candry7731
1dcd328ef4 Add user policy to check if canDelete 2023-02-07 15:56:24 -06:00
Jinho Kim
6e5e14444e Optimize parseVTT
Change back to gettofile

Fix default font in captionTask

Update captionTask.brs
2023-02-06 10:18:00 -05:00
candry7731
654c0b8aaf
Merge branch 'Add-Loading-ux-to-movies-details-screen' into candry-loadingux 2023-02-04 21:53:50 -06:00
candry7731
86deedc7c6 Merge branch 'unstable' of https://github.com/jellyfin/jellyfin-roku into Add-Loading-ux-to-movies-details-screen 2023-02-04 21:50:28 -06:00
Jinho Kim
305ac54d8d Fix variable initialization in captionTask 2023-02-04 16:54:05 -05:00
Jinho Kim
1ee4ef8d12 Move font download to Main.brs
Optimize parseVTT performance
2023-02-04 13:07:40 -05:00
Jimi
9d91ea942b Updates based on PR comments. 2023-02-04 07:21:27 -07:00
Jimi
dbf5bc8dcb Allow user to set a max bitrate 2023-02-04 06:54:39 -07:00
Jimi
a6131864f2
Merge branch 'unstable' into feature/jf-allow-unlimited-bitrate 2023-02-04 05:46:50 -07:00
sevenrats
5c22f8a9e5 more spinners 2023-02-04 01:39:09 -05:00
sevenrats
8e6841f1a0 destroy spinner when season load complete 2023-02-04 01:18:32 -05:00
sevenrats
b54b5bdcc4 unbreak details spinners 2023-02-04 01:15:40 -05:00
sevenrats
3b00d3ab28 simpler spinner 2023-02-04 00:26:55 -05:00
candry7731
fef110058a Fix bug, endless spinner for music videos 2023-02-03 13:31:53 -06:00
candry7731
827a5fd406
Merge branch 'unstable' into Add-Loading-ux-to-movies-details-screen 2023-02-02 13:42:19 -06:00
Jinho Kim
09045c32c8 Change subtitle visibility to follow Roku
Subtitle now follows Roku config

Subtitle now updates immediately when changing languages
2023-02-02 01:53:36 -05:00
candry7731
23fe95229c Move progressDialog to sceneManager Fix load bug 2023-02-01 23:20:19 -06:00
candry7731
b61580c77a Merge branch 'unstable' of https://github.com/jellyfin/jellyfin-roku into Add-Loading-ux-to-movies-details-screen 2023-02-01 21:12:29 -06:00
1hitsong
d8bc511640
Merge branch 'unstable' into CreateUnitTestSuite 2023-02-01 18:26:23 -05:00
1hitsong
89eab9f721
Merge pull request #983 from 1hitsong/FixDefaultView
Fix default view setting for movie genres
2023-02-01 08:36:57 -05:00
sevenrats
c0561af6af remove debug prints 2023-01-30 20:24:31 -05:00
sevenrats
a5c0a40ee3 fix invalid ticks and video errorstate 2023-01-30 20:02:00 -05:00
1hitsong
c702694fc7
Merge pull request #922 from ApexArray/fix-distorted-images
Fix distorted TV episode posters. Add client-side progress bar and played indicator.
2023-01-27 08:04:37 -05:00
Jinho Kim
ec1bc7e0a0 Fix playerState
JFVideo updates playerState for captionTask

Moved pkg:/fonts to pkg:/components/fonts
2023-01-26 21:36:11 -05:00
1hitsong
51569b80b1 Fix default view 2023-01-26 19:39:25 -05:00
Jinho Kim
0bee595dc3 Replace global caption with JF video caption 2023-01-26 19:12:52 -05:00
Jimi
686b5a1259 More straightfoward now that it's "maxlimited" instead of "unlimited" 2023-01-25 20:25:22 -07:00
Jimi
af43378a50 PR suggestions 2023-01-25 07:42:24 -07:00
Jimi
a1348f7b1a Allow for unlimited bitrate 2023-01-25 06:44:26 -07:00
1hitsong
0403b75f77
Merge pull request #884 from 1hitsong/improveNowPlayingArtQuality
Improve quality of Album Art on Now Playing view
2023-01-24 08:27:48 -05:00
1hitsong
883f2abd50 Rework Wording 2023-01-08 12:08:53 -05:00
1hitsong
7040f8d20a Update content for release 2023-01-08 11:55:34 -05:00
Jimi
3c850dcab0
Merge pull request #939 from jimdogx/JF-501-Crash-when-watching-inprogress-recording
Don't crash when viewing in progress recording.
2023-01-05 06:36:59 -07:00
Jimi
3b834442cf Avoid excessive logging 2023-01-05 06:31:48 -07:00
1hitsong
6b926bfeb1 Revert formatting by removing optional chaining 2023-01-04 12:22:07 -05:00
Jimi
ac1a77dda5 Formatting 2023-01-04 08:42:35 -07:00
Jimi
e6f96664fd
Update source/VideoPlayer.brs
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
2023-01-04 07:10:45 -07:00
Jimi
181d6aaae5
Update source/VideoPlayer.brs
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
2023-01-04 07:10:23 -07:00
Jimi
4e83b6befc
Update source/VideoPlayer.brs
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
2023-01-04 07:09:57 -07:00
Jimi
f27dcb2c26
Update source/VideoPlayer.brs
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
2023-01-04 07:09:29 -07:00
Jimi
fa55c5a9cf Don't crash when viewing in progress recording. 2023-01-02 15:50:18 -07:00
1hitsong
4efb87b646
Merge branch 'unstable' into FixTVGenres 2023-01-02 09:39:32 -05:00
1hitsong
e634227c2a
Merge pull request #920 from ApexArray/fix-crash-on-empty-contentId
Fix crash on empty contentId
2022-12-31 08:31:23 -05:00
1hitsong
aed417630e
Merge pull request #909 from ApexArray/set-maximum-bitrates
set maximum bitrates according to roku docs
2022-12-31 07:57:29 -05:00
1hitsong
7af27a5488 Update genre view for TV series 2022-12-30 11:59:56 -05:00
Alex Wardle
ced88a81d1 restore imgParams for maxWidth and maxHeight 2022-12-29 16:05:22 -07:00
Alex Wardle
9406003dc0 re-use inputType and lowercase string comparison 2022-12-29 13:28:03 -07:00
1hitsong
4f0ddb0037
Merge branch 'unstable' into WhatsNewPopup 2022-12-29 12:30:56 -05:00
1hitsong
ee3b389c7a
Merge pull request #882 from 1hitsong/ShowUnwatchedCount
Show unwatched count
2022-12-29 08:30:03 -05:00
1hitsong
e7466d2e4a
Merge pull request #877 from 1hitsong/fixEpisodeFocus
Fix TV Episode focus issues
2022-12-29 08:25:07 -05:00
1hitsong
e045d378de
Merge pull request #881 from 1hitsong/musicGenreView
Update music library view & add genre view
2022-12-29 08:24:26 -05:00
1hitsong
c14ca81847
Merge pull request #862 from 1hitsong/GlobalPlayQueue
Create Queue Manager and use for Music
2022-12-29 08:23:56 -05:00
Alex Wardle
887c8305b0 improve check for empty values 2022-12-28 17:51:31 -07:00
Alex Wardle
c0f0a605c1 add isValidAndNotEmpty() function 2022-12-28 17:50:50 -07:00
Alex Wardle
2b6abe947f grab meta.type after validation check 2022-12-28 16:45:52 -07:00
Alex Wardle
d39ec5c31a add client-side progressBar and playedIndicator
render these client side to ensure they fit in custom image size
2022-12-28 13:13:03 -07:00
Alex Wardle
7fe0dbd0d0 fix crash if channel launched with bad arguments 2022-12-28 10:03:21 -07:00
Alex Wardle
77747f5c56 replace <> invalid with isValid() 2022-12-23 10:08:26 -07:00
Alex Wardle
21e00ee812 add check for empty contentId string
fixes crash when launching app via RASP automation tool
2022-12-23 10:06:17 -07:00
ApexArray
cc30b5f429
Merge branch 'jellyfin:unstable' into straight-to-episode-listing-if-one-season 2022-12-23 08:39:28 -07:00
Alex Wardle
234a4a923d remove debug code 2022-12-22 16:39:27 -07:00
Alex Wardle
efe4530917 add user setting: go to straight episode listing 2022-12-22 16:02:13 -07:00
1hitsong
ae0d12f3c6 Add some Misc tests 2022-12-22 09:50:36 -05:00
1hitsong
72ae35423d Add Test Framework 2022-12-22 09:48:45 -05:00
1hitsong
a4962648f3 Create What's New popup
Demo: 
https://social.linux.pizza/@tgpo/109553679336510552
2022-12-21 17:01:44 -05:00
1hitsong
41b1c978f9 Fix resume popup showing twice 2022-12-20 17:39:06 -05:00
Alex Wardle
8568668741 set maximum bitrates according to roku docs 2022-12-18 17:15:10 -07:00
Austin Crandall
8bf3ac56f5
Merge branch 'jellyfin:unstable' into nobadsubs 2022-12-17 11:19:14 -05:00
1hitsong
077b96df9c Add unplayed count to row of seasons 2022-12-14 20:08:52 -05:00
Jimi
84bba357da
Merge branch 'unstable' into nobadsubs 2022-12-13 19:03:30 -07:00
sevenrats
5961f16087 no more bad subs 2022-12-13 20:47:26 -05:00
1hitsong
aa761c0a35 Requests album art at needed size 2022-12-11 15:25:42 -05:00
1hitsong
926a1623f5 Fix dialog appearing twice 2022-12-10 14:27:49 -05:00
1hitsong
233d981c05 Create music genre view 2022-12-10 14:05:55 -05:00
1hitsong
4f4b1d5748 Fix TV Episode focus issues
1. Pressing back on resume dialog on episode list
2. Choosing resume and pressing back from video playback
2022-12-09 20:26:32 -05:00
1hitsong
c79f9471cb Reset focus to buttons
Fixes #682
2022-12-09 18:27:16 -05:00
1hitsong
1b2392bb16 Fix lockup on Additional Parts resume
This will automatically start playback at resume point. Follow up PR will show user resume dialog popup.
2022-12-08 13:33:08 -05:00