Commit Graph

57 Commits

Author SHA1 Message Date
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Bond_009
ea8f40e84a More cleanup 2021-12-27 14:20:05 +00:00
Claus Vium
00f7f68e53
Merge pull request #5648 from OancaAndrei/syncplay-sessions-fix
Fix session references in SyncPlay
2021-09-10 17:44:44 +02:00
dkanada
f6c0db4bb5 merge branch 'master' into syncplay-sessions-fix 2021-09-06 13:42:48 +09:00
dkanada
5e3905d41a merge branch 'master' into syncplay-clear-queue 2021-09-06 13:35:58 +09:00
Bond_009
7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
cvium
608cba817c Reduce some allocations with the magic of spans etc. 2021-04-30 15:09:36 +02:00
Ian Walton
e4691d45f5 Leave SyncPlay group on session disconnect. 2021-04-24 11:32:34 -04:00
Ionut Andrei Oanca
776ce7c660 Send playing item status in SyncPlay group update 2021-03-29 11:29:48 +02:00
Ionut Andrei Oanca
9eb740ba57 Fix storing outdated sessions in SyncPlay 2021-03-28 13:25:40 +02:00
Ionut Andrei Oanca
68969c9530 Clear playlist in SyncPlay group 2021-01-24 01:05:17 +01:00
Joshua M. Boniface
4f6a585424
Merge pull request #4716 from OancaAndrei/syncplay-new-auth-policies 2020-12-13 16:58:28 -05:00
Ionut Andrei Oanca
499f3ee950 Update authorization policies for SyncPlay 2020-12-07 10:33:15 +01:00
Ionut Andrei Oanca
0825ce687d Add SessionControllerConnected event 2020-12-07 01:04:48 +01:00
Ionut Andrei Oanca
cc64ee483d Reorder parameters in HandleRequest 2020-12-04 23:16:15 +01:00
Ionut Andrei Oanca
1f57b594e6 Loosen locking logic in SyncPlayManager 2020-12-04 21:27:25 +01:00
Ionut Andrei Oanca
cbf70e7a03 Change type of PlaylistItemId to Guid 2020-12-04 20:15:16 +01:00
Ionut Andrei Oanca
b7eb4da04e Rename GroupController into Group 2020-12-03 21:01:18 +01:00
cvium
7e0ea296c3 Move request validation to auth policies 2020-12-03 10:43:44 +01:00
Ionut Andrei Oanca
b57ace7888 Address requested changes from review 2020-11-30 10:03:42 +01:00
Ionut Andrei Oanca
78ea8ef99e Create common interface for SyncPlay requests 2020-11-28 16:03:02 +01:00
Ionut Andrei Oanca
c60714e365 Move query parameters to request body in SyncPlay 2020-11-28 14:20:46 +01:00
Joshua M. Boniface
c98c2ab955
Merge branch 'master' into syncplay-enhanced 2020-11-27 09:46:18 -05:00
Greenback
e51ddd326c Fixes spelling. 2020-11-18 13:23:45 +00:00
Ionut Andrei Oanca
9c20701cf6 Correct typos 2020-11-18 13:28:35 +01:00
Ionut Andrei Oanca
426e258f1f Improve locking logic in SyncPlay manager 2020-11-16 20:25:13 +01:00
Ionut Andrei Oanca
a3ca36cb54 Review logging and minor changes in SyncPlay 2020-11-16 20:05:57 +01:00
Ionut Andrei Oanca
c7e53bce2f Patch data-races and minor changes in SyncPlay 2020-11-15 17:30:28 +01:00
Ionut Andrei Oanca
5d77f422f0 Hide some property setters, init null values, update namespaces 2020-11-14 23:40:01 +01:00
Ionut Andrei Oanca
fa69f6fd51 Handle ignore-wait request in waiting state in SyncPlay 2020-11-14 18:09:25 +01:00
Ionut Andrei Oanca
1dbc91978e Address requested changes and fix some warnings 2020-11-14 12:33:54 +01:00
Ionut Andrei Oanca
563a6fb3c7 Minor changes to group-wait in SyncPlay 2020-11-13 20:55:14 +01:00
Ionut Andrei Oanca
019bc19aa4 Minor changes to play queue in Syncplay group 2020-10-22 16:32:15 +02:00
Ionut Andrei Oanca
0c735a0395 Address requested changes by review 2020-10-22 16:12:27 +02:00
Ionut Andrei Oanca
1cabe82b59 Rewrite play queue logic of SyncPlay group 2020-10-22 16:12:27 +02:00
Ionut Andrei Oanca
0b4c751657 Check for null sessions and requests in SyncPlay 2020-10-22 16:12:19 +02:00
BaronGreenback
1b8adf0f7c
Update Emby.Server.Implementations/SyncPlay/GroupController.cs 2020-10-22 13:28:09 +01:00
Ionut Andrei Oanca
36fee4e60a Minor fixes 2020-10-21 16:42:57 +02:00
Ionut Andrei Oanca
93cbf64f88 End comments with a period 2020-10-21 15:46:50 +02:00
Ionut Andrei Oanca
8819a9d478 Add playlist-sync and group-wait to SyncPlay 2020-10-16 12:06:29 +02:00
gion
e10799e0e8 Rewrite syncplay using a state design pattern 2020-10-16 11:38:50 +02:00
gion
5487dfc145 Rename GroupInfoView to GroupInfoDto 2020-10-16 11:25:19 +02:00
Bond_009
e96d41d5ef Fix build 2020-10-04 16:45:00 +02:00
Bond_009
01e781035f Fix warnings 2020-07-24 16:37:54 +02:00
dkanada
bf09bbeacd
update comment
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2020-07-14 08:25:02 +09:00
dkanada
5e706ba7ce keep playstate during syncplay group creation 2020-07-13 06:55:03 +09:00
telans
afc9224ede
fix SA1111 2020-06-15 10:46:43 +12:00
Patrick Barron
42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
crobibero
44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00