Update Invoice Ninja to 5.8.15 (#907)

Co-authored-by: nmfretz <nmfretz@gmail.com>

invoice-ninja/config/nginx.conf

@@ -2,6 +2,8 @@ server {
     listen 80 default_server;
     server_name _;
 
+    server_tokens off;
+
     client_max_body_size 100M;
 
     root /var/www/app/public/;
@@ -14,6 +16,10 @@ server {
     location = /favicon.ico { access_log off; log_not_found off; }
     location = /robots.txt  { access_log off; log_not_found off; }
 
+    location ~* /storage/.*\.php$ {
+        return 503;
+    }
+
     location ~ \.php$ {
         fastcgi_split_path_info ^(.+\.php)(/.+)$;
         fastcgi_pass invoice-ninja_app_1:9000;

invoice-ninja/docker-compose.yml

@@ -14,9 +14,11 @@ services:
     volumes:
       - ${APP_DATA_DIR}/config/nginx.conf:/etc/nginx/conf.d/nginx.conf:ro
       - ${APP_DATA_DIR}/data/public:/var/www/app/public:ro
+    depends_on:
+      - app
 
   app:
-    image: invoiceninja/invoiceninja:5.5.93@sha256:59af42c410467154e6c50322f1d2ab048297b2d01e862f41bc9f1db4829c6086
+    image: invoiceninja/invoiceninja:5.8.15@sha256:59a283bb7fab29d432047264b12066de4f13eae78fb03f8f5126bcbf75c20570
     # We're forced to run user/group 1500
     # More detail here: https://github.com/invoiceninja/dockerfiles/blob/ad3ffc227d63740330f761dad6e8c87768577847/alpine/5/Dockerfile#L70-L80
     user: "1500:1500"
@@ -26,12 +28,16 @@ services:
       - ${APP_DATA_DIR}/data/storage:/var/www/app/storage:rw,delegated
     environment:
       APP_URL: "http://${APP_DOMAIN}"
+      APP_KEY: "${APP_KEY:-unset}"
+      REQUIRE_HTTPS: "false"
       DB_HOST: invoice-ninja_db_1
       DB_DATABASE: invoiceninja
       DB_USERNAME: invoiceninja
       DB_PASSWORD: moneyprintergobrrr
       IN_USER_EMAIL: "admin@example.com"
       IN_PASSWORD: $APP_PASSWORD
+    depends_on:
+      - db
 
   db:
     image: mariadb:10.5.12@sha256:dfcba5641bdbfd7cbf5b07eeed707e6a3672f46823695a0d3aba2e49bbd9b1dd
@@ -43,5 +49,4 @@ services:
       MYSQL_ROOT_PASSWORD: invoiceninja
       MYSQL_USER: invoiceninja
       MYSQL_PASSWORD: moneyprintergobrrr
-      MYSQL_DATABASE: invoiceninja
-
+      MYSQL_DATABASE: invoiceninja

invoice-ninja/exports.sh

@@ -0,0 +1,7 @@
+LARAVEL_APP_KEY_FILE_PATH="$(readlink -f $(dirname "${BASH_SOURCE[0]}"))/data/laravel-app-key.txt"
+
+if [[ -f "${LARAVEL_APP_KEY_FILE_PATH}" ]]; then
+  # we remove newlines/carriage-returns from the output which cause laravel to fail to parse the APP_KEY.
+  # these may be introduced by users accidentally editing the file.
+  export APP_KEY=$(cat "${LARAVEL_APP_KEY_FILE_PATH}" | tr -d '\r\n')
+fi

invoice-ninja/hooks/pre-start

@@ -1,6 +1,9 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
+# We're forced to run user/group 1500
+# More detail here: https://github.com/invoiceninja/dockerfiles/blob/ad3ffc227d63740330f761dad6e8c87768577847/alpine/5/Dockerfile#L70-L80
+# So we set the owner of the data directories to 1500:1500
 APP_DATA_DIR="$(readlink -f $(dirname "${BASH_SOURCE[0]}")/..)/data"
 
 DESIRED_OWNER="1500:1500"
@@ -21,4 +24,15 @@ invoiceninja_correct_permission() {
 }
 
 invoiceninja_correct_permission "${PUBLIC_DATA_DIR}"
-invoiceninja_correct_permission "${STORAGE_DATA_DIR}"
+invoiceninja_correct_permission "${STORAGE_DATA_DIR}"
+
+LARAVEL_APP_KEY_FILE_PATH="${APP_DATA_DIR}/laravel-app-key.txt"
+
+
+# We only generate and save the Laravel APP_KEY if it doesn't exist already
+if [[ ! -f "${LARAVEL_APP_KEY_FILE_PATH}" ]]; then
+	#  generates a laravel APP_KEY using the invoice-ninja container --> php artisan key:generate --show
+	APP_KEY=$("${UMBREL_ROOT}/scripts/app" compose "${APP_ID}" run --rm app php artisan key:generate --show)
+	# we remove the color codes and newlines from the output which cause laravel to fail to parse the APP_KEY
+	echo "${APP_KEY}" | sed 's/\x1b\[[0-9;]*m//g' | tr -d '\r\n' > "${LARAVEL_APP_KEY_FILE_PATH}"
+fi

invoice-ninja/umbrel-app.yml

@@ -2,7 +2,7 @@ manifestVersion: 1.1
 id: invoice-ninja
 category: finance
 name: Invoice Ninja
-version: "v5.5.93"
+version: "v5.8.15"
 tagline: We’ll help with the invoicing
 description: |-
   Invoicing, Quotes, Expenses, Tasks.
@@ -19,6 +19,11 @@ gallery:
 - 2.jpg
 - 3.jpg
 path: ''
+releaseNotes: >-
+  This release takes invoice-ninja from version 5.5.93 to 5.8.15.
+
+
+  Full release notes here: https://github.com/invoiceninja/invoiceninja/releases
 deterministicPassword: true
 defaultUsername: admin@example.com
 submitter: Umbrel