Commit Graph

161 Commits

Author SHA1 Message Date
Bond_009
722120af74 Remove conditions that are always true/false 2019-01-22 23:49:51 +01:00
Andrew Rabert
803bf563d7 Merge pull request #621 from Bond-009/perf
Minor improvements to library scan code
2019-01-20 18:13:49 -05:00
William Taylor
65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Bond_009
35d97dc949 Minor improvements to library scan code 2019-01-20 19:40:37 +01:00
Erwin de Haan
321c440739 Reformat JustAMan review pt1 changes
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan
e566d9a231 Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv 2019-01-13 20:54:44 +01:00
Erwin de Haan
58b582bdcb Visual Studio Reformat: Emby.Server.Implementations Part I-Lib 2019-01-13 20:21:32 +01:00
Joshua M. Boniface
9dcaafe700 Merge pull request #458 from EraYaN/code-cleanup
Clean up several minor issues and add TODOs
2019-01-13 12:14:53 -05:00
Joshua M. Boniface
016bad1ea3 Merge pull request #556 from grafixeyehero/dev
Fix "Password Reset by PIN" page
2019-01-12 13:44:09 -05:00
Erwin de Haan
e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
grafixeyehero
9659decef0 fix the forgotpasswordpin
fix passwordreset.txt print
2019-01-11 01:15:00 +03:00
Erwin de Haan
ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Vasily
73c6a3f29a Merge pull request #409 from Bond-009/fix254
[Fix #254] Fix nullrefexception in SubtitleEncoder
2019-01-06 03:09:12 +03:00
Bond_009
a997bb609f Remove unnecessary using statements 2019-01-05 01:49:52 +03:00
Bond_009
391b48614d Remove FireEventIfNotNull
It's a pretty useless "helper" class
2019-01-05 01:49:52 +03:00
Bond_009
59d8d9a82c Fix nullrefexception in SubtitleEncoder 2019-01-04 18:52:04 +01:00
Bond_009
340a2c6512 Post GPL cleanup 2019-01-03 23:19:02 +01:00
Bond_009
b1ccd6bad9 Fix build post GPL change 2018-12-30 22:44:39 +01:00
Bond_009
ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009
b7ebb67cbb Remove the need for NullLogger 2018-12-30 22:44:38 +01:00
Bond_009
0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Erwin de Haan
9c1c29325d Added extra extension method that create a new instance of the destination object. 2018-12-30 01:25:42 +01:00
Erwin de Haan
de7fcaadb3 Fixed #320 by adding an extension method to BaseItem to make a deep copy of an object. 2018-12-30 01:12:33 +01:00
Bond_009
6e5d2aadaa Remove custom ToArray extension 2018-12-28 16:48:26 +01:00
Andrew Rabert
a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
Bond_009
22093c9e8f Removed some warnings 2018-12-16 00:49:18 +01:00
Joshua Boniface
0f1b043dad Change default user name 2018-12-10 23:40:55 -05:00
Andrew Rabert
7c2248727a Remove Emby.Server.Connect 2018-12-10 19:29:51 -05:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti
d06532c602 update rules for samples 2017-11-27 14:09:51 -05:00
Luke Pulverenti
58a7829ecd update library changed notifier 2017-11-25 23:48:12 -05:00
Luke Pulverenti
4f09c1e06d reduce dlna chatter 2017-11-23 10:46:16 -05:00
Luke Pulverenti
77695f8abe 3.2.40.1 2017-11-21 17:14:56 -05:00
Luke Pulverenti
47d7eaeedb fixes #1225 - Emby creates bogus seasons from subfolderss 2017-11-20 15:08:20 -05:00
Luke Pulverenti
39418b4172 3.2.36.15 2017-11-19 19:20:12 -05:00
Luke Pulverenti
b5ab7776f1 3.2.36.11 2017-11-16 16:25:18 -05:00
Luke Pulverenti
351d29954a 3.2.36.8 2017-11-12 16:05:40 -05:00
Luke Pulverenti
711f588084 3.2.36.7 2017-11-10 16:22:38 -05:00
Luke Pulverenti
5cb7469028 support track selection before playback 2017-11-05 16:51:23 -05:00
Luke Pulverenti
d765f370b3 update librarymanager 2017-11-01 15:56:20 -04:00
Luke Pulverenti
aa83d09fd7 improve search by artists 2017-11-01 15:50:44 -04:00
Luke Pulverenti
47e6530d84 fix file extension being displayed 2017-11-01 15:50:30 -04:00
Luke Pulverenti
0a0303ca64 normalize strm file contents 2017-11-01 15:50:16 -04:00
Luke Pulverenti
ca2e7a4195 deprecate localized guids config switch 2017-10-26 23:49:56 -04:00
Luke Pulverenti
a59ff27605 fix image analysis 2017-10-22 20:43:52 -04:00
Luke Pulverenti
7e5036a587 update image aspect ratio detection 2017-10-22 02:22:43 -04:00
Luke Pulverenti
e7ecd418c4 update home video library support 2017-10-21 12:39:52 -04:00