michael.heier/jellyfin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
25,853 Commits 2 Branches 79 Tags 73 MiB
ed1b880359
Commit Graph

1224 Commits

Author SHA1 Message Date
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009
210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
Shadowghost
bcd992fb06 Merge remote-tracking branch 'upstream/master' into network-rewrite 2022-12-03 12:44:45 +01:00
Cody Robibero
c9f8b8a7c7
Merge pull request #8790 from Bond-009/todo 2022-11-27 07:51:56 -07:00
Bond-009
9c1da522c6
Fix last CA1305 error (#8806) 2022-11-27 06:49:21 -07:00
Bond_009
556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
Bond-009
f369ddf522
Merge pull request #7039 from 1337joe/providermanager-cleanup 2022-11-23 18:24:07 +01:00
Joe Rogers
6252bc399a
Fix unit tests after merge from master 
Co-authored-by: Bond-009 <bond.009@outlook.com>
 2022-11-23 15:59:50 +01:00
Bond-009
a9e2acc9e4
Merge pull request #8666 from dmitrylyzo/fix-secondary-audio 
Fixes https://github.com/jellyfin/jellyfin-web/issues/4044
Fixed https://github.com/jellyfin/jellyfin/issues/8673
 2022-11-13 12:10:52 +01:00
Bond_009
ba3e7027fe Add regression test for #8696 2022-11-05 14:11:49 +01:00
Dmitry Lyzo
c7a9759a76 fix tests 2022-10-31 15:51:06 +03:00
photonconvergence
09e8a7e62c Fix extra type differentiation 
Change rules for Featurettes and Shorts so they don't both get classed as ExtraType.Clip.

Fix test that these changes break
 2022-10-27 18:01:04 -07:00
MrTimscampi
7ad0c9ba24 Migrate MusicBrainz plugin to MetaBrainz.MusicBrainz 
Co-authored-by: crobibero <cody@robibe.ro>
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
 2022-10-22 12:44:44 +02:00
Shadowghost
f6d6f0367b Properly handle IPs with subnetmasks 2022-10-17 15:51:09 +02:00
Bond_009
224bb355dd Rewrite BaseItem.ModifySortChunks 2022-10-12 17:43:01 +02:00
Joe Rogers
2e4db18ebe
Add hearing impaired subtitle stream indicator (#7379) 
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2022-10-07 12:38:05 +02:00
Claus Vium
81b04ddbb5
Merge branch 'master' into providermanager-cleanup 2022-10-07 09:57:16 +02:00
Claus Vium
14027f962c
Merge pull request #6751 from Bond-009/tests12 
Fix DLNA UpdateProfile test
 2022-10-07 09:49:16 +02:00
Shadowghost
7b90fcd053 Merge branch 'master' into network-rewrite 2022-10-07 09:16:02 +02:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method 
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
 2022-10-06 20:21:23 +02:00
Shadowghost
4fc52a840c Merge branch 'master' into network-rewrite 2022-10-01 19:59:00 +02:00
Hannes Braun
4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
dependabot[bot]
266fb2f81c
Bump Microsoft.NET.Test.Sdk from 17.3.1 to 17.3.2 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.1 to 17.3.2.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v17.3.1...v17.3.2)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-09-26 12:01:34 +00:00
Cody Robibero
3716077495 Backport pull request #8433 from jellyfin/release-10.8.z 
Update to dotnet 6.0.9

Original-merge: 4ec82ec662

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
 2022-09-23 23:12:50 -04:00
Cody Robibero
6004060b4e Fix build errors from new warnings 2022-09-09 07:44:14 -06:00
dependabot[bot]
62ef93e2ce Bump xunit from 2.4.1 to 2.4.2 
Bumps [xunit](https://github.com/xunit/xunit) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](https://github.com/xunit/xunit/compare/2.4.1...2.4.2)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-09-09 07:44:12 -06:00
dependabot[bot]
1be9eb13ef
Bump Moq from 4.18.1 to 4.18.2 
Bumps [Moq](https://github.com/moq/moq4) from 4.18.1 to 4.18.2.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.18.1...v4.18.2)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-09-09 10:49:52 +00:00
dependabot[bot]
a0f873692e
Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.3.1 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.2.0 to 17.3.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v17.2.0...v17.3.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-09-05 15:52:18 +00:00
luz paz
9ec2870b10 Fix various typos 
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
 2022-08-15 06:48:34 -04:00
Cody Robibero
010228b3c0 Backport pull request #8234 from jellyfin/release-10.8.z 
update to dotnet 6.0.8

Original-merge: 31f9938e3a

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua Boniface <joshua@boniface.me>
 2022-08-13 21:46:35 -04:00
SenorSmartyPants
de9a350bad Backport pull request #8212 from jellyfin/release-10.8.z 
Add resolution text for 384 sized video

Original-merge: 7ffdde9a0b

Merged-by: Cody Robibero <cody@robibe.ro>

Backported-by: Joshua Boniface <joshua@boniface.me>
 2022-08-13 21:46:34 -04:00
Joshua Boniface
38eefbbafa Backport pull request #8087 from jellyfin/release-10.8.z 
feat: make subtitleeditparser generic

Authored-by: Claus Vium <cvium@users.noreply.github.com>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: 7323ccfc23
 2022-08-01 14:25:42 -04:00
Joshua Boniface
be3d57ad41 Backport pull request #8115 from jellyfin/release-10.8.z 
Update to dotnet 6.0.7

Authored-by: Cody Robibero <cody@robibe.ro>

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Original-merge: d0fd23bb4b
 2022-07-20 19:29:09 -04:00
Joshua Boniface
924b0740b1 Backport pull request #8104 from jellyfin/release-10.8.z 
Add resolution text output for more resolutions

Authored-by: Shadowghost <Ghost_of_Stone@web.de>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: 2b46917dcf
 2022-07-20 19:29:08 -04:00
Shadowghost
2281b8c997 Move away from using Collection, simplify code, add proper ordering 2022-07-20 14:29:30 +02:00
Shadowghost
a492082f4e Apply review suggestions and fix build 2022-07-20 11:47:48 +02:00
Shadowghost
bdb1483167 Add generic IPAddress.Parse tests 2022-07-19 23:42:32 +02:00
Shadowghost
997aa3f1e7 Fix build 2022-07-19 21:53:10 +02:00
Shadowghost
066db8ac7f Migrate NetworkManager and Tests to native .NET IP objects 2022-07-19 21:28:04 +02:00
Bond-009
d771205544 Merge pull request #7988 from jellyfin/external-streams-exceptions 
(cherry picked from commit a71b190142)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-06-29 01:26:38 -04:00
Joshua M. Boniface
3061446c87 Merge pull request #7984 from crobibero/dotnet-6.0.6 
Upgrade to dotnet 6.0.6, update remaining dependencies

(cherry picked from commit 56e7b323de)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-06-29 01:26:36 -04:00
Joshua M. Boniface
fe32b5e333 Merge pull request #7964 from jellyfin/dovi-side-data 
(cherry picked from commit 39d185c7b1)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-06-29 01:26:15 -04:00
Bond-009
a881733377
Merge pull request #7682 from 1337joe/test-preferred-audio-language 2022-06-14 15:23:40 +02:00
Cody Robibero
a7b1132c92 Merge pull request #7842 from crobibero/dependency-backport 
(cherry picked from commit df6c5b6d42)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-06-06 09:20:07 -04:00
Cody Robibero
3a95d4b04e Merge pull request #7802 from jellyfin/external 
(cherry picked from commit 9954cbd550)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-06-06 09:16:11 -04:00
dependabot[bot]
7ac06429d9
Bump Moq from 4.17.2 to 4.18.1 (#7820) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-06-04 00:27:45 +02:00
dependabot[bot]
0f6bd264ae
Bump Microsoft.NET.Test.Sdk from 17.1.0 to 17.2.0 (#7760) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-25 19:06:17 +02:00
dependabot[bot]
08981f3a04
Bump Microsoft.AspNetCore.Mvc.Testing from 6.0.4 to 6.0.5 
Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 6.0.4 to 6.0.5.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v6.0.4...v6.0.5)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-05-24 14:01:43 +00:00
Joshua M. Boniface
f205661b18 Merge pull request #7741 from LewkyB/fix-improperly-labeled-four-digit-episode-numbering 
Fix to allow for episode numbering over 999 in certain scenarios

(cherry picked from commit 3ea67374ae)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-05-20 23:49:38 -04:00
Joshua M. Boniface
bc1a78575a Merge pull request #7766 from crobibero/dotnet-6.0.5 
(cherry picked from commit 71bf567045)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-05-20 23:00:15 -04:00
Joshua M. Boniface
2d8f7b46f1 Merge pull request #7699 from Shadowghost/streambuilder-fix 
(cherry picked from commit b46d61dfdf)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-05-20 18:30:57 -04:00
Bond-009
2b1a915ead Merge pull request #7604 from Jellifi007/fixes-diactritics 
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-05-20 18:30:56 -04:00
Cody Robibero
e263e9c2b1 Merge pull request #7544 from jaantaponen/long-filename-fix 
(cherry picked from commit 8a1eca0913)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-05-20 18:30:56 -04:00
Joe Rogers
644e774040
Fix default audio selection ignoring type 2022-05-17 21:03:51 +02:00
dependabot[bot]
812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 (#7726) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 15:24:09 +02:00
dependabot[bot]
37b87bc231
Bump xunit.runner.visualstudio from 2.4.3 to 2.4.5 (#7727) 
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.4.3 to 2.4.5.
- [Release notes](https://github.com/xunit/visualstudio.xunit/releases)
- [Commits](https://github.com/xunit/visualstudio.xunit/commits)

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 15:23:45 +02:00
Joe Rogers
e89d1a3be5
Add tests for preferred audio language selection 2022-04-30 15:36:09 +02:00
Cody Robibero
e5e7c10b81 Merge pull request #7638 from 1337joe/fix-quick-connect-tests 
(cherry picked from commit 7c91543694)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-04-28 09:26:45 -04:00
Joshua M. Boniface
96d2d2428a Merge pull request #7590 from crobibero/dotnet-6.0.4 
(cherry picked from commit 5778541d2f)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-04-17 15:45:47 -04:00
Cody Robibero
688553b9a8 Merge pull request #7537 from dmitrylyzo/fix-streambuilder 
(cherry picked from commit 5833c70725)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
 2022-04-17 15:45:10 -04:00
Cody Robibero
04cac23a11 Merge pull request #7548 from 1337joe/comparer-null-fix 
(cherry picked from commit 72aca15191)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-04-07 12:54:58 -04:00
Cody Robibero
1960b5bdce Merge pull request #7523 from crobibero/null-stream 
Allow media without streams to playback 

(cherry picked from commit 577325b788)
Signed-off-by: crobibero <cody@robibe.ro>
 2022-04-07 12:54:58 -04:00
Joe Rogers
6bf71c0fd3
Combine verify calls 
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2022-04-03 23:36:33 +02:00
Joe Rogers
b03f56c3d6
Remove warnings 2022-04-03 23:36:32 +02:00
Joe Rogers
ee5bd0daa6
Implement tests on ProviderManager.RefreshSingleItem 2022-04-03 23:36:32 +02:00
Joe Rogers
bdce435b09
Reorder and flatten provider filtering 2022-04-03 23:36:30 +02:00
Joe Rogers
6ab64f4930
Switch to nameof to simplify theory signatures 2022-04-03 23:34:50 +02:00
Joe Rogers
a7c009e2eb
Pass TypeOptions instead of full LibraryOptions 2022-04-03 23:34:49 +02:00
Joe Rogers
d5e2c2fb5e
Implement CanRefreshMetadata tests for GetMetadataProviders 
Cleanup tests, extract common blocks
 2022-04-03 23:34:49 +02:00
Joe Rogers
e7df72de49
Improve metadata provider sorting 
Extract configured order up front instead of for each provider
Non-IHasOrder providers default to middle, not beginning
Merge image and metadata sort helper methods
 2022-04-03 23:34:49 +02:00
Joe Rogers
91e706d387
Implement sort test for ProviderManager.GetMetadataProviders 2022-04-03 23:34:49 +02:00
Joe Rogers
11c7c24f0e
Clarify naming, minor method ordering improvement 2022-04-03 23:34:49 +02:00
Joe Rogers
56900d0fc3
Implement CanRefresh tests for ProviderManager.GetImageProviders 2022-04-03 23:34:48 +02:00
Joe Rogers
8515e8fbd1
Improve image provider sorting 
Remove irrelevant check for ILocalImageProvider
Providers that are not IHasOrder default to middle, not beginning
 2022-04-03 23:34:48 +02:00
Joe Rogers
785cc1bb6e
Implement sort test for ProviderManager.GetImageProviders 2022-04-03 23:34:48 +02:00
dependabot[bot]
dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406 
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases)
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406)

---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-21 12:22:11 +00:00
Bond_009
09e897d372 Clean up DLNA profile code 2022-03-19 00:45:43 +01:00
Cody Robibero
6a567e8c76
Merge pull request #7474 from nielsvanvelzen/api-secure 2022-03-18 16:52:59 -06:00
Niels van Velzen
8a827ba995 Update tests 2022-03-18 22:21:08 +01:00
Bond-009
bb7068cb63
Move StreamBuilderTests to correct project (#7461) 2022-03-18 22:19:02 +01:00
Cody Robibero
e6df698df1
Merge pull request #7325 from eyezak/issue/6450 2022-03-12 09:08:25 -07:00
Cody Robibero
5319f1571f
Merge pull request #7444 from Bond-009/baseurl 2022-03-11 18:42:14 -07:00
Cody Robibero
28223704f3
Merge pull request #7441 from 1337joe/add-external-stream-indicator 
Add label for external audio/sub tracks
 2022-03-11 07:48:23 -07:00
Bond_009
edeb198313 Add tests for BaseUrl normalization 2022-03-11 15:44:16 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid 
Optimize Guid comparisons
 2022-03-11 08:15:12 +01:00
Joe Rogers
1a307db7eb
Add label for external audio/sub tracks 2022-03-10 22:20:35 +01:00
Mayur Panchal
96de01ce01
ProbeResultNormalizer: fix framerate compare + tests (#7167) 2022-03-10 20:55:30 +01:00
Cody Robibero
965bf7332f Update to dotnet 6.0.3 2022-03-08 17:16:33 -07:00
dependabot[bot]
4c4f5dfe81
Bump Moq from 4.17.1 to 4.17.2 (#7416) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-07 14:23:43 +01:00
Cody Robibero
bbd5d11d3b Remove TranscodeReason.None, Add JsonFlagEnum tests 2022-03-06 18:13:54 -07:00
Isaac Gordezky
84a3db6f84 Fix transcode video matching and add tests for Transcode and Safari 2022-03-06 18:13:54 -07:00
Isaac Gordezky
5e779f20ee Series: issue-6450 
Issue: https://github.com/jellyfin/jellyfin/issues/6450

Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
 2022-03-06 18:13:54 -07:00
Isaac Gordezky
d871dded9f Convert TranscodeReason to Flags 2022-03-06 18:13:54 -07:00
Isaac Gordezky
a3057afde8 StreamBuilder basic tests 2022-03-06 18:13:54 -07:00
Joe Rogers
f7118bebfd
Fix external file check for shorter names 2022-03-05 12:39:03 +01:00
Joe Rogers
3205e97e1e
Strip out external file fuzzy matching 
Convert MediaFlagDelimiter back to char
 2022-03-04 10:52:21 +01:00
Claus Vium
136eab9b1e
Merge pull request #7370 from crobibero/internal-metadata-path 
Only add internal files if the internal metadata path exists
 2022-03-04 08:13:58 +01:00
Cody Robibero
1b3e56bae3 Split DirectoryExists and FileExists 2022-03-02 19:55:44 -07:00
Cody Robibero
fc5c6c0404 Use IFileSystem 2022-02-28 17:14:33 -07:00
Joe Rogers
1d367712bb Improve tests 2022-02-28 10:00:23 -07:00
Cody Robibero
40e413d575 Only add internal files if the internal metadata path exists 
Signed-off-by: Cody Robibero <cody@robibe.ro>
 2022-02-28 08:22:52 -07:00
dependabot[bot]
ee24b85f49
Bump Moq from 4.16.1 to 4.17.1 
Bumps [Moq](https://github.com/moq/moq4) from 4.16.1 to 4.17.1.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.16.1...v4.17.1)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-02-28 12:01:22 +00:00
Joshua M. Boniface
e26446f9c0
Merge pull request #7112 from stanionascu/bdiso-playback 2022-02-26 12:53:34 -05:00
Joe Rogers
a9a3f6bf02
Split match/rejected tests, add wider sampling of extensions 2022-02-22 15:13:44 +01:00
Joe Rogers
cf033b25f8
Require delimiter immediately after filename match 2022-02-21 22:27:28 +01:00
Joe Rogers
15053516f8
Rewrite tests for coverage and less duplication 
Address minor warnings
Revert making GetInternalMetadataPath mockable
 2022-02-21 22:25:58 +01:00
Joshua M. Boniface
59040bfa7d
Merge pull request #7255 from Shadowghost/external-sub-audio 2022-02-21 12:42:49 -05:00
Bond_009
f50a250cd9 Optimize Guid comparisons 
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
 2022-02-21 14:15:09 +01:00
dependabot[bot]
06f259001c
Bump Microsoft.NET.Test.Sdk from 17.0.0 to 17.1.0 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.0.0 to 17.1.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v17.0.0...v17.1.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-02-21 12:01:10 +00:00
Stanislav Ionascu
554d1b2ca8 Fix #7100 by catching the exception on opening invalid UDF images 
When an invalid UDF image is opened by the UdfReader, it may throw
and exception. This change is to catch and log the exception.
 2022-02-20 13:30:55 +00:00
Shadowghost
a36e34fbd2 fix(external-media): implement review suggestions 2022-02-18 22:19:33 +01:00
Shadowghost
719b707281 feat(external-media): refactor to generic provider, extend tests and file recognition, consolidate and extend NamingOptions 2022-02-18 22:19:33 +01:00
Joe Rogers
f1878c43a4 feat(external-media): add tests for external audio and subtitle provider 2022-02-18 22:19:33 +01:00
Shadowghost
ca5112f45a feat(external-media): refactor external subtitle and audio provider 2022-02-18 22:19:24 +01:00
Cody Robibero
4ef0099598
Merge pull request #7233 from Bond-009/warn60 2022-02-14 16:57:00 -07:00
Cody Robibero
4acab00963
Merge pull request #7038 from Bond-009/serverdiscovery 2022-02-14 16:56:29 -07:00
Joshua M. Boniface
94b5334da5
Merge pull request #7290 from crobibero/dotnet-6.0.2 2022-02-14 11:01:55 -05:00
Bond_009
dbd7be091d Fix MediaStreamSelector 2022-02-14 15:03:08 +01:00
Bond_009
3cb49d6df0 Fix option to disable server discovery 2022-02-14 14:39:33 +01:00
Bond-009
bb7916767c
Merge pull request #7286 from daullmer/sonarr-thumb 2022-02-09 19:09:53 +01:00
David Ullmer
a00e6ff426
Update tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs 
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2022-02-09 13:39:39 +01:00
Cody Robibero
b98cc71c3b Update to dotnet 6.0.2 
Signed-off-by: Cody Robibero <cody@robibe.ro>
 2022-02-08 17:36:20 -07:00
David Ullmer
fdfcb45c2a Add regression test for #7285 2022-02-08 09:09:33 +01:00
dependabot[bot]
7649391b9d
Bump coverlet.collector from 3.1.1 to 3.1.2 
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

---
updated-dependencies:
- dependency-name: coverlet.collector
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-02-07 12:01:11 +00:00
dependabot[bot]
6af7d5445f
Bump coverlet.collector from 3.1.0 to 3.1.1 (#7266) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-02-01 22:29:41 +01:00
Bond_009
2dcb2f8a9f Ban the usage of Task.Result 
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
 2022-01-22 16:48:31 +01:00
Cody Robibero
34ee6d82fb
Merge pull request #6600 from cvium/keyframe_extraction_v1 2022-01-20 08:54:40 -07:00
Claus Vium
8b36bc0ade
Merge pull request #7203 from 1337joe/fix-resolving-local-alternates 
Fix resolving local alternates
 2022-01-19 14:36:50 +01:00
Bond-009
ef0708d876
Merge pull request #7078 from 1337joe/metadata-merge-data 2022-01-16 23:17:40 +01:00
Joe Rogers
8b706cebef
Add alternate resolver test, generate extra folder names 2022-01-16 23:00:30 +01:00
Joe Rogers
f87e780fb5
Address review comments 
Co-authored-by: Bond-009 <bond.009@outlook.com>
 2022-01-16 13:21:24 +01:00
Joe Rogers
19b9646d72
Add -extra suffix for consistency 2022-01-15 15:43:06 +01:00
Joe Rogers
f11fa59b15
Order rules so directory takes precedence over naming 2022-01-15 15:16:11 +01:00
Claus Vium
70751722d2
Apply suggestions from code review 
Co-authored-by: Cody Robibero <cody@robibe.ro>
 2022-01-14 08:24:15 +01:00
Claus Vium
768b76b999
Apply suggestions from code review 
Co-authored-by: Cody Robibero <cody@robibe.ro>
 2022-01-12 17:27:02 +01:00
cvium
6ffa9539bb Refactor and add scheduled task 2022-01-11 23:30:30 +01:00
dependabot[bot]
88e02c5290
Bump FsCheck.Xunit from 2.16.3 to 2.16.4 
Bumps [FsCheck.Xunit](https://github.com/fsharp/FsCheck) from 2.16.3 to 2.16.4.
- [Release notes](https://github.com/fsharp/FsCheck/releases)
- [Changelog](https://github.com/fscheck/FsCheck/blob/master/FsCheck%20Release%20Notes.md)
- [Commits](https://github.com/fsharp/FsCheck/compare/2.16.3...2.16.4)

---
updated-dependencies:
- dependency-name: FsCheck.Xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-01-10 12:01:16 +00:00
Cody Robibero
9b1965b48a
Merge pull request #7101 from Bond-009/imagejpg 
Remove incorrect mime type image/jpg
 2022-01-08 04:45:58 -07:00
cvium
c658a883a2 Merge branch 'master' into keyframe_extraction_v1 
# Conflicts:
#	Jellyfin.Api/Controllers/DynamicHlsController.cs
#	MediaBrowser.Controller/MediaEncoding/IMediaEncoder.cs
#	MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
 2022-01-07 10:23:22 +01:00
Bond_009
71ebe220f0 Speed up Jellyfin.Naming.Tests 
In my limited testing this saves ~4 seconds, from 19 to 15 seconds (in
        Xunit itself)
 2022-01-04 17:59:30 +01:00
Bond_009
dc222b75c5 Remove incorrect mime type image/jpg 2022-01-04 10:40:16 +01:00
Cody Robibero
c6a1dcf420
Merge pull request #7080 from crobibero/ws-token 2022-01-03 17:48:21 -07:00
Cody Robibero
fcb8ff7c0f
Merge pull request #7052 from crobibero/image.jpeg 2022-01-03 17:47:52 -07:00
Joe Rogers
1dfbeae045
Embed ProviderUtils into MetadataService 2022-01-04 00:44:03 +01:00
Joe Rogers
c81d2e9dec
Remove existing images when applying identify 2022-01-03 23:41:13 +01:00
Joe Rogers
29755c9384
Merge a couple tests, extract duplicate code 2022-01-02 22:24:04 +01:00
Joe Rogers
608a91162a
Add test for #6830 2022-01-02 22:23:47 +01:00
Bond-009
11d0c6827f
Merge pull request #7058 from cvium/the_most_important_feature 2022-01-02 12:31:20 +01:00
Cody Robibero
0765fd568f Use IAuthorizationContext for websocket 2022-01-01 12:34:22 -07:00
cvium
28c2ac9cc0 Remove file extension filter and fix build 2022-01-01 20:07:03 +01:00
Cody Robibero
25abe479eb Add ability to search by - 2021-12-31 08:51:50 -07:00
Joe Rogers
76e640b0b9
Add tests and documentation for ProviderUtils 2021-12-31 00:10:35 +01:00
cvium
2749509f00 Use dedicated resolvers for extras 2021-12-28 00:37:40 +01:00
Cody Robibero
7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Cody Robibero
a615f87680
Merge pull request #7044 from 1337joe/fix-trailers-v2 
Fix trailers v2
 2021-12-25 23:31:46 +00:00
Cody Robibero
6804624c15 Add image/jpg to extension lookup 2021-12-25 11:41:39 -07:00
Joe Rogers
cf29aae690 Add rule to pick up theme videos 2021-12-24 21:21:19 +00:00
Joe Rogers
c0ab54f0bd Fix resolved type for Trailers 2021-12-24 21:21:19 +00:00
Bond_009
cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe 2021-12-24 01:59:25 +00:00
Cody Robibero
00211ca056
Merge pull request #7028 from cvium/everything_went_wrong 2021-12-22 17:57:00 +00:00
cvium
b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
cvium
83a94aa612 Fix extras folders 2021-12-20 12:15:20 +01:00
Cody Robibero
cb41dda5b3
Merge pull request #7015 from Bond-009/zip 2021-12-19 11:32:12 -07:00
Bond_009
a4565da4a9 Use System.IO.Compression instead of SharpCompress for zips 
Also removes unused methods from ZipClient
 2021-12-18 17:52:38 +01:00
Bond_009
968c534864 Return null on division by zero 2021-12-18 14:56:10 +01:00
Bond_009
f8fcbc88fc Add tests for ProbeResultNormalizer.GetFrameRate 2021-12-18 14:56:10 +01:00
Cody Robibero
923720c988
Merge pull request #6956 from cvium/what_could_go_wrong 2021-12-17 07:51:32 -07:00
Joshua M. Boniface
7405450da2
Merge pull request #7002 from crobibero/dotnet-6.0.1 2021-12-15 10:36:18 -05:00
Claus Vium
9a0618552b
Merge branch 'master' into what_could_go_wrong 2021-12-15 08:38:39 +01:00
Claus Vium
4a58582ad5
Merge pull request #6912 from crobibero/filename-tvmaze 
Add additional provider id parsing to file name
 2021-12-15 08:37:34 +01:00
Claus Vium
4c9bd905c6
Merge pull request #6979 from crobibero/baseitemkind 
Use BaseItemKind where possible
 2021-12-15 08:28:44 +01:00
Cody Robibero
5e8aaa68cf Update to dotnet 6.0.1 2021-12-14 23:47:07 -07:00
Cody Robibero
32629cd7da Use BaseItemKind where possible 2021-12-12 06:11:27 -07:00
Cody Robibero
58f788e8ab
Update tests/Jellyfin.Server.Implementations.Tests/Library/PathExtensionsTests.cs 
Co-authored-by: Bond-009 <bond.009@outlook.com>
 2021-12-11 19:43:01 -07:00
Bond_009
7ee96a59d3 Use correct jpeg MIME type 
image/jpg isn't a valid MIME type
 2021-12-12 02:07:35 +01:00
cvium
220443eca1 Simplify StackResolver 2021-12-10 14:23:31 +01:00
Cody Robibero
d707a201c9 update tests 2021-12-09 12:31:32 -07:00
Cody Robibero
593b2fd359 Add more speed and more tests 2021-12-09 08:06:06 -07:00
cvium
6030946d78 Fixes 2021-12-07 19:23:30 +01:00
cvium
fde84a1e00 Refactor extras parsing 2021-12-07 15:24:57 +01:00
Ahmed Rafiq
cf75f99f0e
Update unit test name 
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2021-12-04 21:14:52 +06:00
Ahmed Rafiq
fa6f6515a6
Update unit test name 
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2021-12-04 21:14:16 +06:00
Ahmed Rafiq
6193fdea69 Use MimeTypes package to determine MIME type 
This simplifies the code since we don't have to keep large mappings of extensions and MIME types.

We still keep the ability to override the mappings for:
- filling in entries not present in the package, for e.g. ".azw3"
- picking preferred extensions, for e.g. MimeTypes provides ".conf" as a possible extionsion for "text/plain", and while that is correct, ".txt" would be preferrable
- compatibility reasons
 2021-12-04 20:08:16 +06:00
Bond_009
40be86eec0 Use PostAsJsonAsync where possible 2021-12-01 15:58:23 +01:00
Bond_009
beafd6eaab Use JsonContent where possible 
Should reduce the # of allocated bytes
 2021-12-01 15:40:06 +01:00
Cody Robibero
1df56335ee Add more tests 2021-11-27 16:25:21 -07:00
Joe Rogers
4a20ae6cb4
Allow default/forced tag without setting language 2021-11-27 20:13:21 +01:00
ianjazz246
95183c365a Use local time for RecordingHelperTests 2021-11-23 12:57:05 -08:00
Joe Rogers
9ba7bf96ef
Query MediaSourceManager directly in image providers 
Add doc comments/minor tweaks to AudioImageProvider
 2021-11-18 15:11:50 +01:00
Joe Rogers
bff5ff0cb8
Merge similar tests with Theories 2021-11-18 14:29:22 +01:00
Joe Rogers
7cf5767949
Query media streams by type instead of filtering 2021-11-17 22:34:04 +01:00
Cody Robibero
c32a421ea7
Merge pull request #6851 from cvium/remove_references_to_ilibrarymanager 2021-11-15 15:45:49 -07:00
Cody Robibero
4cfe8fe588
Merge pull request #6831 from 1337joe/image-provider-cleanup 2021-11-15 15:45:33 -07:00
cvium
4f45c52674 Remove ILibraryManager as a dependency in resolvers etc. 2021-11-15 15:56:02 +01:00
Joe Rogers
f059be8e4d
Add logging and fast return 2021-11-15 15:30:43 +01:00
Joe Rogers
58be1d7759
Actually check server disabled metadata providers 2021-11-15 14:47:06 +01:00
Joe Rogers
370b7f8e12
Handle unexpected case more gracefully 2021-11-14 23:13:45 +01:00
Cody Robibero
34df1a030b
Merge pull request #6818 from Bond-009/password 2021-11-13 16:56:25 -07:00
Cody Robibero
4a28f46cac Don't throw exception on unauthenticated requests 2021-11-13 07:27:28 -07:00
Joe Rogers
1d729b2b0f
Use codec to determine image format 2021-11-12 16:30:30 +01:00
Joe Rogers
f73a7a6ed8
Use ImageFormat instead of string for extension 2021-11-12 16:22:11 +01:00
Joe Rogers
de9bf327c6
Merge similar tests with Theories 2021-11-12 13:44:48 +01:00
Bond_009
5265b3eee7 Replace PBKDF2-SHA1 with PBKDF2-SHA512 
This also migrates already created passwords on login

Source for the number of iterations:
https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2
 2021-11-10 22:34:54 +01:00
Claus Vium
c3523e7cf7
Merge pull request #5905 from BaronGreenback/TVFix 
Fix for Livetv and DLNA when bind interfaces specified.
 2021-11-09 19:53:21 +01:00
Claus Vium
c50c9c3dbf
Merge pull request #6794 from Bond-009/dead 
Remove some dead code
 2021-11-09 19:47:34 +01:00
Bond_009
994101fcf4 Remove some dead code 2021-11-09 16:28:39 +01:00
Bond_009
5726535a26 Fix some warnings 
609 left
 2021-11-09 13:14:31 +01:00
Cody Robibero
40045d2147 Update to full dotnet 6 2021-11-08 09:40:12 -07:00
cvium
f03e77a4d5 Merge branch 'master' into TVFix 2021-11-08 10:38:08 +01:00
Bond_009
4dfb7b18ae Add some docs and tests 2021-11-07 22:32:08 +01:00
Joe Rogers
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot 2021-11-06 20:43:20 +01:00
Bond_009
924c6682b9 Remove unused IHasScreenshots interface 2021-11-04 01:06:21 +01:00
Claus Vium
5c5d49ee60
Merge pull request #6763 from 1337joe/tmdb-image-provider-dedup 2021-11-04 00:22:08 +01:00
Bond_009
416894008e Minor improvements 
* Removed some allocations
* Removed some useless abstractions
 2021-11-03 14:02:57 +01:00
Claus Vium
6822693bd6
Merge pull request #6748 from ptalmeida/master 2021-11-03 13:01:53 +01:00
Claus Vium
0187500373
Merge pull request #6761 from Bond-009/startup2 2021-11-03 13:01:37 +01:00
Claus Vium
869d537aaa
Merge pull request #6752 from 1337joe/fix-metadata-refresh-deletes-backgrounds 2021-11-03 13:01:23 +01:00
Joe Rogers
149c77d9b1
Remove commented theory data, merge tests 2021-11-02 22:46:53 +01:00
Joe Rogers
2b283d249f
Switch to method per image conversion 2021-11-02 21:12:13 +01:00
Claus Vium
2c42d75288
Merge pull request #6027 from fredriklindberg/improve-series-matching 2021-11-02 20:17:49 +01:00
Claus Vium
a9c38870f9
Merge pull request #6379 from dearjoey/master 2021-11-02 20:12:42 +01:00
Joe Rogers
7fcf01235c
Change RemoveImages to array, improve download test 2021-11-02 16:16:06 +01:00
Bond_009
104e36f2f9 Streamline startup code 2021-11-02 16:02:52 +01:00
Joe Rogers
4a5e8b99a0
Extract duplicate code, add test 2021-11-01 23:17:00 +01:00
Joe Rogers
6881cf6874
Merge remote-tracking branch 'origin/master' into fix-metadata-refresh-deletes-backgrounds 2021-11-01 16:41:05 +01:00
dependabot[bot]
baafa10e87
Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-11-01 12:00:53 +00:00
Joe Rogers
b478b115e3
Refactor to validate all images up front 2021-11-01 11:53:31 +01:00
Joe Rogers
080b02cc4c
Add comments, minor cleanup, add tests 2021-10-31 23:56:50 +01:00
Cody Robibero
7b89e0e3a5 Fix tests 2021-10-31 11:06:47 -06:00
Claus Vium
39d5bdac96
Change ReadOnlySpan to string following PR 6383 (#6734) 2021-10-26 14:47:34 +02:00
Claus Vium
dc72d90703
Merge pull request #6383 from sushilicious/master 
Made default parser a tiny bit mroe robust
 2021-10-26 12:10:57 +02:00
Claus Vium
8b2309df82
Merge pull request #6535 from Bond-009/dlnacontrollertests 2021-10-25 23:47:37 +02:00
Claus Vium
768ec60e11
Merge pull request #6689 from 1337joe/expand-image-extraction 2021-10-21 23:05:32 +02:00
Joe Rogers
31baea072a
Address review comments 
Clean up style
Fix references in class summaries
Combine Where+FirstOrDefault queries
Break up large method, long lines
Add validation on file extension
Apply test naming conventions
Extract mock of Movie class, comment on why not mocking interface

Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2021-10-20 14:10:16 +02:00
Cody Robibero
2b10251b32 Update to dotnet6.rc2 2021-10-12 18:31:58 -06:00
Joe Rogers
e3eee10d05
Add image provider tests and clean up 2021-10-11 14:09:02 +02:00
Claus Vium
8fc4a48070
Merge pull request #6501 from crobibero/schedules-direct 2021-10-09 23:21:09 +02:00
Claus Vium
e775286de5
Merge pull request #6646 from 1337joe/test-mp4-metadata 2021-10-09 12:48:30 +02:00
Claus Vium
b16e6621b3
Merge pull request #6663 from crobibero/dotnet-6-rc1 
Reference dotnet6-rc1 packages
 2021-10-08 16:06:15 +02:00
Claus Vium
eea2ba9b68
Merge pull request #6678 from Bond-009/random 
Use new Random.Shared instead of creating new instances
 2021-10-08 16:04:23 +02:00
Claus Vium
851a5f3b55
Merge pull request #6665 from Bond-009/tests6 
Improve test coverage for QuickConnectManager
 2021-10-08 15:53:13 +02:00
Cody Robibero
3bbd98cc3f Merge remote-tracking branch 'upstream/master' into schedules-direct 2021-10-08 07:49:40 -06:00
Bond_009
d05062fec0 Use new Random.Shared instead of creating new instances 2021-10-08 15:40:13 +02:00
Bond_009
67147400bf Fix issue #6123 2021-10-05 21:47:59 +02:00
Bond_009
74d75fad46 Improve test coverage for QuickConnectManager 2021-10-05 16:59:11 +02:00
Cody Robibero
017380f1dd Reference dotnet6-rc1 packages 2021-10-04 07:43:40 -06:00
KonH
6cbfdea4c0 Fix warning: Type cast is redundant (#2149) 2021-10-03 11:05:18 +07:00