Commit Graph

1248 Commits

Author SHA1 Message Date
Stepan Goremykin
0870af330d Remove redundant verbatim string prefixes 2023-10-08 00:15:38 +02:00
Bond_009
852f1dc0c1 Don't create non existent persons in LibraryManager.GetPerson
return null instead.

GetStudio, GetGenre, GetMusicGenre, GetYear, GetArtist still create a new one
when the requested one doesn't exist

Fixes #3901
2023-10-05 23:16:17 +02:00
Bond_009
6f2c165cc3 Use Authorization header in integration tests
instead of X-Emby-Authorization

And ensure the response has a successful status code
2023-10-04 16:06:26 +02:00
Bond-009
14b06ecbe2
Merge pull request #10261 from barronpm/ihostlifetime 2023-10-03 11:05:10 +02:00
Bond_009
cc15ea7f65 Ignore .zfs folder
Maybe helps with #10215 ?
2023-09-27 20:35:00 +02:00
Patrick Barron
493de3297a Use IHostLifetime to handle restarting and shutting down 2023-09-23 11:57:38 -04:00
Bond_009
03b6adf068 Fix xUnit1030: Do not call ConfigureAwait in test method 2023-09-18 17:55:52 +02:00
Bond-009
3087881d93
Merge pull request #10056 from Bond-009/nullable2 2023-09-12 11:09:20 +02:00
Lehonti Ramos
bc959270b7
Removed nesting levels through block-scoped using statement (#10025)
Co-authored-by: John Doe <john@doe>
Co-authored-by: Lehonti Ramos <lehonti@ramos>
2023-09-11 12:12:40 +02:00
Cody Robibero
fb8b11276d fix build 2023-09-01 09:35:57 -06:00
Cody Robibero
35a9feaf70 Disable xUnit1028 2023-09-01 09:35:48 -06:00
Nyanmisaka
debbfaa502
Fix MJPEG video is recognized as embedded image (#10173)
fixes 1d729b2

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-08-30 17:19:52 -06:00
Bond_009
d92e9ae85e Enable nullable for more files and add tests
Adds basic tests for FFProbeVideoInfo.CreateDummyChapters
Fixed error message CreateDummyChapters instead of reporting the total minutes it only reported the minute component
2023-08-22 18:11:34 +02:00
Claus Vium
1e2f199ea4
Merge pull request #10053 from christianlegge/date-formats
Add parsing for dates with spaces
2023-08-10 10:16:20 +02:00
Bond_009
084e0bf450 Fix error in test preventing Moq update (#10096) 2023-08-08 14:17:46 +02:00
Bond-009
07727e1d63
Merge pull request #9875 from Shadowghost/fixes 2023-08-01 20:26:21 +02:00
Bond-009
d3c7af0d5c
Fix Jellyfin.Networking.Tests (#10055) 2023-07-29 15:52:26 -06:00
Bond_009
5677566a41 Enable nullable for more files 2023-07-29 21:35:38 +02:00
scatter-dev
14a762b2f1 added test case, fixed regexes 2023-07-28 16:06:55 -04:00
Christoph Landsdorf
48eb6f655b Change: Update parental code count for DE in test 2023-07-20 10:10:02 +00:00
Shadowghost
05d98fe24c Enforce permissions on websocket connections 2023-07-07 08:50:37 +02:00
Bond-009
5b711f38d1
Merge pull request #9958 from Shadowghost/networking-fixex 2023-07-06 19:56:17 +02:00
Bond-009
b95fa294c9
Merge pull request #9799 from Bond-009/genregex 2023-07-06 19:56:00 +02:00
Shadowghost
e56275fb46 Extract networking constants 2023-07-03 22:04:59 +02:00
Shadowghost
9b0e44019a Apply review suggestions 2023-07-02 12:40:49 +02:00
Bond_009
b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
Shadowghost
32499f0e98 Merge branch 'master' into network-rewrite 2023-06-15 17:53:52 +02:00
Cody Robibero
fe9e764af2
Merge pull request #9564 from AmbulantRex/whitelist-dlls 2023-06-10 07:28:37 -06:00
Shadowghost
006b04dc0b Merge branch 'master' into network-rewrite 2023-06-07 08:25:32 +02:00
Cody Robibero
cb788dbd73 Mock configuration to get SqliteCacheSizeKey during test 2023-06-05 16:47:50 -06:00
Shadowghost
c042f20224 Merge branch 'master' into network-rewrite 2023-05-11 15:41:39 +02:00
SenorSmartyPants
11d7c00de9
Fix local JPG primary image for video being overwritten by screen grabber (#9552) 2023-05-10 17:46:55 -06:00
Shadowghost
6cc1203c1b Merge branch 'master' into network-rewrite 2023-05-09 15:25:41 +02:00
AmbulantRex
c717425549 Remove unnecessary type extension and handle feedback. 2023-04-16 18:47:57 -06:00
AmbulantRex
92f50054b2 Add explicit mapping instead of reflection to manifest reconciliation. 2023-04-16 07:46:12 -06:00
AmbulantRex
4a0b135b7a
Merge branch 'jellyfin:master' into whitelist-dlls 2023-04-15 07:11:33 -06:00
Stepan Goremykin
890fe183cf Use default instead of zero for TranscodeReason 2023-04-10 01:44:56 +02:00
AmbulantRex
7dd4201971 Reconcile pre-packaged meta.json against manifest on install 2023-04-09 10:53:09 -06:00
Stepan Goremykin
c051736c80 Inline out variable declaration 2023-04-06 19:21:29 +02:00
Stepan Goremykin
7d7e177265 Remove redundant casts 2023-04-06 19:17:28 +02:00
Stepan Goremykin
26958162d0 Remove unused using directives 2023-04-06 19:17:28 +02:00
AmbulantRex
a944352aa8 Correct style inconsistencies 2023-04-01 04:59:07 -06:00
AmbulantRex
891b9f7a99 Add DLL whitelist support for plugins 2023-03-30 08:59:21 -06:00
Bond_009
8316bd590e Fix #7610 2023-03-27 15:22:21 +02:00
Cody Robibero
89be3aa37f
Convert Person.Type to use PersonKind enum (#9487) 2023-03-25 11:52:02 -06:00
Cody Robibero
dd491ce8ff
Merge pull request #9403 from SenorSmartyPants/ExtraCleanAndNFO
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-20 07:16:03 -06:00
SenorSmartyPants
b9f7e3971e Add test for cleaning extra names 2023-03-18 21:52:04 -05:00
Bond-009
b2461feffb
Merge pull request #9496 from mammo0/fix_file_stacking 2023-03-18 14:17:59 +01:00
Shadowghost
520c07e8ca Merge branch 'master' into network-rewrite 2023-03-16 11:07:22 +01:00
mammo0
0fd46a100b
fixed typo
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-03-15 13:01:39 +01:00
Bond-009
0c6e2e27a8
Merge pull request #9460 from Shadowghost/rating-overhaul 2023-03-15 12:09:59 +01:00
mammo0
90e8aad05d fixed FourSisters test case
The files should be treated as separate movies and should not be stacked, because the parttype is missing.
2023-03-15 11:56:11 +01:00
mammo0
1c57c52474 fixed stacking test cases
Movies should not be stacked if no parttype is given.
2023-03-15 11:54:44 +01:00
nyanmisaka
f21ab50a81 Backport pull request #9422 from jellyfin/release-10.8.z
Fix stream map when using filter_complex with unlabeled output

Original-merge: 6821a2ab35

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: crobibero <cody@robibe.ro>
2023-03-09 19:38:15 -05:00
SenorSmartyPants
04f23a0e73 Change test to allow owned items to run local providers
I need more information about the need for this test, to make sure I am not introducing an issue.
2023-03-09 17:44:12 -06:00
Shadowghost
daefdaf8b0 Extend language code handling 2023-03-09 14:38:20 +01:00
Joe Rogers
361fff3a0c
Fix cases where multiple files are resolved as a single book 2023-03-06 23:27:21 -05:00
Joe Rogers
18b8efa7e0
Add tests for audio book resolving 2023-03-06 23:22:37 -05:00
Joe Rogers
1c3a97bf6a
Inject IDirectoryService where needed instead of passing it through ItemResolveArgs 2023-03-06 23:00:55 -05:00
Joe Rogers
160baa02fd
Remove some BaseItem references to make ItemResolveArgs more usable for testing. 2023-03-06 22:18:26 -05:00
Shadowghost
80b8661008 Merge branch 'master' into network-rewrite 2023-03-03 10:42:24 +01:00
Cody Robibero
4873d2a54d
Fix auth endpoints using api key (#9408) 2023-02-27 05:48:37 -07:00
Cody Robibero
ecb5c48538
Merge pull request #8526 from Shadowghost/rating-overhaul 2023-02-23 07:04:44 -07:00
Bond-009
ccea623c0d
Merge pull request #9365 from Bond-009/friendlyname 2023-02-21 22:43:06 +01:00
Shadowghost
a5bfeb28aa Apply review suggestions 2023-02-20 21:51:15 +01:00
Bond_009
cf29e9a9c5 Fix #7516 2023-02-20 20:33:00 +01:00
Bond-009
5b493e14ac
Improve alternate ordering (#9336) 2023-02-20 08:07:51 -07:00
Shadowghost
c5a363a007 Merge branch 'master' into network-rewrite 2023-02-20 11:58:14 +01:00
Shadowghost
9d21f078c7 Add default rating selections 2023-02-20 11:53:20 +01:00
Shadowghost
ed2280a060 Overhaul content ratings 2023-02-20 11:53:20 +01:00
Bond-009
dd3e74ca0f
Merge pull request #9343 from Lenart12/master 2023-02-19 11:55:29 +01:00
Bond-009
336e08de1e
Merge pull request #9337 from Bond-009/regex 2023-02-18 14:02:47 +01:00
Cody Robibero
a527034ebe
Validate requested user id (#8812) 2023-02-17 23:16:08 +01:00
Lenart Kos
40a1e1924a Add rule and tests to fix #9341
Add an additional EpisodeExpression that matches
`Series title Season 3 Episode 9 - Episode title.avi` correctly.
Fixes #9341
2023-02-17 22:40:54 +01:00
Shadowghost
20fd05b050 Consistently write IP in upercase 2023-02-17 19:27:36 +01:00
Shadowghost
42498194d9 Replace ISocket and UdpSocket, fix DLNA and SSDP binding and discovery 2023-02-17 17:39:11 +01:00
Bond_009
48263078b4 Reduce string allocations by regex 2023-02-17 15:00:06 +01:00
Bond-009
df8346cd63
Merge pull request #9061 from Bond-009/ct 2023-02-16 18:14:38 +01:00
Bond_009
a38cb3ade8 Fix tests 2023-02-16 15:08:04 +01:00
Bond_009
60f41b80f6 Verify ContentType of uploaded images 2023-02-16 15:08:01 +01:00
Shadowghost
3a91c37283 Merge branch 'master' into network-rewrite 2023-02-15 22:40:07 +01:00
Shadowghost
4eba16c672 Apply review suggestions 2023-02-15 22:34:44 +01:00
Bond_009
59920b4052 Make exact match primary video 2023-02-15 18:05:49 +01:00
Bond-009
36b7157589
Fix #9300 (#9312) 2023-02-14 12:08:52 -07:00
cvium
52e2776d8e Merge branch 'master' into simplify_authz
# Conflicts:
#	Jellyfin.Api/Auth/SyncPlayAccessPolicy/SyncPlayAccessHandler.cs
2023-02-12 22:59:48 +01:00
Bond-009
318f11e793
Fix error in XmlTvListingsProviderTests (#9302) 2023-02-12 11:25:54 -07:00
Bond-009
6fb2fac6e4
Always run code analyzers for tests projects (#9304) 2023-02-12 10:54:55 -07:00
Bond-009
5e074ac945
Merge pull request #9253 from Bond-009/nullref 2023-02-12 16:32:00 +01:00
Cody Robibero
32eccc139c LiveTV fixes 2023-02-11 07:46:52 -07:00
cvium
209edd38a4 refactor: simplify authz 2023-02-09 13:51:37 +01:00
Bond_009
eb7fee9590 Add more tests 2023-02-04 21:08:30 +01:00
Bond_009
52230d1c30 Return NotFound when itemId isn't found 2023-02-04 20:11:08 +01:00
Zoltan Csizmadia
e0519189b2
Use Directory.Packages.props (#9135)
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
Claus Vium
9e155eacea
Merge pull request #9227 from Bond-009/ffprobe
Improve ffprobe json parsing and don't log error for Codec Type attachment
2023-02-02 13:05:02 +01:00
Chris Blake
ad5b83781a
Add 404 response to MarkPlayedItem/MarkUnplayedItem (#9211)
Fixes https://github.com/jellyfin/jellyfin/issues/9120
2023-02-01 11:17:18 -07:00
Bond_009
65d605b17d Improve ffprobe json parsing and don't log error for Codec Type attachment 2023-02-01 14:58:04 +01:00
Shadowghost
414eb45899 Merge branch 'master' into network-rewrite 2023-01-24 23:48:47 +01:00
Bond_009
b7f2c8de5b Simplify AlphanumericComparator 2023-01-24 12:47:59 +01:00
Dmitry Lyzo
28b98cacc8 Backport pull request #9051 from jellyfin/release-10.8.z
Fix transcode reasons

Original-merge: 1dea309ae4

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 14:05:37 -05:00
Shadowghost
a728f0993e Merge branch 'master' into network-rewrite 2023-01-20 14:20:56 +01:00
Bond_009
75fe640f2b Revert 'Fix interlace check for H.264 MBAFF coded MP4 files' (#6222) 2023-01-19 14:20:04 +01:00
Shadowghost
656a0bff6f Merge remote-tracking branch 'upstream/master' into network-rewrite 2023-01-19 10:09:32 +01:00
renovate[bot]
e408da4651
chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 (#9117)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Patrick Barron
f8ca71ee15 Move WebHostBuilder extension method to separate file 2023-01-15 15:48:10 -05:00
Patrick Barron
029d53502f Move some startup methods to StartupHelpers 2023-01-15 15:48:07 -05:00
Patrick Barron
74a07f6d1c Move Middleware to Jellyfin.Api 2023-01-15 15:46:50 -05:00
Patrick Barron
663854bc1e
Update test dependencies (#9094) 2023-01-14 13:15:36 -07:00
Patrick Barron
033ffa9a88 Fix tests 2023-01-12 11:51:12 -05:00
Patrick Barron
7b17799b01 Migrate from IWebHost to IHost 2023-01-11 22:07:41 -05:00
Bond-009
81c8890b6d
Fix all warnings in MediaBrowser.MediaEncoding (#9073) 2023-01-11 17:22:01 -07:00
MBR-0001
8af854315e
Add Chinese Bilingual language (#7623)
Closes https://github.com/jellyfin/jellyfin-plugin-opensubtitles/issues/103
2023-01-09 12:47:12 -07:00
Bond-009
769c48c629
Deduplicate media stream ordering code (#9014) 2023-01-07 11:30:55 -07:00
xdo
1f658f59b8
Fix multi cleaning (#8978)
Right now, a movie Name `Iron Man Multi 1080p.mkv` will be searched as
`Iron
Man Multi` leading to no result.

The cleaning regex was containing multi but it looks like a typo joined
`multi` and `subs` in the same term.

Co-authored-by: Xavier-Do <xavier.dolle@gmail.com>
2022-12-29 19:40:24 -07:00
Bond-009
817996da4b
Merge pull request #7494 from Shadowghost/streambuilder-cleanup 2022-12-29 15:21:28 +01:00
Bond_009
7c77ba529c Add more tests 2022-12-27 17:02:23 +01:00
Bond_009
6bf131b270 Use Diacritics.NET
Last time we had to revert this due to regressions, now those regression
tests seem to succeed with a newer version of Diacritics.NET
2022-12-27 16:53:58 +01:00
Shadowghost
ef085483b2 Merge branch 'master' into network-rewrite 2022-12-20 09:19:45 +01:00
Bond-009
3462676a8f
Fix debug builds (#8909) 2022-12-14 22:03:03 +01:00
Shadowghost
b725fbe51a Apply review suggestions 2022-12-13 10:39:37 +01:00
Shadowghost
697efec86e Cleanup and refactor streambuilder 2022-12-07 18:00:01 +01:00
Shadowghost
3f6354cdb8 Fix .NET 7 compatibility 2022-12-07 17:41:32 +01:00
Shadowghost
2c86bd1875 Merge branch 'master' into network-rewrite 2022-12-07 17:40:24 +01:00
Bond_009
227aa0540b Update Microsoft.AspNetCore.Mvc.Testing to 7.0.0 2022-12-07 17:01:28 +01:00
Bond_009
fd9dc1e308 Update deps 2022-12-07 16:56:32 +01:00
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009
210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
Shadowghost
bcd992fb06 Merge remote-tracking branch 'upstream/master' into network-rewrite 2022-12-03 12:44:45 +01:00
Cody Robibero
c9f8b8a7c7
Merge pull request #8790 from Bond-009/todo 2022-11-27 07:51:56 -07:00
Bond-009
9c1da522c6
Fix last CA1305 error (#8806) 2022-11-27 06:49:21 -07:00
Bond_009
556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
Bond-009
f369ddf522
Merge pull request #7039 from 1337joe/providermanager-cleanup 2022-11-23 18:24:07 +01:00
Joe Rogers
6252bc399a
Fix unit tests after merge from master
Co-authored-by: Bond-009 <bond.009@outlook.com>
2022-11-23 15:59:50 +01:00
Bond-009
a9e2acc9e4
Merge pull request #8666 from dmitrylyzo/fix-secondary-audio
Fixes https://github.com/jellyfin/jellyfin-web/issues/4044
Fixed https://github.com/jellyfin/jellyfin/issues/8673
2022-11-13 12:10:52 +01:00
Bond_009
ba3e7027fe Add regression test for #8696 2022-11-05 14:11:49 +01:00
Dmitry Lyzo
c7a9759a76 fix tests 2022-10-31 15:51:06 +03:00
photonconvergence
09e8a7e62c Fix extra type differentiation
Change rules for Featurettes and Shorts so they don't both get classed as ExtraType.Clip.

Fix test that these changes break
2022-10-27 18:01:04 -07:00
MrTimscampi
7ad0c9ba24 Migrate MusicBrainz plugin to MetaBrainz.MusicBrainz
Co-authored-by: crobibero <cody@robibe.ro>
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2022-10-22 12:44:44 +02:00
Shadowghost
f6d6f0367b Properly handle IPs with subnetmasks 2022-10-17 15:51:09 +02:00
Bond_009
224bb355dd Rewrite BaseItem.ModifySortChunks 2022-10-12 17:43:01 +02:00
Joe Rogers
2e4db18ebe
Add hearing impaired subtitle stream indicator (#7379)
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-10-07 12:38:05 +02:00
Claus Vium
81b04ddbb5
Merge branch 'master' into providermanager-cleanup 2022-10-07 09:57:16 +02:00
Claus Vium
14027f962c
Merge pull request #6751 from Bond-009/tests12
Fix DLNA UpdateProfile test
2022-10-07 09:49:16 +02:00
Shadowghost
7b90fcd053 Merge branch 'master' into network-rewrite 2022-10-07 09:16:02 +02:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Shadowghost
4fc52a840c Merge branch 'master' into network-rewrite 2022-10-01 19:59:00 +02:00
Hannes Braun
4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
dependabot[bot]
266fb2f81c
Bump Microsoft.NET.Test.Sdk from 17.3.1 to 17.3.2
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.1 to 17.3.2.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v17.3.1...v17.3.2)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-26 12:01:34 +00:00
Cody Robibero
3716077495 Backport pull request #8433 from jellyfin/release-10.8.z
Update to dotnet 6.0.9

Original-merge: 4ec82ec662

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:12:50 -04:00