gnattu
162ea38a95
Check MaxAudioChannels for directAudioStream candidates ( #12319 )
...
* Check MaxAudioChannels for directAudioStream candidates
The current stream builder logic does not check the channel limit when determining if the audio stream can be directly used, and this can cause some undesired effects:
- A high channel count surround sound stream might be picked even if a stereo one exists when the user requires stereo audio.
- The user's preferred audio codec might not be respected during the downmix because the requested codec is now forced to be the same as the original source.
Signed-off-by: gnattu <gnattuoc@me.com>
* Fix unit test
Signed-off-by: gnattu <gnattuoc@me.com>
* Set correct transcode reason and target channels for unit test
Signed-off-by: gnattu <gnattuoc@me.com>
* Match old stream selection behavior
Signed-off-by: gnattu <gnattuoc@me.com>
* Fix reason matching
Signed-off-by: gnattu <gnattuoc@me.com>
---------
Signed-off-by: gnattu <gnattuoc@me.com>
2024-07-29 00:11:59 +02:00
Cody Robibero
e731250342
Lowercase MediaStreamProtocol for backwards compatibility
2024-03-08 15:29:22 -07:00
Niels van Velzen
407cf5d0bf
Add MediaStreamProtocol enum ( #10153 )
...
* Add MediaStreamProtocol enum
* Add default handling for enum during deserialization
---------
Co-authored-by: Cody Robibero <cody@robibe.ro>
2024-03-04 16:44:54 -07:00
Dmitry Lyzo
e1ba9c0f42
test: drop default flag from second audio track
...
To test more general situation.
Add another HEVC test file with old logic.
2024-02-22 09:38:13 +03:00
Dmitry Lyzo
47b583456a
test: collect candidate audio streams if no audio index is specified
...
To be consistent with the logic of StreamBuilder.
2024-02-22 09:37:59 +03:00
Dmitry Lyzo
07b9c85f14
test: discard webm from test mkvs if there is an unsupported codec ( #10999 )
...
To comply 39088b5ad2ba877283a1
2024-02-12 07:34:26 -07:00
Dmitry Lyzo
ca280279da
test: add more audio tests
2023-12-21 12:45:02 +03:00
Dmitry Lyzo
8c29fa422a
test: fix tizen profile
2023-12-21 12:43:07 +03:00
Dmitry Lyzo
d92f2ac31c
test: fix remux tests
...
This partially reverts commit 2d8f7b46f1
2023-12-21 12:38:58 +03:00
Bond-009
3087881d93
Merge pull request #10056 from Bond-009/nullable2
2023-09-12 11:09:20 +02:00
Lehonti Ramos
bc959270b7
Removed nesting levels through block-scoped using statement ( #10025 )
...
Co-authored-by: John Doe <john@doe>
Co-authored-by: Lehonti Ramos <lehonti@ramos>
2023-09-11 12:12:40 +02:00
Bond_009
5677566a41
Enable nullable for more files
2023-07-29 21:35:38 +02:00
Stepan Goremykin
890fe183cf
Use default instead of zero for TranscodeReason
2023-04-10 01:44:56 +02:00
Stepan Goremykin
7d7e177265
Remove redundant casts
2023-04-06 19:17:28 +02:00
Dmitry Lyzo
28b98cacc8
Backport pull request #9051 from jellyfin/release-10.8.z
...
Fix transcode reasons
Original-merge: 1dea309ae4
2023-01-22 14:05:37 -05:00
Shadowghost
697efec86e
Cleanup and refactor streambuilder
2022-12-07 18:00:01 +01:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Bond_009
556cc8062d
Investigate some TODO comments
2022-11-27 14:13:31 +01:00
Dmitry Lyzo
c7a9759a76
fix tests
2022-10-31 15:51:06 +03:00
Joshua M. Boniface
2d8f7b46f1
Merge pull request #7699 from Shadowghost/streambuilder-fix
...
(cherry picked from commit b46d61dfdf
2022-05-20 18:30:57 -04:00
Cody Robibero
688553b9a8
Merge pull request #7537 from dmitrylyzo/fix-streambuilder
...
(cherry picked from commit 5833c70725
2022-04-17 15:45:10 -04:00
Cody Robibero
1960b5bdce
Merge pull request #7523 from crobibero/null-stream
...
Allow media without streams to playback
(cherry picked from commit 577325b788
2022-04-07 12:54:58 -04:00
Bond-009
bb7068cb63
Move StreamBuilderTests to correct project ( #7461 )
2022-03-18 22:19:02 +01:00
