dkanada
61b9b4046a
Merge pull request #1929 from Narfinger/parser-fix4
...
[Draft][Help wanted] Fix parsing of certain names and adds a default season if no season was found
2019-11-08 02:14:01 +09:00
Andrew Mahone
d73f46dcda
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-07 11:27:55 -05:00
Andrew Mahone
8b2d7062c4
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-07 11:24:30 -05:00
Andrew Mahone
193a1fa474
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-07 11:23:28 -05:00
Narfinger
9cd62d661f
removed restriction to 3 digits in episodenumber and 4 in season numbers
2019-11-07 10:50:02 +09:00
Andrew Mahone
7110069b39
Return list result directly for MediaAttachments.
2019-11-04 10:37:19 -05:00
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
2019-11-04 10:03:18 -05:00
Bond_009
a245f5a0d4
Rewrite hex encoder/decoder
2019-11-01 17:52:29 +01:00
Bond_009
846857b60e
Deserialize with the correct type (and warning fixes)
2019-11-01 17:07:42 +01:00
Bond_009
016be02cd6
More warning fixes
2019-10-29 17:56:05 +01:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Bond-009
24c076eff3
Update Emby.Server.Implementations/Library/UserViewManager.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2019-10-29 17:50:01 +01:00
Andrew Mahone
1513c76a3e
Support MediaAttachment retrieval in MediaSourceManager.
2019-10-22 10:35:00 -04:00
Narfinger
4a20260a27
add another parser case and allow parsing of seasonless
...
Add another parser case and we now allow parsing of seasonless series which hopefully should cover more cases of directory structure
2019-10-22 15:46:35 +09:00
Bond_009
fef35d0505
Add clearer exceptions, warnings and docs
2019-10-20 21:12:03 +02:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond-009
6f17a0b7af
Remove legacy auth code ( #1677 )
...
* Remove legacy auth code
* Adds tests so we don't break PasswordHash (again)
* Clean up interfaces
* Remove duplicate code
* Use auto properties
* static using
* Don't use 'this'
* Fix build
2019-09-17 12:07:15 -04:00
Bond-009
221b831bb2
Reset invalid login counter on successfull login
2019-09-13 17:18:45 +02:00
Joshua Boniface
baa30b41de
Add debug logs and try/catch when creating folder
2019-09-02 23:32:03 -04:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond_009
efc4805233
Fix login
2019-08-28 14:45:46 +02:00
Bond_009
24fac4b191
Fix UserNotFoundError
2019-08-18 20:12:25 +02:00
Bond_009
8d3b5c851d
Improvements to UserManager
2019-08-16 21:06:11 +02:00
Joshua M. Boniface
a96fa7a5c7
Merge pull request #1397 from Bond-009/passfast
...
Streamline authentication proccess
2019-08-10 21:42:46 -04:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Bond_009
ab7ef9c9cb
Fix style issues
2019-07-06 16:15:38 +02:00
Bond_009
0f897589ed
Streamline authentication proccess
2019-07-06 14:52:24 +02:00
dkanada
9e9952d81f
Merge pull request #1247 from bugfixin/master
...
Adjust detection of 'sample' in filenames to use regex boundaries
2019-07-04 11:38:01 -07:00
Bond_009
d961278b3d
Reduce amount of raw sql
2019-06-28 12:14:27 +02:00
Joshua M. Boniface
687255aa31
Merge pull request #1442 from jellyfin/release-10.3.z
...
Backmerge for Release 10.3.4 and 10.3.5
2019-06-12 23:30:57 -04:00
Joshua M. Boniface
2946ae1009
Revert "Don't set a default reset provider"
...
This reverts commit c230d49d7c
.
This reenables an edge case where an admin might want to reset, with
the default auth provider, the password of an externally-provided
user so they could "unlock" the account while it was failing. There
might be minor security implications to this, but the malicious
actor would need FS access to do it (as they would with any password
resets) so it's probably best to keep it as-is.
Removing this in the first place was due to a misunderstanding
anyways so no harm.
2019-06-09 15:29:43 -04:00
Joshua M. Boniface
4b8f735cb8
Remove superfluous conditional
...
This wasn't needed to prevent updating the policy on-disk from my
tests and can be removed as suggested by @Bond-009
2019-06-09 13:57:49 -04:00
Joshua M. Boniface
c230d49d7c
Don't set a default reset provider
2019-06-09 13:46:53 -04:00
Joshua M. Boniface
20e2cb2d86
Use SecurityException for auth failure
2019-06-09 13:45:51 -04:00
Joshua M. Boniface
b70083f3b3
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-06-09 13:41:14 -04:00
Joshua M. Boniface
74ef389879
Add nicer log message and comment
2019-06-09 11:07:35 -04:00
Joshua M. Boniface
d78a55adb4
Implement InvalidAuthProvider
...
Implements the InvalidAuthProvider, which acts as a fallback if a
configured authentication provider, e.g. LDAP, is unavailable due
to a load failure or removal. Until the user or the authentication
plugin is corrected, this will cause users with the missing provider
to be locked out, while throwing errors in the logs about the issue.
Fixes #1445 part 2
2019-06-08 22:54:31 -04:00
Bond-009
a6f9ceedd8
Fix more warnings
2019-06-01 11:31:27 +02:00
DrPandemic
69ee49bee6
Format correctly the PIN when updating it
2019-05-25 13:46:55 -04:00
Bond-009
2d011b781e
Merge pull request #1383 from jellyfin/release-10.3.z
...
Backmerge for Release 10.3.3
2019-05-18 12:56:42 +02:00
DrPandemic
c22068d6b1
Fix pin bug introduced in 10.3.z.
...
The issue is that the new easyPassword format prepends the hash
function. This PR extract the hash from "$SHA1$_hash_".
2019-05-11 19:53:34 -04:00
Bond-009
35d7e97258
Ignore casing photo extensions
2019-05-11 11:55:41 +02:00
bugfixin
1df73fdeba
Fix incorrect hasPassword flag when easy pin set
2019-04-30 19:16:53 +00:00
bugfixin
da842d5a73
Fix incorrect escaping in regex pattern
2019-04-19 18:35:28 +00:00
bugfixin
0794a3edf4
Adjust detection of 'sample' in filenames to use regex boundaries
2019-04-19 17:53:51 +00:00
Joshua Boniface
1af9c047fb
Override username with AuthenticationProvider
...
Pass back the Username directive returned by an AuthenticationProvider
to the calling code, so we may override the user-provided Username
value if the authentication provider passes this back. Useful for
instance in an LDAP scenario where what the user types may not
necessarily be the "username" that is mapped in the system, e.g.
the user providing 'mail' while 'uid' is the "username" value.
Could also then be extensible to other authentication providers
as well, should they wish to do a similar thing.
2019-04-07 19:51:45 -04:00
Joshua Boniface
f0fbd0232c
Correct bad quote characters
2019-03-29 19:13:01 -04:00
LogicalPhallacy
13e94a8b1b
Remove dashes from pins
2019-03-29 12:48:07 -07:00
Phallacy
2d396cb589
adds readonly to properties
2019-03-29 07:10:49 -07:00
Phallacy
b56031b9f3
fix byte string
2019-03-28 20:49:11 -07:00
Phallacy
48b50a22a4
switched to a hexa string with crypto random backing
2019-03-28 08:15:53 -07:00
Phallacy
5e8496bc59
minor fixes and usings
2019-03-27 22:46:25 -07:00
Bond-009
b07c146fd9
Update Emby.Server.Implementations/Library/DefaultPasswordResetProvider.cs
...
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-03-27 16:17:18 -07:00
Phallacy
6be8624373
async improvements and post reset cleanups
2019-03-25 22:17:23 -07:00
LogicalPhallacy
740c95d557
Apply minor suggestions from code review
...
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-03-25 21:40:10 -07:00
Phallacy
86772bd7bd
removes needless dictionary
2019-03-24 12:17:32 -07:00
Claus Vium
4e2841f0d7
Update Emby.Server.Implementations/Library/UserManager.cs
...
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-03-24 11:41:03 -07:00
Phallacy
26fe4040bf
fixes some usings
2019-03-24 11:40:00 -07:00
Phallacy
758e35baba
greaterthen/lessthen reversal fix
2019-03-24 00:30:16 -07:00
Phallacy
09921a00aa
made password resets an interface and per user
2019-03-22 00:01:23 -07:00
Phallacy
80aedcd7e2
really fixed line endings
2019-03-16 21:36:45 -07:00
Phallacy
fc28c9237c
fixed line endings
2019-03-16 21:34:26 -07:00
Phallacy
b04200ca68
adding regex fix
2019-03-16 21:21:14 -07:00
Joshua M. Boniface
e3dbed1c1a
Update Emby.Server.Implementations/Library/UserManager.cs
...
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-03-16 10:16:23 -07:00
Phallacy
7f0fa74467
updated regex to string literal with escaped -
2019-03-16 00:38:31 -07:00
LogicalPhallacy
9df1506794
Merge pull request #2 from LogicalPhallacy/master
...
update lockoutfix to latest for testing
2019-03-16 00:26:12 -07:00
LogicalPhallacy
2d0844b5db
Merge pull request #1 from jellyfin/master
...
merging myself to latest
2019-03-16 00:25:16 -07:00
Phallacy
1ee016c997
configurable user lockout
2019-03-16 00:18:52 -07:00
Phallacy
221389089c
quick fix for auth bug
2019-03-15 21:25:19 -07:00
Bond-009
bf43dc00bb
More warning fixes
2019-03-13 22:32:52 +01:00
Bond_009
37ea50a572
Reduce the amount of exceptions thrown
2019-03-07 21:42:56 +01:00
Bond-009
f486f5966f
Update Emby.Server.Implementations/Library/DefaultAuthenticationProvider.cs
...
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-03-07 09:56:03 -08:00
Bond-009
c31b0b311b
Apply suggestions from code review
...
more minor fixes before I do larger fixes
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-03-07 02:41:44 -08:00
Phallacy
bef665be36
Minor fixes to address style issues
2019-03-05 23:45:05 -08:00
Phallacy
2c26517172
minor style fixes
2019-03-04 23:58:25 -08:00
Phallacy
edba82db37
fixed logic flip in auth empty check and fixed crypto algo choice
2019-02-27 23:05:12 -08:00
Phallacy
098de6b050
made newlines into linux newlines
2019-02-20 01:17:30 -08:00
Phallacy
a0d31a49a0
merging with master to clear merge conflict
2019-02-20 00:46:13 -08:00
Phallacy
6bbb968b57
minor changes and return to netstandard
2019-02-20 00:00:26 -08:00
Joshua M. Boniface
89d4ce309d
Merge pull request #848 from Bond-009/perf
...
Minor changes to reduce allocations
2019-02-19 21:24:51 -05:00
Phallacy
48e7274d37
added justaman notes, fixed new bug from emty has removals
2019-02-18 01:26:01 -08:00
LogicalPhallacy
9f3aa2cead
Apply suggestions from code review
...
Adding minor stylistic suggestions from Bond-009
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-02-18 00:31:03 -08:00
Bond-009
4811e76860
Merge branch 'master' into perf
2019-02-16 17:05:44 +01:00
Bond-009
bdfd042d70
Merge branch 'master' into fields
2019-02-16 17:03:15 +01:00
Claus Vium
21f0a7e020
Make all class implementing dynamically loaded interfaces public
2019-02-15 23:05:14 +01:00
Claus Vium
d8e6808d77
Update Emby.Server.Implementations/Library/DefaultAuthenticationProvider.cs
...
fix to styling
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-02-13 00:44:07 -08:00
Claus Vium
9e58e31de0
Update Emby.Server.Implementations/Library/DefaultAuthenticationProvider.cs
...
fix to styling
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-02-13 00:43:48 -08:00
Phallacy
77602aff88
Minor fixes re:PR870, added null checks from PR876
2019-02-13 00:33:00 -08:00
Phallacy
1ffd443d5a
fixed nul user check to be first per justaman
2019-02-12 22:30:26 -08:00
Bond_009
3e6819c718
Don't clone lists
2019-02-12 21:06:47 +01:00
Bond_009
41fb1e5106
Tuple -> ValueTuple
2019-02-12 21:06:47 +01:00
Bond_009
64d5ec12e2
Use HashSets for increased perf
2019-02-12 21:06:47 +01:00
Phallacy
05bbf71b6d
sha256 with salt auth and sha1 interop
2019-02-12 02:16:03 -08:00
LogicalPhallacy
8bf88f4cb2
Merge pull request #9 from jellyfin/master
...
Yanking in latest changes
2019-02-11 22:48:50 -08:00
Bond_009
a6a4cd5667
Removed some unused fields
2019-02-09 15:57:42 +01:00
Bond_009
70c85925af
Move some arrays to generics
2019-02-06 22:58:12 +01:00
Claus Vium
0ef2b46106
Remove custom Threading
2019-02-05 16:47:50 +01:00
Vasily
0b3e6548db
Merge pull request #797 from Bond-009/warnings
...
Fix all warnings
2019-02-04 14:08:21 +03:00
Joshua M. Boniface
c4f51e16a5
Merge pull request #736 from Bond-009/startasync
...
Start startup tasks async
2019-02-03 22:23:54 -05:00
Joshua M. Boniface
56dcc45dc0
Merge pull request #732 from Bond-009/locale
...
Reworked LocalizationManager to load data async
2019-02-03 22:08:20 -05:00
Bond-009
78e4e2ed92
Fix all warnings
2019-02-02 21:45:29 +01:00
Joshua M. Boniface
c713824bf9
Merge pull request #734 from Bond-009/culture
...
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00
Claus Vium
8985fb8d58
Remove support for games as a media type
2019-01-31 19:04:47 +01:00
Claus Vium
f7a46c7a56
Remove more Connect related stuff
2019-01-31 18:47:50 +01:00
Bond-009
2a1f6361a5
Merge branch 'master' into locale
2019-01-31 18:44:36 +01:00
Phallacy
4519ce26e2
Upgrade crypto provider, retarget better framework
2019-01-31 00:24:53 -08:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Erwin de Haan
b9a111432a
Unwrapped all /(Write|Read)All(Text|Bytes)/ functions.
2019-01-28 22:10:50 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
ffe79c8982
Check if file exists instead of catching exceptions
2019-01-27 17:00:17 +01:00
Bond_009
85a58fd655
Start startup tasks async
2019-01-27 15:40:37 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Bond_009
51edd5d067
Reworked LocalizationManager to load data async
2019-01-27 10:36:05 +01:00
Bond_009
722120af74
Remove conditions that are always true/false
2019-01-22 23:49:51 +01:00
Andrew Rabert
803bf563d7
Merge pull request #621 from Bond-009/perf
...
Minor improvements to library scan code
2019-01-20 18:13:49 -05:00
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Bond_009
35d97dc949
Minor improvements to library scan code
2019-01-20 19:40:37 +01:00
Erwin de Haan
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
2019-01-13 20:54:44 +01:00
Erwin de Haan
58b582bdcb
Visual Studio Reformat: Emby.Server.Implementations Part I-Lib
2019-01-13 20:21:32 +01:00
Joshua M. Boniface
9dcaafe700
Merge pull request #458 from EraYaN/code-cleanup
...
Clean up several minor issues and add TODOs
2019-01-13 12:14:53 -05:00
Joshua M. Boniface
016bad1ea3
Merge pull request #556 from grafixeyehero/dev
...
Fix "Password Reset by PIN" page
2019-01-12 13:44:09 -05:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
grafixeyehero
9659decef0
fix the forgotpasswordpin
...
fix passwordreset.txt print
2019-01-11 01:15:00 +03:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
Vasily
73c6a3f29a
Merge pull request #409 from Bond-009/fix254
...
[Fix #254 ] Fix nullrefexception in SubtitleEncoder
2019-01-06 03:09:12 +03:00
Bond_009
a997bb609f
Remove unnecessary using statements
2019-01-05 01:49:52 +03:00
Bond_009
391b48614d
Remove FireEventIfNotNull
...
It's a pretty useless "helper" class
2019-01-05 01:49:52 +03:00
Bond_009
59d8d9a82c
Fix nullrefexception in SubtitleEncoder
2019-01-04 18:52:04 +01:00
Bond_009
340a2c6512
Post GPL cleanup
2019-01-03 23:19:02 +01:00
Bond_009
b1ccd6bad9
Fix build post GPL change
2018-12-30 22:44:39 +01:00
Bond_009
ea4c914123
Fix exception logging
2018-12-30 22:44:39 +01:00
Bond_009
b7ebb67cbb
Remove the need for NullLogger
2018-12-30 22:44:38 +01:00
Bond_009
0f8b3c6347
Use Microsoft.Extensions.Logging abstraction
2018-12-30 22:44:38 +01:00
Erwin de Haan
9c1c29325d
Added extra extension method that create a new instance of the destination object.
2018-12-30 01:25:42 +01:00
Erwin de Haan
de7fcaadb3
Fixed #320 by adding an extension method to BaseItem to make a deep copy of an object.
2018-12-30 01:12:33 +01:00
Bond_009
6e5d2aadaa
Remove custom ToArray extension
2018-12-28 16:48:26 +01:00
Andrew Rabert
a86b71899e
Add GPL modules
2018-12-27 18:27:57 -05:00
Bond_009
22093c9e8f
Removed some warnings
2018-12-16 00:49:18 +01:00
Joshua Boniface
0f1b043dad
Change default user name
2018-12-10 23:40:55 -05:00
Andrew Rabert
7c2248727a
Remove Emby.Server.Connect
2018-12-10 19:29:51 -05:00
stefan
48facb797e
Update to 3.5.2 and .net core 2.1
2018-09-12 19:26:21 +02:00
Luke Pulverenti
d06532c602
update rules for samples
2017-11-27 14:09:51 -05:00
Luke Pulverenti
58a7829ecd
update library changed notifier
2017-11-25 23:48:12 -05:00