Mark Monteiro
6897a19051
Add missing null check when retrieving extras
2020-03-22 15:09:51 +01:00
dkanada
a96c0a72b8
Merge pull request #2549 from dkanada/refactor
...
Refactor some provider classes
2020-03-18 17:43:15 +09:00
Bond-009
008a76cf4d
Merge pull request #2502 from JustAMan/baseitem-equals
...
Adds BaseItem.Equals method that compares items by their Id
2020-03-11 16:00:36 +01:00
dkanada
52fde64f10
remove unused files and fix some future warnings
2020-03-09 23:30:57 +09:00
Vasily
f4ccee5801
Add inheritdoc comment and squash simple method bodies
2020-03-05 15:03:17 +03:00
Vasily
456f571343
Follow code review suggestions
2020-03-05 14:25:50 +03:00
Vasily
007c5b9f67
Implement BaseItem.GetHashCode override
2020-03-04 13:06:13 +03:00
Vasily
f21cd30039
Lower log level for BaseItem.Equals to debug
2020-03-03 19:22:45 +03:00
Vasily
11abe31e0d
Speed up equality comparison of BaseItem
2020-03-02 12:31:31 +03:00
Vasily
d1670f8180
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
2020-02-27 16:02:18 +03:00
Vasily
8e20d2e931
Simplify AlphanumericComparer, reduce code duplication
2020-02-27 14:51:34 +03:00
Bond_009
bb236b9591
Merge branch 'master' into warn12
2020-01-10 21:18:16 +01:00
Bond_009
2ef4ffd698
More warnings (removed)
2019-12-11 00:13:57 +01:00
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
2019-11-04 10:03:18 -05:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Andrew Mahone
f22ca6dd9e
Retrieve media attachments in BaseItem.
2019-10-22 10:36:54 -04:00
Bond_009
5edb8159a7
Fix Json serialization error
2019-10-15 17:49:49 +02:00
Anthony Lavado
bae5e3795e
Fix SetImage to avoid out of range exception ( #1798 )
...
* Fix SetImage to avoid out of range exception
* Actually use the new images we've retrieved
2019-09-26 09:47:48 -04:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
SL1288
fdc24ec2ee
Fix LocalTrailers playback.
2019-08-19 18:56:41 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Claus Vium
0ef52c739e
Review changes
...
Untested
2019-05-16 07:27:38 +02:00
Claus Vium
b8a09339cd
Enforce extras folder structure according to Emby's wiki
2019-05-02 08:14:00 +02:00
Claus Vium
c1daea0ec7
Change owner and parent id of extras to the main media item
2019-05-01 07:47:22 +02:00
Bond-009
80fb3dc2cb
Fix error
2019-03-08 06:36:00 +01:00
Bond-009
4625592a83
Quick nullref fix
2019-03-07 22:52:41 +01:00
Bond-009
c5fce647de
Cleanup/simplification
...
* Removed useless copies/allocations
* Reduced unneeded complexity
2019-03-07 21:13:13 +01:00
Torsten
2690ac299b
Only refresh metadata if extras changed
2019-02-20 16:39:49 +01:00
Torsten
9753a76905
Populate video extras again
2019-02-19 22:41:25 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
8487319374
Merge pull request #726 from EraYaN/remove-wrappers-for-system-io
...
Clean up IFileSystem wrappers around stdlib.
2019-01-29 16:50:01 +03:00
Erwin de Haan
450f246f95
Unwrapped GetFileNameWithoutExtension
2019-01-28 22:10:51 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Claus Vium
dc68d61491
Fix default aspect ratio
2019-01-28 21:55:44 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Claus Vium
0e617933f6
Change default aspect ratio to 2/3 from 0
2019-01-26 22:19:14 +01:00
Bond_009
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00
hawken
3701ce4037
Eliminate some compile warnings ( #600 )
...
* Remove some unused variables
* remove duplicate "using .." by sorting and deduping the list
* Remove things that already exist in the parent class (in one case I moved some documentation to the parent)
* EntityBodyData and and NextSearch were never set (only read), removed
* _timeout was never read, subsequently _timer became unused. part of a TODO timeout functionality that was not implemented yet
2019-01-24 18:56:43 +01:00
Bond_009
35d97dc949
Minor improvements to library scan code
2019-01-20 19:40:37 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
2019-01-13 21:31:14 +01:00
Erwin de Haan
ba610b5094
Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller
2019-01-13 21:01:16 +01:00
Erwin de Haan
26ca4b607b
Visual Studio Reformat: MediaBrowser.Controller
2019-01-13 20:25:32 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
Bond_009
340a2c6512
Post GPL cleanup
2019-01-03 23:19:02 +01:00
Bond_009
b1ccd6bad9
Fix build post GPL change
2018-12-30 22:44:39 +01:00
