Commit Graph

442 Commits

Author SHA1 Message Date
Cody Robibero
13f46e3fff Shorten lines from review 2023-10-14 10:55:12 -06:00
Stepan Goremykin
8d7e4229ca Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Net/SocketFactory.cs
#	RSSDP/SsdpCommunicationsServer.cs
#	RSSDP/SsdpDeviceLocator.cs
#	RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Cody Robibero
6bd6fb6e0a Merge branch 'master' into chromecast-config
# Conflicts:
#	Emby.Server.Implementations/ApplicationHost.cs
2023-10-10 15:59:34 -06:00
Cody Robibero
2920611ffc Convert string MediaType to enum MediaType 2023-10-10 15:57:15 -06:00
Stepan Goremykin
f84469d500 Remove redundant using directives 2023-10-08 00:50:02 +02:00
Stepan Goremykin
8ea812b65d Reduce string literal length by using verbatim string 2023-10-08 00:26:12 +02:00
Bond-009
b87765bace
Update Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
Co-authored-by: Patrick Barron <barronpm@gmail.com>
2023-10-05 18:21:43 +02:00
Bond_009
76c64516a7 Simplify some stuff in AuthorizationContext 2023-10-04 16:18:14 +02:00
Patrick Barron
1ca9f8b04b Remove unused fields and parameters 2023-10-03 09:26:20 -04:00
Cody Robibero
bc88c96cbe Validate cast receiver id on get/set 2023-09-23 16:14:03 -06:00
Cody Robibero
ba7e3bfd82 Migrate to customizable cast receiver config 2023-09-23 11:04:53 -06:00
Nick
f97e844c4f Minor code review changes (cvium) 2023-09-04 13:14:45 -07:00
Nick
5a860710a8 Make TrickplayManifest dictionary key a string rather than Guid 2023-09-04 12:30:20 -07:00
Bond_009
a963bce9be Reduce log spam on failed logins
Failed logins already get logged higher up the call chain
2023-08-21 19:09:32 +02:00
Shadowghost
4bb17039d7 Apply review suggestions 2023-07-29 13:50:55 +02:00
Shadowghost
a0d13a2418 Apply suggestions from code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-07-07 08:50:37 +02:00
Shadowghost
46a6755e65 Add item id to playback start/stop events 2023-07-07 08:50:37 +02:00
Shadowghost
958f8f71e8 Add wrapper object for authentication event information 2023-07-07 08:50:37 +02:00
Nick
0e1ae2def2 Add CreateTiles to ITrickplayManager 2023-07-01 16:16:41 -07:00
Bond_009
b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
Nick
ab20ceaad6 Migrate to trickplay table to EF. Rename vars/methods/members to have consistent use of tile and thumbnail 2023-06-26 17:40:10 -07:00
Cody Robibero
d8f0933f33
Merge pull request #9821 from cvium/admin_must_have_pw 2023-05-29 18:38:01 -06:00
cvium
57d8452e2a refactor: admin users must have a non-empty password 2023-05-26 19:52:27 +02:00
cvium
3bdef7207c chore: add db migrations 2023-05-26 19:45:53 +02:00
cvium
716bcc6410 chore: deprecate EasyPassword as it isn't very secure 2023-05-26 19:40:40 +02:00
Stepan Goremykin
26958162d0 Remove unused using directives 2023-04-06 19:17:28 +02:00
Bond_009
48263078b4 Reduce string allocations by regex 2023-02-17 15:00:06 +01:00
Shadowghost
b7418d6e9e Add permission for collection management 2023-02-13 15:42:04 +01:00
Bond-009
5e074ac945
Merge pull request #9253 from Bond-009/nullref 2023-02-12 16:32:00 +01:00
Bond-009
f5417c50f7
Merge pull request #9139 from Jpuc1143/tag-whitelist 2023-02-11 23:52:09 +01:00
Bond_009
52230d1c30 Return NotFound when itemId isn't found 2023-02-04 20:11:08 +01:00
Zoltan Csizmadia
e0519189b2
Use Directory.Packages.props (#9135)
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
renovate[bot]
4b134cac49
chore(deps): update dependency efcoresecondlevelcacheinterceptor to v3.8.3 (#9243)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-02-03 14:53:22 +01:00
Jpuc1143
7fa6d4c81e
Add "Allowed Tags" to Parental Controls 2023-01-20 16:43:59 -03:00
renovate[bot]
e408da4651
chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 (#9117)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Patrick Barron
f3e5139cfc Use default ASP.NET Core logger factory for DbContext factory 2023-01-16 18:15:05 -05:00
Patrick Barron
8479f0f90c Rename JellyfinDb to JellyfinDbContext 2023-01-16 12:14:44 -05:00
Patrick Barron
3f66a48206 Document JellyfinDb 2023-01-16 12:13:06 -05:00
Patrick Barron
40e4370689 Specify AsSplitQuery in initial users query 2023-01-16 11:52:53 -05:00
Patrick Barron
f07553abdf Optimize EF Core queries and remove unnecessary AsQueryable calls 2023-01-16 11:49:59 -05:00
Patrick Barron
ab6baf6486 Enable nullable for Jellyfin DbContext 2023-01-16 10:28:31 -05:00
Patrick Barron
2a86723caf Use file-scoped namespace in db context 2023-01-16 10:06:25 -05:00
Patrick Barron
921618368b Remove unused schema 2023-01-16 10:05:36 -05:00
Bond_009
6dbdb4e9af Fix all warnings in Jellyfin.Server.Implementations 2023-01-11 09:55:05 +01:00
renovate[bot]
7516e61c5b
chore(deps): update dotnet monorepo to v7.0.2 2023-01-10 14:50:35 +00:00
renovate[bot]
6806b983dc
chore(deps): update dependency efcoresecondlevelcacheinterceptor to v3.8.2 2023-01-10 10:55:54 +00:00
Cody Robibero
678bcf9a80
Use EventManager for AuthenticationSuccess, AuthenticationFailure (#8960) 2023-01-07 11:31:10 -07:00
renovate[bot]
02f9e60e7c
chore(deps): update dotnet monorepo to v7.0.1 (#8900)
* chore(deps): update dotnet monorepo to v7.0.1

* Update docker sdk

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-12-15 20:13:11 -07:00
renovate[bot]
42f768faf3
chore(deps): update dependency efcoresecondlevelcacheinterceptor to v3.8.1 (#8881)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-12-09 21:21:11 -07:00
Bond_009
fd9dc1e308 Update deps 2022-12-07 16:56:32 +01:00
Bond_009
b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009
210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
renovate[bot]
036382debb
chore(deps): update dependency efcoresecondlevelcacheinterceptor to v3.8.0 (#8805)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-11-27 08:52:43 -07:00
renovate[bot]
8fb5a1a12f
chore(deps): update dependency efcoresecondlevelcacheinterceptor to v3.7.5 2022-11-23 17:24:37 +00:00
Bond-009
6655cf4e58
Merge pull request #8601 from cvium/add_secondlevelcaching 2022-11-13 12:22:08 +01:00
renovate[bot]
42399dde9c
chore(deps): update dotnet monorepo (#8708)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-11-09 19:09:09 -07:00
cvium
a64acac799 Backport pull request #8608 from jellyfin/release-10.8.z
Add index for DateCreated on ActivityLogs

Original-merge: 39b29eb9f1

Merged-by: Claus Vium <cvium@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-28 22:38:59 -04:00
cvium
395efc94a7 remove unnecessary skipcommand since SQLite does not have NEWID 2022-10-21 15:10:47 +02:00
cvium
b836fe9685 remove JellyfinDbProvider and add second level caching 2022-10-21 11:55:32 +02:00
renovate[bot]
b4f4121bcc
chore(deps): update dotnet monorepo 2022-10-18 23:41:35 +00:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Cody Robibero
3716077495 Backport pull request #8433 from jellyfin/release-10.8.z
Update to dotnet 6.0.9

Original-merge: 4ec82ec662

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:12:50 -04:00
Claus Vium
38b7d0222f
Merge pull request #8377 from Bond-009/resetcase
Make Password Reset case sensitive
2022-09-09 14:01:44 +02:00
Bond_009
5f8477ba47 Make Password Reset case sensitive 2022-09-09 13:36:27 +02:00
Claus Vium
1cbf5431aa
Merge pull request #8250 from Bond-009/minor18
Minor cleanup
2022-09-09 13:27:52 +02:00
Niels van Velzen
dd4af49962 Use Guid type for UserConfiguration fields 2022-08-27 14:19:47 +02:00
Bond_009
5036afd691 Minor cleanup 2022-08-18 13:56:23 +02:00
Cody Robibero
010228b3c0 Backport pull request #8234 from jellyfin/release-10.8.z
update to dotnet 6.0.8

Original-merge: 31f9938e3a

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua Boniface <joshua@boniface.me>
2022-08-13 21:46:35 -04:00
Joshua Boniface
be3d57ad41 Backport pull request #8115 from jellyfin/release-10.8.z
Update to dotnet 6.0.7

Authored-by: Cody Robibero <cody@robibe.ro>

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Original-merge: d0fd23bb4b
2022-07-20 19:29:09 -04:00
Joshua M. Boniface
3061446c87 Merge pull request #7984 from crobibero/dotnet-6.0.6
Upgrade to dotnet 6.0.6, update remaining dependencies

(cherry picked from commit 56e7b323de)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:36 -04:00
Cody Robibero
b611afe34c Merge pull request #7774 from crobibero/api-authinfo
(cherry picked from commit 825e6460c9)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-05-20 23:00:22 -04:00
Joshua M. Boniface
bc1a78575a Merge pull request #7766 from crobibero/dotnet-6.0.5
(cherry picked from commit 71bf567045)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-05-20 23:00:15 -04:00
dependabot[bot]
812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 (#7726)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-09 15:24:09 +02:00
Joshua M. Boniface
96d2d2428a Merge pull request #7590 from crobibero/dotnet-6.0.4
(cherry picked from commit 5778541d2f)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:47 -04:00
dependabot[bot]
dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases)
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406)

---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 12:22:11 +00:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Cody Robibero
965bf7332f Update to dotnet 6.0.3 2022-03-08 17:16:33 -07:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero
b98cc71c3b Update to dotnet 6.0.2
Signed-off-by: Cody Robibero <cody@robibe.ro>
2022-02-08 17:36:20 -07:00
dependabot[bot]
0c89459d5b
Bump System.Linq.Async from 5.1.0 to 6.0.1
Bumps [System.Linq.Async](https://github.com/dotnet/reactive) from 5.1.0 to 6.0.1.
- [Release notes](https://github.com/dotnet/reactive/releases)
- [Commits](https://github.com/dotnet/reactive/compare/ixnet-v5.1.0...ixnet-v6.0.1)

---
updated-dependencies:
- dependency-name: System.Linq.Async
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-07 12:01:03 +00:00
Bond_009
2dcb2f8a9f Ban the usage of Task.Result
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Cody Robibero
a60cb280a3 Properly populate QueryResult 2022-01-20 08:53:06 -07:00
Bond-009
b2a2bdb088
Merge pull request #7049 from crobibero/warn40219 2021-12-30 13:50:39 +01:00
Cody Robibero
57db188c2e Fix device ordering 2021-12-27 16:43:29 -07:00
Cody Robibero
7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009
cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
cvium
b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Cody Robibero
5e8aaa68cf Update to dotnet 6.0.1 2021-12-14 23:47:07 -07:00
dependabot[bot]
0120d80b78
Bump System.Linq.Async from 5.0.0 to 5.1.0
Bumps [System.Linq.Async](https://github.com/dotnet/reactive) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/dotnet/reactive/releases)
- [Commits](https://github.com/dotnet/reactive/compare/ixnet-v5.0.0...ixnet-v5.1.0)

---
updated-dependencies:
- dependency-name: System.Linq.Async
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-13 12:00:51 +00:00
Cody Robibero
34df1a030b
Merge pull request #6818 from Bond-009/password 2021-11-13 16:56:25 -07:00
Nicholas Sica
8ae5316198
Fix Ombi auth through Jellyfin 2021-11-12 16:23:58 -05:00
Nicholas Sica
c5e42ddcc6
Fix Ombi auth through Jellyfin
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-11-11 11:03:27 -05:00
NickSica
4b2c40f717 Fixes Ombi auth through Jellyfin 2021-11-11 00:43:43 -05:00
Bond_009
5265b3eee7 Replace PBKDF2-SHA1 with PBKDF2-SHA512
This also migrates already created passwords on login

Source for the number of iterations:
https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2
2021-11-10 22:34:54 +01:00
Bond_009
5726535a26 Fix some warnings
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero
40045d2147 Update to full dotnet 6 2021-11-08 09:40:12 -07:00
Bond_009
1b6eb2ff2d Enable nullable for more files 2021-10-26 13:56:30 +02:00