crobibero
6bcbc2b88a
Reduce warnings in MediaBrowser.Controller
2021-05-13 07:33:11 -06:00
Cody Robibero
e3f55a0c54
Reduce warnings in MediaBrowser.Controller ( #6006 )
...
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
BaronGreenback
bb6fddde9a
Group Methods
2021-04-17 11:19:09 +01:00
Bond_009
65bab55ca0
Minor improvements
2021-02-13 00:39:18 +01:00
crobibero
223b42aed3
Create BaseItemKind enum
2021-02-10 17:09:23 -07:00
crobibero
ee23d06154
Use a more descriptive function name
2020-12-13 08:15:26 -07:00
crobibero
b670937c3d
Use typed UserManager GetPreference
2020-12-11 15:00:43 -07:00
cvium
15a3d8d626
Forgot to revert some other changes, dunno if needed
2020-12-10 18:02:12 +01:00
Joshua M. Boniface
bf54b5579c
Merge branch 'master' into defer_image_fetching
2020-11-21 17:20:31 -05:00
Joshua M. Boniface
212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
...
Corrects spelling in comments
2020-11-19 13:08:28 -05:00
Claus Vium
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
...
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Greenback
9a323f6df0
More spelling corrections.
2020-11-18 13:46:14 +00:00
Kayila
d0cf60e145
Fixes #4465 by adding the missing extras folders.
2020-11-11 13:47:42 -05:00
crobibero
64b32d3290
Use BaseItemManager
2020-10-27 18:01:52 -06:00
cvium
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
2020-10-03 13:36:53 +02:00
Matt Montgomery
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
2020-09-28 15:04:31 -05:00
Bond-009
5e76d5fd56
Merge pull request #3879 from cvium/fix_theme_songs
...
Populate ThemeVideoIds and ThemeSongIds
2020-09-04 13:13:39 +02:00
Claus Vium
abc527329d
Sort by SortName after scanning
2020-09-03 14:49:02 +02:00
Erwin de Haan
208b00fbb1
Add the item path to the ItemLookupInfo class.
...
This is important for the Shoko Anime Meatdata provider plugin.
2020-09-02 20:11:31 +02:00
Bond_009
404bb4f835
Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release
2020-08-22 21:56:24 +02:00
Bond_009
119f64f5e7
Make some methods async
2020-08-21 22:01:19 +02:00
cvium
e10693cbe0
Remove some LINQ queries
2020-08-12 22:14:14 +02:00
cvium
1ae3dc202c
Populate ThemeVideoIds and ThemeSongIds
2020-08-11 22:04:41 +02:00
Bond_009
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Patrick Barron
6d1b00da64
Use Array.Empty
2020-07-04 11:54:25 -04:00
crobibero
1398c2117c
Revert ILoggerFactory usage in BaseItem.cs
2020-06-23 07:31:59 -06:00
telans
6556bec646
brace multiline if statements (cont.)
2020-06-20 21:19:16 +12:00
telans
7f307f9082
brace multiline if statements
2020-06-20 21:12:36 +12:00
telans
98db8f72e0
fix SA1503 for one line if statements
2020-06-20 20:35:29 +12:00
telans
8de6452967
fix some documentation periods
2020-06-20 18:13:11 +12:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629)
2020-06-16 10:37:52 +12:00
telans
afc9224ede
fix SA1111
2020-06-15 10:46:43 +12:00
telans
3d9049ef08
fix SA1508
2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005
2020-06-15 10:41:00 +12:00
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
aled
299e49f39d
Fix a small number of compile warnings
2020-06-09 23:12:53 +01:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily
9208acd5ae
Convert non-local image to local before computing blurhash
2020-05-28 17:55:29 +03:00
Patrick Barron
31f725fdbf
Fix a bug in Emby.Notifications and clean up
2020-05-26 23:08:27 -04:00
Patrick Barron
eef7cfd912
Make SonarCloud less angry
2020-05-26 22:43:03 -04:00
Vasily
1f83a21288
Rename Hash to BlurHash in all properties and methods for clarity
2020-05-21 01:43:19 +03:00
Vasily
3fb4c1356c
Make blurhash be computed during regular scans if it was not already computed
2020-05-20 23:50:17 +03:00
Patrick Barron
c464f700db
Remove redundant qualifiers
2020-05-20 13:07:53 -04:00
Jesús Higueras
b9fc0d2628
Add BlurHash support to backend
2020-05-18 23:21:37 +03:00
Patrick Barron
9ad839c776
Initial migration code
2020-05-12 22:10:35 -04:00
Anthony Lavado
ed1dc5c922
Remove JsonIgnore from the DateLastSaved property of BaseItem
2020-04-20 02:35:47 -04:00
Bond_009
a73e1f18b6
Minor improvements
2020-04-19 11:16:09 +02:00
Vasily
5b59cd2eb2
Merge pull request #2696 from mark-monteiro/fix-extras
...
Display Extras With Unknown Types
2020-04-07 23:39:31 +03:00
Mark Monteiro
1a4d9d4c53
Code review suggestions
2020-04-01 19:41:52 +02:00
Mark Monteiro
cc8294842a
Add ExtraType.Unknown enum value and use it instead of null
2020-04-01 18:10:29 +02:00
Mark Monteiro
e266ad51c5
Simplify logic; remove unnecessary methods
2020-03-28 14:17:33 +01:00
Mark Monteiro
ea306e8f6d
Do not assign an invalid value of zero to ExtraType
2020-03-28 13:54:14 +01:00
Mark Monteiro
5fcbedc194
Display extras with an unknown type
2020-03-28 13:40:56 +01:00
Bond_009
e9d1eabd53
Remove unused usings
2020-03-24 16:12:06 +01:00
Mark Monteiro
6897a19051
Add missing null check when retrieving extras
2020-03-22 15:09:51 +01:00
dkanada
a96c0a72b8
Merge pull request #2549 from dkanada/refactor
...
Refactor some provider classes
2020-03-18 17:43:15 +09:00
Bond-009
008a76cf4d
Merge pull request #2502 from JustAMan/baseitem-equals
...
Adds BaseItem.Equals method that compares items by their Id
2020-03-11 16:00:36 +01:00
dkanada
52fde64f10
remove unused files and fix some future warnings
2020-03-09 23:30:57 +09:00
Vasily
f4ccee5801
Add inheritdoc comment and squash simple method bodies
2020-03-05 15:03:17 +03:00
Vasily
456f571343
Follow code review suggestions
2020-03-05 14:25:50 +03:00
Vasily
007c5b9f67
Implement BaseItem.GetHashCode override
2020-03-04 13:06:13 +03:00
Vasily
f21cd30039
Lower log level for BaseItem.Equals to debug
2020-03-03 19:22:45 +03:00
Vasily
11abe31e0d
Speed up equality comparison of BaseItem
2020-03-02 12:31:31 +03:00
Vasily
d1670f8180
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
2020-02-27 16:02:18 +03:00
Vasily
8e20d2e931
Simplify AlphanumericComparer, reduce code duplication
2020-02-27 14:51:34 +03:00
Bond_009
bb236b9591
Merge branch 'master' into warn12
2020-01-10 21:18:16 +01:00
Bond_009
2ef4ffd698
More warnings (removed)
2019-12-11 00:13:57 +01:00
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
2019-11-04 10:03:18 -05:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Andrew Mahone
f22ca6dd9e
Retrieve media attachments in BaseItem.
2019-10-22 10:36:54 -04:00
Bond_009
5edb8159a7
Fix Json serialization error
2019-10-15 17:49:49 +02:00
Anthony Lavado
bae5e3795e
Fix SetImage to avoid out of range exception ( #1798 )
...
* Fix SetImage to avoid out of range exception
* Actually use the new images we've retrieved
2019-09-26 09:47:48 -04:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
SL1288
fdc24ec2ee
Fix LocalTrailers playback.
2019-08-19 18:56:41 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Claus Vium
0ef52c739e
Review changes
...
Untested
2019-05-16 07:27:38 +02:00
Claus Vium
b8a09339cd
Enforce extras folder structure according to Emby's wiki
2019-05-02 08:14:00 +02:00
Claus Vium
c1daea0ec7
Change owner and parent id of extras to the main media item
2019-05-01 07:47:22 +02:00
Bond-009
80fb3dc2cb
Fix error
2019-03-08 06:36:00 +01:00
Bond-009
4625592a83
Quick nullref fix
2019-03-07 22:52:41 +01:00
Bond-009
c5fce647de
Cleanup/simplification
...
* Removed useless copies/allocations
* Reduced unneeded complexity
2019-03-07 21:13:13 +01:00
Torsten
2690ac299b
Only refresh metadata if extras changed
2019-02-20 16:39:49 +01:00
Torsten
9753a76905
Populate video extras again
2019-02-19 22:41:25 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
8487319374
Merge pull request #726 from EraYaN/remove-wrappers-for-system-io
...
Clean up IFileSystem wrappers around stdlib.
2019-01-29 16:50:01 +03:00
Erwin de Haan
450f246f95
Unwrapped GetFileNameWithoutExtension
2019-01-28 22:10:51 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Claus Vium
dc68d61491
Fix default aspect ratio
2019-01-28 21:55:44 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Claus Vium
0e617933f6
Change default aspect ratio to 2/3 from 0
2019-01-26 22:19:14 +01:00
Bond_009
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00