Commit Graph

19883 Commits

Author SHA1 Message Date
BaronGreenback
828a9b7c75 rollback 2021-01-17 23:30:56 +00:00
BaronGreenback
13012bfa27 Fix bug in GetItemId 2021-01-17 22:43:05 +00:00
senritsu
4e21b49994 adjust episode path expression to allow digits in series names
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).

The rule, which matches most standard  anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.

Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.

Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
Sinan
d8d9d90469 Translated using Weblate (Turkish)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/tr/
2021-01-17 11:09:42 -05:00
BaronGreenback
b9f0f4f53b reverted 2021-01-17 13:35:30 +00:00
BaronGreenback
688e7c6a2d Moved internalVisibleToAttribute to .csj 2021-01-17 12:45:11 +00:00
Joshua M. Boniface
03242a6afd
Merge pull request #5007 from jellyfin/create 2021-01-16 13:28:48 -05:00
Joshua M. Boniface
fe9096be94
Merge pull request #4970 from BaronGreenback/networkTestCorrection 2021-01-16 13:28:34 -05:00
Joshua M. Boniface
3204ce71b3
Merge pull request #4956 from jceresini/master
Fix rpm package dependencies
2021-01-16 13:27:36 -05:00
crobibero
a087ab389a dotnet 5.0.2 2021-01-16 10:17:33 -07:00
crobibero
3b9567d583 Add query parameter to disable returning first episode as next up 2021-01-15 15:08:48 -07:00
crobibero
3d754fa5bf Revert "Don't return first episodes in next up" 2021-01-15 15:06:11 -07:00
BaronGreenback
620648fe81 Fixed for no data. 2021-01-15 18:55:52 +00:00
BaronGreenback
16d092a8a7 Fixed encoding issue 2021-01-15 12:17:50 +00:00
BaronGreenback
a4e838fbf5 Remoed configurationPageType 2021-01-15 10:36:44 +00:00
BaronGreenback
8ef37f6b0e
Rename IPluginConfigurationPage.cs to ConfigurationPageType.cs.cs
Renamed file.
2021-01-15 10:26:00 +00:00
BaronGreenback
bced1eab54 Assert.True 2021-01-13 21:16:04 +00:00
Alexander Brissman
549160b9b9 Translated using Weblate (Norwegian Bokmål)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/nb_NO/
2021-01-13 14:35:17 -05:00
BaronGreenback
4bc8a1e77b updated 2021-01-13 15:29:57 +00:00
BaronGreenback
9a730241b1 Changed to address. 2021-01-13 15:14:04 +00:00
Deniz
eb82879a4f Translated using Weblate (Turkish)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/tr/
2021-01-13 02:59:55 -05:00
BaronGreenback
c6aa6ceed9 Removal of IPluginConfigurationPage 2021-01-12 22:10:23 +00:00
趙映翔
f7aae0e876 Translated using Weblate (Chinese (Traditional))
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/zh_Hant/
2021-01-12 16:28:17 -05:00
Oriol Serra
580b90aa4c Translated using Weblate (Catalan)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/ca/
2021-01-12 16:28:17 -05:00
BaronGreenback
d66bc3fb3e Fixed indentation 2021-01-12 20:43:25 +00:00
BaronGreenback
dfd7ff5732
Update MediaBrowser.Common/Net/INetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-01-12 20:41:48 +00:00
BaronGreenback
94cc5b9d8b
Update MediaBrowser.Common/Net/INetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-01-12 20:41:40 +00:00
BaronGreenback
08e83cfa54 Remove additional debug logging. 2021-01-12 18:52:48 +00:00
Bond_009
eeff9f52c6 Fix Omdb caching 2021-01-12 16:27:38 +01:00
Bond-009
bffebce909
Merge pull request #5004 from jellyfin/camera-upload
remove unused notification type
2021-01-12 16:13:21 +01:00
Bond_009
1fdd2d6e05 Handle IO errors in LoadManifest 2021-01-12 16:03:13 +01:00
Bond_009
1752423e52 Open FileStream with FileMode.Create instead of FileMode.OpenOrCreate
> The OpenWrite method opens a file if one already exists for the file path,
    or creates a new file if one does not exist. For an existing file,
    it does not append the new text to the existing text. Instead,
    it overwrites the existing characters with the new characters.
    If you overwrite a longer string
    (such as "This is a test of the OpenWrite method") with a shorter string
    (such as "Second run"), the file will contain a mix of the strings
    ("Second runtest of the OpenWrite method").

Ref: https://docs.microsoft.com/en-us/dotnet/api/system.io.file.openwrite?view=net-5.0#remarks
2021-01-12 15:51:32 +01:00
Bond_009
a9b497720d Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.

```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

|          Method |       Mean |    Error |   StdDev |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
|  RoundTripBytes |   932.0 ns |  5.09 ns |  4.25 ns | 0.1173 |     - |     - |     368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 |     - |     - |     464 B |
```
2021-01-12 15:37:18 +01:00
Bond_009
1ea2b200c0 JsonSerializer deserialize from bytes where possible
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

| Method |     Mean |   Error |  StdDev |   Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
|  Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 |     - |     - |  52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 |     - |     - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 |     - |     - |  31.27 KB |
```
2021-01-12 15:28:02 +01:00
BaronGreenback
2979c8dd37 Fixed test on Mac 2021-01-12 13:23:10 +00:00
BaronGreenback
35a30c9d09 Impliments KnownNetworks and KnownProxies 2021-01-12 13:07:34 +00:00
dkanada
cac33ef105 remove unused notification type 2021-01-12 12:28:21 +09:00
Bond-009
aaf889f683
Merge pull request #5002 from jellyfin/dependabot/nuget/coverlet.collector-3.0.0
Bump coverlet.collector from 1.3.0 to 3.0.0
2021-01-11 14:58:23 +01:00
dependabot[bot]
b00f3334f2
Bump coverlet.collector from 1.3.0 to 3.0.0
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 1.3.0 to 3.0.0.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits/v3.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-11 12:01:03 +00:00
Claus Vium
5c00b4175a
Merge pull request #4997 from crobibero/subtitle-upload-auth
Require elevated auth to upload subtitles
2021-01-10 20:45:15 +01:00
crobibero
5f998bdd1f Require elevated auth to upload subtitles 2021-01-10 10:48:37 -07:00
Claus Vium
9970b87439
Merge pull request #4994 from Bond-009/artistnfo
Add tests for artist nfo
2021-01-10 10:33:31 +01:00
Bond_009
4c3fa21e97
Add tests for artist nfo 2021-01-09 21:49:36 +01:00
Claus Vium
75a25de991
Merge pull request #4992 from Bond-009/seriesnfo
Add tests for series nfo
2021-01-09 20:43:15 +01:00
Bond_009
585821954d
Add tests for series nfo 2021-01-09 20:15:16 +01:00
Bond-009
8d4312d739
Merge pull request #4989 from Bond-009/nfotests 2021-01-09 19:35:24 +01:00
Bond-009
0bb0dd646f
Merge pull request #4980 from Ullmie02/chinese
Add additional chinese languages
2021-01-09 18:55:57 +01:00
Bond-009
2e33e14bb2
Merge pull request #4899 from jellyfin/nullableguid
Cover all branches in JsonNullableGuidConverter
2021-01-09 17:37:23 +01:00
Bond-009
2c74262f7c
Merge pull request #4945 from obradovichv/fix-string-culture-specificity 2021-01-09 16:21:19 +01:00
Bond_009
be511ca162
Fix release build ... again 2021-01-09 15:14:26 +01:00