Commit Graph

1080 Commits

Author SHA1 Message Date
Shadowghost
b725fbe51a Apply review suggestions 2022-12-13 10:39:37 +01:00
Shadowghost
697efec86e Cleanup and refactor streambuilder 2022-12-07 18:00:01 +01:00
Shadowghost
3f6354cdb8 Fix .NET 7 compatibility 2022-12-07 17:41:32 +01:00
Shadowghost
2c86bd1875 Merge branch 'master' into network-rewrite 2022-12-07 17:40:24 +01:00
Bond_009
227aa0540b Update Microsoft.AspNetCore.Mvc.Testing to 7.0.0 2022-12-07 17:01:28 +01:00
Bond_009
fd9dc1e308 Update deps 2022-12-07 16:56:32 +01:00
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009
210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
Shadowghost
bcd992fb06 Merge remote-tracking branch 'upstream/master' into network-rewrite 2022-12-03 12:44:45 +01:00
Cody Robibero
c9f8b8a7c7
Merge pull request #8790 from Bond-009/todo 2022-11-27 07:51:56 -07:00
Bond-009
9c1da522c6
Fix last CA1305 error (#8806) 2022-11-27 06:49:21 -07:00
Bond_009
556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
Bond-009
f369ddf522
Merge pull request #7039 from 1337joe/providermanager-cleanup 2022-11-23 18:24:07 +01:00
Joe Rogers
6252bc399a
Fix unit tests after merge from master
Co-authored-by: Bond-009 <bond.009@outlook.com>
2022-11-23 15:59:50 +01:00
Bond-009
a9e2acc9e4
Merge pull request #8666 from dmitrylyzo/fix-secondary-audio
Fixes https://github.com/jellyfin/jellyfin-web/issues/4044
Fixed https://github.com/jellyfin/jellyfin/issues/8673
2022-11-13 12:10:52 +01:00
Bond_009
ba3e7027fe Add regression test for #8696 2022-11-05 14:11:49 +01:00
Dmitry Lyzo
c7a9759a76 fix tests 2022-10-31 15:51:06 +03:00
photonconvergence
09e8a7e62c Fix extra type differentiation
Change rules for Featurettes and Shorts so they don't both get classed as ExtraType.Clip.

Fix test that these changes break
2022-10-27 18:01:04 -07:00
MrTimscampi
7ad0c9ba24 Migrate MusicBrainz plugin to MetaBrainz.MusicBrainz
Co-authored-by: crobibero <cody@robibe.ro>
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2022-10-22 12:44:44 +02:00
Shadowghost
f6d6f0367b Properly handle IPs with subnetmasks 2022-10-17 15:51:09 +02:00
Bond_009
224bb355dd Rewrite BaseItem.ModifySortChunks 2022-10-12 17:43:01 +02:00
Joe Rogers
2e4db18ebe
Add hearing impaired subtitle stream indicator (#7379)
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-10-07 12:38:05 +02:00
Claus Vium
81b04ddbb5
Merge branch 'master' into providermanager-cleanup 2022-10-07 09:57:16 +02:00
Claus Vium
14027f962c
Merge pull request #6751 from Bond-009/tests12
Fix DLNA UpdateProfile test
2022-10-07 09:49:16 +02:00
Shadowghost
7b90fcd053 Merge branch 'master' into network-rewrite 2022-10-07 09:16:02 +02:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Shadowghost
4fc52a840c Merge branch 'master' into network-rewrite 2022-10-01 19:59:00 +02:00
Hannes Braun
4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
dependabot[bot]
266fb2f81c
Bump Microsoft.NET.Test.Sdk from 17.3.1 to 17.3.2
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.1 to 17.3.2.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v17.3.1...v17.3.2)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-26 12:01:34 +00:00
Cody Robibero
3716077495 Backport pull request #8433 from jellyfin/release-10.8.z
Update to dotnet 6.0.9

Original-merge: 4ec82ec662

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:12:50 -04:00
Cody Robibero
6004060b4e Fix build errors from new warnings 2022-09-09 07:44:14 -06:00
dependabot[bot]
62ef93e2ce Bump xunit from 2.4.1 to 2.4.2
Bumps [xunit](https://github.com/xunit/xunit) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](https://github.com/xunit/xunit/compare/2.4.1...2.4.2)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-09 07:44:12 -06:00
dependabot[bot]
1be9eb13ef
Bump Moq from 4.18.1 to 4.18.2
Bumps [Moq](https://github.com/moq/moq4) from 4.18.1 to 4.18.2.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.18.1...v4.18.2)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-09 10:49:52 +00:00
dependabot[bot]
a0f873692e
Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.3.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.2.0 to 17.3.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v17.2.0...v17.3.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-05 15:52:18 +00:00
luz paz
9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero
010228b3c0 Backport pull request #8234 from jellyfin/release-10.8.z
update to dotnet 6.0.8

Original-merge: 31f9938e3a

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua Boniface <joshua@boniface.me>
2022-08-13 21:46:35 -04:00
SenorSmartyPants
de9a350bad Backport pull request #8212 from jellyfin/release-10.8.z
Add resolution text for 384 sized video

Original-merge: 7ffdde9a0b

Merged-by: Cody Robibero <cody@robibe.ro>

Backported-by: Joshua Boniface <joshua@boniface.me>
2022-08-13 21:46:34 -04:00
Joshua Boniface
38eefbbafa Backport pull request #8087 from jellyfin/release-10.8.z
feat: make subtitleeditparser generic

Authored-by: Claus Vium <cvium@users.noreply.github.com>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: 7323ccfc23
2022-08-01 14:25:42 -04:00
Joshua Boniface
be3d57ad41 Backport pull request #8115 from jellyfin/release-10.8.z
Update to dotnet 6.0.7

Authored-by: Cody Robibero <cody@robibe.ro>

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Original-merge: d0fd23bb4b
2022-07-20 19:29:09 -04:00
Joshua Boniface
924b0740b1 Backport pull request #8104 from jellyfin/release-10.8.z
Add resolution text output for more resolutions

Authored-by: Shadowghost <Ghost_of_Stone@web.de>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: 2b46917dcf
2022-07-20 19:29:08 -04:00
Shadowghost
2281b8c997 Move away from using Collection, simplify code, add proper ordering 2022-07-20 14:29:30 +02:00
Shadowghost
a492082f4e Apply review suggestions and fix build 2022-07-20 11:47:48 +02:00
Shadowghost
bdb1483167 Add generic IPAddress.Parse tests 2022-07-19 23:42:32 +02:00
Shadowghost
997aa3f1e7 Fix build 2022-07-19 21:53:10 +02:00
Shadowghost
066db8ac7f Migrate NetworkManager and Tests to native .NET IP objects 2022-07-19 21:28:04 +02:00
Bond-009
d771205544 Merge pull request #7988 from jellyfin/external-streams-exceptions
(cherry picked from commit a71b190142)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:38 -04:00
Joshua M. Boniface
3061446c87 Merge pull request #7984 from crobibero/dotnet-6.0.6
Upgrade to dotnet 6.0.6, update remaining dependencies

(cherry picked from commit 56e7b323de)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:36 -04:00
Joshua M. Boniface
fe32b5e333 Merge pull request #7964 from jellyfin/dovi-side-data
(cherry picked from commit 39d185c7b1)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:15 -04:00
Bond-009
a881733377
Merge pull request #7682 from 1337joe/test-preferred-audio-language 2022-06-14 15:23:40 +02:00
Cody Robibero
a7b1132c92 Merge pull request #7842 from crobibero/dependency-backport
(cherry picked from commit df6c5b6d42)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-06 09:20:07 -04:00
Cody Robibero
3a95d4b04e Merge pull request #7802 from jellyfin/external
(cherry picked from commit 9954cbd550)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-06 09:16:11 -04:00
dependabot[bot]
7ac06429d9
Bump Moq from 4.17.2 to 4.18.1 (#7820)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-04 00:27:45 +02:00
dependabot[bot]
0f6bd264ae
Bump Microsoft.NET.Test.Sdk from 17.1.0 to 17.2.0 (#7760)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-25 19:06:17 +02:00
dependabot[bot]
08981f3a04
Bump Microsoft.AspNetCore.Mvc.Testing from 6.0.4 to 6.0.5
Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 6.0.4 to 6.0.5.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v6.0.4...v6.0.5)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-24 14:01:43 +00:00
Joshua M. Boniface
f205661b18 Merge pull request #7741 from LewkyB/fix-improperly-labeled-four-digit-episode-numbering
Fix to allow for episode numbering over 999 in certain scenarios

(cherry picked from commit 3ea67374ae)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-05-20 23:49:38 -04:00
Joshua M. Boniface
bc1a78575a Merge pull request #7766 from crobibero/dotnet-6.0.5
(cherry picked from commit 71bf567045)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-05-20 23:00:15 -04:00
Joshua M. Boniface
2d8f7b46f1 Merge pull request #7699 from Shadowghost/streambuilder-fix
(cherry picked from commit b46d61dfdf)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Bond-009
2b1a915ead Merge pull request #7604 from Jellifi007/fixes-diactritics
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero
e263e9c2b1 Merge pull request #7544 from jaantaponen/long-filename-fix
(cherry picked from commit 8a1eca0913)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Joe Rogers
644e774040
Fix default audio selection ignoring type 2022-05-17 21:03:51 +02:00
dependabot[bot]
812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 (#7726)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-09 15:24:09 +02:00
dependabot[bot]
37b87bc231
Bump xunit.runner.visualstudio from 2.4.3 to 2.4.5 (#7727)
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.4.3 to 2.4.5.
- [Release notes](https://github.com/xunit/visualstudio.xunit/releases)
- [Commits](https://github.com/xunit/visualstudio.xunit/commits)

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-09 15:23:45 +02:00
Joe Rogers
e89d1a3be5
Add tests for preferred audio language selection 2022-04-30 15:36:09 +02:00
Cody Robibero
e5e7c10b81 Merge pull request #7638 from 1337joe/fix-quick-connect-tests
(cherry picked from commit 7c91543694)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-28 09:26:45 -04:00
Joshua M. Boniface
96d2d2428a Merge pull request #7590 from crobibero/dotnet-6.0.4
(cherry picked from commit 5778541d2f)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:47 -04:00
Cody Robibero
688553b9a8 Merge pull request #7537 from dmitrylyzo/fix-streambuilder
(cherry picked from commit 5833c70725)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:10 -04:00
Cody Robibero
04cac23a11 Merge pull request #7548 from 1337joe/comparer-null-fix
(cherry picked from commit 72aca15191)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Cody Robibero
1960b5bdce Merge pull request #7523 from crobibero/null-stream
Allow media without streams to playback 

(cherry picked from commit 577325b788)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Joe Rogers
6bf71c0fd3
Combine verify calls
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-04-03 23:36:33 +02:00
Joe Rogers
b03f56c3d6
Remove warnings 2022-04-03 23:36:32 +02:00
Joe Rogers
ee5bd0daa6
Implement tests on ProviderManager.RefreshSingleItem 2022-04-03 23:36:32 +02:00
Joe Rogers
bdce435b09
Reorder and flatten provider filtering 2022-04-03 23:36:30 +02:00
Joe Rogers
6ab64f4930
Switch to nameof to simplify theory signatures 2022-04-03 23:34:50 +02:00
Joe Rogers
a7c009e2eb
Pass TypeOptions instead of full LibraryOptions 2022-04-03 23:34:49 +02:00
Joe Rogers
d5e2c2fb5e
Implement CanRefreshMetadata tests for GetMetadataProviders
Cleanup tests, extract common blocks
2022-04-03 23:34:49 +02:00
Joe Rogers
e7df72de49
Improve metadata provider sorting
Extract configured order up front instead of for each provider
Non-IHasOrder providers default to middle, not beginning
Merge image and metadata sort helper methods
2022-04-03 23:34:49 +02:00
Joe Rogers
91e706d387
Implement sort test for ProviderManager.GetMetadataProviders 2022-04-03 23:34:49 +02:00
Joe Rogers
11c7c24f0e
Clarify naming, minor method ordering improvement 2022-04-03 23:34:49 +02:00
Joe Rogers
56900d0fc3
Implement CanRefresh tests for ProviderManager.GetImageProviders 2022-04-03 23:34:48 +02:00
Joe Rogers
8515e8fbd1
Improve image provider sorting
Remove irrelevant check for ILocalImageProvider
Providers that are not IHasOrder default to middle, not beginning
2022-04-03 23:34:48 +02:00
Joe Rogers
785cc1bb6e
Implement sort test for ProviderManager.GetImageProviders 2022-04-03 23:34:48 +02:00
dependabot[bot]
dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases)
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406)

---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 12:22:11 +00:00
Bond_009
09e897d372 Clean up DLNA profile code 2022-03-19 00:45:43 +01:00
Cody Robibero
6a567e8c76
Merge pull request #7474 from nielsvanvelzen/api-secure 2022-03-18 16:52:59 -06:00
Niels van Velzen
8a827ba995 Update tests 2022-03-18 22:21:08 +01:00
Bond-009
bb7068cb63
Move StreamBuilderTests to correct project (#7461) 2022-03-18 22:19:02 +01:00
Cody Robibero
e6df698df1
Merge pull request #7325 from eyezak/issue/6450 2022-03-12 09:08:25 -07:00
Cody Robibero
5319f1571f
Merge pull request #7444 from Bond-009/baseurl 2022-03-11 18:42:14 -07:00
Cody Robibero
28223704f3
Merge pull request #7441 from 1337joe/add-external-stream-indicator
Add label for external audio/sub tracks
2022-03-11 07:48:23 -07:00
Bond_009
edeb198313 Add tests for BaseUrl normalization 2022-03-11 15:44:16 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Joe Rogers
1a307db7eb
Add label for external audio/sub tracks 2022-03-10 22:20:35 +01:00
Mayur Panchal
96de01ce01
ProbeResultNormalizer: fix framerate compare + tests (#7167) 2022-03-10 20:55:30 +01:00
Cody Robibero
965bf7332f Update to dotnet 6.0.3 2022-03-08 17:16:33 -07:00
dependabot[bot]
4c4f5dfe81
Bump Moq from 4.17.1 to 4.17.2 (#7416)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-07 14:23:43 +01:00
Cody Robibero
bbd5d11d3b Remove TranscodeReason.None, Add JsonFlagEnum tests 2022-03-06 18:13:54 -07:00
Isaac Gordezky
84a3db6f84 Fix transcode video matching and add tests for Transcode and Safari 2022-03-06 18:13:54 -07:00
Isaac Gordezky
5e779f20ee Series: issue-6450
Issue: https://github.com/jellyfin/jellyfin/issues/6450

Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
2022-03-06 18:13:54 -07:00