Commit Graph

46 Commits

Author SHA1 Message Date
Bond_009
07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009
2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
Bond_009
42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
Bond-009
ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond_009
f70a63d575 Return DB asap 2019-08-18 22:05:06 +02:00
Bond-009
6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond_009
7898af4ceb Reworked PRAGMA statements use 2019-06-28 12:14:27 +02:00
Bond_009
d00ad28efd Address comments 2019-06-28 12:14:27 +02:00
Bond-009
02b864e41b Last line? 2019-06-28 12:14:27 +02:00
Bond-009
b6954f3bfd More 2019-06-28 12:14:27 +02:00
Bond-009
27c29bbb4c Back to a single connection 2019-06-28 12:13:34 +02:00
Bond-009
c30ba14c1f Use a connection pool instead of creating new connections 2019-06-28 12:12:54 +02:00
Bond-009
cec22ad10d Simplify db code 2019-06-28 12:12:54 +02:00
Erwin de Haan
d1a0497f55 Revert "Merge pull request #452 from Bond-009/activitydb"
This reverts commit 48ad18d12b, reversing
changes made to fe197415ca.
2019-01-25 23:32:06 +01:00
Bond_009
3cd31cadf8 No need to check if the dir exists 2019-01-23 18:34:34 +01:00
Bond_009
8d9428ebdc Ensure DB exists 2019-01-23 18:34:34 +01:00
Bond_009
f6f0a8a481 Use EF Core for Activity database 2019-01-23 16:39:12 +01:00
William Taylor
65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Erwin de Haan
a5288115a8 Visual Studio Reformat: Emby.Server.Implementations Part A-Da 2019-01-13 20:20:16 +01:00
Erwin de Haan
ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009
88aa5da354 Fix build due to rebase 2018-12-30 22:44:39 +01:00
Bond_009
ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009
0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Bond_009
6e5d2aadaa Remove custom ToArray extension 2018-12-28 16:48:26 +01:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti
7e5036a587 update image aspect ratio detection 2017-10-22 02:22:43 -04:00
Luke Pulverenti
2d29d903be fixes #2904 - disabling transcoding for a user is not working 2017-09-22 01:54:57 -04:00
Luke Pulverenti
e287e3a50d remove async when there's nothing to await 2017-08-26 20:32:33 -04:00
Luke Pulverenti
40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti
1dab9a60f4 rename methods 2017-05-07 16:02:32 -04:00
Luke Pulverenti
71854c1a09 update connection process 2016-12-13 03:45:04 -05:00
Luke Pulverenti
e1b880a5a0 update series queries 2016-12-13 02:36:30 -05:00
Luke Pulverenti
c2d0fd9985 update season queries 2016-12-12 03:53:25 -05:00
Luke Pulverenti
1aff48b93b move book support into the core 2016-12-12 00:49:19 -05:00
Luke Pulverenti
a9a808a9c4 fix db locking errors 2016-12-11 00:12:00 -05:00
Luke Pulverenti
61e195c096 update repositories 2016-11-29 14:12:37 -05:00
Luke Pulverenti
1c52e4f51b update transaction modes 2016-11-28 14:26:48 -05:00
Luke Pulverenti
a9645e1429 update components 2016-11-25 01:58:38 -05:00
Luke Pulverenti
f275d7f3d2 reduce library queries 2016-11-21 03:54:53 -05:00
Luke Pulverenti
1dc080df8b update connections 2016-11-20 22:52:58 -05:00
Luke Pulverenti
24dc91160d update activity log 2016-11-20 15:31:55 -05:00
Luke Pulverenti
7f62a99ab5 update extensions 2016-11-20 02:10:07 -05:00
Luke Pulverenti
64d15be839 update queries 2016-11-20 00:59:36 -05:00
Luke Pulverenti
52227ce00d update save methods 2016-11-19 03:40:13 -05:00
Luke Pulverenti
65a1ef020b move sync repository to portable project 2016-11-19 00:52:49 -05:00
Luke Pulverenti
fa714425dd begin to rework repositories 2016-11-18 03:39:20 -05:00