Commit Graph

113 Commits

Author SHA1 Message Date
Stepan
b66239fd52 One more missed suggestions (removing commented out code) 2020-11-12 13:18:22 +01:00
Stepan
3bca1181b3 Taken suggestions from code review and created test for ExtraRuleType.Regex instead of throwing exception there. 2020-11-12 13:16:33 +01:00
martinek-stepan
496923719c
Apply suggestions from code review
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 12:54:55 +01:00
Stepan
158eff62d7 Xml-doc part2 2020-11-10 19:23:10 +01:00
Stepan
693760e38a Xml-doc part1 2020-11-10 17:11:48 +01:00
Stepan
c0747512d6 Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable 2020-11-10 12:42:49 +01:00
crobibero
78551d166a Don't throw exception if name is null 2020-11-09 06:10:16 -07:00
Stepan
3466dc5581 Finish coverage for Emby.Naming.Video 2020-11-05 16:59:15 +01:00
Stepan
5741150367 Enable MultiVersion video tests and added support for naming based on tests 11 & 8 2020-11-05 14:51:27 +01:00
Stepan
1e71775688 Add Name and Year parsing for audiobooks 2020-11-02 20:03:12 +01:00
Stepan
e7a37bedfc Simplify AudioBookResolver since there is no option of passing directories into it (AudioResolver.cs:179) and handling directories were not implemented anyway 2020-11-01 13:42:56 +01:00
Stepan
60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
Stepan
59619b6ea7 Enable nullable in Emby.Naming 2020-11-01 10:47:31 +01:00
Vasily
ce16651dbd Fix a check broken by https://github.com/jellyfin/jellyfin/pull/2105 2020-05-15 01:55:53 +03:00
Bond_009
a273ed9a57 Address comments 2020-04-25 15:29:59 +02:00
Bond_009
735e7c3f7d Fix VideoResolver and tests 2020-04-21 12:11:55 +02:00
Mark Monteiro
7be4b57fe7 Fix documentation for ExtraRuleType enum values 2020-04-05 09:47:55 -04:00
Mark Monteiro
377f9896ce Small fixes 2020-04-01 19:04:00 +02:00
Mark Monteiro
4ff8d30e41 Document ExtraRule properly 2020-04-01 18:54:06 +02:00
Mark Monteiro
2e1ec2858a Match using directory names in ExtraResolver 2020-04-01 18:53:19 +02:00
crobibero
bd5c66b2a6 implement suggestions 2020-03-25 18:29:47 -06:00
crobibero
18906d0205 implement suggestions 2020-03-25 14:33:44 -06:00
crobibero
261a2e1989 revert xml docs indentation 2020-03-25 14:31:03 -06:00
crobibero
cb68fbeb0a Fix warnings in Emby.Naming 2020-03-25 10:53:03 -06:00
Bond_009
07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009
adc9fc282c Minor improvements 2020-02-19 23:08:58 +01:00
Bond_009
dc62e436c4 Clean up Emby.Naming 2020-01-22 22:18:56 +01:00
Bond_009
abf03f7d3a Clean up some more 2020-01-11 22:17:05 +01:00
Bond_009
ec0ef2a2c5 Remove useless statement 2020-01-11 22:17:05 +01:00
Bond_009
cd0592ea8f Improve parsers 2020-01-11 22:17:05 +01:00
Bond_009
dd254eddac Simplify CleanDateTimeParser 2020-01-11 22:17:05 +01:00
Bond_009
b1dc595be1 Fix a couple of tests 2020-01-11 22:17:05 +01:00
Bond_009
b50c4938e1 Merge branch 'master' into namingtests 2020-01-09 18:26:22 +01:00
Bond_009
5a8e972952 Enable TreatWarningsAsErrors for some projects
Analyzers are only run in debug build, so setting TreatWarningsAsErrors
for release build will catch the compiler warnings until we resolve all
analyzer warnings.
2019-12-13 20:11:37 +01:00
Bond_009
35151553e3 Add back all old emby tests 2019-12-06 20:41:39 +01:00
Bond-009
b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond-009
a6f9ceedd8 Fix more warnings 2019-06-01 11:31:27 +02:00
Claus Vium
6016a27736 Check for whitespace 2019-02-19 22:30:21 +01:00
Claus Vium
566646ad8b Remove limit comment 2019-02-19 19:44:22 +01:00
Claus Vium
6c1ca6f737 Remove arbitrary limit and minor style fixes 2019-02-19 19:33:41 +01:00
Claus Vium
aa0c20afd5 Revert "Change multi version logic for movies"
This reverts commit a4055779f6.
2019-02-19 17:39:47 +01:00
Claus Vium
46acff4113 Revert "Remove unnecessary ToList"
This reverts commit 42abb5a993.
2019-02-19 17:39:30 +01:00
Claus Vium
de5c0bab70 Revert "Add Year to the new VideoInfo"
This reverts commit 05ad2e9b3f.
2019-02-19 17:39:10 +01:00
Claus Vium
5181427234 Revert "Merge pull request #924 from cvium/fix_movie_matching"
This reverts commit f274d024ce, reversing
changes made to 4b4399fba6.
2019-02-19 17:34:43 +01:00
Claus Vium
c79324154f Revert "Merge pull request #933 from cvium/fix_movie_matching_again"
This reverts commit 77d4fec6eb, reversing
changes made to f274d024ce.
2019-02-19 17:10:11 +01:00
Claus Vium
29ff80d69c Minor style fixes 2019-02-18 22:02:16 +01:00
Claus Vium
4a700778e3 Semi-revert to prefer old movie grouping behaviour 2019-02-18 21:56:08 +01:00
Claus Vium
c45b6aa53e Use the movie name instead of folder name 2019-02-17 07:39:36 +01:00
Claus Vium
05ad2e9b3f Add Year to the new VideoInfo 2019-01-27 16:50:17 +01:00
Claus Vium
42abb5a993 Remove unnecessary ToList 2019-01-27 16:37:12 +01:00
Claus Vium
a4055779f6 Change multi version logic for movies 2019-01-27 16:27:18 +01:00
Bond_009
35d97dc949 Minor improvements to library scan code 2019-01-20 19:40:37 +01:00
Erwin de Haan
321c440739 Reformat JustAMan review pt1 changes
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan
a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan
e566d9a231 Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv 2019-01-13 20:54:44 +01:00
Erwin de Haan
5665933849 Visual Studio Reformat: Emby.Naming 2019-01-13 20:17:29 +01:00
Erwin de Haan
846456b41e Reformatted the files with notes. 2019-01-12 21:41:08 +01:00
Erwin de Haan
e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan
ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00