Commit Graph

666 Commits

Author SHA1 Message Date
BaronGreenback
bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback
80877aa945 Cleaned up "value assigned is not used in any execution path" 2021-04-17 09:27:58 +01:00
Bond-009
631df8c560
Merge pull request #5520 from Bond-009/hdhomerun2 2021-04-08 00:27:58 +02:00
Bond_009
aa76957338 Remove useless code 2021-04-01 19:16:00 +02:00
LIAUD
32853ca244 Add 'group-title' channel parsing 2021-03-20 20:15:19 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009
f9640f4366 Rewrite HdHomerunManager.ParseReturnMessage 2021-03-13 21:12:11 +01:00
Bond_009
e8b18e5f8f Add test for HdHomerunManager.ParseReturnMessage 2021-03-13 19:32:40 +01:00
Bond_009
f5789483fd Add test for HdHomerunManager.WriteSetMessage 2021-03-13 19:21:29 +01:00
Bond-009
b755c25217
Merge pull request #5220 from Bond-009/hdhomerun 2021-03-13 15:05:18 +01:00
David
ece0d67f99 Use FileShare.Read for log files 2021-03-09 17:31:31 +01:00
David
eca3b37d6e Use FileShare.Read to fix HdHomeRun 2021-03-09 17:01:05 +01:00
David
60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
Bond_009
1c74e2f40e Fix build 2021-02-24 02:57:10 +01:00
Bond_009
b1fe28d0a6 Use GetEncodingOptions where possible 2021-02-21 02:58:30 +01:00
Bond_009
eba859e33e Minor improvements 2021-02-21 02:49:52 +01:00
dkanada
13d65318eb
Merge pull request #5223 from Bond-009/minor10
Minor improvements
2021-02-20 10:56:55 +09:00
Bond_009
e9f22303a4 Properly forward cancellationTokens 2021-02-15 14:19:17 +01:00
Bond_009
65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
Bond_009
e1bc322b70 Add test for WriteGetMessage 2021-02-12 18:35:54 +01:00
Bond_009
3a9fcb6abd Rewrite packet writing code for HdHomerun 2021-02-12 17:34:51 +01:00
dkanada
aea1c4f310
Merge pull request #5142 from M0ssTee/updateRegex
Replaced /d with [0-9], see issue #2923
2021-02-08 22:52:58 +09:00
dkanada
54a3ab15a3
Merge pull request #5005 from jellyfin/bytes
JsonSerializer deserialize from bytes where possible
2021-02-05 11:47:06 +09:00
M0ssTee
8f88d0d2cb
Update Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-02-03 00:57:04 -05:00
Troy
8c640a1492 Replaced /d with [0-9], see issue #2923 2021-02-01 02:49:23 +00:00
Bond_009
a9b497720d Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.

```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

|          Method |       Mean |    Error |   StdDev |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
|  RoundTripBytes |   932.0 ns |  5.09 ns |  4.25 ns | 0.1173 |     - |     - |     368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 |     - |     - |     464 B |
```
2021-01-12 15:37:18 +01:00
Bond_009
1ea2b200c0 JsonSerializer deserialize from bytes where possible
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

| Method |     Mean |   Error |  StdDev |   Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
|  Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 |     - |     - |  52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 |     - |     - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 |     - |     - |  31.27 KB |
```
2021-01-12 15:28:02 +01:00
Bond-009
054adf6379
Merge pull request #4853 from Ullmie02/servicestack-json 2020-12-30 10:33:32 +01:00
David
3dec1fd6b2 Use UTF8 encoding and async correctly 2020-12-29 00:35:59 +01:00
David
21fd124bca Code revie 2020-12-27 11:15:46 +01:00
David
f73bb92ce3 Remove manual N/A removal and write directly to stream 2020-12-26 20:00:54 +01:00
David
043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
David
e835dfb27d Use sync string instead of file 2020-12-24 10:31:51 +01:00
David
2a574914ea Use streams instead of strings 2020-12-23 19:24:58 +01:00
David
196388d607 Remove custom Json serializer from Emby.Server.Implementations 2020-12-23 13:14:40 +01:00
Ryan Petris
c0c0eaec05
new List(int) does not pre-allocate indicies like Arrays, it merely sets the initial capacity. 2020-12-22 20:37:07 -07:00
Claus Vium
f322866127
Merge pull request #4737 from crobibero/missing-ensure-success 2020-12-11 09:53:43 +01:00
crobibero
a9aafbaf5a Don't throw exception unless needed 2020-12-10 08:25:05 -07:00
Bond_009
c0fde3496c Add tests for HdHomerunHost.TryGetTunerHostInfo 2020-12-09 01:24:30 +01:00
Bond_009
514d95e5aa Add tests for HdHomerunHost.GetLineup 2020-12-09 01:08:41 +01:00
Claus Vium
e6650651b3
Merge pull request #4738 from jellyfin/tests8
Add tests for HdHomerunHost.GetModelInfo
2020-12-08 20:20:33 +01:00
Bond_009
7027561e19 Add tests for HdHomerunHost.GetModelInfo 2020-12-08 18:53:38 +01:00
Claus Vium
b6ecaccf92
Merge pull request #4730 from crobibero/base-item-dto-guid-nullable
Don't serialize empty GUID to null
2020-12-08 18:22:18 +01:00
crobibero
e621244405 Add missing EnsureSuccessStatusCode 2020-12-08 08:28:19 -07:00
crobibero
26e5aacb90 Fix JsonConverter recursion 2020-12-08 07:18:25 -07:00
crobibero
8517b28eba Make BaseItemDto Guids nullable 2020-12-07 15:23:40 -07:00
crobibero
66a1880a58 Add number to bool json converter 2020-12-06 20:26:21 -07:00
Bond_009
e4fd61411f Minor improvements 2020-12-02 15:38:52 +01:00
Claus Vium
0a35f35311
Merge pull request #4591 from jellyfin/schedulesdirect
Clean up SchedulesDirect
2020-11-30 19:58:20 +01:00
Joshua M. Boniface
9169a28df1
Merge pull request #4588 from jellyfin/hex
Remove Hex class as the BCL has one now
2020-11-27 01:59:58 -05:00
Bond_009
81ca6cb47c Clean up SchedulesDirect 2020-11-26 21:54:14 +01:00
Bond_009
38932fc7d1 Schedules Direct requires the hex to be lowercase 2020-11-26 13:21:04 +01:00
Bond_009
8c8a71692e Remove Hex class as the BCL has one now 2020-11-25 23:40:31 +01:00
crobibero
0acea5b077 Don't throw null reference if ContentType is null. 2020-11-24 16:42:27 -07:00
Joshua M. Boniface
2c9e355e42
Merge branch 'master' into NetworkPR2 2020-11-21 23:28:15 -05:00
Joshua M. Boniface
d5eb7e786f
Merge pull request #4182 from ryanpetris/fix-hdhomerun
Fix HD Home Run streaming
2020-11-21 17:22:19 -05:00
BaronGreenback
8f25eaeb9d
Update Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-11-21 16:02:54 +00:00
Greenback
616caca2b7 Added more comments. 2020-11-21 13:27:27 +00:00
BaronGreenback
7a6063ed41
Merge branch 'master' into NetworkPR2 2020-11-21 00:35:53 +00:00
Fernando Fernández
e21e00cad5 Merge remote-tracking branch 'upstream/master' into no-scaling 2020-11-19 23:18:25 +01:00
Greenback
a3e47f3e4e Updated to latest Unstable. 2020-11-19 18:27:18 +00:00
Greenback
e51ddd326c Fixes spelling. 2020-11-18 13:23:45 +00:00
Fernando Fernández
38c3b6fcd3 Fix build and thread detection logic 2020-11-18 10:20:59 +01:00
Bond_009
4b1c9dc9ea Pass cancellation where possible 2020-11-17 19:43:00 +01:00
Fernando Fernández
94cae4f145 Specify threads to ffmpeg properly 2020-11-17 16:44:04 +01:00
BaronGreenback
d66f88672c
Merge branch 'master' into NetworkPR2 2020-11-16 16:27:37 +00:00
Ryan Petris
8204b25a56
Merge branch 'master' into fix-hdhomerun 2020-11-15 19:55:30 -07:00
Ryan Petris
81d5eb4db5
Return a Task object and discard it instead of using async void. 2020-11-15 19:44:11 -07:00
crobibero
e66d79fc0c Merge remote-tracking branch 'upstream/master' into http-exception 2020-11-15 13:09:05 -07:00
crobibero
95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Bond_009
c4bb32f259
Access last element by index where possible 2020-11-14 20:28:14 +01:00
Bond_009
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[]) 2020-11-14 20:27:48 +01:00
crobibero
73f9a6d7d0 Convert array property to IReadOnlyList 2020-11-12 08:29:42 -07:00
Neil Burrows
e9d35cb2ca Switching to the more efficient Hex.Encode function 2020-11-08 17:16:51 +00:00
Neil Burrows
866c41519f Perform hashing of Password for Schedules Direct on server 2020-11-08 12:34:35 +00:00
Bond-009
082705c0d8
Merge pull request #4410 from crobibero/m3u-user-agent
Set UserAgent when getting M3u playlist
2020-11-06 16:28:50 +01:00
BaronGreenback
ec245dce90
Merge branch 'master' into NetworkPR2 2020-11-04 20:17:41 +00:00
crobibero
b4d52d8009 Apply patch 2020-11-03 16:38:47 -07:00
crobibero
5d88e61076 Merge remote-tracking branch 'upstream/master' into livetv-ts-fix 2020-11-03 07:05:58 -07:00
Anthony Lavado
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
Minor improvements
2020-11-02 11:10:39 -05:00
crobibero
6763d456ff Set UserAgent when getting M3u playlist 2020-11-01 19:23:28 -07:00
Greenback
83af636c61 Updated with new NetManager 2020-10-31 18:21:46 +00:00
crobibero
0c674b496f Add stream disposal comment. 2020-10-29 13:58:47 -06:00
crobibero
3568c5f39b Fix early filestream close 2020-10-29 13:56:29 -06:00
BaronGreenback
0b5ddc90ff
Merge branch 'master' into NetworkPR2 2020-10-26 13:21:48 +00:00
Bond_009
49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
Jan-Pieter Baert
6f9beef732
Fix SA1012 and SA1013 warnings 2020-10-12 19:22:33 +02:00
Jim Cartlidge
53af1e3455 Updatig netcollection & re-inserting BOM 2020-10-04 09:56:33 +01:00
Jim Cartlidge
fcd1b2f0e4 Merged with latest master 2020-09-30 17:52:33 +01:00
Bond-009
7775066475
Merge pull request #4236 from ConfusedPolarBear/warnings1
Fix some warnings
2020-09-29 09:18:52 +02:00
Matt Montgomery
53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
Ryan Petris
3fa3a9d57a
Preemptively throw a LiveTvConflictException when the tracked live streams for a given device/tuner will exceed the number of supported streams. 2020-09-23 14:23:04 -07:00
Ryan Petris
361f51ac94
Use TcpClient.Connect(). 2020-09-19 15:27:07 -07:00
Ryan Petris
0496e18179
Fix HD Home Run streaming.
* Use LocalEndPoint instead of RemoteEndPoint when determining local address.
* HdHomerunUdpStream.StartStreaming is meant to run until stream is closed, however HdHomerunUdpStream.Open needs to return as soon as stream is open to send stream url back to client. Therefore, StartStreaming should not be awaited on.
* TcpClient(IPEndPoint) treats endpoint as the local endpoint; use TcpClient(string, int) instead as it treats endpoint as the remote endpoint.
2020-09-18 22:29:09 -07:00
Jim Cartlidge
38b8110a3e Removing blank lines. 2020-09-14 15:55:25 +01:00
Jim Cartlidge
b44455ad0d Update based on PR1 changes. 2020-09-14 15:46:38 +01:00
Jim Cartlidge
9ef79d190b Large number of files 2020-09-12 16:41:37 +01:00
Bond_009
384ab39f5b Fix some warnings 2020-09-07 13:20:39 +02:00
crobibero
23df4991b6 Use proper buffer size 2020-09-04 08:24:21 -06:00
crobibero
2a8653b309 Merge remote-tracking branch 'upstream/master' into http-client-migrate 2020-09-04 08:16:49 -06:00
crobibero
ae8ff1ca54 last time I swear 2020-09-03 07:30:34 -06:00
crobibero
4d4dc0b555 Remove ResponseHeadersRead in SchedulesDirect 2020-09-03 07:22:32 -06:00
crobibero
d8a0edc511 Revert "Remove ResponseHeadersRead where applicable"
This reverts commit 85844a84b6.
2020-09-03 07:20:33 -06:00
crobibero
85844a84b6 Remove ResponseHeadersRead where applicable 2020-09-03 06:48:19 -06:00
crobibero
b111b9e2c9 Fix styling 2020-09-01 07:58:05 -06:00
crobibero
e1d0b430d9 Remove HttpRequestOptions 2020-09-01 07:51:55 -06:00
crobibero
4038d15c83 Properly migrate all HttpCompletionOption 2020-09-01 07:51:06 -06:00
Bond_009
e653eef44f Fix some warnings 2020-08-31 22:20:19 +02:00
crobibero
8d592777c4 change to using declaration 2020-08-31 12:46:42 -06:00
crobibero
6ae4da709e migrate to IHttpClientFactory in M3UTunerHost 2020-08-31 12:08:45 -06:00
crobibero
5b93b3b15e migrate to IHttpClientFactory in M3uParser 2020-08-31 12:08:37 -06:00
crobibero
af9ebef577 migrate to IHttpClientFactory in SharedHttpStream 2020-08-31 12:06:42 -06:00
crobibero
96fdee38cb migrate to IHttpClientFactory in HdHomerunHost 2020-08-31 12:03:41 -06:00
crobibero
97cc3d54bb migrate to IHttpClientFactory in XmlTvListingsProvider 2020-08-31 12:00:09 -06:00
crobibero
652e688cc1 migrate to IHttpClientFactory in SchedulesDirect 2020-08-31 11:57:11 -06:00
crobibero
50a1e35765 migrate to IHttpClientFactory in EmbyTV 2020-08-31 11:39:40 -06:00
crobibero
804b0fc034 migrate to IHttpClientFactory in DirectRecorder 2020-08-31 11:38:47 -06:00
Patrick Barron
9fa4fff15d Merge branch 'master' into event-rewrite-1
# Conflicts:
#	Emby.Dlna/Emby.Dlna.csproj
#	Emby.Dlna/Eventing/DlnaEventManager.cs
#	Emby.Dlna/Service/BaseService.cs
#	Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
#	MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009
119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Bond_009
ab2147751f Make MediaBrowser.MediaEncoding warnings free 2020-08-20 12:16:24 +02:00
Patrick Barron
98ed90c4a2 Merge branch 'master' into event-rewrite-1 2020-08-19 18:11:17 -04:00
Bond_009
68edccd9f4 More warn 2020-08-19 18:02:34 +02:00
Bond_009
e77a45adcf Minor change 2020-08-19 17:52:14 +02:00
Bond_009
2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
Patrick Barron
ca1f15af19 Move GenericEventArgs to Jellyfin.Data.Events 2020-08-13 20:52:55 -04:00
Patrick Barron
70e56314d7 Minor fixes to LiveTvMediaSourceProvider 2020-08-13 13:11:30 -04:00
Patrick Barron
8373d6297c Fix MemoryCache usage 2020-08-07 14:05:47 -04:00
Patrick Barron
5c65abcd94 Clean up TunerHost classes 2020-08-04 18:58:14 -04:00
Bond-009
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
Joshua M. Boniface
d7287a05ad
Merge pull request #3684 from Bond-009/warn22
Fix warnings
2020-07-27 00:16:09 -04:00
Bond_009
01e781035f Fix warnings 2020-07-24 16:37:54 +02:00
Bond-009
3ff110984a
Merge branch 'master' into readonlyspan 2020-07-24 09:40:44 +02:00
Patrick Barron
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore 2020-07-23 23:50:12 +00:00
Patrick Barron
7adac7561a Use System.Text.Json in LiveTvManager 2020-07-22 19:52:14 -04:00
Bond_009
febb6bced6 Review usage of string.Substring (part 1)
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Patrick Barron
ab396225ea Migrate Display Preferences to EF Core 2020-07-17 16:11:53 -04:00
telans
98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans
afe09612e8
fix SA1119 2020-06-20 18:13:11 +12:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans
3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
telans
726e116d5b
fix SA1510 2020-06-15 10:40:57 +12:00
Patrick Barron
42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada
403cd3205f
Merge pull request #3254 from crobibero/ilogger
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron
7a115024aa Merge branch 'master' into userdb-efcore
# Conflicts:
#	MediaBrowser.Controller/Library/ILibraryManager.cs
#	MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
aled
22a860a806 Fix a small number of compile warnings 2020-06-06 20:17:49 +01:00
crobibero
57d1dbfe7b undo erroneous changes 2020-06-05 18:29:58 -06:00
crobibero
44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00