Commit Graph

157 Commits

Author SHA1 Message Date
Bond_009
d202df6e8a Remove useless line 2021-03-09 03:22:51 +01:00
Bond_009
9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
Bond_009
5241bd41ef Add code analysis attributes where appropriate 2021-03-09 01:28:21 +01:00
cvium
e0db17a935 do not throw ArgumentNullException in TryCleanString 2021-03-07 22:49:31 +01:00
dependabot[bot]
829442c419
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-01 12:00:38 +00:00
dependabot[bot]
d033c30cd7
Bump coverlet.collector from 3.0.2 to 3.0.3
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 12:00:42 +00:00
Bond_009
54eee41207 Fix broken test 2021-02-17 10:38:44 +01:00
dkanada
2e9661c415
Merge pull request #5043 from senritsu/improve-episode-number-parsing-with-digits-in-names
adjust episode path expression to allow digits in series names
2021-02-05 11:43:32 +09:00
dependabot[bot]
09471a206a
Bump coverlet.collector from 3.0.1 to 3.0.2
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-25 12:00:44 +00:00
Bond-009
3806cc5b3f
Merge pull request #5074 from jellyfin/cov
100% branch coverage for Jellyfin.Naming
2021-01-24 14:11:48 +01:00
Bond_009
956ca0e5aa 100% branch coverage for Jellyfin.Naming 2021-01-21 15:46:10 +01:00
dependabot[bot]
0cb80d3815
Bump coverlet.collector from 3.0.0 to 3.0.1
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-18 12:01:03 +00:00
senritsu
4e21b49994 adjust episode path expression to allow digits in series names
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).

The rule, which matches most standard  anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.

Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.

Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
dependabot[bot]
b00f3334f2
Bump coverlet.collector from 1.3.0 to 3.0.0
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 1.3.0 to 3.0.0.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits/v3.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-11 12:01:03 +00:00
dependabot[bot]
3e062bc0cd
Bump Microsoft.NET.Test.Sdk from 16.8.0 to 16.8.3
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.0 to 16.8.3.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.0...v16.8.3)

Signed-off-by: dependabot[bot] <support@github.com>
2020-12-10 12:57:44 +00:00
crobibero
f512d5167d Remove broken CleanDateTimes regex 2020-11-20 11:27:37 -07:00
crobibero
5b8e248d72 Merge remote-tracking branch 'upstream/master' into video-resolver 2020-11-20 11:21:24 -07:00
BaronGreenback
2bbfcc264d
Merge branch 'master' into emby-namig-nullable 2020-11-16 19:47:36 +00:00
Stepan
3bca1181b3 Taken suggestions from code review and created test for ExtraRuleType.Regex instead of throwing exception there. 2020-11-12 13:16:33 +01:00
Stepan
195a6261c4 Dummy test case explanation. 2020-11-10 19:28:03 +01:00
Stepan
158eff62d7 Xml-doc part2 2020-11-10 19:23:10 +01:00
crobibero
83629ab6f2 Update packages to net5 2020-11-10 09:52:34 -07:00
dependabot[bot]
e15891df51
Bump Microsoft.NET.Test.Sdk from 16.7.1 to 16.8.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.7.1 to 16.8.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.7.1...v16.8.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-11-09 12:00:39 +00:00
Stepan
3d1076ae42 Rest of tests for Emby.Naming code coverage 2020-11-07 12:30:22 +01:00
Stepan
f22e0800e2 Episode parsing coverage 2020-11-07 11:02:12 +01:00
Stepan
3466dc5581 Finish coverage for Emby.Naming.Video 2020-11-05 16:59:15 +01:00
Stepan
5741150367 Enable MultiVersion video tests and added support for naming based on tests 11 & 8 2020-11-05 14:51:27 +01:00
Stepan
c96aa0551d Added NamingOptions tests 2020-11-05 13:25:29 +01:00
Stepan
aef1fe62c2 Complete test coverage for Emby.Naming.Subtitles 2020-11-03 16:25:33 +01:00
Stepan
c060ed1a18 Added resolving of alternative files and extras for audibooks. 2020-11-03 16:24:04 +01:00
Stepan
7b6363b09a Update test for detecting audiobooks extras and alternative files 2020-11-02 23:07:46 +01:00
Stepan
1e71775688 Add Name and Year parsing for audiobooks 2020-11-02 20:03:12 +01:00
Stepan
50a2ef9d8a Simplify Resolve_InvalidExtension Test and created tests for Alternative Versions parsing & Year Extraction for audiobooks 2020-11-01 17:41:47 +01:00
Stepan
f39775dc3a Written test to finish coverage for AudioBookListResolver & AudioBookResolver and corrected some logical erros / unhandled exception 2020-11-01 17:10:48 +01:00
Stepan
60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
Stepan
59619b6ea7 Enable nullable in Emby.Naming 2020-11-01 10:47:31 +01:00
BaronGreenback
d42bb515ce
Merge branch 'master' into video-resolver 2020-10-17 09:26:14 +01:00
Bond_009
74f4affcda Fix AudioBookListResolver test coverage 2020-10-12 20:09:15 +02:00
Bond_009
228b33a23b Minor improvements 2020-09-20 14:02:41 +02:00
Keridos
ba777039ef
remove unnecessary nullchecks 2020-09-09 02:43:06 +02:00
Keridos
8eb1eedc8d
implement suggested changes 2020-09-09 02:33:59 +02:00
Keridos
b9c7cce696
some testing for AudioBook
fix PartNumber detection
2020-09-09 02:24:17 +02:00
Bond-009
6d154041b9
Merge pull request #3880 from DirtyRacer1337/datetime
Fix year parsing
2020-09-05 16:09:05 +02:00
crobibero
b216b91e21 Bump Microsoft.NET.Test.Sdk and add missing reference 2020-08-31 08:14:22 -06:00
crobibero
6709645ec9 bump deps 2020-08-12 15:52:29 -06:00
DirtyRacer1337
6ac8955715 Add tests 2020-08-12 22:20:31 +07:00
dependabot[bot]
4fd2b7a879
Bump Microsoft.NET.Test.Sdk from 16.6.1 to 16.7.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.6.1 to 16.7.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.6.1...v16.7.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-08-10 12:01:45 +00:00
dependabot[bot]
979137f567
Bump coverlet.collector from 1.2.1 to 1.3.0
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2020-06-15 12:01:24 +00:00
telans
bf5b21e67b
enable code analyzers for tests 2020-06-13 23:37:41 +12:00
dependabot[bot]
a4de0bb373
Bump Microsoft.NET.Test.Sdk from 16.5.0 to 16.6.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.5.0 to 16.6.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.5.0...v16.6.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-06-11 10:30:13 +00:00
Erik Rigtorp
82ff3fa75d Add additional resolver tests 2020-06-08 16:35:20 -07:00
aled
3ff6e3ff65 Add code analyzers to Jellyfin.Naming.Tests and fix resulting warnings 2020-05-14 18:59:10 +01:00
aled
2849d2b134 Fix compile warnings in Jellyfin.Naming.Tests 2020-05-13 23:59:19 +01:00
Anthony Lavado
0e11646107
Merge pull request #2950 from Bond-009/videoresolver
Fix VideoResolver and tests
2020-05-04 04:21:30 -04:00
Vasily
aff65adca9
Merge pull request #2917 from Bond-009/tests
Improved tests
2020-04-29 12:17:39 +03:00
Bond_009
99fe8dbe62 Remove BaseVideoTest 2020-04-25 18:55:54 +02:00
Bond_009
da17a1201f Please roslyn 2020-04-25 15:49:53 +02:00
Bond_009
a273ed9a57 Address comments 2020-04-25 15:29:59 +02:00
Bond-009
c0b3c11b2e
Merge pull request #2846 from jellyfin/azure
Remove requirement to build web during server builds
2020-04-22 00:17:44 +02:00
Mark Monteiro
c5f163293f Add <ProjectGuid> properties to all project files
This is required for SonarCloud analysis to run
2020-04-21 16:21:09 -04:00
Bond_009
851dda097e Minor improvement 2020-04-21 12:54:04 +02:00
Bond_009
735e7c3f7d Fix VideoResolver and tests 2020-04-21 12:11:55 +02:00
Bond_009
e21d6160c1 Address comments 2020-04-21 10:21:20 +02:00
Bond_009
fc3e2baccc Address comments 2020-04-19 18:27:07 +02:00
Bond_009
d99536e99f Improved tests 2020-04-19 11:57:03 +02:00
Delgan
be6cc9644f Another iteration 2020-04-13 16:11:02 +02:00
Delgan
90d289f946 Fix failing tests? 2020-04-13 15:55:18 +02:00
dtparr
41f6fa0ae8
Whitespace fix
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-04-11 13:33:16 -05:00
dtparr
e027f4645f
Whitespace fix
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-04-11 13:33:06 -05:00
dtparr
8e67cb541e Refactor the NamingOptions instantiations from both new and pre-existing facts/theories to be a readonly field to save instantiation costs 2020-04-10 23:00:30 +00:00
dtparr
8e42d0063d Fix tab/space issue causing github oddity 2020-04-10 21:21:22 +00:00
dtparr
ce86455747 Update to use the Theory/InlineData method to parameterize unit tests 2020-04-10 21:18:41 +00:00
dtparr
1f33c51977 Add Unit Test for the Extras directories.
Parameterize the valid extras as well as the null conditions.
2020-04-10 03:50:17 +00:00
dependabot-preview[bot]
b80c2a532e
Bump coverlet.collector from 1.2.0 to 1.2.1
Bumps [coverlet.collector](https://github.com/tonerdo/coverlet) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/tonerdo/coverlet/releases)
- [Commits](https://github.com/tonerdo/coverlet/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-03 10:44:33 +00:00
dependabot-preview[bot]
b10f268c43
Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-26 17:15:35 +00:00
Narfinger
107974e3f8 moves shows tests to Theory and InlineData format 2020-02-27 11:35:01 +09:00
dkanada
fd3ee279de
Merge pull request #2448 from Narfinger/tests-fix2
adds names from the episodenumber tests to path tests
2020-02-27 02:05:16 +09:00
Narfinger
496bdc65f3 adds names from the episodenumber tests to path tests 2020-02-23 19:45:29 +09:00
Narfinger
fd5f0c54a6 fixes formatting and enabling another test 2020-02-23 18:50:33 +09:00
Narfinger
b306b8b881 add todos and fixes some todo tests 2020-02-23 18:46:10 +09:00
Narfinger
4dabc50f09 fixes last tests and cleanup 2020-02-23 18:31:23 +09:00
Narfinger
c2fe628c79 removed failing tests 2020-02-23 18:19:19 +09:00
Narfinger
21f11c600a converted tests to inlinedata 2020-02-23 12:12:48 +09:00
Bond-009
7df6d4e7a0
Update EpisodeNumberTests.cs 2020-02-20 12:02:45 +01:00
Bond_009
dfd74adc15 Add test 2020-02-19 22:51:30 +01:00
Bond_009
620047ab9a Fix episode parsing 2020-02-19 22:35:40 +01:00
dkanada
8ee917143f
Merge pull request #2358 from Bond-009/tests
Enable TreatWarningsAsErrors and Nullable for test projects
2020-02-14 00:31:00 +09:00
Bond-009
22510909fb
Update Jellyfin.Naming.Tests.csproj 2020-02-06 13:00:15 +01:00
Bond-009
d5fcca3d05
Merge branch 'master' into naming 2020-02-05 23:28:00 +01:00
Bond_009
71abf1d3ce Enable TreatWarningsAsErrors and Nullable for test projects 2020-01-31 22:46:10 +01:00
Bond_009
87d2479b78 Fix warnings 2020-01-31 22:26:53 +01:00
Bond_009
2186df8ac4 Update deps 2020-01-28 22:42:07 +01:00
Bond_009
dc62e436c4 Clean up Emby.Naming 2020-01-22 22:18:56 +01:00
Vasily
f23434f4f7
Merge pull request #2299 from dkanada/testing
Fix a few more tests for music and episodes
2020-01-21 13:21:24 +03:00
dkanada
11c758b6be remove unsupported test cases 2020-01-21 00:20:24 +09:00
dkanada
e700fc8a07 fix and remove a few more tests 2020-01-19 00:18:55 +09:00
Bond_009
cd0592ea8f Improve parsers 2020-01-11 22:17:05 +01:00
Bond_009
b1dc595be1 Fix a couple of tests 2020-01-11 22:17:05 +01:00
Bond_009
a647dc5705 Cleanup tests 2020-01-11 22:17:05 +01:00
Bond_009
b50c4938e1 Merge branch 'master' into namingtests 2020-01-09 18:26:22 +01:00