Commit Graph

212 Commits

Author SHA1 Message Date
Joe Rogers
6e4710d048
Fix review comment
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-04-03 23:36:32 +02:00
Joe Rogers
ac675318f8
Simplify RefreshSingleItem 2022-04-03 23:36:32 +02:00
Joe Rogers
bdce435b09
Reorder and flatten provider filtering 2022-04-03 23:36:30 +02:00
Joe Rogers
a7c009e2eb
Pass TypeOptions instead of full LibraryOptions 2022-04-03 23:34:49 +02:00
Joe Rogers
e7df72de49
Improve metadata provider sorting
Extract configured order up front instead of for each provider
Non-IHasOrder providers default to middle, not beginning
Merge image and metadata sort helper methods
2022-04-03 23:34:49 +02:00
Joe Rogers
11c7c24f0e
Clarify naming, minor method ordering improvement 2022-04-03 23:34:49 +02:00
Joe Rogers
6221991c63
Add nullable annotations 2022-04-03 23:34:48 +02:00
Joe Rogers
8515e8fbd1
Improve image provider sorting
Remove irrelevant check for ILocalImageProvider
Providers that are not IHasOrder default to middle, not beginning
2022-04-03 23:34:48 +02:00
Joe Rogers
4ace7f5c53
Fix unused var, log typo 2022-04-03 23:34:47 +02:00
Joe Rogers
2e2a594e19
Move Get*Providers definitions to interface 2022-04-03 23:34:47 +02:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Bond_009
e7be01d7a5 Flush to disk async where possible 2022-01-22 23:36:42 +01:00
cvium
b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Cody Robibero
32629cd7da Use BaseItemKind where possible 2021-12-12 06:11:27 -07:00
Bond_009
f5ca9cbc3b Enable nullable for MediaBrowser.Providers 2021-10-26 15:49:01 +02:00
Bond_009
9af16fcb6c Remove workaround for dotnet/runtime#42790 2021-10-03 19:52:38 +02:00
Chris Tam
b0cd1f5e39 Fix images "not loading" after manual identification 2021-09-09 19:16:15 -04:00
Claus Vium
74fef6c05b
Merge pull request #6177 from Bond-009/async
Use async FileStreams where it makes sense
2021-09-06 13:55:34 +02:00
Bond_009
e3dac4fda2 Use async FileStreams where it makes sense 2021-09-02 14:02:04 +02:00
Cody Robibero
cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Cody Robibero
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) (#6078)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
wehrstedt
ad1d9d9a23
fixed no channel icons when using tvheadend (#5996)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Maximilian Wehrstedt <wehrstedt.coding@outlook.de>
2021-05-06 23:07:32 +02:00
Bond-009
86a2e6eeda
Merge pull request #5867 from Bond-009/provider
ProviderManager: fix discard and 2 warnings
2021-04-21 13:53:53 +02:00
Bond-009
da78a96312
Merge pull request #5807 from Bond-009/refreshdelay
Remove throttle in refresh code
2021-04-21 13:52:05 +02:00
Bond_009
dcd6ab769b ProviderManager: fix discard and 2 warnings 2021-04-19 23:52:58 +02:00
BaronGreenback
bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
Bond_009
3d0a42da9e Remove throttle in refresh code 2021-04-13 20:09:50 +02:00
Bond_009
2ed0801be2 Fix possible nullref
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`

```
Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
cvium
ba366118f9 Do not use language or imagelanguages when searching for images
TMDb API returns all images if languages are excluded, which is needed for the All Languages toggle in Identify.
2021-03-05 08:18:04 +01:00
cvium
664c5da317 return false when providerid is null or empty 2021-03-03 09:09:57 +01:00
martinek-stepan
cc92f7afe5
Enable nullable for MediaBrowser.XbmcMetadata project (#4612)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Stepan <ste.martinek+git@gmail.com>
2020-12-31 12:09:25 +01:00
Gary Wilber
2b6b2cbf31 Remove Lazy 2020-12-02 23:23:13 -08:00
Gary Wilber
f4edca7c27 Move MetadataRefreshThrottler to BaseItemManager 2020-12-02 18:51:53 -08:00
Claus Vium
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Bond_009
4b1c9dc9ea Pass cancellation where possible 2020-11-17 19:43:00 +01:00
crobibero
95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
crobibero
64b32d3290 Use BaseItemManager 2020-10-27 18:01:52 -06:00
Gary Wilber
25d8d85740 Back to HttpException 2020-09-29 01:19:12 -07:00
Gary Wilber
e9911b70dd Use EnsureSuccessStatusCode 2020-09-28 18:12:35 -07:00
Gary Wilber
722ec43e25 remove status code from exception message 2020-09-27 23:05:43 -07:00
Gary Wilber
3ca9b13f99 Check response status code before saving images 2020-09-27 21:47:30 -07:00
Bond_009
384ab39f5b Fix some warnings 2020-09-07 13:20:39 +02:00
crobibero
dd078e7b82 use named client 2020-08-31 11:05:21 -06:00
Patrick Barron
9fa4fff15d Merge branch 'master' into event-rewrite-1
# Conflicts:
#	Emby.Dlna/Emby.Dlna.csproj
#	Emby.Dlna/Eventing/DlnaEventManager.cs
#	Emby.Dlna/Service/BaseService.cs
#	Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
#	MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Patrick Barron
98ed90c4a2 Merge branch 'master' into event-rewrite-1 2020-08-19 18:11:17 -04:00
Bond_009
2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
crobibero
767c73e5c1 fix usings 2020-08-17 13:22:42 -06:00
crobibero
1325815182 Remove IHttpClient from Providers 2020-08-17 13:10:02 -06:00
crobibero
f7dc124b5e Remove IHttpClient from ProviderManager 2020-08-17 11:50:07 -06:00
Patrick Barron
ca1f15af19 Move GenericEventArgs to Jellyfin.Data.Events 2020-08-13 20:52:55 -04:00