Commit Graph

14917 Commits

Author SHA1 Message Date
Ben Magee
d1461b4238
Changed cast style as suggested, improved some member names to make them less ambiguous 2019-12-22 23:21:20 +00:00
Ben Magee
00c6d392a1
Added tests for FirstTimeSetupOrElevatedHandler 2019-12-22 23:18:42 +00:00
Ben Magee
ef75455178
Test RequiresElevationHandler for all roles 2019-12-22 22:54:46 +00:00
Ben Magee
8d06d0dbdf
Removed unneeded dependency 2019-12-22 22:39:29 +00:00
Ben Magee
8c4e679ff4
PR style comments 2019-12-22 22:36:11 +00:00
Bond_009
f9a454628d Preformance!!! 2019-12-22 22:21:41 +01:00
Bond_009
cf2e2a3f30 Fix exceptions while scanning
Fixes these exceptions:
```
[2019-12-22 20:48:14.779 +01:00] [ERR] Error in WaitForExit
System.InvalidOperationException: No process is associated with this object.
   at System.Diagnostics.Process.EnsureState(State state)
   at System.Diagnostics.Process.EnsureState(State state)
   at System.Diagnostics.Process.GetWaitState()
   at System.Diagnostics.Process.WaitForExitCore(Int32 milliseconds)
   at System.Diagnostics.Process.WaitForExit(Int32 milliseconds)
   at Emby.Server.Implementations.Diagnostics.CommonProcess.WaitForExit(Int32 timeMs) in /home/pi/dev/jellyfin/Emby.Server.Implementations/Diagnostics/CommonProcess.cs:line 100
   at MediaBrowser.MediaEncoding.Encoder.MediaEncoder.StopProcess(ProcessWrapper process, Int32 waitTimeMs) in /home/pi/dev/jellyfin/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs:line 785
[2019-12-22 20:48:14.790 +01:00] [INF] Killing ffmpeg process
[2019-12-22 20:48:14.795 +01:00] [ERR] Error killing process
System.InvalidOperationException: No process is associated with this object.
   at System.Diagnostics.Process.EnsureState(State state)
   at System.Diagnostics.Process.EnsureState(State state)
   at System.Diagnostics.Process.Kill()
   at Emby.Server.Implementations.Diagnostics.CommonProcess.Kill() in /home/pi/dev/jellyfin/Emby.Server.Implementations/Diagnostics/CommonProcess.cs:line 95
   at MediaBrowser.MediaEncoding.Encoder.MediaEncoder.StopProcess(ProcessWrapper process, Int32 waitTimeMs) in /home/pi/dev/jellyfin/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs:line 799
[2019-12-22 20:48:14.808 +01:00] [ERR] Error in "ffprobe"
System.Text.Json.JsonException: The JSON value could not be converted to System.String. Path: $.streams[0].start_pts | LineNumber: 32 | BytePositionInLine: 26.
 ---> System.InvalidOperationException: Cannot get the value of a token type 'Number' as a string.
   at System.Text.Json.Utf8JsonReader.GetString()
   at System.Text.Json.Serialization.Converters.JsonConverterString.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
   at System.Text.Json.JsonPropertyInfoNotNullable`4.OnRead(JsonTokenType tokenType, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.JsonPropertyInfo.Read(JsonTokenType tokenType, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.JsonSerializer.HandleValue(JsonTokenType tokenType, JsonSerializerOptions options, Utf8JsonReader& reader, ReadStack& state)
   at System.Text.Json.JsonSerializer.ReadCore(JsonSerializerOptions options, Utf8JsonReader& reader, ReadStack& readStack)
   --- End of inner exception stack trace ---
   at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& readStack, Utf8JsonReader& reader, Exception ex)
   at System.Text.Json.JsonSerializer.ReadCore(JsonSerializerOptions options, Utf8JsonReader& reader, ReadStack& readStack)
   at System.Text.Json.JsonSerializer.ReadCore(JsonReaderState& readerState, Boolean isFinalBlock, ReadOnlySpan`1 buffer, JsonSerializerOptions options, ReadStack& readStack)
   at System.Text.Json.JsonSerializer.ReadAsync[TValue](Stream utf8Json, Type returnType, JsonSerializerOptions options, CancellationToken cancellationToken)
   at MediaBrowser.MediaEncoding.Encoder.MediaEncoder.GetMediaInfoInternal(String inputPath, String primaryPath, MediaProtocol protocol, Boolean extractChapters, String probeSizeArgument, Boolean isAudio, Nullable`1 videoType, Boolean forceEnableLogging, CancellationToken cancellationToken) in /home/pi/dev/jellyfin/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs:line 399
   at MediaBrowser.Providers.MediaInfo.FFProbeVideoInfo.ProbeVideo[T](T item, MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/pi/dev/jellyfin/MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs:line 122
   at MediaBrowser.Providers.Manager.MetadataService`2.RunCustomProvider(ICustomMetadataProvider`1 provider, TItemType item, String logName, MetadataRefreshOptions options, RefreshResult refreshResult, CancellationToken cancellationToken) in /home/pi/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 815
```
2019-12-22 22:09:09 +01:00
Waldemar Tomme
57aec873d0 Add check if output container supports "global_header" flag 2019-12-22 13:01:18 +01:00
Ben Magee
f47c7959af
Wrote tests to cover CustomAuthenticationHandler 2019-12-22 09:46:09 +00:00
Bond_009
b87750d8e0 Update vs code workspace 2019-12-20 21:50:15 +01:00
Bond_009
5751d86536 Fix warnings and move to System.Text.Json 2019-12-20 21:49:16 +01:00
David
94d3dda324 Refactor seriesId 2019-12-20 20:10:02 +01:00
David
d720d8f356 Add requested changes 2019-12-20 20:04:27 +01:00
Bond_009
7f5a174dff Merge branch 'master' into warn12 2019-12-20 19:43:57 +01:00
Bond-009
137db45fc7
Apply suggestions from code review
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2019-12-19 22:01:05 +01:00
David
ce8754d052 Refactor list of RemoteImageInfo 2019-12-19 19:58:00 +01:00
David
1f323683b3 Add requested changes 2019-12-19 18:59:55 +01:00
Bond-009
bb62dd14c2 Limit size for playbacktest 2019-12-19 17:46:17 +01:00
Vasily
06dfa2e687
Merge pull request #2134 from Bond-009/dlnam3u8
Fix comparison between different types
2019-12-19 18:51:51 +03:00
Bond-009
a5cd11735c Minor changes to MediaInfoService 2019-12-19 15:54:27 +01:00
David
eb12754fc5 Add Tmdb as a Provider for Season Images
Changes to be committed:
	modified:   CONTRIBUTORS.md
	new file:   MediaBrowser.Providers/Tmdb/TV/TmdbSeasonImageProvider.cs
	modified:   MediaBrowser.Providers/Tmdb/TV/TmdbSeasonProvider.cs
2019-12-18 17:27:44 +01:00
Bond-009
5c9e849b85 Enable analyzers 2019-12-18 12:03:54 +01:00
Bond-009
a1ca50fd5a Merge branch 'namingtests' of https://github.com/Bond-009/jellyfin into namingtests 2019-12-18 11:53:41 +01:00
Bond-009
8723bdbb4f Fix tests 2019-12-18 11:52:32 +01:00
dkanada
bc7cbfb21a
Merge pull request #1941 from Bond-009/mediaencoding
Make probesize and analyzeduration configurable and simplify circular dependencies
2019-12-18 08:54:40 +09:00
pagaiba
0f444c21e9 Translated using Weblate (Catalan)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/ca/
2019-12-17 13:16:15 -05:00
Bond_009
742d84e53f Enable analyzers for Emby.Naming 2019-12-17 17:41:12 +01:00
Bond-009
91562a4392
Merge pull request #2155 from mark-monteiro/2149-jellyfin-drawing-skia-warnings
Jellyfin.Drawing.Skia Warnings and Analyzers
2019-12-17 17:39:35 +01:00
Bond-009
6b185119aa
Merge branch 'master' into namingtests 2019-12-17 17:35:27 +01:00
Óskar Freyr
db61a58c39 Translated using Weblate (Icelandic)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/is/
2019-12-16 12:16:14 -05:00
tanto faz
dda431dff1 Translated using Weblate (Portuguese (Brazil))
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/pt_BR/
2019-12-16 12:16:14 -05:00
Roland Vet
6fb7999a14 Translated using Weblate (Dutch)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/nl/
2019-12-16 12:16:14 -05:00
Robin
a7a4974d95 Translated using Weblate (Dutch)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/nl/
2019-12-16 12:16:14 -05:00
schbal
c6851bd72c Translated using Weblate (Korean)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/ko/
2019-12-16 12:16:14 -05:00
dkanada
61b9845e0f
Merge pull request #2099 from cryptobank/master
Fix VAAPI encoding on 10-bit hevc. Update QSV encoding and scaling to...
2019-12-15 19:54:20 +09:00
cryptobank
d063300af4
Add space
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-12-15 20:35:52 +10:30
Bond-009
b8c61a5c40
Merge pull request #2146 from cromefire/patch-1
Fix invalid username handling
2019-12-15 10:07:22 +01:00
Joshua M. Boniface
d79242c3c7 Remove broken Microsoft SDK image (#2158)
* Remove broken Microsoft SDK image

This was not working; for some reason the Microsoft .NET Docker image
for 3.0 still had a 2.1 binary which was wreaking havoc. Replace it with
the manual download that all the other .deb packages use.

* Install missing dependency
2019-12-15 01:55:07 -05:00
dkanada
28e922326d
remove space
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-12-15 13:38:59 +09:00
Mark Monteiro
3924df9c51 Move CA1032 rule to correct location 2019-12-14 23:35:28 +01:00
Neil Burrows
d9c0721e3d Reformatting code 2019-12-14 17:48:30 +00:00
Mark Monteiro
47805d89fe Set CA1032 (Implement standard exception constructors) severity to info globally
This replaces the existing [SurpressMessage] attribute
2019-12-14 16:01:24 +01:00
Mark Monteiro
4c30557527 Remove commented code 2019-12-14 15:48:35 +01:00
Mark Monteiro
f7eef1aa7f Use the correct verbiage for documenting thrown exceptions 2019-12-14 15:47:35 +01:00
dkanada
623e85a9e4
add suggested changes
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-12-14 22:34:18 +09:00
Bond-009
831d1daa68
Merge pull request #2152 from dkanada/progress
Track progress for any item that supports the feature
2019-12-14 14:06:13 +01:00
Mark Monteiro
c1c1672d0f Fix remaining StyleCop warnings 2019-12-14 12:20:52 +01:00
Mark Monteiro
c05933234a Enable TreatWarningsAsErrors flag is project file 2019-12-14 11:46:25 +01:00
Mark Monteiro
2c3e1b8562 Enable StyleCop analyzer and fix existing issues 2019-12-14 11:04:22 +01:00
Mark Monteiro
b8c8d45b8d Enable Serilog and multithreading analyzer 2019-12-14 10:53:54 +01:00