Shadowghost
5cdb0c7932
Apply review suggestions
2023-02-20 11:53:20 +01:00
Shadowghost
2e315b7f08
Properly build where clause for rating checks
2023-02-20 11:53:20 +01:00
Bond_009
24a7e210c3
Optimize tryparse
...
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Claus Vium
f5c970e67f
Merge pull request #9297 from crobibero/livetv-tweaks
...
LiveTV fixes
2023-02-12 13:07:18 +01:00
Cody Robibero
32eccc139c
LiveTV fixes
2023-02-11 07:46:52 -07:00
Jpuc1143
7fa6d4c81e
Add "Allowed Tags" to Parental Controls
2023-01-20 16:43:59 -03:00
Bond_009
8ff0cb1e9d
Remove AddPeopleQueryIndex migration
2023-01-14 21:39:47 +01:00
Bond_009
ab918c6292
Fine tune DB settings
2023-01-14 21:39:46 +01:00
Brad Beattie
ac9b7142cc
Fixing similar parental rating calculation ( #8959 )
2023-01-07 11:31:33 -07:00
Brad Beattie
f0376cdad9
Augment tag searching to consider all ItemValues
2022-12-28 16:13:36 -08:00
Bond-009
3f82c90c48
Improve DB perf for everyone not using debug logging ( #8827 )
2022-12-14 22:03:38 +01:00
Bond-009
d34ded211e
Merge pull request #8842 from bradbeattie/master
2022-12-11 20:27:44 +01:00
Brad Beattie
ab145c5ddc
Search tags as well
2022-12-05 17:38:51 -08:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Bond-009
b2def4c9ea
Fix build ( #8859 )
2022-12-05 14:56:58 +01:00
SteveTheGrey
87d4ef7403
Minor search update - full word titles matches first ( #8757 )
2022-11-27 09:03:28 -07:00
cvium
08d2acba20
Backport pull request #8662 from jellyfin/release-10.8.z
...
fix: use a combination of ParentIndexNumber and IndexNumber to determine next up episodes
Original-merge: 45f3fb1cfc
Merged-by: Joshua M. Boniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-31 23:08:42 -04:00
cvium
812a4170ee
Backport pull request #8501 from jellyfin/release-10.8.z
...
fix: set MinIndexNumber for the next up query
Original-merge: 679e83082f
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-28 22:38:58 -04:00
Joe Rogers
62799697a1
Fix localization lookup
2022-10-07 07:48:31 -04:00
Joe Rogers
2e4db18ebe
Add hearing impaired subtitle stream indicator ( #7379 )
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-10-07 12:38:05 +02:00
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Joshua Boniface
bffda19bbc
Backport pull request #8166 from jellyfin/release-10.8.z
...
Bind @userid only when it's in the statement
Authored-by: Joseph <1315585+joseph39@users.noreply.github.com>
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Original-merge: 057e8ef240
2022-07-24 12:35:47 -04:00
Joshua M. Boniface
fe32b5e333
Merge pull request #7964 from jellyfin/dovi-side-data
...
(cherry picked from commit 39d185c7b1
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:15 -04:00
Cody Robibero
5b0af106c2
Merge pull request #7940 from Shadowghost/fix-recommendations
...
(cherry picked from commit 6749313249
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Bond-009
2b1a915ead
Merge pull request #7604 from Jellifi007/fixes-diactritics
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero
efcdab116f
Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
...
(cherry picked from commit 60affd0965
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero
78a8c26690
Don't allow unknown sort-by
2022-03-25 09:18:18 -06:00
Joe Rogers
1a307db7eb
Add label for external audio/sub tracks
2022-03-10 22:20:35 +01:00
Bond_009
23ea14aa27
Clean up SqliteItemRepository
...
* remove dead code
* reduce allocations
2022-02-15 22:27:38 +01:00
Bond_009
1c14c86b20
Fix some warnings
2022-02-14 14:46:04 +01:00
Cody Robibero
a60cb280a3
Properly populate QueryResult
2022-01-20 08:53:06 -07:00
Cody Robibero
7d63377194
Use provided SortOrder
2022-01-04 13:07:51 -07:00
Cody Robibero
f802763e8f
Reverse all order-by
2022-01-03 07:59:50 -07:00
Cody Robibero
c3071f8996
Fix orderby query
2021-12-31 08:03:08 -07:00
Cody Robibero
7bfc6b5679
Remove more warnings
2021-12-27 07:38:06 -07:00
Bond_009
ea8f40e84a
More cleanup
2021-12-27 14:20:05 +00:00
Bond_009
cbfa355e31
Update StyleCop
2021-12-24 18:28:27 +01:00
Cody Robibero
8ddba55214
Use string builder instead of string interpolation
2021-12-16 09:18:51 -07:00
Cody Robibero
0dd304f86c
Log warning for unknown BaseItemKind to Type mapping
2021-12-16 07:54:22 -07:00
Cody Robibero
249a1ca955
Add mapping from BaseItemKind to Type.FullName for querying
2021-12-15 17:57:39 -07:00
Cody Robibero
87439665d7
Use array instead of HashSet
2021-12-14 15:10:40 -07:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
Patrick Barron
21007aec20
Fix warnings in Data
2021-10-02 13:03:04 -04:00
Bond_009
5fd315b17c
Address comments
2021-09-24 20:15:46 +02:00
Bond_009
4d1d9f23d5
Use new Enum.TryParse(ReadOnlySpan<char>) overload
2021-09-24 20:15:46 +02:00
Fernando Fernández
3d0b1ccae6
Remove all unused usings
2021-09-06 21:15:30 +02:00
Bond_009
637e86478f
Fix some warnings
2021-09-03 19:32:11 +02:00
Cody Robibero
ec13412155
Merge remote-tracking branch 'upstream/master' into warn-259810
2021-09-03 06:56:45 -06:00
Bond_009
286dabdc4b
Add SqliteItemRepository.ItemImageInfoFromValueString as a fuzzing
...
target
and add test cases
2021-09-02 21:28:00 +02:00
Cody Robibero
ecb4b8e0aa
Apply suggestions from code review
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-08-30 07:11:34 -06:00
Cody Robibero
cba07b1ca6
Remove more and more warnings
2021-08-28 16:32:50 -06:00
Bond_009
981cf4cfa0
Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net
2021-06-22 09:48:40 +02:00
Bond_009
6f8ccab788
Move non-jellyfin extensions to separate project
2021-06-19 18:04:46 +02:00
Bond_009
5fb72951a0
Add test for ReadOnlySpan.Count extension
2021-06-12 00:56:09 +02:00
cvium
9111730a0a
More review
2021-06-05 20:16:04 +02:00
cvium
0835b26889
review
2021-05-31 13:55:54 +02:00
cvium
42a2cc1747
Remove some unnecessary allocations
2021-05-24 00:30:41 +02:00
cvium
3b59064f97
Bump SQLitePCL.pretty.netstandard to 3.0.1
2021-05-21 19:35:00 +02:00
Bond_009
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
2021-05-20 22:48:53 +02:00
Bond-009
e8790bfa96
Merge pull request #6054 from cvium/allocationz_2_extreme_db_plsdonthurtme
2021-05-20 22:40:25 +02:00
cvium
e0f793799a
Fix build
2021-05-19 19:52:45 +02:00
cvium
1027792b16
Review changes
2021-05-19 08:51:46 +02:00
Bond_009
2b321d8b89
Enable nullable for InternalItemsQuery
2021-05-18 12:23:26 +02:00
cvium
be4aeb5c2c
Rename SQL extension methods
2021-05-16 19:06:10 +02:00
cvium
1b49435a0e
Reduce some allocations
2021-05-16 14:49:11 +02:00
Bond-009
50f617357b
Merge pull request #5929 from crobibero/sort
2021-05-11 12:41:25 +00:00
Bond-009
d729a76707
Merge pull request #5934 from Bond-009/utf8
...
SqliteItemRepository: Parse ChannelId directly from utf-8 data
2021-05-05 14:04:20 +02:00
cvium
c0feb3694b
rename to SplitEnumerator and fix test
2021-05-03 23:51:45 +02:00
Claus Vium
b9d18f0fa7
Merge branch 'master' into allocationz
2021-05-03 22:52:31 +02:00
Bond_009
874f92e93a
Add tests for SqliteItemRepository.(De)SerializeProviderIds
2021-05-02 12:45:02 +02:00
Bond_009
8a6b9e1fb6
Add tests for SqliteItemRepository.(De)SerializeImages
2021-05-02 00:26:30 +02:00
cvium
716cbb0695
remove span based setproviderid
2021-04-30 23:35:29 +02:00
cvium
a6726730fc
revert the last bits of the getcount experiment
2021-04-30 15:11:16 +02:00
cvium
608cba817c
Reduce some allocations with the magic of spans etc.
2021-04-30 15:09:36 +02:00
Bond_009
34313ef216
SqliteItemRepository: Parse ChannelId directly from utf-8 data
2021-04-29 16:23:29 +02:00
crobibero
d27ca993a5
Add ability to sort on Genre, MusicGenre, Artist
2021-04-28 18:33:30 -06:00
Bond_009
a02e37daa0
SqliteItemRepository: remove redundant operations
...
removed:
* nameof -> FullName lookup
* IndexOf before Replace
* Enum.GetNames -> Enum.Parse roundtrip
2021-04-22 16:05:12 +02:00
Claus Vium
db530e61f5
move IsPlayed to outerquery
...
IsPlayed is a column in UserDatas and does not belong in the inner query. None of the other UserDatas columns are in the innerquery.
2021-04-09 11:32:19 +02:00
Bond_009
a8ed753f6c
FxCop -> Net Analyzers (part 2)
2021-03-13 22:33:28 +01:00
Bond_009
141efafd3d
Enable TreatWarningsAsErrors for MediaBrowser.Model
2021-02-20 23:29:33 +01:00
Bond_009
65bab55ca0
Minor improvements
2021-02-13 00:39:18 +01:00
crobibero
60b7e49a7f
Suggestions from code review
2020-12-04 08:00:55 -07:00
crobibero
b7443f6042
Optimize FavoritePersons query
2020-12-03 20:16:11 -07:00
Matt Montgomery
185476c08a
Add support for query negation
2020-11-27 16:12:16 -06:00
Matt Montgomery
0758d84a61
Test query value
2020-11-25 16:54:16 -06:00
crobibero
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
2020-11-16 20:29:46 -07:00
Bond_009
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
2020-11-14 20:27:48 +01:00
cvium
b99519898d
Remove duplicate /Similar endpoints and add poor matching for artists and albums
2020-11-09 20:15:15 +01:00
cvium
584b4fa41f
Fix Persons, Genres and Studios endpoints
2020-11-05 12:27:22 +01:00
Anthony Lavado
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
2020-11-02 11:10:39 -05:00
Bond_009
49569ca0a0
Use nameof where possible
2020-10-17 16:19:57 +02:00
Jan-Pieter Baert
ec91d3893d
Fix SA 1116 warnings
2020-10-12 20:05:11 +02:00
Jan-Pieter Baert
6f9beef732
Fix SA1012 and SA1013 warnings
2020-10-12 19:22:33 +02:00
Matt Montgomery
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
2020-09-28 15:04:31 -05:00
Bond_009
15be11fca8
Fix build
2020-09-09 14:22:27 +02:00
Bond_009
48e1cf9fd7
Minor performance improvements to item saving
2020-09-09 13:38:27 +02:00
crobibero
5f64ab02a0
bump System.Text.Json
2020-08-25 07:33:58 -06:00
crobibero
340f83c3f5
Ignore null json values
2020-08-23 07:48:12 -06:00
Bond_009
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
2020-08-20 12:16:24 +02:00