Commit Graph

817 Commits

Author SHA1 Message Date
ArabCoders
07db2025a1 Refactored the code to not use reflection. 2023-11-13 17:32:24 +03:00
ArabCoders
2a25c5a2e3 Refactored api call logic handling. 2023-11-13 15:51:06 +03:00
Cody Robibero
892973a9e3
Merge branch 'master' into media-type 2023-11-09 22:03:55 -07:00
Cody Robibero
906f701fa8
Convert CollectionType, SpecialFolderType to enum (#9764)
* Convert CollectionType, SpecialFolderType to enum

* Hide internal enum CollectionType values

* Apply suggestions from code review

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>

* Fix recent change

* Update Jellyfin.Data/Attributes/OpenApiIgnoreEnumAttribute.cs

Co-authored-by: Patrick Barron <barronpm@gmail.com>

---------

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
Co-authored-by: Patrick Barron <barronpm@gmail.com>
2023-11-09 14:00:29 -07:00
Cody Robibero
c7a94d48ae
Convert ItemSortBy to enum (#9765)
* Convert ItemSortBy to enum

* Rename Unknown to Default
2023-11-09 14:00:13 -07:00
Stepan Goremykin
38d962242a Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Updates/InstallationManager.cs
#	tests/Jellyfin.Server.Integration.Tests/OpenApiSpecTests.cs
2023-10-14 00:45:52 +02:00
Stepan Goremykin
8d7e4229ca Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Net/SocketFactory.cs
#	RSSDP/SsdpCommunicationsServer.cs
#	RSSDP/SsdpDeviceLocator.cs
#	RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Bond_009
d7748cfa04 Multiple Stream changes
* Remove useless MemoryStream in DlnaHttpClient
* Use HttpContent.ReadFromJsonAsync extension
* Call ConfigureAwait for IAsyncDisposable
* Use HttpContent.CopyToAsync where possible
2023-10-11 18:32:57 +02:00
Cody Robibero
2920611ffc Convert string MediaType to enum MediaType 2023-10-10 15:57:15 -06:00
Bond-009
406c5df8a3
Merge pull request #10345 from Bond-009/getperson 2023-10-08 14:07:38 +02:00
Stepan Goremykin
f84469d500 Remove redundant using directives 2023-10-08 00:50:02 +02:00
Stepan Goremykin
8ea812b65d Reduce string literal length by using verbatim string 2023-10-08 00:26:12 +02:00
Stepan Goremykin
a37dc3da96 Use async overload 2023-10-08 00:17:48 +02:00
Bond_009
b176beb88e Reduce string allocations
Some simple changes to reduce the number of allocated strings
2023-10-06 01:04:25 +02:00
Bond_009
852f1dc0c1 Don't create non existent persons in LibraryManager.GetPerson
return null instead.

GetStudio, GetGenre, GetMusicGenre, GetYear, GetArtist still create a new one
when the requested one doesn't exist

Fixes #3901
2023-10-05 23:16:17 +02:00
Claus Vium
467aa40d21
Merge pull request #10222 from Bond-009/photos 2023-10-03 19:23:35 +02:00
Bond_009
cc15ea7f65 Ignore .zfs folder
Maybe helps with #10215 ?
2023-09-27 20:35:00 +02:00
Bond_009
57891e7639 PhotoResolver: change how generated images are detected
Backdrops/fanart are generated as (backdrop)|(fanart)[0-9]*.extension

Fixes #7830
2023-09-27 17:20:55 +02:00
Bond_009
767a42fbdb Minor LibraryMonitor improvements
* Enable nullable
* Add a fast return to ReportFileSystemChanged when path should be ignored
* Use Span overloads of Path.* functions where possible
* IFileSystem: remove NormalizePath as Path.TrimEndingDirectorySeparator already checks if it's a root path
2023-09-13 17:30:50 +02:00
Stepan Goremykin
0ed2aa6f06 Fix a few multiple enumerations 2023-08-26 16:57:27 +02:00
cvium
2e32e335ac refactor: use ConcurrentDictionary when IMemoryCache isn't needed 2023-08-18 14:00:56 +02:00
Bond-009
b95fa294c9
Merge pull request #9799 from Bond-009/genregex 2023-07-06 19:56:00 +02:00
Claus Vium
bfb7c60f72
Merge pull request #9447 from Bond-009/disablerealtimemonitor
Disable real time monitoring by default
2023-07-01 19:33:53 +02:00
Bond_009
b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
Cody Robibero
fe9e764af2
Merge pull request #9564 from AmbulantRex/whitelist-dlls 2023-06-10 07:28:37 -06:00
Cody Robibero
81cf798430
Merge pull request #8203 from Shadowghost/nfo-season-names
Implement NFO named season parsing
2023-06-10 07:27:54 -06:00
Shadowghost
81746666de Fix TotalRecordCount calculation 2023-05-26 11:06:04 +02:00
Bond_009
b44c9eb88e Check for Imdb id for series 2023-05-23 16:23:25 +02:00
Shadowghost
6ddc449a89 Implement NFO named season parsing 2023-05-20 18:57:56 +02:00
Shadowghost
eb52af4e6a
Fix playlists library and migration (#9770) 2023-05-15 06:45:33 -06:00
Shadowghost
a8cdf4434b
Fix access to playlists not created by a user (#9746) 2023-05-12 07:11:59 -06:00
AmbulantRex
4a0b135b7a
Merge branch 'jellyfin:master' into whitelist-dlls 2023-04-15 07:11:33 -06:00
JPVenson
3c22d5c970
#7626 Added handling for common FormatExceptions with Skia loading sv… (#9581)
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-04-10 21:38:07 +02:00
Stepan Goremykin
910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin
b6cfdb8b92 Simplify conditional expression 2023-04-06 19:30:17 +02:00
Stepan Goremykin
19e65269a2 Simplify linq expressions (use All) 2023-04-06 19:27:57 +02:00
elmuffo
bb5bf0277a
Implement check to hide all libraries when user has no access (#9536) 2023-04-01 15:01:05 -06:00
AmbulantRex
3a731051ad Correct styling inconsistencies 2023-04-01 05:03:55 -06:00
AmbulantRex
a944352aa8 Correct style inconsistencies 2023-04-01 04:59:07 -06:00
AmbulantRex
677b1f8e34 Remove unnecessary using statements in PluginManager 2023-03-30 12:56:57 -06:00
AmbulantRex
891b9f7a99 Add DLL whitelist support for plugins 2023-03-30 08:59:21 -06:00
Cody Robibero
dd491ce8ff
Merge pull request #9403 from SenorSmartyPants/ExtraCleanAndNFO
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-20 07:16:03 -06:00
Bond_009
d8ec3a5470 Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Bond-009
6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00
SenorSmartyPants
b96420b786 Clean Extra Names
- Adds regular expression to CleanStrings to remove suffix style extra naming from the name presented in JF.
- Override Resolve for Extras to enable parsename
- remove exclusion on parsename of extratypes
2023-03-09 17:44:12 -06:00
Bond_009
891e2495c9 Disable real time monitoring by default 2023-03-07 17:59:29 +01:00
Joe Rogers
361fff3a0c
Fix cases where multiple files are resolved as a single book 2023-03-06 23:27:21 -05:00
Joe Rogers
1c3a97bf6a
Inject IDirectoryService where needed instead of passing it through ItemResolveArgs 2023-03-06 23:00:55 -05:00
Joe Rogers
160baa02fd
Remove some BaseItem references to make ItemResolveArgs more usable for testing. 2023-03-06 22:18:26 -05:00
Bond_009
4b01aaa0f7 Allocate less Lists 2023-03-01 00:44:57 +01:00
Bond_009
48263078b4 Reduce string allocations by regex 2023-02-17 15:00:06 +01:00
Shadowghost
3d4b2f840a Fix BD and DVD folder recognition for tv episodes 2023-02-04 18:39:50 +01:00
Bond-009
769c48c629
Deduplicate media stream ordering code (#9014) 2023-01-07 11:30:55 -07:00
Bond-009
497d8c4957
Use Order() introduced in .NET 7 (#8923) 2022-12-19 09:30:00 -07:00
Joe Rogers
e4040ab812
Allow video extras to use owner library options 2022-12-08 01:00:27 -05:00
Claus Vium
2c5573b145
Merge pull request #8868 from Bond-009/priorityqueue
Remove dependency on OptimizedPriorityQueue
2022-12-07 18:32:23 +01:00
Claus Vium
558e3d1333
Merge pull request #8867 from stanionascu/fix-8276
Fix to make sure that UDF streams are opened with Share.Read (#8276)
2022-12-07 18:31:53 +01:00
Bond_009
9bb1bc5a3e Remove dependency on OptimizedPriorityQueue 2022-12-07 18:02:12 +01:00
Stanislav Ionascu
7d6ec0a5bd Fix to make sure that UDF streams are opened with Share.Read (#8276)
Make sure that any subsequent requests to open the file for read will
succeed.
2022-12-07 16:40:26 +00:00
Bond_009
b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009
556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
Shadowghost
2e639c77c7 Apply review suggestions 2022-11-17 18:54:35 +01:00
Shadowghost
072651c4be Add xmldocs for TMDb provider, correct provider spelling 2022-11-17 11:16:20 +01:00
Claus Vium
263a1663ae
Merge pull request #8521 from 1337joe/fix-missing-symlink-scan
Skip missing symlink instead of breaking out of directory scan
2022-10-12 22:47:41 +02:00
Claus Vium
99e31846bf
Merge pull request #8541 from Bond-009/minor 2022-10-12 16:36:12 +02:00
Claus Vium
fc78a6c35c
Merge pull request #8472 from jgriff6/subs
Fix subtitle selection behaviour
2022-10-12 07:22:47 +02:00
Bond_009
f6af28cf96 Fix some things that slipped through the cracks 2022-10-11 23:37:29 +02:00
jgriff6
a83d4b03dc Make 'Always' subtitle mode prioritise full tracks 2022-10-11 18:36:19 +01:00
Joe Rogers
c38052a753
Skip missing symlink instead of breaking out of directory scan 2022-10-09 18:56:25 -04:00
Claus Vium
b137d0cc2b
Merge pull request #7514 from Shadowghost/music-extend 2022-10-07 15:21:00 +02:00
jgriff6
fbeec04da7 Polish smart subtitle selection logic 2022-10-07 14:17:20 +01:00
Shadowghost
6c6f89acc3 Apply review suggestions 2022-10-07 14:14:21 +02:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
jgriff6
b9abc004a7 Fix subtitle selection behaviour 2022-09-28 22:26:42 +01:00
Hannes Braun
4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
LogicalPhallacy
e8893f3d41 Backport pull request #8399 from jellyfin/release-10.8.z
Respect visibility for people items (rebased)

Original-merge: e6124bc154

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:09:38 -04:00
Shadowghost
42fc02cab6 Add xmldocs 2022-09-13 17:20:22 +02:00
Shadowghost
cfd1db1638 Prevent MusicArtist creation for artist subfolders 2022-09-13 17:20:22 +02:00
Shadowghost
61fa325ef0 Extend music parsing 2022-09-13 17:20:22 +02:00
luz paz
9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero
8ba83e41ae
Merge pull request #7845 from utkuozdemir/fix/photos-lib-dir-with-single-video 2022-08-14 09:49:27 -07:00
Joshua Boniface
e251f1483f Backport pull request #8167 from jellyfin/release-10.8.z
Add back library scan from library manager

Authored-by: Cody Robibero <cody@robibe.ro>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: f9dffa767f
2022-08-01 14:25:44 -04:00
Utku Ozdemir
9ec42f8cf5 fix: single video folder during photos lib scan
Prevent a directory with a single video file to be detected as a movie directory when the library type is "Photos". Closes jellyfin/jellyfin#7825

Signed-off-by: Utku Ozdemir <uoz@protonmail.com>
2022-06-30 13:36:46 +02:00
Cody Robibero
7f1223016d Merge pull request #7946 from cvium/svg
(cherry picked from commit 4ebe70cf6a)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Cody Robibero
b35d608b19 Merge pull request #7892 from cvium/fix_tv_multi
(cherry picked from commit 21afec3225)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-14 19:30:59 -04:00
Bond-009
a881733377
Merge pull request #7682 from 1337joe/test-preferred-audio-language 2022-06-14 15:23:40 +02:00
Bond-009
2b1a915ead Merge pull request #7604 from Jellifi007/fixes-diactritics
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero
efcdab116f Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
(cherry picked from commit 60affd0965)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Joe Rogers
644e774040
Fix default audio selection ignoring type 2022-05-17 21:03:51 +02:00
Cody Robibero
e086eebb71 Merge pull request #7525 from 1337joe/fix-duplicate-library-media-paths
(cherry picked from commit bebe1808ce)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
jakobkukla
75475285da Fix supportsTranscoding not reflecting user permissions sometimes 2022-03-17 17:24:30 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Stanislav Ionascu
554d1b2ca8 Fix #7100 by catching the exception on opening invalid UDF images
When an invalid UDF image is opened by the UdfReader, it may throw
and exception. This change is to catch and log the exception.
2022-02-20 13:30:55 +00:00
Bond_009
adad13b865 Remove some dead code 2022-02-17 08:15:26 +01:00
Bond_009
5732e6188c Fix some warnings 2022-02-15 18:59:46 +01:00
Bond_009
5d28c5547e Fix indentation 2022-02-14 16:31:07 +01:00
Bond_009
dbd7be091d Fix MediaStreamSelector 2022-02-14 15:03:08 +01:00