Bond_009
277830855d
Clean up UserDataManager
...
* enable nullable
* remove unused methods
* fix warnings and docs
2024-08-30 15:08:56 +02:00
Shadowghost
81e38e772b
Backport pull request #12134 from jellyfin/release-10.9.z
...
Only cleanup children on specific exceptions
Original-merge: 6cf98d4930
2024-06-23 11:40:58 -04:00
Shadowghost
bb0c234984
Backport pull request #11959 from jellyfin/release-10.9.z
...
Do not stop validation if folder was removed
Original-merge: cf59140276
2024-06-06 14:30:32 -04:00
crobibero
3564b00fc0
Backport pull request #11569 from jellyfin/release-10.9.z
...
Default to processor count concurrent scan instead of 2 * processor count
Original-merge: f77a5d0c5c
2024-05-13 12:47:34 -04:00
Joshua M. Boniface
47b79df136
Update MediaBrowser.Controller/Entities/Folder.cs
2024-05-11 10:56:14 -04:00
gnattu
588fb9e82b
Don't assume library change only on item count
...
The library will also be updated when the number of children remains the same before and after scanning. For example, if one video file is removed and replaced with another version, we still need to remove the old one in this case.
Signed-off-by: gnattu <gnattuoc@me.com>
2024-05-11 03:57:22 +08:00
gnattu
3ae0fb90cb
Validate Collection Folders on adding and removal ( #11444 )
2024-05-05 08:21:40 -06:00
gnattu
1b567efeb5
fix: correctly pass parameters in overrides
...
Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-17 21:32:21 +08:00
gnattu
e4d66f35fd
chore: use proper way to override remove root
...
This is an alternate approach which is more proper, but changes all parts that uses/overrides the original ValidateChildren method
Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-17 14:41:19 +08:00
Cody Robibero
31e0756c0c
Only update if actively refreshing ( #11341 )
2024-04-12 17:45:15 -06:00
Claus Vium
239727e896
fix: skip library folders that are inaccessible or empty ( #9291 )
2024-03-18 09:09:00 -06:00
Patrick Barron
505c09c85b
Fix tests
2024-02-06 12:21:52 -05:00
Patrick Barron
0960438065
Remove ActionableProgress
2024-02-06 09:58:25 -05:00
Patrick Barron
8698b90594
Remove SimpleProgress
2024-02-06 09:50:46 -05:00
Cody Robibero
e7b8d45bbb
Use helper function to compare guid ( #10825 )
2024-01-17 08:51:39 -07:00
Stepan Goremykin
6512f85ccb
Pass cancellation token
2023-10-08 00:55:14 +02:00
Bond-009
3982b0e057
Reduce bottlenecks scan code ( #9863 )
2023-06-21 21:01:47 -06:00
Shadowghost
81746666de
Fix TotalRecordCount calculation
2023-05-26 11:06:04 +02:00
Egor Bakanov
46e9f5ad2e
Fix recursive children lookup of folders ( #8678 )
...
Fixes https://github.com/jellyfin/jellyfin/issues/6193
Fixes https://github.com/jellyfin/jellyfin/issues/7226
2023-01-07 11:48:14 -07:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Luke F
e579b4d42d
Backport pull request #8189 from jellyfin/release-10.8.z
...
Fix GetItems IndexOutOfRangeException when IDs do not exist
Original-merge: 527ed0607d
2022-09-23 23:09:34 -04:00
Niels van Velzen
61afd029df
Check for empty guid
2022-08-14 12:58:38 +02:00
Niels van Velzen
0f91244239
Use Guid for adjacentTo API parameter
2022-08-14 12:47:25 +02:00
Bond_009
7fdc0e3c3d
BaseItem: remove unused function
2022-03-11 16:21:32 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Joe Rogers
354f22d065
Add post filtering for theme song and video
2022-02-27 23:38:00 +01:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Claus Vium
488ce51032
Remove some allocations ( #7246 )
2022-01-28 12:21:40 +01:00
Bond_009
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Cody Robibero
a60cb280a3
Properly populate QueryResult
2022-01-20 08:53:06 -07:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
Bond_009
1d19a5be61
Fix some warnings
...
down to 580
2021-11-09 22:29:33 +01:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero
64652b6392
Fix and disable new dotnet6 warnings
2021-11-08 12:40:52 -07:00
Bond_009
0d16c48998
Fix some warnings
2021-09-09 15:59:13 +02:00
Cody Robibero
cba07b1ca6
Remove more and more warnings
2021-08-28 16:32:50 -06:00
Rich Lander
e3df4dcaae
Fix warnings in MediaBrowser.Controller
2021-08-13 20:34:36 -07:00
Rich Lander
ad6f27143f
Update MediaBrowser.Controller/Entities/Folder.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-08-11 13:38:23 -07:00
Rich Lander
0ce7a15534
Fix more warnings
2021-07-23 16:36:27 -07:00
Rich Lander
a7cc77e7fa
Fix partial set of MediaBrowser.Controller/Entities warnings
2021-07-23 13:49:18 -07:00
Cody Robibero
65f8d8c0cd
[CA1801] Parameter is never used. Remove the parameter or use it in the method body.
2021-07-10 10:09:02 -06:00
Claus Vium
f17d43c564
Merge pull request #6071 from BaronGreenback/DLNAFolderFixPart1
...
Make DLNA folders to work as expected.
2021-06-07 09:55:58 +02:00
Cody Robibero
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
BaronGreenback
48bb338352
Enable child items to be returned if a musicAlbum
2021-05-17 23:34:50 +01:00
crobibero
6bcbc2b88a
Reduce warnings in MediaBrowser.Controller
2021-05-13 07:33:11 -06:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
cvium
608cba817c
Reduce some allocations with the magic of spans etc.
2021-04-30 15:09:36 +02:00
Bond-009
48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf
2021-04-21 13:52:51 +02:00
