Bond_009
e9d1eabd53
Remove unused usings
2020-03-24 16:12:06 +01:00
Mark Monteiro
6897a19051
Add missing null check when retrieving extras
2020-03-22 15:09:51 +01:00
dkanada
a96c0a72b8
Merge pull request #2549 from dkanada/refactor
...
Refactor some provider classes
2020-03-18 17:43:15 +09:00
Bond-009
008a76cf4d
Merge pull request #2502 from JustAMan/baseitem-equals
...
Adds BaseItem.Equals method that compares items by their Id
2020-03-11 16:00:36 +01:00
dkanada
52fde64f10
remove unused files and fix some future warnings
2020-03-09 23:30:57 +09:00
Vasily
f4ccee5801
Add inheritdoc comment and squash simple method bodies
2020-03-05 15:03:17 +03:00
Vasily
456f571343
Follow code review suggestions
2020-03-05 14:25:50 +03:00
Vasily
007c5b9f67
Implement BaseItem.GetHashCode override
2020-03-04 13:06:13 +03:00
dkanada
c07e1e4f84
Merge pull request #2476 from JustAMan/playto-sort
...
Bring back sorting when needed to fix PlayTo
2020-03-04 01:53:26 +09:00
Vasily
f21cd30039
Lower log level for BaseItem.Equals to debug
2020-03-03 19:22:45 +03:00
Bond-009
1c21248e2e
Merge pull request #2474 from JustAMan/simplify-sorting
...
Simplify AlphanumericComparer, reduce code duplication
2020-03-02 12:28:31 +01:00
Vasily
ba8d8cede9
Replace foreach with for - MOAR SPEED
2020-03-02 12:39:34 +03:00
Vasily
9a9f2aa293
Apply suggestions from code review
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-03-02 12:36:44 +03:00
Vasily
11abe31e0d
Speed up equality comparison of BaseItem
2020-03-02 12:31:31 +03:00
Vasily
7f38af3701
Remove custom queue class as it is not needed
2020-02-28 17:27:16 +03:00
Vasily
f81cd037f0
Small speed improvement - no need to convert an array to a list to just iterate over it
2020-02-28 16:19:51 +03:00
Vasily
ae1f975b99
Implement fast sorting
2020-02-27 20:21:34 +03:00
Vasily
0f0b89f344
Trying to be more safe
2020-02-27 20:14:56 +03:00
Vasily
e125db4fe3
Bring back sorting when needed to fix PlayTo
...
This is partial revert of https://github.com/jellyfin/jellyfin/pull/1011
2020-02-27 20:11:40 +03:00
Vasily
d1670f8180
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
2020-02-27 16:02:18 +03:00
Vasily
8e20d2e931
Simplify AlphanumericComparer, reduce code duplication
2020-02-27 14:51:34 +03:00
Bond_009
a07ee65365
Minor improvements
2020-02-23 10:53:51 +01:00
dkanada
65a9d618cc
add config options for musicbrainz
2020-02-22 15:04:52 +09:00
Bond-009
b02a3a29f5
Fix photo serialization
2020-02-20 15:30:04 +01:00
Bond-009
6a6472bb8a
Update MediaBrowser.Controller/Entities/PersonInfo.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2020-02-04 12:28:16 +01:00
Bond-009
c9e11c95ee
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2020-02-04 12:05:14 +01:00
Bond_009
32dcd372f4
Fix some warnings in MediaBrowser.Controller
2020-02-04 02:10:44 +01:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
Carey Metcalfe
d3de91dab6
Fix another issue with DLNA responses not properly paginating
...
The `UserRootFolder.GetItemsInternal` method now applies any sorting and
pagination requested by the `InternalItemsQuery` that was passed to it.
Previous pagination fix : #2304
Original issue #2303
2020-01-24 00:43:28 -05:00
Bond_009
bb236b9591
Merge branch 'master' into warn12
2020-01-10 21:18:16 +01:00
dkanada
aca31457c0
merge branch master into media-attachments
2020-01-08 01:21:09 +09:00
Bond_009
7f5a174dff
Merge branch 'master' into warn12
2019-12-20 19:43:57 +01:00
Bond_009
2ef4ffd698
More warnings (removed)
2019-12-11 00:13:57 +01:00
Bond_009
0bf8bfbb0c
Merge branch 'master' into mediaencoding
2019-12-10 23:00:59 +01:00
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
2019-12-06 12:06:13 +01:00
Bond_009
cc5acf37f7
Make probesize and analyzeduration configurable and simplify circular
...
dependencies
Makes the probesize and analyzeduration configurable with env args.
(`JELLYFIN_FFmpeg_probesize` and `FFmpeg_analyzeduration`)
2019-11-25 12:07:59 +01:00
dkanada
51cdc6ea16
Merge pull request #1926 from Bond-009/auth
...
Add clearer exceptions, warnings and docs
2019-11-23 01:14:32 +09:00
dkanada
f51f59d675
Merge pull request #1965 from Bond-009/dbjson
...
Deserialize with the correct type (and warning fixes)
2019-11-10 16:51:54 +09:00
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
2019-11-04 10:03:18 -05:00
Bond_009
846857b60e
Deserialize with the correct type (and warning fixes)
2019-11-01 17:07:42 +01:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Andrew Mahone
f22ca6dd9e
Retrieve media attachments in BaseItem.
2019-10-22 10:36:54 -04:00
Bond_009
fef35d0505
Add clearer exceptions, warnings and docs
2019-10-20 21:12:03 +02:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
Bond_009
5edb8159a7
Fix Json serialization error
2019-10-15 17:49:49 +02:00
Anthony Lavado
bae5e3795e
Fix SetImage to avoid out of range exception ( #1798 )
...
* Fix SetImage to avoid out of range exception
* Actually use the new images we've retrieved
2019-09-26 09:47:48 -04:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond_009
e4f893a0eb
More warning fixes
2019-08-29 22:28:33 +02:00
SL1288
fdc24ec2ee
Fix LocalTrailers playback.
2019-08-19 18:56:41 +02:00
Bond_009
8d3b5c851d
Improvements to UserManager
2019-08-16 21:06:11 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Andrew Rabert
fc439cc02a
Merge pull request #1448 from joshuaboniface/nice-userconfig-paths
...
Use the username for the user config path
2019-06-24 12:54:24 -04:00
Anthony Lavado
b25c08e79a
Merge pull request #1156 from Bond-009/sep
...
Small cleanups here and there
2019-06-13 22:27:00 -04:00
Joshua M. Boniface
d1d0ddf62f
Use the username for the user config path
...
Use the username to construct the UserConfigurationDirectory,
instead of the user ID, and move the old ID-based path to the new
path if needed when loading (temporary transitional code). Removes
administrator guesswork as to what user each directory belongs to,
which I found very annoying when investigating user configs.
2019-06-08 23:54:26 -04:00
Bond-009
2d011b781e
Merge pull request #1383 from jellyfin/release-10.3.z
...
Backmerge for Release 10.3.3
2019-05-18 12:56:42 +02:00
Claus Vium
0ef52c739e
Review changes
...
Untested
2019-05-16 07:27:38 +02:00
Claus Vium
b8a09339cd
Enforce extras folder structure according to Emby's wiki
2019-05-02 08:14:00 +02:00
Claus Vium
c1daea0ec7
Change owner and parent id of extras to the main media item
2019-05-01 07:47:22 +02:00
Bond-009
2f33e99006
Speed up DeepCopy
2019-04-02 18:17:50 +02:00
Bond-009
6566c91360
Seperate changes from #1023
...
The unrelated changes from #1023 (and more)
2019-03-25 21:27:03 +01:00
Bond-009
80fb3dc2cb
Fix error
2019-03-08 06:36:00 +01:00
Bond-009
4625592a83
Quick nullref fix
2019-03-07 22:52:41 +01:00
Bond-009
c5fce647de
Cleanup/simplification
...
* Removed useless copies/allocations
* Reduced unneeded complexity
2019-03-07 21:13:13 +01:00
Bond-009
1731bf7372
Remove ordering items
2019-02-26 20:47:23 +01:00
Torsten
2690ac299b
Only refresh metadata if extras changed
2019-02-20 16:39:49 +01:00
Torsten
9753a76905
Populate video extras again
2019-02-19 22:41:25 +01:00
Bond_009
1385d89df6
Remove MoreLINQ
2019-02-02 12:27:06 +01:00
Joshua M. Boniface
c713824bf9
Merge pull request #734 from Bond-009/culture
...
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00
Claus Vium
8985fb8d58
Remove support for games as a media type
2019-01-31 19:04:47 +01:00
Claus Vium
f7a46c7a56
Remove more Connect related stuff
2019-01-31 18:47:50 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
8487319374
Merge pull request #726 from EraYaN/remove-wrappers-for-system-io
...
Clean up IFileSystem wrappers around stdlib.
2019-01-29 16:50:01 +03:00
Erwin de Haan
450f246f95
Unwrapped GetFileNameWithoutExtension
2019-01-28 22:10:51 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Claus Vium
dc68d61491
Fix default aspect ratio
2019-01-28 21:55:44 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Claus Vium
0e617933f6
Change default aspect ratio to 2/3 from 0
2019-01-26 22:19:14 +01:00
Andrew Rabert
7165868509
Merge pull request #709 from Bond-009/null
...
Fix always null expressions
2019-01-26 14:14:23 -05:00
Bond_009
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00
Bond_009
8af256f9c2
Fix always null expressions
2019-01-25 21:52:10 +01:00
hawken
3701ce4037
Eliminate some compile warnings ( #600 )
...
* Remove some unused variables
* remove duplicate "using .." by sorting and deduping the list
* Remove things that already exist in the parent class (in one case I moved some documentation to the parent)
* EntityBodyData and and NextSearch were never set (only read), removed
* _timeout was never read, subsequently _timer became unused. part of a TODO timeout functionality that was not implemented yet
2019-01-24 18:56:43 +01:00
Claus Vium
b2ffad9ce9
Set Parent to current query Item if ParentId is empty ( #680 )
...
**Changes**
Fixed a faulty change in logic that occurred during the Christmas GPL nightmare.
I stepped through Emby 3.5.2 and stumbled over a difference in the query between Jellyfin and Emby, where in Emby, query.ParentId was set to the item itself. So I did a little digging in the old GPLv2 source and found this https://github.com/MediaBrowser/Emby/blob/3.4.1.8/MediaBrowser.Controller/Entities/Folder.cs#L720
**Issues**
Fixes #673
2019-01-24 18:48:37 +01:00
hawken
a356c1417a
Change MusicAlbum.Tracks to return Audio items
2019-01-22 12:19:50 +00:00
Bond_009
35d97dc949
Minor improvements to library scan code
2019-01-20 19:40:37 +01:00
Erwin de Haan
d116efe1f7
Merge branch 'dev' into reformat
2019-01-18 17:04:01 +01:00
Erwin de Haan
38f96af079
Reformat JustAMan review pt2 changes
...
Refs #575
2019-01-17 20:24:39 +01:00
hawken
bddfca6215
Fix potential problem where aspect ratio would be incorrectly calculated
2019-01-15 20:10:26 +00:00
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
2019-01-13 21:31:14 +01:00
Erwin de Haan
ba610b5094
Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller
2019-01-13 21:01:16 +01:00
Erwin de Haan
26ca4b607b
Visual Studio Reformat: MediaBrowser.Controller
2019-01-13 20:25:32 +01:00
Erwin de Haan
846456b41e
Reformatted the files with notes.
2019-01-12 21:41:08 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Joshua M. Boniface
15c89d281e
Merge pull request #506 from hawken93/linting
...
Removing tabs and trailing whitespace
2019-01-10 19:54:18 -05:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00