Commit Graph

2382 Commits

Author SHA1 Message Date
Bond_009
b62b0ec2b5 Fix warnings 2023-11-14 21:14:21 +01:00
Bond_009
eb022c49cc Update to .NET 8 2023-11-14 21:12:16 +01:00
Cody Robibero
453c65d619 Fix build after merge 2023-11-10 08:01:39 -07:00
Cody Robibero
892973a9e3
Merge branch 'master' into media-type 2023-11-09 22:03:55 -07:00
Cody Robibero
c7a94d48ae
Convert ItemSortBy to enum (#9765)
* Convert ItemSortBy to enum

* Rename Unknown to Default
2023-11-09 14:00:13 -07:00
Bond-009
5e48278e2a
Merge pull request #10078 from scampower3/master
Combine Title and Overview for multi-episodes files for the TMDB provider
2023-11-08 11:18:12 +01:00
Bond_009
a9ef103c95 Add IDisposableAnalyzers to more projects 2023-11-05 02:01:14 +01:00
Nick
cd662506a1 Merge branch 'master' into trickplay 2023-10-18 19:27:05 -07:00
LJQ
1d19fe50b4 Deep copy instead of Shallow copy 2023-10-16 21:18:25 +08:00
LJQ
298a7488a3 Applied 2nd Round of Suggested Changes 2023-10-16 19:48:01 +08:00
Stepan Goremykin
38d962242a Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Updates/InstallationManager.cs
#	tests/Jellyfin.Server.Integration.Tests/OpenApiSpecTests.cs
2023-10-14 00:45:52 +02:00
Bond-009
4fc27fa63e
Merge pull request #10390 from Bond-009/streams 2023-10-13 10:45:15 +02:00
Stepan Goremykin
8d7e4229ca Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Net/SocketFactory.cs
#	RSSDP/SsdpCommunicationsServer.cs
#	RSSDP/SsdpDeviceLocator.cs
#	RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Bond_009
d7748cfa04 Multiple Stream changes
* Remove useless MemoryStream in DlnaHttpClient
* Use HttpContent.ReadFromJsonAsync extension
* Call ConfigureAwait for IAsyncDisposable
* Use HttpContent.CopyToAsync where possible
2023-10-11 18:32:57 +02:00
Cody Robibero
2920611ffc Convert string MediaType to enum MediaType 2023-10-10 15:57:15 -06:00
Bond_009
d15f6908b0 Empty Guids shouldn't make it into the refresh queue
```
System.ArgumentException: Guid can't be empty (Parameter 'id')
   at Emby.Server.Implementations.Library.LibraryManager.GetItemById(Guid id) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1224
   at MediaBrowser.Providers.Manager.ProviderManager.StartProcessingRefreshQueue() in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/ProviderManager.cs:line 983
```
2023-10-10 13:29:16 +02:00
Bond_009
c707baed83 Jellyfin.Drawing minor improvements
Reduce duplicate/dead code
2023-10-08 17:10:04 +02:00
Stepan Goremykin
f84469d500 Remove redundant using directives 2023-10-08 00:50:02 +02:00
Stepan Goremykin
8ea812b65d Reduce string literal length by using verbatim string 2023-10-08 00:26:12 +02:00
Stepan Goremykin
3f9ee316d5 Use non nullable property type when possible 2023-10-08 00:22:36 +02:00
Stepan Goremykin
d6b557d9ee Move declaration closer to usage 2023-10-07 23:56:07 +02:00
Bond_009
efc4c305a9 Use CryptoStream to convert stream from base64
Should be way more efficient
2023-10-05 23:36:37 +02:00
LJQ
136a4abbd3 Applied Suggested Changes 2023-09-11 20:29:49 +08:00
Nyanmisaka
debbfaa502
Fix MJPEG video is recognized as embedded image (#10173)
fixes 1d729b2

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-08-30 17:19:52 -06:00
Bond-009
c7ca416206
Merge pull request #10138 from cvium/sqlite_client_poc 2023-08-28 11:54:35 +02:00
Bond-009
3b07d73d40
Merge pull request #10154 from goremykin/multiple-enumerations 2023-08-27 10:17:30 +02:00
Stepan Goremykin
ee83e4cca5 Remove redundant method 2023-08-26 17:29:00 +02:00
Stepan Goremykin
0ed2aa6f06 Fix a few multiple enumerations 2023-08-26 16:57:27 +02:00
cvium
c76026600e simplify if 2023-08-23 13:36:08 +02:00
cvium
7689990ad1 reduce calls to GetValidSeasonNameForSeries 2023-08-23 12:22:35 +02:00
cvium
9a246166b0 move a computation out of transaction and skip season updates if name matches 2023-08-23 12:15:21 +02:00
Bond_009
18a311d32f == null -> is null 2023-08-22 21:14:54 +02:00
Bond_009
d92e9ae85e Enable nullable for more files and add tests
Adds basic tests for FFProbeVideoInfo.CreateDummyChapters
Fixed error message CreateDummyChapters instead of reporting the total minutes it only reported the minute component
2023-08-22 18:11:34 +02:00
Claus Vium
956e3dab43
fix: accessing Standard* of a Process requires manually disposing them afterwards (#10125) 2023-08-20 20:06:57 +02:00
LJQ
a0011886b0 Fixes metadata refresh problems with NFO files 2023-08-06 16:14:33 +08:00
LJQ
0676b878f3 Removed unused imports 2023-08-04 21:25:43 +08:00
LJQ
28a6694f6e Combined Title and Overview for multi-episodes files for the TMDB provider 2023-08-04 21:19:08 +08:00
Jan Müller
66ff724acf Fix the probing of m4a metadata
The composer is not set in some of my m4a files. For some reason
TagLibSharp returns the composer as an empty string in this case. This
causes an exception in PeopleHelper.AddPerson, and thus probing fails.

IMHO we can simply ignore empty values.

Fixes: #10061
2023-07-31 22:19:06 +02:00
MBR-0001
9564248b10
Add ability to upload (and save) SDH subtitles (#10036) 2023-07-29 06:52:35 -06:00
Bond-009
b95fa294c9
Merge pull request #9799 from Bond-009/genregex 2023-07-06 19:56:00 +02:00
Niels van Velzen
0af5373f6d Use string.IsNullOrEmpty 2023-07-01 14:07:59 +02:00
Niels van Velzen
0ae4d175a1 Check for empty string in DefaultLyricProvider 2023-07-01 11:16:21 +02:00
Niels van Velzen
6be45f73bc Simplify file extension checks in lyrics parsers and provider 2023-06-29 21:16:29 +02:00
Bond_009
b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
Nick
ab20ceaad6 Migrate to trickplay table to EF. Rename vars/methods/members to have consistent use of tile and thumbnail 2023-06-26 17:40:10 -07:00
Niels van Velzen
1ed5f0a624 Move line break characters to static readonly string array in TxtLyricParser 2023-06-24 09:25:25 +02:00
Nick
a2a144869d Minor code fixes (cvium) 2023-06-23 14:30:55 -07:00
Nick
619d1d47f2 Move GetHlsPlaylist to ITrickplayManager 2023-06-23 14:22:00 -07:00
Niels van Velzen
6de56f0518 Add support for lyric provider plugins 2023-06-23 21:13:20 +02:00
Nick
0e2c362078 Move SkiaSharp related code to Jellyfin.Drawing and IImageEncoder 2023-06-22 16:23:52 -07:00
Nick
049361b66c TrickplayController return 404 if playlist doesn't exist. Minor code style/format changes (crobibero) 2023-06-22 16:23:52 -07:00
Nick
a9594cd8b4 Minor code change 2023-06-22 16:23:52 -07:00
Nick
f82af04781 Trickplay task pagination 2023-06-22 16:23:52 -07:00
Nick
98e41d5a14 Styling, format, minor code changes (crobibero) 2023-06-22 16:23:52 -07:00
Nick
3377032228 crobibero styling, format, code suggestions 2023-06-22 16:23:52 -07:00
Nick
d7fd54197c Task localization 2023-06-22 16:23:52 -07:00
nicknsy
0f053f0fe0 Change generation task to search recursively 2023-06-22 16:23:51 -07:00
nicknsy
79a0e36b90 Remove max runtime 2023-06-22 16:23:51 -07:00
nicknsy
6744e712d3 Use config values 2023-06-22 16:23:51 -07:00
nicknsy
d448cc18ea update 2023-06-22 16:19:59 -07:00
nicknsy
31a858f520 IsAutomated not set on copy 2023-06-22 16:19:59 -07:00
nicknsy
515ee90fb9 Hls playlist 2023-06-22 16:19:59 -07:00
nicknsy
ca7d1a1300 Trickplay generation, manager, storage 2023-06-22 16:19:59 -07:00
Bond-009
3982b0e057
Reduce bottlenecks scan code (#9863) 2023-06-21 21:01:47 -06:00
Cody Robibero
198b9aa530
Update MediaBrowser.Providers/TV/SeriesMetadataService.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2023-06-10 07:04:23 -06:00
Shadowghost
a496da24e3
Apply suggestions from code review
Co-authored-by: Bond-009 <bond.009@outlook.com>
2023-05-21 13:52:43 +02:00
Shadowghost
6ddc449a89 Implement NFO named season parsing 2023-05-20 18:57:56 +02:00
TelepathicWalrus
603fce59df
Audio normalization (#9222)
Co-authored-by: Joe Rogers <1337joe@users.noreply.github.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
2023-05-15 13:12:24 +02:00
SenorSmartyPants
11d7c00de9
Fix local JPG primary image for video being overwritten by screen grabber (#9552) 2023-05-10 17:46:55 -06:00
Stepan Goremykin
6ae1903453 Use TryAdd 2023-04-06 19:17:28 +02:00
Stepan Goremykin
26958162d0 Remove unused using directives 2023-04-06 19:17:28 +02:00
Cody Robibero
89be3aa37f
Convert Person.Type to use PersonKind enum (#9487) 2023-03-25 11:52:02 -06:00
Cody Robibero
dd491ce8ff
Merge pull request #9403 from SenorSmartyPants/ExtraCleanAndNFO
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-20 07:16:03 -06:00
SenorSmartyPants
39677525f3
Don't overwrite NFO images (#9452)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-18 19:24:48 -06:00
Bond-009
cf1cb2eea5
Merge pull request #9418 from Bond-009/getawaiter 2023-03-15 18:30:03 +01:00
Shadowghost
21dcf775be
Add config option to disable dummy chapter generation (#9410) 2023-03-14 16:20:12 -06:00
Bond_009
d8ec3a5470 Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Bond-009
6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00
Shadowghost
0da5255f12 Apply review suggestions 2023-03-10 15:27:17 +01:00
Shadowghost
cd852d43c1 Add more comments and logging, streamline code 2023-03-10 15:27:17 +01:00
Shadowghost
2403a0a367 Apply review suggestions 2023-03-10 15:27:05 +01:00
SenorSmartyPants
99816b07dc Enable NFO processing for Extras
- Change test to prevent owned items from using parent NFO. Test is now in MovieNFOSaver, only movie type will use movie.nfo.
2023-03-09 17:44:12 -06:00
Bond_009
4b01aaa0f7 Allocate less Lists 2023-03-01 00:44:57 +01:00
Bond_009
e35119987a Enable nullable for more files 2023-02-25 17:20:53 +01:00
Bond-009
eaeb65f94d
Update MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeImageProvider.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-02-24 16:22:30 +01:00
Bond_009
ab24c0e2cf Enable nullable for more files 2023-02-23 19:09:16 +01:00
Shadowghost
e7a7edbac0
Various fixes (#9361) 2023-02-20 08:04:30 -07:00
Bond-009
720852f708
Merge pull request #9356 from Bond-009/tryparse 2023-02-20 11:09:54 +01:00
Shadowghost
a9bfb13dc7 Format MusicBrainz config page 2023-02-19 18:20:30 +01:00
Shadowghost
815aa40170 Fix MusicBrainz config page input validation 2023-02-19 18:12:28 +01:00
Shadowghost
3c921e25da Fix MusicBrainz album queries and releasegroup handling 2023-02-19 17:54:59 +01:00
Bond_009
24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Shadowghost
4baa534679 Fix MusicBrainz configuration parsing and update 2023-02-19 16:16:34 +01:00
Shadowghost
2f4e43b87f Add migration for MusicBrainz settings 2023-02-19 09:30:27 +01:00
Shadowghost
3c5b0e0035 Fix MusicBrainz default server 2023-02-18 21:22:45 +01:00
Bond_009
3bec70302b Fix use after dispose 2023-02-17 20:47:07 +01:00
Joe Rogers
4ce30989e0
Make update type for RunTimeTicks consistent with other file attributes 2023-02-12 23:14:43 -05:00
Joe Rogers
2d2b0a528c
Add missing checks for item locked state in metadata updates 2023-02-12 21:59:58 -05:00
cvium
b5d5667965 remove a hardcoded DefaultAuthorization 2023-02-09 14:40:50 +01:00
Bond-009
151aa0f678
Merge pull request #8982 from bradbeattie/background-images-no-language 2023-02-07 00:22:06 +01:00
Bond-009
ebbd1b9db1
Update MediaBrowser.Providers/Manager/ItemImageProvider.cs 2023-02-07 00:16:03 +01:00
Shadowghost
626bb24bdd Remove DvdLib 2023-02-04 18:39:50 +01:00
Shadowghost
3d4b2f840a Fix BD and DVD folder recognition for tv episodes 2023-02-04 18:39:50 +01:00
Shadowghost
ddfdec7f46 Fix BD and DVD folder probing and playback 2023-02-04 18:37:57 +01:00
Shadowghost
519709bf10 Revert "Remove DvdLib (#9068)"
This reverts commit db1913b08f.
2023-02-04 18:36:47 +01:00
Zoltan Csizmadia
e0519189b2
Use Directory.Packages.props (#9135)
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
Cody Robibero
58b3945805
Merge pull request #9191 from barronpm/applicationhost-cleanup1 2023-02-02 07:26:25 -07:00
Claus Vium
9eaad18c2c
fix: don't allow exceptions to propagate from Refresh progress event handlers (#9228) 2023-02-02 06:02:57 -07:00
Patrick Barron
4f81f4daaa Use depencency injection for ISubtitleProvider 2023-01-27 18:41:10 -05:00
Patrick Barron
db1913b08f
Remove DvdLib (#9068)
* Remove DvdLib

* Update error message for blu-ray folders

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>

* Remove BDInfo

* Remove MediaEncoder.GetPrimaryPlaylistVobFiles

* Remove BlurayDiscInfo

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-01-20 13:29:45 +01:00
renovate[bot]
e408da4651
chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 (#9117)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Bond_009
b934b346e1 Fix all warnings in MediaBrowser.Providers 2023-01-11 10:36:18 +01:00
renovate[bot]
3ed0e70eab
chore(deps): update dependency tmdblib to v2 (#9053)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-10 14:57:17 -07:00
Claus Vium
223aaec93f
Merge pull request #8995 from daullmer/nfo-remote-images-initial
Use nfo provided remote images on initial scan
2023-01-02 18:43:49 +01:00
Brad Beattie
d639d35baa Backdrops prefer no language images 2023-01-02 08:39:58 -08:00
David Ullmer
6e7b0a8cb2
Use nfo provided remote images on initial scan 2023-01-02 11:07:00 +01:00
Bond_009
6bf131b270 Use Diacritics.NET
Last time we had to revert this due to regressions, now those regression
tests seem to succeed with a newer version of Diacritics.NET
2022-12-27 16:53:58 +01:00
Bond-009
497d8c4957
Use Order() introduced in .NET 7 (#8923) 2022-12-19 09:30:00 -07:00
Bond-009
f8da8ba3c6
Merge pull request #8886 from jellyfin/renovate/playlistsnet-1.x 2022-12-11 20:39:23 +01:00
renovate[bot]
1987b138f9
chore(deps): update dependency playlistsnet to v1.3.1 2022-12-10 14:44:24 +00:00
Joe Rogers
a74b8b99af
Add option to allow extras to use embedded titles 2022-12-08 01:00:35 -05:00
Claus Vium
2c5573b145
Merge pull request #8868 from Bond-009/priorityqueue
Remove dependency on OptimizedPriorityQueue
2022-12-07 18:32:23 +01:00
Bond-009
16fdb127ab
Check HTTP status code before writing response to file (#8863)
fix https://github.com/jellyfin/jellyfin/issues/8084
2022-12-07 18:14:32 +01:00
Bond_009
9bb1bc5a3e Remove dependency on OptimizedPriorityQueue 2022-12-07 18:02:12 +01:00
Bond_009
fd9dc1e308 Update deps 2022-12-07 16:56:32 +01:00
Bond_009
b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009
210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
Shadowghost
fe3e7979b0
Add MusicBrainz server validation and fallback (#8833) 2022-12-03 08:47:50 -07:00
Cody Robibero
d4bd72049b
Merge pull request #8137 from negulici-r-barnabas/master 2022-11-27 07:53:18 -07:00
Bond_009
fb3e97d7ac Use typed logger 2022-11-27 14:35:07 +01:00
renovate[bot]
e1bd5684e5
chore(deps): update dependency newtonsoft.json to v13.0.2 (#8792)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-11-27 14:09:24 +01:00
Negulici-R. Barnabas
e977aade77
Merge branch 'jellyfin:master' into master 2022-11-26 10:56:23 +02:00
Bond-009
f369ddf522
Merge pull request #7039 from 1337joe/providermanager-cleanup 2022-11-23 18:24:07 +01:00
Bond-009
66954b4efe
Merge pull request #8695 from JeWe37/master 2022-11-22 22:08:39 +01:00
Shadowghost
2e639c77c7 Apply review suggestions 2022-11-17 18:54:35 +01:00
Shadowghost
4b1654ae3b Add xmldocs for studio image provider 2022-11-17 11:16:20 +01:00
Shadowghost
072651c4be Add xmldocs for TMDb provider, correct provider spelling 2022-11-17 11:16:20 +01:00
Negulici-R. Barnabas
7db1813cc8 changed ChapterImageResolution in model to enum type;
added 144p to the ImageResolution enum;
updated chapters limit comment inside FFProbeVideoInfo.cs;
2022-11-13 16:23:21 +02:00
Negulici-R. Barnabas
b7aa5ed862
Merge branch 'jellyfin:master' into master 2022-11-13 15:29:16 +02:00
Jendrik Weise
21072310e7 Sort external files when scanning
Sorts files such as external subtitles or audio as well as metadata
Useful for deterministic display in the UI.
2022-11-04 15:16:27 +01:00
David Ullmer
abcb188916 Backport pull request #8667 from jellyfin/release-10.8.z
Enable OMDB plot for non-English languages as fallback

Original-merge: f83a24ec43

Merged-by: Cody Robibero <cody@robibe.ro>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-31 23:08:42 -04:00
Shadowghost
385f1cc1b8 Apply review suggestions 2022-10-22 12:44:44 +02:00
MrTimscampi
7ad0c9ba24 Migrate MusicBrainz plugin to MetaBrainz.MusicBrainz
Co-authored-by: crobibero <cody@robibe.ro>
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2022-10-22 12:44:44 +02:00
Joe Rogers
dd41fb9a61
Update embedded image names to match docs 2022-10-08 23:20:10 -04:00
Claus Vium
05c20001c8
Merge pull request #8381 from 1hitsong/lyric-lrc-file-support 2022-10-07 15:21:42 +02:00
Claus Vium
b137d0cc2b
Merge pull request #7514 from Shadowghost/music-extend 2022-10-07 15:21:00 +02:00
Shadowghost
9b2e9640be Apply review suggestions 2022-10-07 14:41:00 +02:00