Joe Rogers
c81d2e9dec
Remove existing images when applying identify
2022-01-03 23:41:13 +01:00
Joe Rogers
ce66df2c92
Clean up warnings, simplify
2022-01-03 22:59:58 +01:00
Joe Rogers
853ef727da
Add refresh flag to remove existing data/images
...
Fixes #7040
2022-01-02 22:21:05 +01:00
Joe Rogers
76e640b0b9
Add tests and documentation for ProviderUtils
2021-12-31 00:10:35 +01:00
Joe Rogers
e3a7c9238d
Pull default MergeData implementation to parent
2021-12-28 15:12:09 +01:00
Cody Robibero
7bfc6b5679
Remove more warnings
2021-12-27 07:38:06 -07:00
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
2021-12-24 01:59:25 +00:00
cvium
c86b064f80
Catch HttpRequestException when saving images from local provider
2021-12-21 12:29:09 +01:00
cvium
b880dc8a4a
Use our own Contains extension
2021-12-20 13:31:07 +01:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
Cody Robibero
14c072dd32
Fix filtering images without dimensions
2021-11-12 07:21:46 -07:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Joe Rogers
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot
2021-11-06 20:43:20 +01:00
Bond_009
924c6682b9
Remove unused IHasScreenshots interface
2021-11-04 01:06:21 +01:00
Joe Rogers
7fcf01235c
Change RemoveImages to array, improve download test
2021-11-02 16:16:06 +01:00
Joe Rogers
7da6bd905a
Fix edge case in multi-image replacing
2021-11-02 00:31:59 +01:00
Joe Rogers
b478b115e3
Refactor to validate all images up front
2021-11-01 11:53:31 +01:00
Joe Rogers
0fbd8d85c8
Validate multi-images, lazy-delete bg on refresh
...
Fix failing test: Invalid background images not purged by validate
Fixes #6310 : Background images only delete when using "Replace existing images" when new image(s) is found to replace them
2021-11-01 00:16:11 +01:00
Joe Rogers
080b02cc4c
Add comments, minor cleanup, add tests
2021-10-31 23:56:50 +01:00
Bond_009
f5ca9cbc3b
Enable nullable for MediaBrowser.Providers
2021-10-26 15:49:01 +02:00
Bond_009
9af16fcb6c
Remove workaround for dotnet/runtime#42790
2021-10-03 19:52:38 +02:00
Cody Robibero
9234e5bf80
Remove all instances of en-US culture
2021-09-26 09:11:25 -06:00
Bond_009
f31224fa8f
Remove sync FileStream hack
2021-09-25 19:44:40 +02:00
Bond-009
12a54c070e
Apply suggestions from code review
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-09-21 23:12:38 +02:00
Bond_009
8fec510971
ItemImageProvider: improve HTTP error handling
2021-09-21 22:47:30 +02:00
Chris Tam
b0cd1f5e39
Fix images "not loading" after manual identification
2021-09-09 19:16:15 -04:00
Fernando Fernández
3d0b1ccae6
Remove all unused usings
2021-09-06 21:15:30 +02:00
Claus Vium
74fef6c05b
Merge pull request #6177 from Bond-009/async
...
Use async FileStreams where it makes sense
2021-09-06 13:55:34 +02:00
Bond_009
e3dac4fda2
Use async FileStreams where it makes sense
2021-09-02 14:02:04 +02:00
Cody Robibero
cba07b1ca6
Remove more and more warnings
2021-08-28 16:32:50 -06:00
Rich Lander
927b003143
Fix remaining MediaBrowser.Providers warnings
2021-07-22 20:16:38 -07:00
Rich Lander
fb92eab69b
Fix analysis issues
2021-07-22 17:33:19 -07:00
Bond_009
cf061f7563
MediaBrowser.Providers: Remove some warnings
2021-06-27 02:00:27 +02:00
Bond_009
981cf4cfa0
Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net
2021-06-22 09:48:40 +02:00
Bond-009
83e492b72b
Merge pull request #5384 from Larvitar/season-metadata-fix
2021-06-12 00:58:58 +02:00
Claus Vium
8daa679a26
Update MediaBrowser.Providers/Manager/MetadataService.cs
2021-06-12 00:22:55 +02:00
Bond-009
cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram
2021-06-12 00:20:54 +02:00
Cody Robibero
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
Mariusz Chryc
d44025c620
Clear episode and season provider IDs during ApplySearchResult
2021-05-29 10:56:38 +02:00
PingWin
7cba148a30
Don't prefer OMDB rating over all other providers
2021-05-25 14:38:02 +00:00
cvium
42a2cc1747
Remove some unnecessary allocations
2021-05-24 00:30:41 +02:00
wehrstedt
ad1d9d9a23
fixed no channel icons when using tvheadend ( #5996 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Maximilian Wehrstedt <wehrstedt.coding@outlook.de>
2021-05-06 23:07:32 +02:00
BaronGreenback
f2c10471bf
Code Clean up: Use Pattern Matching ( #5838 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:37:36 +02:00
cvium
77261a8445
add UpdatePeopleAsync and add people to both tables
2021-04-24 20:22:23 +02:00
Bond-009
86a2e6eeda
Merge pull request #5867 from Bond-009/provider
...
ProviderManager: fix discard and 2 warnings
2021-04-21 13:53:53 +02:00
Bond-009
da78a96312
Merge pull request #5807 from Bond-009/refreshdelay
...
Remove throttle in refresh code
2021-04-21 13:52:05 +02:00
Bond_009
dcd6ab769b
ProviderManager: fix discard and 2 warnings
2021-04-19 23:52:58 +02:00
cvium
351b987982
Add Person to TypedBaseItems if it's new
2021-04-18 12:34:33 +02:00
BaronGreenback
bc1cc2d04a
Remove unused using directives
2021-04-17 11:37:55 +01:00
Bond_009
3d0a42da9e
Remove throttle in refresh code
2021-04-13 20:09:50 +02:00
cvium
35cfd760d4
Do not touch "old" local artwork unless saving locally
2021-04-11 00:27:53 +02:00
Bond_009
2ed0801be2
Fix possible nullref
...
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`
```
Error Message:
System.ArgumentNullException : Value cannot be null. (Parameter 'source')
Stack Trace:
at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
Claus Vium
df60d176b8
ensure only valid images are saved in ItemImageProvider
2021-04-01 15:27:28 +02:00
Bond-009
16011d96a0
Merge pull request #5321 from Ullmie02/nfo-thumb
2021-03-25 01:10:37 +01:00
David
a4cac09d5b
Use |=
2021-03-23 19:25:32 +01:00
David
60ffa6f514
Use FileShare.None when creating files
2021-03-07 14:43:28 +01:00
cvium
ba366118f9
Do not use language or imagelanguages when searching for images
...
TMDb API returns all images if languages are excluded, which is needed for the All Languages toggle in Identify.
2021-03-05 08:18:04 +01:00
cvium
664c5da317
return false when providerid is null or empty
2021-03-03 09:09:57 +01:00
David
16694b0cfc
Add nfo thumb tag support
2021-02-28 15:00:17 +01:00
Bond_009
e9f22303a4
Properly forward cancellationTokens
2021-02-15 14:19:17 +01:00
martinek-stepan
cc92f7afe5
Enable nullable for MediaBrowser.XbmcMetadata project ( #4612 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Stepan <ste.martinek+git@gmail.com>
2020-12-31 12:09:25 +01:00
cvium
3f6e6c4839
Simplify
2020-12-10 14:47:47 +01:00
cvium
dd238937f4
Remember to await the async task
2020-12-10 13:44:58 +01:00
cvium
3c5bbeb80c
Remove ImageFetcherPostScanTask
2020-12-10 13:38:33 +01:00
Claus Vium
f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
...
Increase library scan and metadata refresh speed
2020-12-04 13:17:26 +01:00
Gary Wilber
2b6b2cbf31
Remove Lazy
2020-12-02 23:23:13 -08:00
Gary Wilber
f4edca7c27
Move MetadataRefreshThrottler to BaseItemManager
2020-12-02 18:51:53 -08:00
BaronGreenback
d3b0080a27
Update MetadataService.cs
...
added return Task.CompletedTask;
2020-11-21 23:29:52 +00:00
BaronGreenback
79855a76b1
Update MetadataService.cs
...
removed async line 232
2020-11-21 23:21:15 +00:00
Joshua M. Boniface
bf54b5579c
Merge branch 'master' into defer_image_fetching
2020-11-21 17:20:31 -05:00
Joshua M. Boniface
212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
...
Corrects spelling in comments
2020-11-19 13:08:28 -05:00
Claus Vium
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
...
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Greenback
9a323f6df0
More spelling corrections.
2020-11-18 13:46:14 +00:00
Bond_009
4b1c9dc9ea
Pass cancellation where possible
2020-11-17 19:43:00 +01:00
crobibero
95a2de757f
remove custom HttpException
2020-11-14 14:30:34 -07:00
Fernando Fernández
103d503c15
Removed code as suggested by @cvium
2020-11-10 02:12:47 +01:00
crobibero
64b32d3290
Use BaseItemManager
2020-10-27 18:01:52 -06:00
ferferga
9fd01fade6
Remove "download images in advance" option
2020-10-19 17:28:07 +02:00
cvium
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
2020-10-03 13:36:53 +02:00
Gary Wilber
25d8d85740
Back to HttpException
2020-09-29 01:19:12 -07:00
Gary Wilber
e9911b70dd
Use EnsureSuccessStatusCode
2020-09-28 18:12:35 -07:00
Gary Wilber
722ec43e25
remove status code from exception message
2020-09-27 23:05:43 -07:00
Gary Wilber
3ca9b13f99
Check response status code before saving images
2020-09-27 21:47:30 -07:00
Bond_009
2dbf73b989
Minor improvements
2020-09-16 14:16:44 +02:00
Bond_009
384ab39f5b
Fix some warnings
2020-09-07 13:20:39 +02:00
crobibero
dd078e7b82
use named client
2020-08-31 11:05:21 -06:00
Patrick Barron
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009
119f64f5e7
Make some methods async
2020-08-21 22:01:19 +02:00
Patrick Barron
98ed90c4a2
Merge branch 'master' into event-rewrite-1
2020-08-19 18:11:17 -04:00
Bond_009
2b400c99ef
Fix warnings
2020-08-19 17:50:50 +02:00
crobibero
767c73e5c1
fix usings
2020-08-17 13:22:42 -06:00
crobibero
1325815182
Remove IHttpClient from Providers
2020-08-17 13:10:02 -06:00
crobibero
10ac32569e
Remove IHttpClient from ItemImageProvider
2020-08-17 11:54:55 -06:00
crobibero
f7dc124b5e
Remove IHttpClient from ProviderManager
2020-08-17 11:50:07 -06:00
Patrick Barron
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
2020-08-13 20:52:55 -04:00
Anthony Lavado
5480674c4f
Merge pull request #3838 from Bond-009/memorystream
...
MemoryStream optimizations
2020-08-13 13:01:43 -04:00
Bond-009
bacfbbbd58
Merge pull request #3835 from cvium/fix_tvdb_404_shit_nginx_failure
...
Throw HttpException when tvdb sends us crap data
2020-08-10 10:50:21 +02:00
Bond_009
371a09c60b
MemoryStream optimizations
2020-08-09 14:08:55 +02:00
cvium
23dfadd430
Throw HttpException when tvdb sends us crap data
2020-08-06 23:43:19 +02:00
Anthony Lavado
da14c306b8
Merge pull request #3809 from Bond-009/minor4
...
Minor improvements
2020-08-04 17:35:12 -07:00
cvium
52d409101b
Change OnRefreshStart and OnRefreshComplete logging levels to debug
2020-08-04 09:05:51 +02:00
Bond_009
2b355c36ff
Minor improvements
...
OFC I reduced some allocations
2020-08-03 20:32:45 +02:00
E.Smith
f50348ca0b
Log path on lookup errors
...
If the lookup fails (due to a bad id in an nfo file for example), then
we had no indication of which directory failed, so the user can not
fix the problem.
Now we include the path in the error message such as:
MediaBrowser.Providers.TV.SeriesMetadataService: Error in
DummySeasonProvider for /media/x/y/z
and
MediaBrowser.Providers.Manager.ProviderManager:
TvdbSeriesImageProvider failed in GetImageInfos for type Series at
/media/x/y/z
2020-07-22 18:22:52 +01:00
Patrick Barron
6e11f77922
Add missing documentation.
2020-07-19 22:30:25 -04:00
Patrick Barron
3fdbdf4078
Clean up ProviderManager.cs
2020-07-19 20:54:57 -04:00
Patrick Barron
6d1b00da64
Use Array.Empty
2020-07-04 11:54:25 -04:00
Mark Monteiro
0e9164351b
Merge remote-tracking branch 'upstream/master' into external-id-type
2020-06-26 10:12:22 -04:00
Bond-009
f75024fade
Fix scan crashed
2020-06-22 10:06:35 +02:00
Anthony Lavado
bb947718ea
Merge pull request #3380 from Bond-009/warn20
...
Enable TreatWarningsAsErrors in Release for MediaBrowser.Providers
2020-06-20 12:26:02 -04:00
telans
98db8f72e0
fix SA1503 for one line if statements
2020-06-20 20:35:29 +12:00
telans
afe09612e8
fix SA1119
2020-06-20 18:13:11 +12:00
Bond_009
eba488a0f8
Enable TreatWarningsAsErrors in Release for MediaBrowser.Providers
2020-06-19 20:24:13 +02:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629)
2020-06-16 10:37:52 +12:00
telans
3d9049ef08
fix SA1508
2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005
2020-06-15 10:41:00 +12:00
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
aled
299e49f39d
Fix a small number of compile warnings
2020-06-09 23:12:53 +01:00
crobibero
57d1dbfe7b
undo erroneous changes
2020-06-05 18:29:58 -06:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Bond_009
7439e095e2
Merge branch 'master' into nullable3
2020-05-27 20:49:18 +02:00
ferferga
ba03ed65fe
Remove "download images in advance" option
2020-05-27 19:13:41 +02:00
Patrick Barron
1d1a145ad4
Fix issues and add profile image support
2020-05-20 10:04:00 -04:00
Mark Monteiro
d06fee75b6
Rename Name to ProviderName
2020-05-17 17:36:36 -04:00
Mark Monteiro
67edf1b7f5
Do not convert 'Type' value to string unnecessarily, and do not replace 'General' type with null
2020-05-17 15:59:13 -04:00
Mark Monteiro
e5c857ac36
Rename external id type 'None' to 'General'
2020-05-17 15:29:53 -04:00
Mark Monteiro
96acd6481e
Merge branch 'master' into externalid-type
2020-05-17 13:50:44 -04:00
Patrick Barron
9ad839c776
Initial migration code
2020-05-12 22:10:35 -04:00
Bond_009
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
2020-04-05 18:10:56 +02:00
Mark Monteiro
3d8b81039d
Log refresh progress at Debug level
2020-04-04 15:08:04 -04:00
Mark Monteiro
51b9a6e94b
Register IProviderManager correctly
2020-04-04 14:56:50 -04:00
Bond_009
3ab50f5a3f
Address comments
2020-04-01 19:05:41 +02:00
Bond_009
787049f35f
Merge branch 'master' into minor
2020-04-01 18:53:22 +02:00
Luke Foust
0fb78cf54b
Add documentation around Name, Id, and Type. Changed ExternalIdType to ExternalIdMediaType
2020-03-26 14:26:12 -07:00
Luke Foust
9bdb99fe92
Add type to externalids to distinguish them in the UI
2020-03-22 12:58:53 -07:00
dkanada
4f195f289c
remove useless interface
2020-03-10 00:10:02 +09:00
dkanada
52fde64f10
remove unused files and fix some future warnings
2020-03-09 23:30:57 +09:00
Bond_009
e699e5d405
Fix possible race condition
2020-02-28 20:34:10 +01:00
Bond_009
d1e1aef5f7
Fix possible race condition
2020-02-26 18:19:34 +01:00
Bond_009
a07ee65365
Minor improvements
2020-02-23 10:53:51 +01:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
Bond-009
c8409d2ea1
Remove FileSystem.GetStream
2020-01-22 22:20:35 +01:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Anthony Lavado
cb393c215a
Merge pull request #1686 from Bond-009/warn7
...
More warning fixes
2019-09-02 02:07:19 -04:00
Bond_009
e4f893a0eb
More warning fixes
2019-08-29 22:28:33 +02:00