Commit Graph

497 Commits

Author SHA1 Message Date
gnattu
97d7151289 Don't use finally block for tag fallback
Signed-off-by: gnattu <gnattuoc@me.com>
2024-05-28 20:24:40 +08:00
gnattu
475fa36ea3
Use better exception logging
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2024-05-28 20:23:03 +08:00
gnattu
e8d1ee0934 Use music metadata from ffprobe when TagLib fails
TagLib has its own limitations, which cause it to fail on certain audio files or extract incomplete information from the tags. Use the information from ffprobe when TagLib fails to extract data.

Signed-off-by: gnattu <gnattuoc@me.com>
2024-05-28 14:24:36 +08:00
Tim Eisele
b2d54b82fa
Improve reliability of HasChanged check (#11792) 2024-05-24 07:50:09 -06:00
Nathan McCrina
d5dc4435d9
Handle exception for unexpected audio file YEAR tag values (#11621) 2024-05-14 21:28:29 -06:00
gnattu
cf483203f5
Fix external LRC files being incorrectly overwritten during the initial scan (#11480) 2024-05-05 08:22:48 -06:00
Bond_009
88a38a61b5 Improve audio normalization
* Move calculation of LUFS to a scheduled task as it's pretty slow
* Correctly calculate album LUFS
* Don't try to convert replaygain tags to LUFS values
2024-04-28 15:18:53 +02:00
Bond-009
428283f787
Always scan ReplayGain tag (#11418) 2024-04-24 08:09:01 -06:00
Bond-009
3936fc9f25
Don't run ffprobe a second time for music file (#11419) 2024-04-23 07:08:49 -06:00
Cody Robibero
d402005d32 fix: fallback to artist if album artist not provided 2024-04-14 14:29:55 -06:00
Dominik Krivohlavek
ab731d9212
Fix track MBID in audio metadata (#11301) 2024-04-12 17:44:30 -06:00
Bond-009
b6d130ae2d
Merge pull request #11155 from sel10ut/bugfix/fix-releasedate-tag
Fix parsing of audio PremiereDate property
2024-03-16 16:43:59 +01:00
sel10ut
368a1b385a
fix: fallback to TagLib date parsing if ffprobe fails
Bring back hardcoded PremiereDate with correctly parsed year from TagLib, if ffprobe cannot get it
2024-03-15 01:37:11 +03:00
sel10ut
e9caa65eba
fix: change parsing of audio title tag 2024-03-14 13:25:04 +03:00
sel10ut
1236bb298c
fix: correct parsing of audio release date property
Read full date from ffmpeg probe.
2024-03-14 12:54:53 +03:00
Bond-009
35df0486f5
Merge pull request #11081 from crobibero/embedded-lyrics
Save embedded lyrics when probing audio
2024-03-03 07:52:23 -05:00
Bond-009
5a4aff36c1
Merge pull request #11079 from crobibero/bdinfo-codec
Always use ffmpeg codec for bluray
2024-03-01 10:25:11 -05:00
Cody Robibero
169e0dcb11 Save embedded lyrics when probing audio 2024-02-28 17:34:33 -07:00
Cody Robibero
ac33d1593a oops 2024-02-28 17:34:06 -07:00
Cody Robibero
5a652360c3
Update AudioFileProber.cs 2024-02-28 17:18:52 -07:00
Cody Robibero
ddf8f7d636
Update AudioFileProber.cs 2024-02-28 17:12:05 -07:00
Cody Robibero
f3c333f4d5
Merge branch 'master' into bhowe34/fix-replace-missing-metadata-for-music 2024-02-28 17:09:23 -07:00
Cody Robibero
c603cd2e4e Always use ffmpeg codec for bluray 2024-02-28 14:10:44 -07:00
Brian Howe
54eb81395e Merge branch 'master' into bhowe34/fix-replace-missing-metadata-for-music 2024-02-27 21:07:30 -06:00
Cody Robibero
0bc41c015f
Store lyrics in the database as media streams (#9951) 2024-02-26 05:09:40 -07:00
TelepathicWalrus
7b5c41c2a5
Add option to use replaygain tags for audio (#10566)
* Add option to use replaygain tags for audio

* Change regex to be specific

* Use ffprobe for faster metadata grabs

* Change regex to .Match
2024-01-06 13:59:56 -07:00
Brian Howe
7f1fec688c check ReplaceAllMetadata option and name field lock 2023-12-06 23:55:36 -06:00
GinoGinocchio
ddcd29f17e Update MediaBrowser.Providers/MediaInfo/AudioFileProber.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-12-06 22:57:11 -06:00
GinoGinocchio
de91a213a1 Update MediaBrowser.Providers/MediaInfo/AudioFileProber.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-12-06 22:57:11 -06:00
GinoGinocchio
81d642abe3 Removing unnecesary empty and null validations 2023-12-06 22:57:11 -06:00
GinoGinocchio
eb41cd51ea Using TryGetProviderId and adding an empty validation 2023-12-06 22:57:11 -06:00
GinoGinocchio
01bbc7d117 Correcting according to the comments provided 2023-12-06 22:57:11 -06:00
GinoGinocchio
d1cc56f78c Fix: "Feature 'replace missing metadata' overwrites existing metadata that does exist" for music 2023-12-06 22:57:11 -06:00
Bond_009
b62b0ec2b5 Fix warnings 2023-11-14 21:14:21 +01:00
Cody Robibero
892973a9e3
Merge branch 'master' into media-type 2023-11-09 22:03:55 -07:00
Stepan Goremykin
8d7e4229ca Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Net/SocketFactory.cs
#	RSSDP/SsdpCommunicationsServer.cs
#	RSSDP/SsdpDeviceLocator.cs
#	RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Cody Robibero
2920611ffc Convert string MediaType to enum MediaType 2023-10-10 15:57:15 -06:00
Bond_009
c707baed83 Jellyfin.Drawing minor improvements
Reduce duplicate/dead code
2023-10-08 17:10:04 +02:00
Stepan Goremykin
8ea812b65d Reduce string literal length by using verbatim string 2023-10-08 00:26:12 +02:00
Stepan Goremykin
d6b557d9ee Move declaration closer to usage 2023-10-07 23:56:07 +02:00
Nyanmisaka
debbfaa502
Fix MJPEG video is recognized as embedded image (#10173)
fixes 1d729b2

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-08-30 17:19:52 -06:00
Bond_009
18a311d32f == null -> is null 2023-08-22 21:14:54 +02:00
Bond_009
d92e9ae85e Enable nullable for more files and add tests
Adds basic tests for FFProbeVideoInfo.CreateDummyChapters
Fixed error message CreateDummyChapters instead of reporting the total minutes it only reported the minute component
2023-08-22 18:11:34 +02:00
Claus Vium
956e3dab43
fix: accessing Standard* of a Process requires manually disposing them afterwards (#10125) 2023-08-20 20:06:57 +02:00
Jan Müller
66ff724acf Fix the probing of m4a metadata
The composer is not set in some of my m4a files. For some reason
TagLibSharp returns the composer as an empty string in this case. This
causes an exception in PeopleHelper.AddPerson, and thus probing fails.

IMHO we can simply ignore empty values.

Fixes: #10061
2023-07-31 22:19:06 +02:00
Bond_009
b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
TelepathicWalrus
603fce59df
Audio normalization (#9222)
Co-authored-by: Joe Rogers <1337joe@users.noreply.github.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
2023-05-15 13:12:24 +02:00
Cody Robibero
89be3aa37f
Convert Person.Type to use PersonKind enum (#9487) 2023-03-25 11:52:02 -06:00
Shadowghost
21dcf775be
Add config option to disable dummy chapter generation (#9410) 2023-03-14 16:20:12 -06:00
Bond-009
6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00