Jonas Resch
0894a6193f
Implement coding standards from 2nd code feedback
2021-11-30 19:31:46 +01:00
Jonas Resch
9d34d6339a
Change return type from List<string> to IEnumerable<string> in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
bbf1399826
Check language for null or empty instead of only null in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
d016d483ae
Change return type from Task<List<MediaStream>> to Task<IAsyncEnumerable<MediaStream>> in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
61b191d345
Fix indentation in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
If statement which checks if filename of audio and video file match or if audio file starts with video filename
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
9433072f90
Only search in video folder for external audio files
...
Don't search in video metadata folder since audio files won't be stored there
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
a3c5afa443
Add ConfigureAwait false MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-11-30 19:31:46 +01:00
Jonas Resch
f1862f9b1a
Add ConfigureAwait false to MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-11-30 19:31:46 +01:00
Jonas Resch
a68e58556c
Implement code feedback
...
- Rewrite AudioResolver
- Use async & await instead of .Result
- Add support for audio containers with multiple audio streams (e.g.
mka)
- Fix bug when using external subtitle and external audio streams at the
same time
2021-11-30 19:31:46 +01:00
Jonas Resch
c1a8385c9c
Shorten calculation of audio startIndex in MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
9978164438
Add support for external audio files
2021-11-30 19:31:46 +01:00
Bond-009
2a09d4244c
Merge pull request #6923 from cvium/query_a_bit_less
2021-11-29 13:00:38 +01:00
cvium
beef6f0855
Don't query series twice
2021-11-28 19:56:31 +01:00
Joe Rogers
1df5b5034b
Address suppressed warnings
2021-11-27 20:35:18 +01:00
Joe Rogers
4a20ae6cb4
Allow default/forced tag without setting language
2021-11-27 20:13:21 +01:00
Cody Robibero
b2b4bd82d7
Merge pull request #6862 from 1337joe/query-instead-of-filtering
2021-11-20 08:50:39 -07:00
cvium
71a0abe211
Remove unnecessary N/A checks (converter changes them to null)
2021-11-20 08:32:07 +01:00
cvium
d8c3b8e7f8
Don't use AppendFormat
2021-11-20 08:24:52 +01:00
Joe Rogers
88baff5693
Apply suggestions from code review
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-19 22:40:42 +01:00
cvium
96ea865681
Refactor omdb providers
2021-11-19 15:32:07 +01:00
Joe Rogers
9ba7bf96ef
Query MediaSourceManager directly in image providers
...
Add doc comments/minor tweaks to AudioImageProvider
2021-11-18 15:11:50 +01:00
Joe Rogers
7cf5767949
Query media streams by type instead of filtering
2021-11-17 22:34:04 +01:00
Cody Robibero
fa366f0099
Merge pull request #6860 from cvium/fix_xml_endless_loops
2021-11-17 08:39:49 -07:00
cvium
61b75c82ce
Read past empty elements
2021-11-17 14:49:30 +01:00
cvium
24024706bf
Fix release build
2021-11-16 12:55:35 +01:00
cvium
93fd1c7075
Fix
2021-11-16 12:27:27 +01:00
cvium
b50c3852ef
Remove unused dependencies
2021-11-16 12:24:17 +01:00
Cody Robibero
4cfe8fe588
Merge pull request #6831 from 1337joe/image-provider-cleanup
2021-11-15 15:45:33 -07:00
Joe Rogers
f059be8e4d
Add logging and fast return
2021-11-15 15:30:43 +01:00
Joe Rogers
370b7f8e12
Handle unexpected case more gracefully
2021-11-14 23:13:45 +01:00
Joe Rogers
1d729b2b0f
Use codec to determine image format
2021-11-12 16:30:30 +01:00
Joe Rogers
f73a7a6ed8
Use ImageFormat instead of string for extension
2021-11-12 16:22:11 +01:00
Cody Robibero
14c072dd32
Fix filtering images without dimensions
2021-11-12 07:21:46 -07:00
Joe Rogers
de9bf327c6
Merge similar tests with Theories
2021-11-12 13:44:48 +01:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero
64652b6392
Fix and disable new dotnet6 warnings
2021-11-08 12:40:52 -07:00
Cody Robibero
40045d2147
Update to full dotnet 6
2021-11-08 09:40:12 -07:00
Joe Rogers
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot
2021-11-06 20:43:20 +01:00
Joe Rogers
c8eba90c17
Add cast limit to tmdb plugin settings
2021-11-05 00:38:50 +01:00
Joe Rogers
6c76d30538
Add missing checkboxes
2021-11-04 23:58:32 +01:00
Bond_009
924c6682b9
Remove unused IHasScreenshots interface
2021-11-04 01:06:21 +01:00
Claus Vium
5c5d49ee60
Merge pull request #6763 from 1337joe/tmdb-image-provider-dedup
2021-11-04 00:22:08 +01:00
Joe Rogers
4fc0521d69
Move ConvertToRemoteImage to TmdbClientManager
2021-11-03 17:16:40 +01:00
Claus Vium
869d537aaa
Merge pull request #6752 from 1337joe/fix-metadata-refresh-deletes-backgrounds
2021-11-03 13:01:23 +01:00
Joe Rogers
2b283d249f
Switch to method per image conversion
2021-11-02 21:12:13 +01:00
Joe Rogers
7fcf01235c
Change RemoveImages to array, improve download test
2021-11-02 16:16:06 +01:00
zehner
3d858955b6
Make tags import from TMDB configurable
...
new settings added
2021-11-02 15:11:01 +01:00
Joe Rogers
7da6bd905a
Fix edge case in multi-image replacing
2021-11-02 00:31:59 +01:00
Joe Rogers
4a5e8b99a0
Extract duplicate code, add test
2021-11-01 23:17:00 +01:00
Joe Rogers
b478b115e3
Refactor to validate all images up front
2021-11-01 11:53:31 +01:00