Commit Graph

183 Commits

Author SHA1 Message Date
Bond_009
7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
crobibero
223b42aed3 Create BaseItemKind enum 2021-02-10 17:09:23 -07:00
crobibero
4e2d029b3d Add null check for ImageTags 2021-01-25 08:48:24 -07:00
crobibero
13f347a813 Fix potential null reference 2021-01-05 07:00:48 -07:00
crobibero
d077c425d3 Add only correct person blurhash 2021-01-01 12:35:03 -07:00
cvium
a0fbf0f539 Only apply series image aspect ratio if episode/season has no primary image 2020-12-06 22:49:00 +01:00
Bond_009
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[]) 2020-11-14 20:27:48 +01:00
Bond_009
49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
Bond-009
7775066475
Merge pull request #4236 from ConfusedPolarBear/warnings1
Fix some warnings
2020-09-29 09:18:52 +02:00
Matt Montgomery
53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
dkanada
63b49ff4d8
Merge pull request #4204 from cvium/add_aspect_ratio_seriesprimary
Add series image aspect ratio when ep/season is missing an image
2020-09-27 19:07:57 +09:00
cvium
ec5b738079 Fix aspect ratio calculation returning 0 or 1 when item has no default AR 2020-09-24 23:09:26 +02:00
cvium
9cdef5b57c Add series image aspect ratio when ep/season is missing an image 2020-09-24 22:27:17 +02:00
Bond_009
e653eef44f Fix some warnings 2020-08-31 22:20:19 +02:00
Patrick Barron
2be1865b42 Remove unused methods in IDtoService 2020-08-13 12:50:04 -04:00
crobibero
0651d7512b Enable BlurHash for People 2020-06-16 15:12:48 -06:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans
3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
telans
726e116d5b
fix SA1510 2020-06-15 10:40:57 +12:00
Patrick Barron
42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
crobibero
44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily
2482bcb3b1 Add blurhashes to ImageBlurHashes for all images 2020-05-27 16:27:27 +03:00
Vasily
0f32b0ffad Change image blurhash mapping to "image type to blurhash" 2020-05-26 01:04:40 +03:00
Vasily
1f83a21288 Rename Hash to BlurHash in all properties and methods for clarity 2020-05-21 01:43:19 +03:00
Patrick Barron
c464f700db Remove redundant qualifiers 2020-05-20 13:07:53 -04:00
Vasily
186b7f303c More small optimizations 2020-05-19 15:08:43 +03:00
Jesús Higueras
b9fc0d2628 Add BlurHash support to backend 2020-05-18 23:21:37 +03:00
Patrick Barron
9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Mark Monteiro
1e1295bebf Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-11 10:00:39 -04:00
Mark Monteiro
51b9a6e94b Register IProviderManager correctly 2020-04-04 14:56:50 -04:00
Mark Monteiro
75b05ca1e6 Register and construct DtoService correctly 2020-04-04 14:41:03 -04:00
Mark Monteiro
4699ec6417
Use null-coalescing assignment
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-04-01 21:20:36 +02:00
Mark Monteiro
cc8294842a Add ExtraType.Unknown enum value and use it instead of null 2020-04-01 18:10:29 +02:00
Mark Monteiro
e266ad51c5 Simplify logic; remove unnecessary methods 2020-03-28 14:17:33 +01:00
Mark Monteiro
5fcbedc194 Display extras with an unknown type 2020-03-28 13:40:56 +01:00
Bond_009
07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009
ddf9b38799 Simplify image processing by removing image enhancers 2020-01-21 20:26:30 +01:00
Bond_009
2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
Bond_009
42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
dkanada
e006b7f1e1 add comment explaining a bug fix 2019-10-06 01:24:04 +09:00
dkanada
db10f380d1 fix missing image on seasons without posters 2019-10-06 00:58:27 +09:00
Bond_009
c9820d30ed Fix multiple mistakes and warnings 2019-09-23 20:32:44 +02:00
Bond-009
ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond_009
e4f893a0eb More warning fixes 2019-08-29 22:28:33 +02:00
SL1288
fdc24ec2ee Fix LocalTrailers playback. 2019-08-19 18:56:41 +02:00
Bond_009
838e5d05d5 Document all public/internal members of Emby.Drawing
Forces all new public/internal members to be documented.
Enables TreatWarningsAsErrors for Emby.Drawing
2019-08-11 16:52:37 +02:00
Bond-009
6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond-009
6566c91360 Seperate changes from #1023
The unrelated changes from #1023 (and more)
2019-03-25 21:27:03 +01:00
Bond-009
1731bf7372 Remove ordering items 2019-02-26 20:47:23 +01:00
Bond_009
a6a4cd5667 Removed some unused fields 2019-02-09 15:57:42 +01:00
Bond-009
e216702bcf Complete rename ImageSize -> ImageDimensions 2019-02-05 19:53:50 +01:00
Bond_009
1385d89df6 Remove MoreLINQ 2019-02-02 12:27:06 +01:00
Claus Vium
8985fb8d58 Remove support for games as a media type 2019-01-31 19:04:47 +01:00
Bond_009
883575893b Change image dimentions from double to int
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00
William Taylor
65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Erwin de Haan
321c440739 Reformat JustAMan review pt1 changes
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan
c5c7a3c4ee Visual Studio Reformat: Emby.Server.Implementations Part De-H 2019-01-13 20:20:41 +01:00
Erwin de Haan
ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009
79d18cf5a5 Clean up some catch statements 2018-12-30 22:44:39 +01:00
Bond_009
ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009
0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Bond_009
6e5d2aadaa Remove custom ToArray extension 2018-12-28 16:48:26 +01:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti
a59ff27605 fix image analysis 2017-10-22 20:43:52 -04:00
Luke Pulverenti
7e5036a587 update image aspect ratio detection 2017-10-22 02:22:43 -04:00
Luke Pulverenti
4ef9f68837 support delete per library 2017-10-16 02:10:55 -04:00
Luke Pulverenti
1da8509ae5 update playback settings 2017-10-01 20:13:43 -04:00
Luke Pulverenti
31b01cbb56 add fixes for dng images 2017-09-22 16:33:01 -04:00
Luke Pulverenti
b4851d4789 separate deinterlacing params by video codec 2017-09-21 17:36:19 -04:00
Luke
eb2a133004 Merge pull request #2897 from MediaBrowser/beta
Beta
2017-09-20 13:22:39 -04:00
Luke Pulverenti
cdd79ec7e2 update owned items 2017-09-18 12:52:22 -04:00
Luke Pulverenti
eb63e0d264 update image processor 2017-09-07 14:17:18 -04:00
Luke Pulverenti
8de80d43ba update ResolutionNormalizer 2017-08-30 14:06:54 -04:00
Luke Pulverenti
ed81591175 update dto methods 2017-08-27 20:33:05 -04:00
Luke
f3ee129bd9 Merge pull request #2847 from MediaBrowser/beta
Beta
2017-08-27 13:34:55 -04:00
Luke Pulverenti
e441e2f53d update active recordings 2017-08-24 15:52:19 -04:00
Luke Pulverenti
afd94407f9 rework active recordings 2017-08-23 15:45:52 -04:00
Luke Pulverenti
2d0c98733a normalize media source container 2017-08-23 13:27:53 -04:00
Luke Pulverenti
6736f79abe removed dead code 2017-08-23 13:08:17 -04:00
Luke Pulverenti
9ccdd71f29 fix quick play with play button 2017-08-20 15:06:05 -04:00
Luke Pulverenti
1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00
Luke Pulverenti
0951819f00 fixes #2798, fixes #2799 2017-08-13 16:15:07 -04:00
Luke Pulverenti
b7867214ef update download error handling 2017-08-11 17:55:48 -04:00
Luke Pulverenti
a7db7cd40c reduce traffic from session player 2017-08-11 02:29:49 -04:00
Luke Pulverenti
900714c866 consolidate fields 2017-08-10 16:06:36 -04:00
Luke Pulverenti
e7425e6205 revert servicestack.text update 2017-08-10 14:01:31 -04:00
Luke Pulverenti
40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti
52aeb3c40b consolidate interfaces 2017-08-07 17:06:13 -04:00
Luke Pulverenti
6d78824c8e update components 2017-08-06 19:01:00 -04:00
Luke Pulverenti
db315c4e32 update media source methods 2017-08-05 15:02:33 -04:00
Luke Pulverenti
dc7a59c73a ensure custom css is loaded last 2017-07-23 18:29:53 -04:00
Luke Pulverenti
24d91d9363 update image inheritance 2017-07-07 18:04:46 -04:00
Luke Pulverenti
dcaf8356e6 update inherited images 2017-06-29 15:10:58 -04:00