From e8a05ad996ab35909cd5928d49c4e8c46e9985d5 Mon Sep 17 00:00:00 2001
From: herby2212 <12448284+herby2212@users.noreply.github.com>
Date: Mon, 9 Oct 2023 19:15:25 +0200
Subject: [PATCH] optimize checkForInactiveStreams logic

---
 .../Session/SessionManager.cs                 | 50 ++++++++-----------
 1 file changed, 22 insertions(+), 28 deletions(-)

diff --git a/Emby.Server.Implementations/Session/SessionManager.cs b/Emby.Server.Implementations/Session/SessionManager.cs
index 329138feb..dc59a4523 100644
--- a/Emby.Server.Implementations/Session/SessionManager.cs
+++ b/Emby.Server.Implementations/Session/SessionManager.cs
@@ -625,43 +625,37 @@ namespace Emby.Server.Implementations.Session
 
         private async void CheckForInactiveSteams(object state)
         {
-            var pausedSessions = Sessions.Where(i =>
+            var inactiveSessions = Sessions.Where(i =>
                     i.NowPlayingItem is not null
                     && i.PlayState.IsPaused
-                    && i.LastPausedDate is not null)
-                .ToList();
+                    && (DateTime.UtcNow - i.LastPausedDate).Value.TotalMinutes > _config.Configuration.InactiveSessionThreshold);
 
-            if (pausedSessions.Count > 0)
+            foreach (var session in inactiveSessions)
             {
-                var inactiveSessions = pausedSessions.Where(i => (DateTime.UtcNow - i.LastPausedDate).Value.TotalMinutes > _config.Configuration.InactiveSessionThreshold).ToList();
+                _logger.LogDebug("Session {Session} has been inactive for {InactiveTime} minutes. Stopping it.", session.Id, _config.Configuration.InactiveSessionThreshold);
 
-                foreach (var session in inactiveSessions)
+                try
                 {
-                    _logger.LogDebug("Session {Session} has been inactive for {InactiveTime} minutes. Stopping it.", session.Id, _config.Configuration.InactiveSessionThreshold);
-
-                    try
-                    {
-                        await SendPlaystateCommand(
-                            session.Id,
-                            session.Id,
-                            new PlaystateRequest()
-                            {
-                                Command = PlaystateCommand.Stop,
-                                ControllingUserId = session.UserId.ToString(),
-                                SeekPositionTicks = session.PlayState?.PositionTicks
-                            },
-                            CancellationToken.None).ConfigureAwait(true);
-                    }
-                    catch (Exception ex)
-                    {
-                        _logger.LogDebug(ex, "Error calling SendPlaystateCommand for stopping inactive session {Session}.", session.Id);
-                    }
+                    await SendPlaystateCommand(
+                        session.Id,
+                        session.Id,
+                        new PlaystateRequest()
+                        {
+                            Command = PlaystateCommand.Stop,
+                            ControllingUserId = session.UserId.ToString(),
+                            SeekPositionTicks = session.PlayState?.PositionTicks
+                        },
+                        CancellationToken.None).ConfigureAwait(true);
+                }
+                catch (Exception ex)
+                {
+                    _logger.LogDebug(ex, "Error calling SendPlaystateCommand for stopping inactive session {Session}.", session.Id);
                 }
             }
 
-            var playingSessions = Sessions.Where(i => i.NowPlayingItem is not null)
-                .ToList();
-            if (playingSessions.Count == 0)
+            bool playingSessions = Sessions.Any(i => i.NowPlayingItem is not null);
+
+            if (!playingSessions)
             {
                 StopInactiveCheckTimer();
             }