michael.heier/jellyfin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable StyleCop and FxCop analyzers for integration tests project

Browse Source 
Use a custom ruleset that derives from the base solution ruleset, overriding rules where necessary
This commit is contained in:
Mark Monteiro 2020-05-03 16:23:42 -04:00
parent ea82e2158c
commit e66b000183
3 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/MediaBrowser.Api.Tests/JellyfinApplicationFactory.cs
View File

@ -26,7 +26,7 @@ namespace MediaBrowser.Api.Tests
private static readonly ConcurrentBag<IDisposable> _disposableComponents = new ConcurrentBag<IDisposable>();
/// <summary>
/// Initializes a new instance of <see cref="JellyfinApplicationFactory"/>.
/// Initializes a new instance of the <see cref="JellyfinApplicationFactory"/> class.
/// </summary>
public JellyfinApplicationFactory()
{

10
tests/MediaBrowser.Api.Tests/MediaBrowser.Api.Tests.csproj
View File

@ -20,4 +20,14 @@
<ProjectReference Include="..\..\MediaBrowser.Api\MediaBrowser.Api.csproj" />
</ItemGroup>
<!-- Code Analyzers-->
<ItemGroup Condition=" '$(Configuration)' == 'Debug' ">
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8" PrivateAssets="All" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118" PrivateAssets="All" />
</ItemGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<CodeAnalysisRuleSet>MediaBrowser.Api.Tests.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>
</Project>

22
tests/MediaBrowser.Api.Tests/MediaBrowser.Api.Tests.ruleset Normal file
View File

@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<RuleSet Name="Rules for MediaBrowser.Api.Tests" Description="Code analysis rules for MediaBrowser.Api.Tests.csproj" ToolsVersion="14.0">
<!-- Include the solution default RuleSet. The rules in this file will override the defaults. -->
<Include Path="../../jellyfin.ruleset" Action="Default" />
<!-- StyleCop Analyzer Rules -->
<Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
<!-- SA0001: XML comment analysis is disabled due to project configuration -->
<Rule Id="SA0001" Action="None" />
</Rules>
<!-- FxCop Analyzer Rules -->
<Rules AnalyzerId="Microsoft.CodeAnalysis.FxCopAnalyzers" RuleNamespace="Microsoft.Design">
<!-- CA1707: Identifiers should not contain underscores -->
<Rule Id="CA1707" Action="None" />
<!-- CA2007: Consider calling ConfigureAwait on the awaited task -->
<Rule Id="CA2007" Action="None" />
<!-- CA2234: Pass system uri objects instead of strings -->
<Rule Id="CA2234" Action="Info" />
</Rules>
</RuleSet>