From 1009836a792f5b76829b8ec9b2a6d859d2cde298 Mon Sep 17 00:00:00 2001
From: cvium <clausvium@gmail.com>
Date: Sun, 22 Oct 2023 22:28:45 +0200
Subject: [PATCH] add IAsyncDisposable to DisplayPreferencesManager

Properly dispose dbcontext
Add IDisposableAnalyzer to Jellyfin.Server.Implementations
---
 .../Jellyfin.Server.Implementations.csproj               | 4 ++++
 .../Users/DisplayPreferencesManager.cs                   | 9 ++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj b/Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj
index 390ed58b3..fa6adb022 100644
--- a/Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj
+++ b/Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj
@@ -8,6 +8,10 @@
 
   <!-- Code analysers-->
   <ItemGroup Condition=" '$(Configuration)' == 'Debug' ">
+    <PackageReference Include="IDisposableAnalyzers">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
diff --git a/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs b/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs
index bfae81e4c..edc6aa173 100644
--- a/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs
+++ b/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
 using Jellyfin.Data.Entities;
 using MediaBrowser.Controller;
 using Microsoft.EntityFrameworkCore;
@@ -13,7 +14,7 @@ namespace Jellyfin.Server.Implementations.Users
     /// <summary>
     /// Manages the storage and retrieval of display preferences through Entity Framework.
     /// </summary>
-    public class DisplayPreferencesManager : IDisplayPreferencesManager
+    public sealed class DisplayPreferencesManager : IDisplayPreferencesManager, IAsyncDisposable
     {
         private readonly JellyfinDbContext _dbContext;
 
@@ -97,5 +98,11 @@ namespace Jellyfin.Server.Implementations.Users
         {
             _dbContext.SaveChanges();
         }
+
+        /// <inheritdoc />
+        public async ValueTask DisposeAsync()
+        {
+            await _dbContext.DisposeAsync().ConfigureAwait(false);
+        }
     }
 }