Update to use the Theory/InlineData method to parameterize unit tests

This commit is contained in:
dtparr 2020-04-10 21:18:41 +00:00
parent 1f33c51977
commit ce86455747

View File

@ -45,44 +45,35 @@ namespace Jellyfin.Naming.Tests.Video
Test("300-behindthescenes.mp4", ExtraType.BehindTheScenes, videoOptions); Test("300-behindthescenes.mp4", ExtraType.BehindTheScenes, videoOptions);
} }
[Fact] [Theory]
public void TestDirectories() [InlineData(ExtraType.BehindTheScenes, "behind the scenes" )]
[InlineData(ExtraType.DeletedScene, "deleted scenes" )]
[InlineData(ExtraType.Interview, "interviews" )]
[InlineData(ExtraType.Scene, "scenes" )]
[InlineData(ExtraType.Sample, "samples" )]
[InlineData(ExtraType.Clip, "shorts" )]
[InlineData(ExtraType.Clip, "featurettes" )]
[InlineData(ExtraType.Unknown, "extras" )]
public void TestDirectories(ExtraType type, string dirName)
{ {
var videoOptions = new NamingOptions(); var videoOptions = new NamingOptions();
(ExtraType Type, string dirName)[] extraDirectoryNameTests =
{
(ExtraType.BehindTheScenes, "behind the scenes" ),
(ExtraType.DeletedScene, "deleted scenes" ),
(ExtraType.Interview, "interviews" ),
(ExtraType.Scene, "scenes" ),
(ExtraType.Sample, "samples" ),
(ExtraType.Clip, "shorts" ),
(ExtraType.Clip, "featurettes" ),
(ExtraType.Unknown, "extras" ),
};
foreach ((ExtraType type, string dirName) in extraDirectoryNameTests)
{
Test(dirName + "/300.mp4", type, videoOptions); Test(dirName + "/300.mp4", type, videoOptions);
Test("300/" + dirName + "/something.mkv", type, videoOptions); Test("300/" + dirName + "/something.mkv", type, videoOptions);
Test("/data/something/Movies/300/" + dirName + "/whoknows.mp4", type, videoOptions); Test("/data/something/Movies/300/" + dirName + "/whoknows.mp4", type, videoOptions);
} }
//Test the null condition [Theory]
string[] nonExtraDirectoryNames = [InlineData("gibberish")]
{ [InlineData("not a scene")]
"gibberish", [InlineData("The Big Short")]
"not a scene", public void TestNonExtraDirectories(string dirName)
};
foreach (string dirName in nonExtraDirectoryNames)
{ {
var videoOptions = new NamingOptions();
Test(dirName + "/300.mp4", null, videoOptions); Test(dirName + "/300.mp4", null, videoOptions);
Test("300/" + dirName + "/something.mkv", null, videoOptions); Test("300/" + dirName + "/something.mkv", null, videoOptions);
Test("/data/something/Movies/300/" + dirName + "/whoknows.mp4", null, videoOptions); Test("/data/something/Movies/300/" + dirName + "/whoknows.mp4", null, videoOptions);
} Test("/data/something/Movies/" + dirName + "/" + dirName + ".mp4", null, videoOptions);
Test("/data/something/Movies/not a scene/not a scene.mp4", null, videoOptions);
Test("/data/something/Movies/The Big Short/The Big Short.mp4", null, videoOptions);
} }
[Fact] [Fact]