Fix suggestions from review

This commit is contained in:
crobibero 2021-05-15 15:33:50 -06:00
parent 6bcbc2b88a
commit b6dda30a33
7 changed files with 21 additions and 24 deletions

View File

@ -51,14 +51,14 @@ namespace MediaBrowser.Controller.Channels
/// Gets the channels internal. /// Gets the channels internal.
/// </summary> /// </summary>
/// <param name="query">The query.</param> /// <param name="query">The query.</param>
/// <returns>The <see cref="QueryResult{T}"/> of <see cref="Channel"/>.</returns> /// <returns>The channels.</returns>
QueryResult<Channel> GetChannelsInternal(ChannelQuery query); QueryResult<Channel> GetChannelsInternal(ChannelQuery query);
/// <summary> /// <summary>
/// Gets the channels. /// Gets the channels.
/// </summary> /// </summary>
/// <param name="query">The query.</param> /// <param name="query">The query.</param>
/// <returns>The <see cref="QueryResult{T}"/> of <see cref="BaseItemDto"/>.</returns> /// <returns>The channels.</returns>
QueryResult<BaseItemDto> GetChannels(ChannelQuery query); QueryResult<BaseItemDto> GetChannels(ChannelQuery query);
/// <summary> /// <summary>
@ -66,7 +66,7 @@ namespace MediaBrowser.Controller.Channels
/// </summary> /// </summary>
/// <param name="query">The item query.</param> /// <param name="query">The item query.</param>
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A <see cref="Task"/> containing the <see cref="QueryResult{T}"/> of <see cref="BaseItemDto"/>.</returns> /// <returns>The latest channels.</returns>
Task<QueryResult<BaseItemDto>> GetLatestChannelItems(InternalItemsQuery query, CancellationToken cancellationToken); Task<QueryResult<BaseItemDto>> GetLatestChannelItems(InternalItemsQuery query, CancellationToken cancellationToken);
/// <summary> /// <summary>
@ -74,7 +74,7 @@ namespace MediaBrowser.Controller.Channels
/// </summary> /// </summary>
/// <param name="query">The item query.</param> /// <param name="query">The item query.</param>
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A <see cref="Task"/> containing the <see cref="QueryResult{T}"/> of <see cref="BaseItem"/>.</returns> /// <returns>The latest channels.</returns>
Task<QueryResult<BaseItem>> GetLatestChannelItemsInternal(InternalItemsQuery query, CancellationToken cancellationToken); Task<QueryResult<BaseItem>> GetLatestChannelItemsInternal(InternalItemsQuery query, CancellationToken cancellationToken);
/// <summary> /// <summary>
@ -82,7 +82,7 @@ namespace MediaBrowser.Controller.Channels
/// </summary> /// </summary>
/// <param name="query">The query.</param> /// <param name="query">The query.</param>
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A <see cref="Task"/> containing the <see cref="QueryResult{T}"/> of <see cref="BaseItemDto"/>.</returns> /// <returns>The channel items.</returns>
Task<QueryResult<BaseItemDto>> GetChannelItems(InternalItemsQuery query, CancellationToken cancellationToken); Task<QueryResult<BaseItemDto>> GetChannelItems(InternalItemsQuery query, CancellationToken cancellationToken);
/// <summary> /// <summary>
@ -91,7 +91,7 @@ namespace MediaBrowser.Controller.Channels
/// <param name="query">The query.</param> /// <param name="query">The query.</param>
/// <param name="progress">The progress to report to.</param> /// <param name="progress">The progress to report to.</param>
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A <see cref="Task"/> containing the <see cref="QueryResult{T}"/> of <see cref="BaseItem"/>.</returns> /// <returns>The channel items.</returns>
Task<QueryResult<BaseItem>> GetChannelItemsInternal(InternalItemsQuery query, IProgress<double> progress, CancellationToken cancellationToken); Task<QueryResult<BaseItem>> GetChannelItemsInternal(InternalItemsQuery query, IProgress<double> progress, CancellationToken cancellationToken);
/// <summary> /// <summary>
@ -99,7 +99,7 @@ namespace MediaBrowser.Controller.Channels
/// </summary> /// </summary>
/// <param name="item">The item.</param> /// <param name="item">The item.</param>
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>Task{IEnumerable{MediaSourceInfo}}.</returns> /// <returns>The item media sources.</returns>
IEnumerable<MediaSourceInfo> GetStaticMediaSources(BaseItem item, CancellationToken cancellationToken); IEnumerable<MediaSourceInfo> GetStaticMediaSources(BaseItem item, CancellationToken cancellationToken);
/// <summary> /// <summary>

View File

@ -1,6 +1,4 @@
#nullable disable #pragma warning disable CS1591
#pragma warning disable CS1591
using System.Threading; using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;

View File

@ -15,7 +15,7 @@ namespace MediaBrowser.Controller.Channels
/// </summary> /// </summary>
/// <param name="request">The request.</param> /// <param name="request">The request.</param>
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>Task{IEnumerable{ChannelItemInfo}}.</returns> /// <returns>The latest media.</returns>
Task<IEnumerable<ChannelItemInfo>> GetLatestMedia(ChannelLatestMediaSearch request, CancellationToken cancellationToken); Task<IEnumerable<ChannelItemInfo>> GetLatestMedia(ChannelLatestMediaSearch request, CancellationToken cancellationToken);
} }
} }

View File

@ -46,7 +46,7 @@ namespace MediaBrowser.Controller.Dto
/// <param name="options">The dto options.</param> /// <param name="options">The dto options.</param>
/// <param name="taggedItems">The list of tagged items.</param> /// <param name="taggedItems">The list of tagged items.</param>
/// <param name="user">The user.</param> /// <param name="user">The user.</param>
/// <returns>The <see cref="BaseItemDto"/>.</returns> /// <returns>The item dto.</returns>
BaseItemDto GetItemByNameDto(BaseItem item, DtoOptions options, List<BaseItem> taggedItems, User user = null); BaseItemDto GetItemByNameDto(BaseItem item, DtoOptions options, List<BaseItem> taggedItems, User user = null);
} }
} }

View File

@ -48,7 +48,7 @@ namespace MediaBrowser.Controller.Library
/// <param name="parent">The parent folder.</param> /// <param name="parent">The parent folder.</param>
/// <param name="libraryOptions">The library options.</param> /// <param name="libraryOptions">The library options.</param>
/// <param name="collectionType">The collection type.</param> /// <param name="collectionType">The collection type.</param>
/// <returns>The list of <see cref="BaseItem"/>.</returns> /// <returns>The items resolved from the paths.</returns>
IEnumerable<BaseItem> ResolvePaths( IEnumerable<BaseItem> ResolvePaths(
IEnumerable<FileSystemMetadata> files, IEnumerable<FileSystemMetadata> files,
IDirectoryService directoryService, IDirectoryService directoryService,

View File

@ -22,15 +22,14 @@ namespace MediaBrowser.Controller.Playlists
{ {
public class Playlist : Folder, IHasShares public class Playlist : Folder, IHasShares
{ {
public static readonly IReadOnlyList<string> SupportedExtensions = public static readonly IReadOnlyList<string> SupportedExtensions = new[]
new[] {
{ ".m3u",
".m3u", ".m3u8",
".m3u8", ".pls",
".pls", ".wpl",
".wpl", ".zpl"
".zpl" };
};
public Guid OwnerUserId { get; set; } public Guid OwnerUserId { get; set; }

View File

@ -16,7 +16,7 @@ namespace MediaBrowser.Controller.TV
/// </summary> /// </summary>
/// <param name="query">The next up query.</param> /// <param name="query">The next up query.</param>
/// <param name="options">The dto options.</param> /// <param name="options">The dto options.</param>
/// <returns>The query result of <see cref="BaseItem"/>.</returns> /// <returns>The next up items.</returns>
QueryResult<BaseItem> GetNextUp(NextUpQuery query, DtoOptions options); QueryResult<BaseItem> GetNextUp(NextUpQuery query, DtoOptions options);
/// <summary> /// <summary>
@ -25,7 +25,7 @@ namespace MediaBrowser.Controller.TV
/// <param name="request">The next up request.</param> /// <param name="request">The next up request.</param>
/// <param name="parentsFolders">The list of parent folders.</param> /// <param name="parentsFolders">The list of parent folders.</param>
/// <param name="options">The dto options.</param> /// <param name="options">The dto options.</param>
/// <returns>The query result of <see cref="BaseItem"/>.</returns> /// <returns>The next up items.</returns>
QueryResult<BaseItem> GetNextUp(NextUpQuery request, BaseItem[] parentsFolders, DtoOptions options); QueryResult<BaseItem> GetNextUp(NextUpQuery request, BaseItem[] parentsFolders, DtoOptions options);
} }
} }