diff --git a/MediaBrowser.Server.Implementations/MediaBrowser.Server.Implementations.csproj b/MediaBrowser.Server.Implementations/MediaBrowser.Server.Implementations.csproj
index 423f27c4a..9d2fc8c6b 100644
--- a/MediaBrowser.Server.Implementations/MediaBrowser.Server.Implementations.csproj
+++ b/MediaBrowser.Server.Implementations/MediaBrowser.Server.Implementations.csproj
@@ -254,10 +254,8 @@
-
-
diff --git a/MediaBrowser.Server.Implementations/MediaEncoder/MediaEncoder.cs b/MediaBrowser.Server.Implementations/MediaEncoder/MediaEncoder.cs
index 5792806d8..b24c9a5ca 100644
--- a/MediaBrowser.Server.Implementations/MediaEncoder/MediaEncoder.cs
+++ b/MediaBrowser.Server.Implementations/MediaEncoder/MediaEncoder.cs
@@ -1,9 +1,7 @@
using MediaBrowser.Common.Configuration;
using MediaBrowser.Common.IO;
using MediaBrowser.Common.MediaInfo;
-using MediaBrowser.Common.Net;
using MediaBrowser.Model.Entities;
-using MediaBrowser.Model.IO;
using MediaBrowser.Model.Logging;
using MediaBrowser.Model.Serialization;
using System;
@@ -13,7 +11,6 @@ using System.Diagnostics;
using System.Globalization;
using System.IO;
using System.Linq;
-using System.Reflection;
using System.Runtime.InteropServices;
using System.Text;
using System.Threading;
@@ -26,12 +23,6 @@ namespace MediaBrowser.Server.Implementations.MediaEncoder
///
public class MediaEncoder : IMediaEncoder, IDisposable
{
- ///
- /// Gets or sets the zip client.
- ///
- /// The zip client.
- private readonly IZipClient _zipClient;
-
///
/// The _logger
///
@@ -48,8 +39,6 @@ namespace MediaBrowser.Server.Implementations.MediaEncoder
/// The json serializer.
private readonly IJsonSerializer _jsonSerializer;
- private readonly IHttpClient _httpClient;
-
///
/// The video image resource pool
///
@@ -70,50 +59,25 @@ namespace MediaBrowser.Server.Implementations.MediaEncoder
///
private readonly SemaphoreSlim _ffProbeResourcePool = new SemaphoreSlim(2, 2);
- ///
- /// Gets or sets the versioned directory path.
- ///
- /// The versioned directory path.
- private string VersionedDirectoryPath { get; set; }
+ public string FFMpegPath { get; private set; }
- ///
- /// Initializes a new instance of the class.
- ///
- /// The logger.
- /// The zip client.
- /// The app paths.
- /// The json serializer.
- public MediaEncoder(ILogger logger, IZipClient zipClient, IApplicationPaths appPaths,
- IJsonSerializer jsonSerializer, IHttpClient httpClient)
+ public string FFProbePath { get; private set; }
+
+ public string Version { get; private set; }
+
+ public MediaEncoder(ILogger logger, IApplicationPaths appPaths,
+ IJsonSerializer jsonSerializer, string ffMpegPath, string ffProbePath, string version)
{
_logger = logger;
- _zipClient = zipClient;
_appPaths = appPaths;
_jsonSerializer = jsonSerializer;
- _httpClient = httpClient;
+ Version = version;
+ FFProbePath = ffProbePath;
+ FFMpegPath = ffMpegPath;
// Not crazy about this but it's the only way to suppress ffmpeg crash dialog boxes
SetErrorMode(ErrorModes.SEM_FAILCRITICALERRORS | ErrorModes.SEM_NOALIGNMENTFAULTEXCEPT |
ErrorModes.SEM_NOGPFAULTERRORBOX | ErrorModes.SEM_NOOPENFILEERRORBOX);
-
- Task.Run(() => VersionedDirectoryPath = GetVersionedDirectoryPath());
- }
-
- ///
- /// Gets the media tools path.
- ///
- /// if set to true [create].
- /// System.String.
- private string GetMediaToolsPath(bool create)
- {
- var path = Path.Combine(_appPaths.ProgramDataPath, "ffmpeg");
-
- if (create && !Directory.Exists(path))
- {
- Directory.CreateDirectory(path);
- }
-
- return path;
}
///
@@ -125,182 +89,6 @@ namespace MediaBrowser.Server.Implementations.MediaEncoder
get { return FFMpegPath; }
}
- ///
- /// The _ FF MPEG path
- ///
- private string _FFMpegPath;
-
- ///
- /// Gets the path to ffmpeg.exe
- ///
- /// The FF MPEG path.
- public string FFMpegPath
- {
- get { return _FFMpegPath ?? (_FFMpegPath = Path.Combine(VersionedDirectoryPath, "ffmpeg.exe")); }
- }
-
- ///
- /// The _ FF probe path
- ///
- private string _FFProbePath;
-
- ///
- /// Gets the path to ffprobe.exe
- ///
- /// The FF probe path.
- private string FFProbePath
- {
- get { return _FFProbePath ?? (_FFProbePath = Path.Combine(VersionedDirectoryPath, "ffprobe.exe")); }
- }
-
- ///
- /// Gets the version.
- ///
- /// The version.
- public string Version
- {
- get { return Path.GetFileNameWithoutExtension(VersionedDirectoryPath); }
- }
-
- ///
- /// Gets the versioned directory path.
- ///
- /// System.String.
- private string GetVersionedDirectoryPath()
- {
- var assembly = GetType().Assembly;
-
- var prefix = GetType().Namespace + ".";
-
- var srch = prefix + "ffmpeg";
-
- var resource = assembly.GetManifestResourceNames().First(r => r.StartsWith(srch));
-
- var filename =
- resource.Substring(resource.IndexOf(prefix, StringComparison.OrdinalIgnoreCase) + prefix.Length);
-
- var versionedDirectoryPath = Path.Combine(GetMediaToolsPath(true),
- Path.GetFileNameWithoutExtension(filename));
-
- if (!Directory.Exists(versionedDirectoryPath))
- {
- Directory.CreateDirectory(versionedDirectoryPath);
- }
-
- ExtractTools(assembly, resource, versionedDirectoryPath);
-
- return versionedDirectoryPath;
- }
-
- ///
- /// Extracts the tools.
- ///
- /// The assembly.
- /// The zip file resource path.
- /// The target path.
- private async void ExtractTools(Assembly assembly, string zipFileResourcePath, string targetPath)
- {
- using (var resourceStream = assembly.GetManifestResourceStream(zipFileResourcePath))
- {
- _zipClient.ExtractAll(resourceStream, targetPath, false);
- }
-
- try
- {
- await DownloadFonts(targetPath).ConfigureAwait(false);
- }
- catch (Exception ex)
- {
- _logger.ErrorException("Error getting ffmpeg font files", ex);
- }
- }
-
- private const string FontUrl = "https://www.dropbox.com/s/9nb76tybcsw5xrk/ARIALUNI.zip?dl=1";
-
- ///
- /// Extracts the fonts.
- ///
- /// The target path.
- private async Task DownloadFonts(string targetPath)
- {
- var fontsDirectory = Path.Combine(targetPath, "fonts");
-
- if (!Directory.Exists(fontsDirectory))
- {
- Directory.CreateDirectory(fontsDirectory);
- }
-
- const string fontFilename = "ARIALUNI.TTF";
-
- var fontFile = Path.Combine(fontsDirectory, fontFilename);
-
- if (!File.Exists(fontFile))
- {
- await DownloadFontFile(fontsDirectory, fontFilename).ConfigureAwait(false);
- }
-
- await WriteFontConfigFile(fontsDirectory).ConfigureAwait(false);
- }
-
- private async Task DownloadFontFile(string fontsDirectory, string fontFilename)
- {
- var existingFile = Directory
- .EnumerateFiles(_appPaths.ProgramDataPath, fontFilename, SearchOption.AllDirectories)
- .FirstOrDefault();
-
- if (existingFile != null)
- {
- try
- {
- File.Copy(existingFile, Path.Combine(fontsDirectory, fontFilename), true);
- return;
- }
- catch (IOException ex)
- {
- // Log this, but don't let it fail the operation
- _logger.ErrorException("Error copying file", ex);
- }
- }
-
- var tempFile = await _httpClient.GetTempFile(new HttpRequestOptions
- {
- Url = FontUrl,
- Progress = new Progress()
- });
-
- _zipClient.ExtractAll(tempFile, fontsDirectory, true);
-
- try
- {
- File.Delete(tempFile);
- }
- catch (IOException ex)
- {
- // Log this, but don't let it fail the operation
- _logger.ErrorException("Error deleting temp file {0}", ex, tempFile);
- }
- }
-
- private async Task WriteFontConfigFile(string fontsDirectory)
- {
- const string fontConfigFilename = "fonts.conf";
- var fontConfigFile = Path.Combine(fontsDirectory, fontConfigFilename);
-
- if (!File.Exists(fontConfigFile))
- {
- var contents = string.Format("{0}ArialArial Unicode MS", fontsDirectory);
-
- var bytes = Encoding.UTF8.GetBytes(contents);
-
- using (var fileStream = new FileStream(fontConfigFile, FileMode.Create, FileAccess.Write,
- FileShare.Read, StreamDefaults.DefaultFileStreamBufferSize,
- FileOptions.Asynchronous))
- {
- await fileStream.WriteAsync(bytes, 0, bytes.Length);
- }
- }
- }
-
///
/// Gets the media info.
///
diff --git a/MediaBrowser.ServerApplication/ApplicationHost.cs b/MediaBrowser.ServerApplication/ApplicationHost.cs
index 2d19260dc..5cae99785 100644
--- a/MediaBrowser.ServerApplication/ApplicationHost.cs
+++ b/MediaBrowser.ServerApplication/ApplicationHost.cs
@@ -284,8 +284,7 @@ namespace MediaBrowser.ServerApplication
RegisterSingleInstance(() => new LuceneSearchEngine(ApplicationPaths, LogManager, LibraryManager));
- MediaEncoder = new MediaEncoder(LogManager.GetLogger("MediaEncoder"), ZipClient, ApplicationPaths, JsonSerializer, HttpClient);
- RegisterSingleInstance(MediaEncoder);
+ await RegisterMediaEncoder().ConfigureAwait(false);
var clientConnectionManager = new SessionManager(UserDataRepository, ServerConfigurationManager, Logger, UserRepository);
RegisterSingleInstance(clientConnectionManager);
@@ -316,6 +315,18 @@ namespace MediaBrowser.ServerApplication
SetKernelProperties();
}
+ ///
+ /// Registers the media encoder.
+ ///
+ /// Task.
+ private async Task RegisterMediaEncoder()
+ {
+ var info = await new FFMpegDownloader(Logger, ApplicationPaths, HttpClient, ZipClient).GetFFMpegInfo().ConfigureAwait(false);
+
+ MediaEncoder = new MediaEncoder(LogManager.GetLogger("MediaEncoder"), ApplicationPaths, JsonSerializer, info.Path, info.ProbePath, info.Version);
+ RegisterSingleInstance(MediaEncoder);
+ }
+
///
/// Sets the kernel properties.
///
diff --git a/MediaBrowser.ServerApplication/Implementations/FFMpegDownloader.cs b/MediaBrowser.ServerApplication/Implementations/FFMpegDownloader.cs
new file mode 100644
index 000000000..7fd0acddd
--- /dev/null
+++ b/MediaBrowser.ServerApplication/Implementations/FFMpegDownloader.cs
@@ -0,0 +1,205 @@
+using MediaBrowser.Common.Configuration;
+using MediaBrowser.Common.IO;
+using MediaBrowser.Common.Net;
+using MediaBrowser.Model.IO;
+using MediaBrowser.Model.Logging;
+using System;
+using System.IO;
+using System.Linq;
+using System.Reflection;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace MediaBrowser.ServerApplication.Implementations
+{
+ public class FFMpegDownloader
+ {
+ private readonly IZipClient _zipClient;
+ private readonly IHttpClient _httpClient;
+ private readonly IApplicationPaths _appPaths;
+ private readonly ILogger _logger;
+
+ public FFMpegDownloader(ILogger logger, IApplicationPaths appPaths, IHttpClient httpClient, IZipClient zipClient)
+ {
+ _logger = logger;
+ _appPaths = appPaths;
+ _httpClient = httpClient;
+ _zipClient = zipClient;
+ }
+
+ public async Task GetFFMpegInfo()
+ {
+ var assembly = GetType().Assembly;
+
+ var prefix = GetType().Namespace + ".";
+
+ var srch = prefix + "ffmpeg";
+
+ var resource = assembly.GetManifestResourceNames().First(r => r.StartsWith(srch));
+
+ var filename =
+ resource.Substring(resource.IndexOf(prefix, StringComparison.OrdinalIgnoreCase) + prefix.Length);
+
+ var versionedDirectoryPath = Path.Combine(GetMediaToolsPath(true),
+ Path.GetFileNameWithoutExtension(filename));
+
+ if (!Directory.Exists(versionedDirectoryPath))
+ {
+ Directory.CreateDirectory(versionedDirectoryPath);
+ }
+
+ await ExtractTools(assembly, resource, versionedDirectoryPath).ConfigureAwait(false);
+
+ return new FFMpegInfo
+ {
+ ProbePath = Path.Combine(versionedDirectoryPath, "ffprobe.exe"),
+ Path = Path.Combine(versionedDirectoryPath, "ffmpeg.exe"),
+ Version = Path.GetFileNameWithoutExtension(versionedDirectoryPath)
+ };
+ }
+
+ ///
+ /// Extracts the tools.
+ ///
+ /// The assembly.
+ /// The zip file resource path.
+ /// The target path.
+ private async Task ExtractTools(Assembly assembly, string zipFileResourcePath, string targetPath)
+ {
+ using (var resourceStream = assembly.GetManifestResourceStream(zipFileResourcePath))
+ {
+ _zipClient.ExtractAll(resourceStream, targetPath, false);
+ }
+
+ try
+ {
+ await DownloadFonts(targetPath).ConfigureAwait(false);
+ }
+ catch (Exception ex)
+ {
+ _logger.ErrorException("Error getting ffmpeg font files", ex);
+ }
+ }
+
+ private const string FontUrl = "https://www.dropbox.com/s/9nb76tybcsw5xrk/ARIALUNI.zip?dl=1";
+
+ ///
+ /// Extracts the fonts.
+ ///
+ /// The target path.
+ private async Task DownloadFonts(string targetPath)
+ {
+ var fontsDirectory = Path.Combine(targetPath, "fonts");
+
+ if (!Directory.Exists(fontsDirectory))
+ {
+ Directory.CreateDirectory(fontsDirectory);
+ }
+
+ const string fontFilename = "ARIALUNI.TTF";
+
+ var fontFile = Path.Combine(fontsDirectory, fontFilename);
+
+ if (!File.Exists(fontFile))
+ {
+ await DownloadFontFile(fontsDirectory, fontFilename).ConfigureAwait(false);
+ }
+
+ await WriteFontConfigFile(fontsDirectory).ConfigureAwait(false);
+ }
+
+ ///
+ /// Downloads the font file.
+ ///
+ /// The fonts directory.
+ /// The font filename.
+ /// Task.
+ private async Task DownloadFontFile(string fontsDirectory, string fontFilename)
+ {
+ var existingFile = Directory
+ .EnumerateFiles(_appPaths.ProgramDataPath, fontFilename, SearchOption.AllDirectories)
+ .FirstOrDefault();
+
+ if (existingFile != null)
+ {
+ try
+ {
+ File.Copy(existingFile, Path.Combine(fontsDirectory, fontFilename), true);
+ return;
+ }
+ catch (IOException ex)
+ {
+ // Log this, but don't let it fail the operation
+ _logger.ErrorException("Error copying file", ex);
+ }
+ }
+
+ var tempFile = await _httpClient.GetTempFile(new HttpRequestOptions
+ {
+ Url = FontUrl,
+ Progress = new Progress()
+ });
+
+ _zipClient.ExtractAll(tempFile, fontsDirectory, true);
+
+ try
+ {
+ File.Delete(tempFile);
+ }
+ catch (IOException ex)
+ {
+ // Log this, but don't let it fail the operation
+ _logger.ErrorException("Error deleting temp file {0}", ex, tempFile);
+ }
+ }
+
+ ///
+ /// Writes the font config file.
+ ///
+ /// The fonts directory.
+ /// Task.
+ private async Task WriteFontConfigFile(string fontsDirectory)
+ {
+ const string fontConfigFilename = "fonts.conf";
+ var fontConfigFile = Path.Combine(fontsDirectory, fontConfigFilename);
+
+ if (!File.Exists(fontConfigFile))
+ {
+ var contents = string.Format("{0}ArialArial Unicode MS", fontsDirectory);
+
+ var bytes = Encoding.UTF8.GetBytes(contents);
+
+ using (var fileStream = new FileStream(fontConfigFile, FileMode.Create, FileAccess.Write,
+ FileShare.Read, StreamDefaults.DefaultFileStreamBufferSize,
+ FileOptions.Asynchronous))
+ {
+ await fileStream.WriteAsync(bytes, 0, bytes.Length);
+ }
+ }
+ }
+
+ ///
+ /// Gets the media tools path.
+ ///
+ /// if set to true [create].
+ /// System.String.
+ private string GetMediaToolsPath(bool create)
+ {
+ var path = Path.Combine(_appPaths.ProgramDataPath, "ffmpeg");
+
+ if (create && !Directory.Exists(path))
+ {
+ Directory.CreateDirectory(path);
+ }
+
+ return path;
+ }
+ }
+
+ public class FFMpegInfo
+ {
+ public string Path { get; set; }
+ public string ProbePath { get; set; }
+ public string Version { get; set; }
+ }
+}
diff --git a/MediaBrowser.Server.Implementations/MediaEncoder/ffmpeg20130904.zip.REMOVED.git-id b/MediaBrowser.ServerApplication/Implementations/ffmpeg20130904.zip.REMOVED.git-id
similarity index 100%
rename from MediaBrowser.Server.Implementations/MediaEncoder/ffmpeg20130904.zip.REMOVED.git-id
rename to MediaBrowser.ServerApplication/Implementations/ffmpeg20130904.zip.REMOVED.git-id
diff --git a/MediaBrowser.Server.Implementations/MediaEncoder/readme.txt b/MediaBrowser.ServerApplication/Implementations/readme.txt
similarity index 100%
rename from MediaBrowser.Server.Implementations/MediaEncoder/readme.txt
rename to MediaBrowser.ServerApplication/Implementations/readme.txt
diff --git a/MediaBrowser.ServerApplication/MediaBrowser.ServerApplication.csproj b/MediaBrowser.ServerApplication/MediaBrowser.ServerApplication.csproj
index f19ffe5b0..043d5c18f 100644
--- a/MediaBrowser.ServerApplication/MediaBrowser.ServerApplication.csproj
+++ b/MediaBrowser.ServerApplication/MediaBrowser.ServerApplication.csproj
@@ -210,6 +210,7 @@
+
Component
@@ -277,6 +278,7 @@
Resources.Designer.cs
+
SettingsSingleFileGenerator
@@ -388,6 +390,9 @@
+
+
+
if $(ConfigurationName) == Release (