diff --git a/Jellyfin.Api/Controllers/ActivityLogController.cs b/Jellyfin.Api/Controllers/ActivityLogController.cs
index ec50fb022..c287d1a77 100644
--- a/Jellyfin.Api/Controllers/ActivityLogController.cs
+++ b/Jellyfin.Api/Controllers/ActivityLogController.cs
@@ -35,17 +35,14 @@ namespace Jellyfin.Api.Controllers
/// Optional. The record index to start at. All items with a lower index will be dropped from the results.
/// Optional. The maximum number of records to return.
/// Optional. The minimum date. Format = ISO.
- /// Optional. Only returns activities that have a user associated.
/// Activity log returned.
/// A containing the log entries.
[HttpGet("Entries")]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "hasUserId", Justification = "Imported from ServiceStack")]
public ActionResult> GetLogEntries(
[FromQuery] int? startIndex,
[FromQuery] int? limit,
- [FromQuery] DateTime? minDate,
- bool? hasUserId)
+ [FromQuery] DateTime? minDate)
{
var filterFunc = new Func, IQueryable>(
entries => entries.Where(entry => entry.DateCreated >= minDate));
diff --git a/Jellyfin.Api/Controllers/DashboardController.cs b/Jellyfin.Api/Controllers/DashboardController.cs
index aab920ff3..6cfee2463 100644
--- a/Jellyfin.Api/Controllers/DashboardController.cs
+++ b/Jellyfin.Api/Controllers/DashboardController.cs
@@ -178,14 +178,13 @@ namespace Jellyfin.Api.Controllers
[ApiExplorerSettings(IgnoreApi = true)]
public ActionResult GetRobotsTxt()
{
- return GetWebClientResource("robots.txt", string.Empty);
+ return GetWebClientResource("robots.txt");
}
///
/// Gets a resource from the web client.
///
/// The resource name.
- /// The v.
/// Web client returned.
/// Server does not host a web client.
/// The resource.
@@ -193,10 +192,7 @@ namespace Jellyfin.Api.Controllers
[ApiExplorerSettings(IgnoreApi = true)]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status404NotFound)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "v", Justification = "Imported from ServiceStack")]
- public ActionResult GetWebClientResource(
- [FromRoute] string resourceName,
- [FromQuery] string? v)
+ public ActionResult GetWebClientResource([FromRoute] string resourceName)
{
if (!_appConfig.HostWebClient() || WebClientUiPath == null)
{
@@ -228,7 +224,7 @@ namespace Jellyfin.Api.Controllers
[ApiExplorerSettings(IgnoreApi = true)]
public ActionResult GetFavIcon()
{
- return GetWebClientResource("favicon.ico", string.Empty);
+ return GetWebClientResource("favicon.ico");
}
///
diff --git a/Jellyfin.Api/Controllers/FilterController.cs b/Jellyfin.Api/Controllers/FilterController.cs
index 0934a116a..8a0a6ad86 100644
--- a/Jellyfin.Api/Controllers/FilterController.cs
+++ b/Jellyfin.Api/Controllers/FilterController.cs
@@ -125,7 +125,6 @@ namespace Jellyfin.Api.Controllers
/// Optional. User id.
/// Optional. Specify this to localize the search to a specific item or folder. Omit to use the root.
/// Optional. If specified, results will be filtered based on item type. This allows multiple, comma delimited.
- /// [Unused] Optional. Filter by MediaType. Allows multiple, comma delimited.
/// Optional. Is item airing.
/// Optional. Is item movie.
/// Optional. Is item sports.
@@ -137,12 +136,10 @@ namespace Jellyfin.Api.Controllers
/// Query filters.
[HttpGet("/Items/Filters2")]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "mediaTypes", Justification = "Imported from ServiceStack")]
public ActionResult GetQueryFilters(
[FromQuery] Guid? userId,
[FromQuery] string? parentId,
[FromQuery] string? includeItemTypes,
- [FromQuery] string? mediaTypes,
[FromQuery] bool? isAiring,
[FromQuery] bool? isMovie,
[FromQuery] bool? isSports,
diff --git a/Jellyfin.Api/Controllers/ItemRefreshController.cs b/Jellyfin.Api/Controllers/ItemRefreshController.cs
index e6cdf4edb..3801ce5b7 100644
--- a/Jellyfin.Api/Controllers/ItemRefreshController.cs
+++ b/Jellyfin.Api/Controllers/ItemRefreshController.cs
@@ -47,7 +47,6 @@ namespace Jellyfin.Api.Controllers
/// (Optional) Specifies the image refresh mode.
/// (Optional) Determines if metadata should be replaced. Only applicable if mode is FullRefresh.
/// (Optional) Determines if images should be replaced. Only applicable if mode is FullRefresh.
- /// (Unused) Indicates if the refresh should occur recursively.
/// Item metadata refresh queued.
/// Item to refresh not found.
/// An on success, or a if the item could not be found.
@@ -55,14 +54,12 @@ namespace Jellyfin.Api.Controllers
[Description("Refreshes metadata for an item.")]
[ProducesResponseType(StatusCodes.Status204NoContent)]
[ProducesResponseType(StatusCodes.Status404NotFound)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "recursive", Justification = "Imported from ServiceStack")]
public ActionResult Post(
[FromRoute] Guid itemId,
[FromQuery] MetadataRefreshMode metadataRefreshMode = MetadataRefreshMode.None,
[FromQuery] MetadataRefreshMode imageRefreshMode = MetadataRefreshMode.None,
[FromQuery] bool replaceAllMetadata = false,
- [FromQuery] bool replaceAllImages = false,
- [FromQuery] bool recursive = false)
+ [FromQuery] bool replaceAllImages = false)
{
var item = _libraryManager.GetItemById(itemId);
if (item == null)
diff --git a/Jellyfin.Api/Controllers/LibraryController.cs b/Jellyfin.Api/Controllers/LibraryController.cs
index b822b3991..1ecf2ac73 100644
--- a/Jellyfin.Api/Controllers/LibraryController.cs
+++ b/Jellyfin.Api/Controllers/LibraryController.cs
@@ -120,22 +120,13 @@ namespace Jellyfin.Api.Controllers
///
/// Gets critic review for an item.
///
- /// The item id.
- /// Optional. The record index to start at. All items with a lower index will be dropped from the results.
- /// Optional. The maximum number of records to return.
/// Critic reviews returned.
/// The list of critic reviews.
[HttpGet("/Items/{itemId}/CriticReviews")]
[Authorize(Policy = Policies.DefaultAuthorization)]
[Obsolete("This endpoint is obsolete.")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "itemId", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "startIndex", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "limit", Justification = "Imported from ServiceStack")]
[ProducesResponseType(StatusCodes.Status200OK)]
- public ActionResult> GetCriticReviews(
- [FromRoute] Guid itemId,
- [FromQuery] int? startIndex,
- [FromQuery] int? limit)
+ public ActionResult> GetCriticReviews()
{
return new QueryResult();
}
@@ -682,10 +673,6 @@ namespace Jellyfin.Api.Controllers
///
/// The item id.
/// Exclude artist ids.
- /// (Unused) Optional. include image information in output.
- /// (Unused) Optional. include user data.
- /// (Unused) Optional. the max number of images to return, per image type.
- /// (Unused) Optional. The image types to include in the output.
/// Optional. Filter by user id, and attach user data.
/// Optional. The maximum number of records to return.
/// Optional. Specify additional fields of information to return in the output. This allows multiple, comma delimited. Options: Budget, Chapters, DateCreated, Genres, HomePageUrl, IndexOptions, MediaStreams, Overview, ParentId, Path, People, ProviderIds, PrimaryImageAspectRatio, Revenue, SortName, Studios, Taglines, TrailerUrls.
@@ -697,18 +684,10 @@ namespace Jellyfin.Api.Controllers
[HttpGet("/Shows/{itemId}/Similar")]
[HttpGet("/Movies/{itemId}/Similar")]
[HttpGet("/Trailers/{itemId}/Similar")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "enableImages", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "enableUserData", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "imageTypeLimit", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "enableImageTypes", Justification = "Imported from ServiceStack")]
[ProducesResponseType(StatusCodes.Status200OK)]
public ActionResult> GetSimilarItems(
[FromRoute] Guid itemId,
[FromQuery] string excludeArtistIds,
- [FromQuery] bool? enableImages,
- [FromQuery] bool? enableUserData,
- [FromQuery] int? imageTypeLimit,
- [FromQuery] string enableImageTypes,
[FromQuery] Guid userId,
[FromQuery] int? limit,
[FromQuery] string fields)
diff --git a/Jellyfin.Api/Controllers/LibraryStructureController.cs b/Jellyfin.Api/Controllers/LibraryStructureController.cs
index 62c547409..e4ac019c9 100644
--- a/Jellyfin.Api/Controllers/LibraryStructureController.cs
+++ b/Jellyfin.Api/Controllers/LibraryStructureController.cs
@@ -50,13 +50,11 @@ namespace Jellyfin.Api.Controllers
///
/// Gets all virtual folders.
///
- /// The user id.
/// Virtual folders retrieved.
/// An with the virtual folders.
[HttpGet]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "userId", Justification = "Imported from ServiceStack")]
- public ActionResult> GetVirtualFolders([FromQuery] string userId)
+ public ActionResult> GetVirtualFolders()
{
return _libraryManager.GetVirtualFolders(true);
}
diff --git a/Jellyfin.Api/Controllers/NotificationsController.cs b/Jellyfin.Api/Controllers/NotificationsController.cs
index f22636489..cfa7545c9 100644
--- a/Jellyfin.Api/Controllers/NotificationsController.cs
+++ b/Jellyfin.Api/Controllers/NotificationsController.cs
@@ -36,23 +36,11 @@ namespace Jellyfin.Api.Controllers
///
/// Gets a user's notifications.
///
- /// The user's ID.
- /// An optional filter by notification read state.
- /// The optional index to start at. All notifications with a lower index will be omitted from the results.
- /// An optional limit on the number of notifications returned.
/// Notifications returned.
/// An containing a list of notifications.
[HttpGet("{userId}")]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "userId", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "isRead", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "startIndex", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "limit", Justification = "Imported from ServiceStack")]
- public ActionResult GetNotifications(
- [FromRoute] string userId,
- [FromQuery] bool? isRead,
- [FromQuery] int? startIndex,
- [FromQuery] int? limit)
+ public ActionResult GetNotifications()
{
return new NotificationResultDto();
}
@@ -60,14 +48,11 @@ namespace Jellyfin.Api.Controllers
///
/// Gets a user's notification summary.
///
- /// The user's ID.
/// Summary of user's notifications returned.
/// An containing a summary of the users notifications.
[HttpGet("{userId}/Summary")]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "userId", Justification = "Imported from ServiceStack")]
- public ActionResult GetNotificationsSummary(
- [FromRoute] string userId)
+ public ActionResult GetNotificationsSummary()
{
return new NotificationsSummaryDto();
}
@@ -134,17 +119,11 @@ namespace Jellyfin.Api.Controllers
///
/// Sets notifications as read.
///
- /// The userID.
- /// A comma-separated list of the IDs of notifications which should be set as read.
/// Notifications set as read.
/// A .
[HttpPost("{userId}/Read")]
[ProducesResponseType(StatusCodes.Status204NoContent)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "userId", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "ids", Justification = "Imported from ServiceStack")]
- public ActionResult SetRead(
- [FromRoute] string userId,
- [FromQuery] string ids)
+ public ActionResult SetRead()
{
return NoContent();
}
@@ -152,17 +131,11 @@ namespace Jellyfin.Api.Controllers
///
/// Sets notifications as unread.
///
- /// The userID.
- /// A comma-separated list of the IDs of notifications which should be set as unread.
/// Notifications set as unread.
/// A .
[HttpPost("{userId}/Unread")]
[ProducesResponseType(StatusCodes.Status204NoContent)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "userId", Justification = "Imported from ServiceStack")]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "ids", Justification = "Imported from ServiceStack")]
- public ActionResult SetUnread(
- [FromRoute] string userId,
- [FromQuery] string ids)
+ public ActionResult SetUnread()
{
return NoContent();
}
diff --git a/Jellyfin.Api/Controllers/PluginsController.cs b/Jellyfin.Api/Controllers/PluginsController.cs
index 979d40119..fd48983ea 100644
--- a/Jellyfin.Api/Controllers/PluginsController.cs
+++ b/Jellyfin.Api/Controllers/PluginsController.cs
@@ -42,13 +42,11 @@ namespace Jellyfin.Api.Controllers
///
/// Gets a list of currently installed plugins.
///
- /// Optional. Unused.
/// Installed plugins returned.
/// List of currently installed plugins.
[HttpGet]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "isAppStoreEnabled", Justification = "Imported from ServiceStack")]
- public ActionResult> GetPlugins([FromRoute] bool? isAppStoreEnabled)
+ public ActionResult> GetPlugins()
{
return Ok(_appHost.Plugins.OrderBy(p => p.Name).Select(p => p.GetPluginInfo()));
}
diff --git a/Jellyfin.Api/Controllers/TvShowsController.cs b/Jellyfin.Api/Controllers/TvShowsController.cs
index bd950b39f..6738dd8c8 100644
--- a/Jellyfin.Api/Controllers/TvShowsController.cs
+++ b/Jellyfin.Api/Controllers/TvShowsController.cs
@@ -185,12 +185,10 @@ namespace Jellyfin.Api.Controllers
/// Optional. The image types to include in the output.
/// Optional. Include user data.
/// Optional. Specify one or more sort orders, comma delimeted. Options: Album, AlbumArtist, Artist, Budget, CommunityRating, CriticRating, DateCreated, DatePlayed, PlayCount, PremiereDate, ProductionYear, SortName, Random, Revenue, Runtime.
- /// Optional. Sort order: Ascending,Descending.
/// A with the episodes on success or a if the series was not found.
[HttpGet("{seriesId}/Episodes")]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status404NotFound)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "sortOrder", Justification = "Imported from ServiceStack")]
public ActionResult> GetEpisodes(
[FromRoute] string seriesId,
[FromQuery] Guid userId,
@@ -206,8 +204,7 @@ namespace Jellyfin.Api.Controllers
[FromQuery] int? imageTypeLimit,
[FromQuery] string? enableImageTypes,
[FromQuery] bool? enableUserData,
- [FromQuery] string? sortBy,
- [FromQuery] SortOrder? sortOrder)
+ [FromQuery] string? sortBy)
{
var user = _userManager.GetUserById(userId);
diff --git a/Jellyfin.Api/Controllers/UserController.cs b/Jellyfin.Api/Controllers/UserController.cs
index c1f417df5..9f8d564a7 100644
--- a/Jellyfin.Api/Controllers/UserController.cs
+++ b/Jellyfin.Api/Controllers/UserController.cs
@@ -68,17 +68,14 @@ namespace Jellyfin.Api.Controllers
///
/// Optional filter by IsHidden=true or false.
/// Optional filter by IsDisabled=true or false.
- /// Optional filter by IsGuest=true or false.
/// Users returned.
/// An containing the users.
[HttpGet]
[Authorize(Policy = Policies.DefaultAuthorization)]
[ProducesResponseType(StatusCodes.Status200OK)]
- [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "isGuest", Justification = "Imported from ServiceStack")]
public ActionResult> GetUsers(
[FromQuery] bool? isHidden,
- [FromQuery] bool? isDisabled,
- [FromQuery] bool? isGuest)
+ [FromQuery] bool? isDisabled)
{
var users = Get(isHidden, isDisabled, false, false);
return Ok(users);