Fix WebSocket disconnecting when exception is thrown during processing (#11395)

2024-04-21 18:54:42 +02:00 · 2024-04-21 18:54:42 +02:00 · 43569082f9
commit 43569082f9
parent e42325883f
1 changed files with 14 additions and 7 deletions
--- a/Emby.Server.Implementations/HttpServer/WebSocketConnection.cs
+++ b/Emby.Server.Implementations/HttpServer/WebSocketConnection.cs
@ -199,13 +199,20 @@ namespace Emby.Server.Implementations.HttpServer
            }
            else
            {
-                await OnReceive(
-                    new WebSocketMessageInfo
-                    {
-                        MessageType = stub.MessageType,
-                        Data = stub.Data?.ToString(), // Data can be null
-                        Connection = this
-                    }).ConfigureAwait(false);
+                try
+                {
+                    await OnReceive(
+                        new WebSocketMessageInfo
+                        {
+                            MessageType = stub.MessageType,
+                            Data = stub.Data?.ToString(), // Data can be null
+                            Connection = this
+                        }).ConfigureAwait(false);
+                }
+                catch (Exception exception)
+                {
+                    _logger.LogWarning(exception, "Failed to process WebSocket message");
+                }
            }
        }