michael.heier/jellyfin
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Mark where ILogger is being set to null

Browse Source
This commit is contained in:
Bond_009 2018-12-13 18:40:51 +01:00
parent 0f8b3c6347
commit 3d3ec3588b
7 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Emby.Dlna/Didl/DidlBuilder.cs
View File

@ -180,7 +180,7 @@ namespace Emby.Dlna.Didl
return _logger;
}
return null;
return null; // TODO: @bond NullLogger
}
private string GetMimeType(string input)
@ -925,7 +925,7 @@ namespace Emby.Dlna.Didl
}
catch (XmlException)
{
_logger?.LogError("Error adding xml value: {value}", name);
_logger.LogError("Error adding xml value: {value}", name);
}
}
@ -937,7 +937,7 @@ namespace Emby.Dlna.Didl
}
catch (XmlException)
{
_logger?.LogError("Error adding xml value: {value}", value);
_logger.LogError("Error adding xml value: {value}", value);
}
}

2
Emby.Dlna/PlayTo/PlayToController.cs
View File

@ -539,7 +539,7 @@ namespace Emby.Dlna.PlayTo
return _logger;
}
return null;
return null; // TODO: @bond NullLogger
}
private PlaylistItem GetPlaylistItem(BaseItem item, List<MediaSourceInfo> mediaSources, DeviceProfile profile, string deviceId, string mediaSourceId, int? audioStreamIndex, int? subtitleStreamIndex)

4
Emby.Server.Implementations/Emby.Server.Implementations.csproj
View File

@ -38,7 +38,7 @@
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
<ItemGroup>
<ItemGroup>
<EmbeddedResource Include="Localization\iso6392.txt" />
<EmbeddedResource Include="Localization\countries.json" />
<EmbeddedResource Include="Localization\Core\*.json" />
@ -46,6 +46,6 @@
<EmbeddedResource Include="TextEncoding\NLangDetect\Utils\messages.properties" />
<EmbeddedResource Include="Localization\Ratings\*.txt" />
<EmbeddedResource Include="values.txt" />
</ItemGroup>
</ItemGroup>
</Project>

2
Emby.Server.Implementations/Services/ServiceHandler.cs
View File

@ -63,7 +63,7 @@ namespace Emby.Server.Implementations.Services
if (this.RestPath == null)
{
string contentType;
// TODO: change null out
// TODO: @bond NullLogger
this.RestPath = FindMatchingRestPath(httpMethod, pathInfo, null, out contentType);
if (contentType != null)

2
MediaBrowser.Controller/Providers/DirectoryService.cs
View File

@ -27,7 +27,7 @@ namespace MediaBrowser.Controller.Providers
}
public DirectoryService(IFileSystem fileSystem)
: this(null, fileSystem) // TODO change
: this(null, fileSystem) // TODO: @bond NullLogger
{
}

2
MediaBrowser.Controller/Providers/MetadataRefreshOptions.cs
View File

@ -25,7 +25,7 @@ namespace MediaBrowser.Controller.Providers
public bool EnableRemoteContentProbe { get; set; }
public MetadataRefreshOptions(IFileSystem fileSystem)
: this(new DirectoryService(null, fileSystem)) // TODO
: this(new DirectoryService(null, fileSystem)) // TODO: @bond NullLogger
{
}

1
SocketHttpListener/Net/HttpListener.cs
View File

@ -58,6 +58,7 @@ namespace SocketHttpListener.Net
auth_schemes = AuthenticationSchemes.Anonymous;
}
// TODO: @bond NullLogger
public HttpListener(X509Certificate certificate, ICryptoProvider cryptoProvider, ISocketFactory socketFactory, INetworkManager networkManager, ITextEncoding textEncoding, IStreamHelper streamHelper, IFileSystem fileSystem, IEnvironmentInfo environmentInfo)
:this(null, certificate, cryptoProvider, socketFactory, networkManager, textEncoding, streamHelper, fileSystem, environmentInfo)
{