michael.heier/jellyfin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address comments

Browse Source
This commit is contained in:
Bond_009 2020-03-11 16:36:55 +01:00
parent bbd4860b55
commit 29cee00d2d
2 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
MediaBrowser.WebDashboard/Api/DashboardService.cs
View File

@ -101,19 +101,10 @@ namespace MediaBrowser.WebDashboard.Api
/// </summary> /// </summary>
/// <value>The HTTP result factory.</value> /// <value>The HTTP result factory.</value>
private readonly IHttpResultFactory _resultFactory; private readonly IHttpResultFactory _resultFactory;
/// <summary>
/// The _app host.
/// </summary>
private readonly IServerApplicationHost _appHost; private readonly IServerApplicationHost _appHost;
/// <summary>
/// The _server configuration manager.
/// </summary>
private readonly IServerConfigurationManager _serverConfigurationManager; private readonly IServerConfigurationManager _serverConfigurationManager;
private readonly IFileSystem _fileSystem; private readonly IFileSystem _fileSystem;
private IResourceFileManager _resourceFileManager; private readonly IResourceFileManager _resourceFileManager;
/// <summary> /// <summary>
/// Initializes a new instance of the <see cref="DashboardService" /> class. /// Initializes a new instance of the <see cref="DashboardService" /> class.
@ -163,7 +154,7 @@ namespace MediaBrowser.WebDashboard.Api
} }
} }
[SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "request")] [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "request", Justification = "Required for ServiceStack")]
public object Get(GetFavIcon request) public object Get(GetFavIcon request)
{ {
return Get(new GetDashboardResource return Get(new GetDashboardResource
@ -177,7 +168,7 @@ namespace MediaBrowser.WebDashboard.Api
/// </summary> /// </summary>
/// <param name="request">The request.</param> /// <param name="request">The request.</param>
/// <returns>System.Object.</returns> /// <returns>System.Object.</returns>
[SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "request")] [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "request", Justification = "Required for ServiceStack")]
public Task<object> Get(GetDashboardConfigurationPage request) public Task<object> Get(GetDashboardConfigurationPage request)
{ {
IPlugin plugin = null; IPlugin plugin = null;
@ -300,7 +291,7 @@ namespace MediaBrowser.WebDashboard.Api
return GetPluginPages(plugin).Select(i => new ConfigurationPageInfo(plugin, i.Item1)); return GetPluginPages(plugin).Select(i => new ConfigurationPageInfo(plugin, i.Item1));
} }
[SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "request")] [SuppressMessage("Microsoft.Performance", "CA1801:ReviewUnusedParameters", MessageId = "request", Justification = "Required for ServiceStack")]
public object Get(GetRobotsTxt request) public object Get(GetRobotsTxt request)
{ {
return Get(new GetDashboardResource return Get(new GetDashboardResource

2
jellyfin.ruleset
View File

@ -5,8 +5,6 @@
<Rule Id="SA1202" Action="Info" /> <Rule Id="SA1202" Action="Info" />
<!-- disable warning SA1204: Static members must appear before non-static members --> <!-- disable warning SA1204: Static members must appear before non-static members -->
<Rule Id="SA1204" Action="Info" /> <Rule Id="SA1204" Action="Info" />
<!-- disable warning SA1404: Code analysis suppression should have justification -->
<Rule Id="SA1404" Action="Info" />
<!-- disable warning SA1009: Closing parenthesis should be followed by a space. --> <!-- disable warning SA1009: Closing parenthesis should be followed by a space. -->
<Rule Id="SA1009" Action="None" /> <Rule Id="SA1009" Action="None" />