diff --git a/Emby.Server.Implementations/Activity/ActivityRepository.cs b/Emby.Server.Implementations/Activity/ActivityRepository.cs index ebf93fa33..d730e420a 100644 --- a/Emby.Server.Implementations/Activity/ActivityRepository.cs +++ b/Emby.Server.Implementations/Activity/ActivityRepository.cs @@ -84,19 +84,16 @@ namespace Emby.Server.Implementations.Activity using (var connection = CreateConnection(true)) { var commandText = BaseActivitySelectText; - var whereClauses = new List(); - var paramList = new List(); if (minDate.HasValue) { - whereClauses.Add("DateCreated>=?"); - paramList.Add(minDate.Value.ToDateTimeParamValue()); + whereClauses.Add("DateCreated>=@DateCreated"); } var whereTextWithoutPaging = whereClauses.Count == 0 ? - string.Empty : - " where " + string.Join(" AND ", whereClauses.ToArray()); + string.Empty : + " where " + string.Join(" AND ", whereClauses.ToArray()); if (startIndex.HasValue && startIndex.Value > 0) { @@ -122,13 +119,31 @@ namespace Emby.Server.Implementations.Activity commandText += " LIMIT " + limit.Value.ToString(_usCulture); } - var totalRecordCount = connection.Query("select count (Id) from ActivityLogEntries" + whereTextWithoutPaging, paramList.ToArray()).SelectScalarInt().First(); - var list = new List(); - foreach (var row in connection.Query(commandText, paramList.ToArray())) + using (var statement = connection.PrepareStatement(commandText)) { - list.Add(GetEntry(row)); + if (minDate.HasValue) + { + statement.TryBind("@DateCreated", minDate.Value.ToDateTimeParamValue()); + } + + foreach (var row in statement.ExecuteQuery()) + { + list.Add(GetEntry(row)); + } + } + + int totalRecordCount; + + using (var statement = connection.PrepareStatement("select count (Id) from ActivityLogEntries" + whereTextWithoutPaging)) + { + if (minDate.HasValue) + { + statement.TryBind("@DateCreated", minDate.Value.ToDateTimeParamValue()); + } + + totalRecordCount = statement.ExecuteQuery().SelectScalarInt().First(); } return new QueryResult() diff --git a/Emby.Server.Implementations/Data/SqliteItemRepository.cs b/Emby.Server.Implementations/Data/SqliteItemRepository.cs index e4ceca267..255235cc7 100644 --- a/Emby.Server.Implementations/Data/SqliteItemRepository.cs +++ b/Emby.Server.Implementations/Data/SqliteItemRepository.cs @@ -3860,7 +3860,7 @@ namespace Emby.Server.Implementations.Data whereClauses.Add("LocationType=@LocationType"); if (statement != null) { - statement.TryBind("LocationType", query.LocationTypes[0].ToString()); + statement.TryBind("@LocationType", query.LocationTypes[0].ToString()); } } } @@ -3881,7 +3881,7 @@ namespace Emby.Server.Implementations.Data whereClauses.Add("LocationType<>@ExcludeLocationTypes"); if (statement != null) { - statement.TryBind("ExcludeLocationTypes", query.ExcludeLocationTypes[0].ToString()); + statement.TryBind("@ExcludeLocationTypes", query.ExcludeLocationTypes[0].ToString()); } } }