From 1a14902da854591c4bcb8cac45315d9e85913188 Mon Sep 17 00:00:00 2001 From: Shadowghost Date: Tue, 11 Jun 2024 18:48:38 +0200 Subject: [PATCH] Apply review suggestion --- MediaBrowser.Controller/Entities/Folder.cs | 2 +- MediaBrowser.Controller/Entities/TV/Season.cs | 15 --------------- MediaBrowser.Controller/Entities/TV/Series.cs | 13 ------------- .../TV/SeriesMetadataService.cs | 3 +++ 4 files changed, 4 insertions(+), 29 deletions(-) diff --git a/MediaBrowser.Controller/Entities/Folder.cs b/MediaBrowser.Controller/Entities/Folder.cs index 235495c0c..fcb45e7e5 100644 --- a/MediaBrowser.Controller/Entities/Folder.cs +++ b/MediaBrowser.Controller/Entities/Folder.cs @@ -194,7 +194,7 @@ namespace MediaBrowser.Controller.Entities /// /// The item. /// Unable to add + item.Name. - public virtual void AddChild(BaseItem item) + public void AddChild(BaseItem item) { item.SetParent(this); diff --git a/MediaBrowser.Controller/Entities/TV/Season.cs b/MediaBrowser.Controller/Entities/TV/Season.cs index 844438257..083f12746 100644 --- a/MediaBrowser.Controller/Entities/TV/Season.cs +++ b/MediaBrowser.Controller/Entities/TV/Season.cs @@ -265,20 +265,5 @@ namespace MediaBrowser.Controller.Entities.TV return hasChanges; } - - /// - public override void AddChild(BaseItem item) - { - if (item is Episode episode) - { - episode.SeriesPresentationUniqueKey = SeriesPresentationUniqueKey; - episode.SeriesId = SeriesId; - episode.SeriesName = SeriesName; - episode.SeasonId = Id; - episode.SeasonName = Name; - } - - base.AddChild(item); - } } } diff --git a/MediaBrowser.Controller/Entities/TV/Series.cs b/MediaBrowser.Controller/Entities/TV/Series.cs index dd3df510f..6297b67e4 100644 --- a/MediaBrowser.Controller/Entities/TV/Series.cs +++ b/MediaBrowser.Controller/Entities/TV/Series.cs @@ -499,18 +499,5 @@ namespace MediaBrowser.Controller.Entities.TV return list; } - - /// - public override void AddChild(BaseItem item) - { - if (item is IHasSeries typedItem) - { - typedItem.SeriesId = Id; - typedItem.SeriesName = Name; - typedItem.SeriesPresentationUniqueKey = PresentationUniqueKey; - } - - base.AddChild(item); - } } } diff --git a/MediaBrowser.Providers/TV/SeriesMetadataService.cs b/MediaBrowser.Providers/TV/SeriesMetadataService.cs index 13aa6226e..5ede023f1 100644 --- a/MediaBrowser.Providers/TV/SeriesMetadataService.cs +++ b/MediaBrowser.Providers/TV/SeriesMetadataService.cs @@ -241,6 +241,9 @@ namespace MediaBrowser.Providers.TV series.Id + (seasonNumber ?? -1).ToString(CultureInfo.InvariantCulture) + seasonName, typeof(Season)), IsVirtualItem = false, + SeriesId = series.Id, + SeriesName = series.Name, + SeriesPresentationUniqueKey = series.GetPresentationUniqueKey() }; series.AddChild(season);