michael.heier/jellyfin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
83d2bc3f9f
jellyfin/tests/Jellyfin.Model.Tests/Dlna/StreamBuilderTests.cs

564 lines
42 KiB
C#
Raw Normal View History

StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
using System;
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
using System.Collections.Specialized;
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
using System.IO;
using System.Linq;
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
using System.Runtime.Serialization;
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
using System.Text.Json;
using System.Threading.Tasks;
using Jellyfin.Extensions.Json;
using MediaBrowser.Model.Dlna;
using MediaBrowser.Model.Dto;
using MediaBrowser.Model.Entities;
using MediaBrowser.Model.Session;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using Xunit;
Move StreamBuilderTests to correct project (#7461)
2022-03-18 21:19:02 +00:00
namespace Jellyfin.Model.Tests
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
public class StreamBuilderTests
{
[Theory]
// Chrome
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Chrome", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Chrome", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Chrome", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Chrome", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioIsExternal)] // #6450
[InlineData("Chrome", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
[InlineData("Chrome", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Transcode")]
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Chrome", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.AudioCodecNotSupported, "Transcode")]
[InlineData("Chrome", "mp4-hevc-ac3-aacDef-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.SecondaryAudioNotSupported, "Transcode")]
test: fix remux tests This partially reverts commit 2d8f7b46f11ee458fe0b31d8e1473aaaea9cf296
2023-12-19 20:21:57 +00:00
[InlineData("Chrome", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported, "Remux")] // #6450
test: discard webm from test mkvs if there is an unsupported codec (#10999) To comply 39088b5ad29cf098729c31f0be90a387df5debf6, ba877283a17f9f1ef32569669989e6d72cc571c5
2024-02-12 14:34:26 +00:00
[InlineData("Chrome", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported | TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Chrome", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// Firefox
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Firefox", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Firefox", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Firefox", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Firefox", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioIsExternal)] // #6450
[InlineData("Firefox", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
[InlineData("Firefox", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Transcode")]
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Firefox", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.AudioCodecNotSupported, "Transcode")]
[InlineData("Firefox", "mp4-hevc-ac3-aacDef-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.SecondaryAudioNotSupported, "Transcode")]
test: fix remux tests This partially reverts commit 2d8f7b46f11ee458fe0b31d8e1473aaaea9cf296
2023-12-19 20:21:57 +00:00
[InlineData("Firefox", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported, "Remux")] // #6450
test: discard webm from test mkvs if there is an unsupported codec (#10999) To comply 39088b5ad29cf098729c31f0be90a387df5debf6, ba877283a17f9f1ef32569669989e6d72cc571c5
2024-02-12 14:34:26 +00:00
[InlineData("Firefox", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported | TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Firefox", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// Safari
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("SafariNext", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)] // #6450
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
[InlineData("SafariNext", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Remux", "HLS.mp4")] // #6450
[InlineData("SafariNext", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Remux", "HLS.mp4")] // #6450
[InlineData("SafariNext", "mp4-hevc-ac3-aacExt-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Remux", "HLS.mp4")] // #6450
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// AndroidPixel
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("AndroidPixel", "mp4-h264-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("AndroidPixel", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("AndroidPixel", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("AndroidPixel", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
[InlineData("AndroidPixel", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("AndroidPixel", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// Yatse
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Yatse", "mp4-h264-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Yatse", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Yatse", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Yatse", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Yatse", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Yatse", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Yatse", "mp4-hevc-ac3-aacDef-srt-15200k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// RokuSSPlus
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("RokuSSPlus", "mp4-h264-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("RokuSSPlus", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("RokuSSPlus", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450 should be DirectPlay
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("RokuSSPlus", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("RokuSSPlus", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("RokuSSPlus", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("RokuSSPlus", "mp4-hevc-ac3-aacDef-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("RokuSSPlus", "mp4-hevc-ac3-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// JellyfinMediaPlayer
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("JellyfinMediaPlayer", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
[InlineData("JellyfinMediaPlayer", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
[InlineData("JellyfinMediaPlayer", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("JellyfinMediaPlayer", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("JellyfinMediaPlayer", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("JellyfinMediaPlayer", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("JellyfinMediaPlayer", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("JellyfinMediaPlayer", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)] // #6450
// Chrome-NoHLS
[InlineData("Chrome-NoHLS", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Chrome-NoHLS", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Chrome-NoHLS", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Chrome-NoHLS", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioIsExternal)] // #6450
[InlineData("Chrome-NoHLS", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Chrome-NoHLS", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Transcode", "http")]
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("Chrome-NoHLS", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.AudioCodecNotSupported, "Transcode", "http")]
[InlineData("Chrome-NoHLS", "mp4-hevc-ac3-aacDef-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.SecondaryAudioNotSupported, "Transcode", "http")]
test: fix remux tests This partially reverts commit 2d8f7b46f11ee458fe0b31d8e1473aaaea9cf296
2023-12-19 20:21:57 +00:00
[InlineData("Chrome-NoHLS", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported, "Remux")] // #6450
test: discard webm from test mkvs if there is an unsupported codec (#10999) To comply 39088b5ad29cf098729c31f0be90a387df5debf6, ba877283a17f9f1ef32569669989e6d72cc571c5
2024-02-12 14:34:26 +00:00
[InlineData("Chrome-NoHLS", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported | TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Chrome-NoHLS", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// TranscodeMedia
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
[InlineData("TranscodeMedia", "mp4-h264-aac-vtt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "Remux", "HLS.mp4")]
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("TranscodeMedia", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "DirectStream", "HLS.mp4")]
[InlineData("TranscodeMedia", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "Remux", "HLS.mp4")]
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
[InlineData("TranscodeMedia", "mp4-h264-ac3-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "DirectStream", "HLS.mp4")]
[InlineData("TranscodeMedia", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "Remux", "HLS.mp4")]
test: drop default flag from second audio track To test more general situation. Add another HEVC test file with old logic.
2024-02-20 18:39:15 +00:00
[InlineData("TranscodeMedia", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "DirectStream", "HLS.mp4")]
[InlineData("TranscodeMedia", "mp4-hevc-ac3-aacDef-srt-15200k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "Remux", "HLS.mp4")]
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
[InlineData("TranscodeMedia", "mkv-av1-aac-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "DirectStream", "http")]
[InlineData("TranscodeMedia", "mkv-av1-vorbis-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "Remux", "http")]
[InlineData("TranscodeMedia", "mkv-vp9-aac-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "DirectStream", "http")]
[InlineData("TranscodeMedia", "mkv-vp9-ac3-srt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "DirectStream", "http")]
[InlineData("TranscodeMedia", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.Transcode, TranscodeReason.DirectPlayError, "Remux", "http")]
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// DirectMedia
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("DirectMedia", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
[InlineData("DirectMedia", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
[InlineData("DirectMedia", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
[InlineData("DirectMedia", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
[InlineData("DirectMedia", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
[InlineData("DirectMedia", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("DirectMedia", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("DirectMedia", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("DirectMedia", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)]
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// LowBandwidth
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("LowBandwidth", "mp4-h264-aac-vtt-2600k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mp4-h264-ac3-srt-2600k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mkv-vp9-aac-srt-2600k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mkv-vp9-ac3-srt-2600k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("LowBandwidth", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
// Null
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Null", "mp4-h264-aac-vtt-2600k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mp4-h264-ac3-aac-srt-2600k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mp4-h264-ac3-srt-2600k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mp4-hevc-aac-srt-15200k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mp4-hevc-ac3-aac-srt-15200k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mkv-vp9-aac-srt-2600k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mkv-vp9-ac3-srt-2600k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
[InlineData("Null", "mkv-vp9-vorbis-vtt-2600k", null, TranscodeReason.ContainerBitrateExceedsLimit)]
Merge pull request #7537 from dmitrylyzo/fix-streambuilder (cherry picked from commit 5833c707259247338c27b1a75a175c5aba925c29) Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-15 19:29:20 +00:00
// AndroidTV
[InlineData("AndroidTVExoPlayer", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
// Tizen 3 Stereo
[InlineData("Tizen3-stereo", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-h264-dts-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-hevc-truehd-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
[InlineData("Tizen3-stereo", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)]
// Tizen 4 4K 5.1
[InlineData("Tizen4-4K-5.1", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-h264-dts-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
[InlineData("Tizen4-4K-5.1", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-hevc-truehd-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
[InlineData("Tizen4-4K-5.1", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)]
Use default instead of zero for TranscodeReason
2023-04-09 23:44:56 +00:00
public async Task BuildVideoItemSimple(string deviceName, string mediaSource, PlayMethod? playMethod, TranscodeReason why = default, string transcodeMode = "DirectStream", string transcodeProtocol = "")
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var options = await GetMediaOptions(deviceName, mediaSource);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
BuildVideoItemSimpleTest(options, playMethod, why, transcodeMode, transcodeProtocol);
}
[Theory]
// Chrome
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Chrome", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("Chrome", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Chrome", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450 <BUG: this is direct played>
[InlineData("Chrome", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Chrome", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
[InlineData("Chrome", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Transcode")]
Backport pull request #9051 from jellyfin/release-10.8.z Fix transcode reasons Original-merge: 1dea309ae4a1eb00f7f5a7d4c91a235963fd069e Merged-by: Joshua M. Boniface <joshua@boniface.me> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 19:05:37 +00:00
[InlineData("Chrome", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.AudioCodecNotSupported, "Transcode")]
test: fix remux tests This partially reverts commit 2d8f7b46f11ee458fe0b31d8e1473aaaea9cf296
2023-12-19 20:21:57 +00:00
[InlineData("Chrome", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported, "Remux")] // #6450
test: discard webm from test mkvs if there is an unsupported codec (#10999) To comply 39088b5ad29cf098729c31f0be90a387df5debf6, ba877283a17f9f1ef32569669989e6d72cc571c5
2024-02-12 14:34:26 +00:00
[InlineData("Chrome", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported | TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Chrome", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// Firefox
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Firefox", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("Firefox", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Firefox", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Firefox", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
[InlineData("Firefox", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Transcode")]
Backport pull request #9051 from jellyfin/release-10.8.z Fix transcode reasons Original-merge: 1dea309ae4a1eb00f7f5a7d4c91a235963fd069e Merged-by: Joshua M. Boniface <joshua@boniface.me> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 19:05:37 +00:00
[InlineData("Firefox", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.AudioCodecNotSupported, "Transcode")]
test: fix remux tests This partially reverts commit 2d8f7b46f11ee458fe0b31d8e1473aaaea9cf296
2023-12-19 20:21:57 +00:00
[InlineData("Firefox", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported, "Remux")] // #6450
test: discard webm from test mkvs if there is an unsupported codec (#10999) To comply 39088b5ad29cf098729c31f0be90a387df5debf6, ba877283a17f9f1ef32569669989e6d72cc571c5
2024-02-12 14:34:26 +00:00
[InlineData("Firefox", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.ContainerNotSupported | TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Firefox", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// Safari
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("SafariNext", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("SafariNext", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)] // #6450
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
[InlineData("SafariNext", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Remux", "HLS.mp4")] // #6450
[InlineData("SafariNext", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Remux", "HLS.mp4")] // #6450
[InlineData("SafariNext", "mp4-hevc-ac3-aacExt-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Remux", "HLS.mp4")] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// AndroidPixel
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("AndroidPixel", "mp4-h264-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("AndroidPixel", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("AndroidPixel", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
[InlineData("AndroidPixel", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
[InlineData("AndroidPixel", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")]
// Yatse
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Yatse", "mp4-h264-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Yatse", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Yatse", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("Yatse", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("Yatse", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Yatse", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// RokuSSPlus
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("RokuSSPlus", "mp4-h264-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("RokuSSPlus", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450 should be DirectPlay
[InlineData("RokuSSPlus", "mp4-h264-ac3-aacDef-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("RokuSSPlus", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("RokuSSPlus", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("RokuSSPlus", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
[InlineData("RokuSSPlus", "mp4-hevc-ac3-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// JellyfinMediaPlayer
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("JellyfinMediaPlayer", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
[InlineData("JellyfinMediaPlayer", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
[InlineData("JellyfinMediaPlayer", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("JellyfinMediaPlayer", "mp4-hevc-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")] // #6450
[InlineData("JellyfinMediaPlayer", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.ContainerBitrateExceedsLimit, "Transcode")] // #6450
[InlineData("JellyfinMediaPlayer", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("JellyfinMediaPlayer", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)] // #6450
[InlineData("JellyfinMediaPlayer", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)] // #6450
Merge pull request #7537 from dmitrylyzo/fix-streambuilder (cherry picked from commit 5833c707259247338c27b1a75a175c5aba925c29) Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-15 19:29:20 +00:00
// AndroidTV
[InlineData("AndroidTVExoPlayer", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("AndroidTVExoPlayer", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
// Tizen 3 Stereo
[InlineData("Tizen3-stereo", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-h264-dts-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mp4-hevc-truehd-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
[InlineData("Tizen3-stereo", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen3-stereo", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)]
// Tizen 4 4K 5.1
[InlineData("Tizen4-4K-5.1", "mp4-h264-aac-vtt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-h264-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-h264-dts-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
[InlineData("Tizen4-4K-5.1", "mp4-hevc-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mp4-hevc-truehd-srt-15200k", PlayMethod.DirectStream, TranscodeReason.AudioCodecNotSupported)]
[InlineData("Tizen4-4K-5.1", "mkv-vp9-aac-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mkv-vp9-ac3-srt-2600k", PlayMethod.DirectPlay)]
[InlineData("Tizen4-4K-5.1", "mkv-vp9-vorbis-vtt-2600k", PlayMethod.DirectPlay)]
Use default instead of zero for TranscodeReason
2023-04-09 23:44:56 +00:00
public async Task BuildVideoItemWithFirstExplicitStream(string deviceName, string mediaSource, PlayMethod? playMethod, TranscodeReason why = default, string transcodeMode = "DirectStream", string transcodeProtocol = "")
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var options = await GetMediaOptions(deviceName, mediaSource);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
options.AudioStreamIndex = 1;
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
options.SubtitleStreamIndex = options.MediaSources[0].MediaStreams.Count - 1;
var streamInfo = BuildVideoItemSimpleTest(options, playMethod, why, transcodeMode, transcodeProtocol);
Assert.Equal(streamInfo?.AudioStreamIndex, options.AudioStreamIndex);
Assert.Equal(streamInfo?.SubtitleStreamIndex, options.SubtitleStreamIndex);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
[Theory]
// Chrome
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Chrome", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
test: add more audio tests
2023-12-20 19:38:01 +00:00
[InlineData("Chrome", "mp4-h264-ac3-aac-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
[InlineData("Chrome", "mp4-h264-ac3-aacExt-srt-2600k", PlayMethod.DirectStream, TranscodeReason.AudioIsExternal)] // #6450
Backport pull request #9051 from jellyfin/release-10.8.z Fix transcode reasons Original-merge: 1dea309ae4a1eb00f7f5a7d4c91a235963fd069e Merged-by: Joshua M. Boniface <joshua@boniface.me> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 19:05:37 +00:00
[InlineData("Chrome", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.SecondaryAudioNotSupported, "Transcode")]
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// Firefox
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Firefox", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
test: add more audio tests
2023-12-20 19:38:01 +00:00
[InlineData("Firefox", "mp4-h264-ac3-aac-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
Backport pull request #9051 from jellyfin/release-10.8.z Fix transcode reasons Original-merge: 1dea309ae4a1eb00f7f5a7d4c91a235963fd069e Merged-by: Joshua M. Boniface <joshua@boniface.me> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 19:05:37 +00:00
[InlineData("Firefox", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported | TranscodeReason.SecondaryAudioNotSupported, "Transcode")]
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// Yatse
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Yatse", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
test: add more audio tests
2023-12-20 19:38:01 +00:00
[InlineData("Yatse", "mp4-h264-ac3-aac-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
fix tests
2022-10-31 12:51:06 +00:00
[InlineData("Yatse", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")] // #6450
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// RokuSSPlus
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
[InlineData("RokuSSPlus", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
[InlineData("RokuSSPlus", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")] // #6450
Merge pull request #7523 from crobibero/null-stream Allow media without streams to playback (cherry picked from commit 577325b7888c5769c9d9c329ebd40e5f388242ad) Signed-off-by: crobibero <cody@robibe.ro>
2022-04-04 11:45:45 +00:00
// no streams
[InlineData("Chrome", "no-streams", PlayMethod.Transcode, TranscodeReason.VideoCodecNotSupported, "Transcode")] // #6450
Merge pull request #7537 from dmitrylyzo/fix-streambuilder (cherry picked from commit 5833c707259247338c27b1a75a175c5aba925c29) Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-15 19:29:20 +00:00
// AndroidTV
[InlineData("AndroidTVExoPlayer", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
[InlineData("AndroidTVExoPlayer", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectPlay, (TranscodeReason)0, "Remux")]
// Tizen 3 Stereo
test: fix tizen profile
2023-12-20 19:36:25 +00:00
[InlineData("Tizen3-stereo", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
test: add more audio tests
2023-12-20 19:38:01 +00:00
[InlineData("Tizen3-stereo", "mp4-h264-ac3-aac-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
test: fix tizen profile
2023-12-20 19:36:25 +00:00
[InlineData("Tizen3-stereo", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
Merge pull request #7537 from dmitrylyzo/fix-streambuilder (cherry picked from commit 5833c707259247338c27b1a75a175c5aba925c29) Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-15 19:29:20 +00:00
// Tizen 4 4K 5.1
test: fix tizen profile
2023-12-20 19:36:25 +00:00
[InlineData("Tizen4-4K-5.1", "mp4-h264-ac3-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
test: add more audio tests
2023-12-20 19:38:01 +00:00
[InlineData("Tizen4-4K-5.1", "mp4-h264-ac3-aac-aac-srt-2600k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
test: fix tizen profile
2023-12-20 19:36:25 +00:00
[InlineData("Tizen4-4K-5.1", "mp4-hevc-ac3-aac-srt-15200k", PlayMethod.DirectStream, TranscodeReason.SecondaryAudioNotSupported, "Remux")]
Use default instead of zero for TranscodeReason
2023-04-09 23:44:56 +00:00
public async Task BuildVideoItemWithDirectPlayExplicitStreams(string deviceName, string mediaSource, PlayMethod? playMethod, TranscodeReason why = default, string transcodeMode = "DirectStream", string transcodeProtocol = "")
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var options = await GetMediaOptions(deviceName, mediaSource);
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
var streamCount = options.MediaSources[0].MediaStreams.Count;
Merge pull request #7523 from crobibero/null-stream Allow media without streams to playback (cherry picked from commit 577325b7888c5769c9d9c329ebd40e5f388242ad) Signed-off-by: crobibero <cody@robibe.ro>
2022-04-04 11:45:45 +00:00
if (streamCount > 0)
{
options.AudioStreamIndex = streamCount - 2;
options.SubtitleStreamIndex = streamCount - 1;
}
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
var streamInfo = BuildVideoItemSimpleTest(options, playMethod, why, transcodeMode, transcodeProtocol);
Assert.Equal(streamInfo?.AudioStreamIndex, options.AudioStreamIndex);
Assert.Equal(streamInfo?.SubtitleStreamIndex, options.SubtitleStreamIndex);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
private StreamInfo? BuildVideoItemSimpleTest(MediaOptions options, PlayMethod? playMethod, TranscodeReason why, string transcodeMode, string transcodeProtocol)
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
if (string.IsNullOrEmpty(transcodeProtocol))
{
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
transcodeProtocol = playMethod == PlayMethod.DirectStream ? "http" : "HLS.ts";
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
var builder = GetStreamBuilder();
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var streamInfo = builder.GetOptimalVideoStream(options);
Assert.NotNull(streamInfo);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Replace != null with is not null
2022-12-05 14:01:13 +00:00
if (playMethod is not null)
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal(playMethod, streamInfo.PlayMethod);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal(why, streamInfo.TranscodeReasons);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
var audioStreamIndexInput = options.AudioStreamIndex;
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var targetVideoStream = streamInfo.TargetVideoStream;
var targetAudioStream = streamInfo.TargetAudioStream;
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var mediaSource = options.MediaSources.First(source => source.Id == streamInfo.MediaSourceId);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
Assert.NotNull(mediaSource);
var videoStreams = mediaSource.MediaStreams.Where(stream => stream.Type == MediaStreamType.Video);
var audioStreams = mediaSource.MediaStreams.Where(stream => stream.Type == MediaStreamType.Audio);
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// TODO: Check AudioStreamIndex vs options.AudioStreamIndex
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
var inputAudioStream = mediaSource.GetDefaultAudioStream(audioStreamIndexInput ?? mediaSource.DefaultAudioStreamIndex);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
var uri = ParseUri(streamInfo);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
if (playMethod == PlayMethod.DirectPlay)
{
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected container
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
var containers = ContainerProfile.SplitValue(mediaSource.Container);
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// TODO: Test transcode too
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
// Assert.Contains(uri.Extension, containers);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected video codec (1)
Enable nullable for more files
2023-07-29 19:35:38 +00:00
Assert.Contains(targetVideoStream?.Codec, streamInfo.TargetVideoCodec);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Single(streamInfo.TargetVideoCodec);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected audio codecs (1)
Enable nullable for more files
2023-07-29 19:35:38 +00:00
Assert.Contains(targetAudioStream?.Codec, streamInfo.TargetAudioCodec);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Single(streamInfo.TargetAudioCodec);
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
// Assert.Single(val.AudioCodecs);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Investigate some TODO comments
2022-11-23 14:58:11 +00:00
if (transcodeMode.Equals("DirectStream", StringComparison.Ordinal))
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal(streamInfo.Container, uri.Extension);
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
}
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
else if (playMethod == PlayMethod.DirectStream || playMethod == PlayMethod.Transcode)
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.NotNull(streamInfo.Container);
Assert.NotEmpty(streamInfo.VideoCodecs);
Assert.NotEmpty(streamInfo.AudioCodecs);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected container (todo: this could be a test param)
Investigate some TODO comments
2022-11-23 14:58:11 +00:00
if (transcodeProtocol.Equals("http", StringComparison.Ordinal))
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// Assert.Equal("webm", val.Container);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal(streamInfo.Container, uri.Extension);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
Assert.Equal("stream", uri.Filename);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal("http", streamInfo.SubProtocol);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
Investigate some TODO comments
2022-11-23 14:58:11 +00:00
else if (transcodeProtocol.Equals("HLS.mp4", StringComparison.Ordinal))
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal("mp4", streamInfo.Container);
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
Assert.Equal("m3u8", uri.Extension);
Assert.Equal("master", uri.Filename);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal("hls", streamInfo.SubProtocol);
Fix transcode video matching and add tests for Transcode and Safari
2022-02-19 17:02:41 +00:00
}
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
else
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal("ts", streamInfo.Container);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
Assert.Equal("m3u8", uri.Extension);
Assert.Equal("master", uri.Filename);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Equal("hls", streamInfo.SubProtocol);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
// Full transcode
Investigate some TODO comments
2022-11-23 14:58:11 +00:00
if (transcodeMode.Equals("Transcode", StringComparison.Ordinal))
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
if ((streamInfo.TranscodeReasons & (StreamBuilder.ContainerReasons | TranscodeReason.DirectPlayError)) == 0)
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
Assert.All(
videoStreams,
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
stream => Assert.DoesNotContain(stream.Codec, streamInfo.VideoCodecs));
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
// TODO: fill out tests here
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
// DirectStream and Remux
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
else
{
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected video codec (1)
Enable nullable for more files
2023-07-29 19:35:38 +00:00
Assert.Contains(targetVideoStream?.Codec, streamInfo.TargetVideoCodec);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Single(streamInfo.TargetVideoCodec);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Investigate some TODO comments
2022-11-23 14:58:11 +00:00
if (transcodeMode.Equals("DirectStream", StringComparison.Ordinal))
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected audio codecs (1)
Enable nullable for more files
2023-07-29 19:35:38 +00:00
if (targetAudioStream?.IsExternal == false)
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
// Check expected audio codecs (1)
test: fix remux tests This partially reverts commit 2d8f7b46f11ee458fe0b31d8e1473aaaea9cf296
2023-12-19 20:21:57 +00:00
Assert.DoesNotContain(targetAudioStream.Codec, streamInfo.AudioCodecs);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
}
Investigate some TODO comments
2022-11-23 14:58:11 +00:00
else if (transcodeMode.Equals("Remux", StringComparison.Ordinal))
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Check expected audio codecs (1)
Enable nullable for more files
2023-07-29 19:35:38 +00:00
Assert.Contains(targetAudioStream?.Codec, streamInfo.AudioCodecs);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Single(streamInfo.AudioCodecs);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Video details
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
var videoStream = targetVideoStream;
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.False(streamInfo.EstimateContentLength);
Assert.Equal(TranscodeSeekInfo.Auto, streamInfo.TranscodeSeekInfo);
Enable nullable for more files
2023-07-29 19:35:38 +00:00
Assert.Contains(videoStream?.Profile?.ToLowerInvariant() ?? string.Empty, streamInfo.TargetVideoProfile?.Split(",").Select(s => s.ToLowerInvariant()) ?? Array.Empty<string>());
Assert.Equal(videoStream?.Level, streamInfo.TargetVideoLevel);
Assert.Equal(videoStream?.BitDepth, streamInfo.TargetVideoBitDepth);
Assert.InRange(streamInfo.VideoBitrate.GetValueOrDefault(), videoStream?.BitRate.GetValueOrDefault() ?? 0, int.MaxValue);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Audio codec not supported
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-05 20:58:21 +00:00
if ((why & TranscodeReason.AudioCodecNotSupported) != 0)
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Audio stream specified
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
if (options.AudioStreamIndex >= 0)
{
// TODO:fixme
Enable nullable for more files
2023-07-29 19:35:38 +00:00
if (targetAudioStream?.IsExternal == false)
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.DoesNotContain(targetAudioStream.Codec, streamInfo.AudioCodecs);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
}
Merge pull request #7699 from Shadowghost/streambuilder-fix (cherry picked from commit b46d61dfdf5e068a9feb26d8b41377a9fdb2cba6) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-16 00:22:13 +00:00
// Audio stream not specified
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
else
{
test: collect candidate audio streams if no audio index is specified To be consistent with the logic of StreamBuilder.
2024-02-20 18:32:54 +00:00
bool isDefault = targetAudioStream?.IsDefault == true;
var language = targetAudioStream?.Language;
// Collect candidate audio streams
var candidateAudioStreams = audioStreams.Where(stream =>
{
return isDefault ? stream.IsDefault : (stream.Language == language);
});
Assert.All(candidateAudioStreams, stream =>
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
{
if (!stream.IsExternal)
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.DoesNotContain(stream.Codec, streamInfo.AudioCodecs);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
}
});
}
}
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
}
Replace == null with is null
2022-12-05 14:00:20 +00:00
else if (playMethod is null)
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.Null(streamInfo.SubProtocol);
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
Assert.Equal("stream", uri.Filename);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
Assert.False(streamInfo.EstimateContentLength);
Assert.Equal(TranscodeSeekInfo.Auto, streamInfo.TranscodeSeekInfo);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
return streamInfo;
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
private static async ValueTask<T> TestData<T>(string name)
{
var path = Path.Join("Test Data", typeof(T).Name + "-" + name + ".json");
Removed nesting levels through block-scoped `using` statement (#10025) Co-authored-by: John Doe <john@doe> Co-authored-by: Lehonti Ramos <lehonti@ramos>
2023-09-11 10:12:40 +00:00
using var stream = File.OpenRead(path);
var value = await JsonSerializer.DeserializeAsync<T>(stream, JsonDefaults.Options);
if (value is not null)
{
return value;
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
Removed nesting levels through block-scoped `using` statement (#10025) Co-authored-by: John Doe <john@doe> Co-authored-by: Lehonti Ramos <lehonti@ramos>
2023-09-11 10:12:40 +00:00
throw new SerializationException("Invalid test data: " + name);
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
private StreamBuilder GetStreamBuilder()
{
var transcodeSupport = new Mock<ITranscoderSupport>();
var logger = new NullLogger<StreamBuilderTests>();
return new StreamBuilder(transcodeSupport.Object, logger);
}
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
private static async ValueTask<MediaOptions> GetMediaOptions(string deviceProfile, params string[] sources)
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
var mediaSources = sources.Select(src => TestData<MediaSourceInfo>(src))
.Select(val => val.Result)
.ToArray();
var mediaSourceId = mediaSources[0]?.Id;
var dp = await TestData<DeviceProfile>(deviceProfile);
Cleanup and refactor streambuilder
2022-03-26 11:11:00 +00:00
return new MediaOptions()
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
{
ItemId = new Guid("11D229B7-2D48-4B95-9F9B-49F6AB75E613"),
MediaSourceId = mediaSourceId,
MediaSources = mediaSources,
DeviceId = "test-deviceId",
Profile = dp,
Series: issue-6450 Issue: https://github.com/jellyfin/jellyfin/issues/6450 Enable DirectPlay responses Rewrite DirectPlay and DirectStream resolution Prefer copy transcode video codec options Enhance condition processor Support DirectStream and Transcode with parity Rework audio stream selection and add tests for ExternalAudio Update MediaInfoHelper to only call StreamBuilder once
2022-01-23 23:49:14 +00:00
AllowAudioStreamCopy = true,
AllowVideoStreamCopy = true,
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
};
}
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
private static (string Path, NameValueCollection Query, string Filename, string Extension) ParseUri(StreamInfo val)
{
var href = val.ToUrl("media:", "ACCESSTOKEN").Split("?", 2);
var path = href[0];
var queryString = href.ElementAtOrDefault(1);
var query = string.IsNullOrEmpty(queryString) ? System.Web.HttpUtility.ParseQueryString(queryString ?? string.Empty) : new NameValueCollection();
Move StreamBuilderTests to correct project (#7461)
2022-03-18 21:19:02 +00:00
var filename = Path.GetFileNameWithoutExtension(path);
var extension = Path.GetExtension(path);
Convert TranscodeReason to Flags
2022-01-23 16:37:52 +00:00
if (extension.Length > 0)
{
extension = extension.Substring(1);
}
return (path, query, filename, extension);
}
StreamBuilder basic tests
2022-01-10 02:53:15 +00:00
}
}
Reference in New Issue Copy Permalink