michael.heier/citadel-apps
1
0
Fork 1
mirror of https://github.com/runcitadel/apps.git synced 2024-12-26 14:44:37 +00:00
Code Issues Projects Releases Wiki Activity

Skip validation for auto-updates

Browse Source
This commit is contained in:
Aaron Dewes 2022-02-10 15:00:36 +01:00
parent 93f68e433e
commit 9fea3c5c33
1 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
lib/validate.py
View File

@ -3,26 +3,11 @@
# SPDX-License-Identifier: AGPL-3.0-only # SPDX-License-Identifier: AGPL-3.0-only
import os import os
import yaml
from jsonschema import validate
import json
# Validates app data # Validates app data
# Returns true if valid, false otherwise # Returns true if valid, false otherwise
appDir = os.path.join(os.path.dirname(os.path.realpath(__file__)), "..") appDir = os.path.join(os.path.dirname(os.path.realpath(__file__)), "..")
def validateApp(app: dict):
with open(os.path.join(appDir, 'app-standard-v1.json'), 'r') as f:
schema = json.loads(f.read())
try:
validate(app, schema)
return True
# Catch and log any errors, and return false
except Exception as e:
print(e)
return False
# Lists all folders in a directory and checks if they are valid # Lists all folders in a directory and checks if they are valid
# A folder is valid if it contains an app.yml file # A folder is valid if it contains an app.yml file
@ -35,37 +20,4 @@ def findAndValidateApps(dir: str):
app_dir = os.path.join(root, name) app_dir = os.path.join(root, name)
if os.path.isfile(os.path.join(app_dir, "app.yml")): if os.path.isfile(os.path.join(app_dir, "app.yml")):
apps.append(name) apps.append(name)
# Read the app.yml and append it to app_data
with open(os.path.join(app_dir, "app.yml"), 'r') as f:
app_data[name] = yaml.safe_load(f)
# Now validate all the apps using the validateApp function by passing the app.yml as an argument to it, if an app is invalid, remove it from the list
for app in apps:
appyml = app_data[app]
if not validateApp(appyml):
apps.remove(app)
print("Warning: App {} is invalid".format(app))
# Skip to the next iteration of the loop
continue
# More security validation
should_continue=True
if appyml['metadata']['dependencies']:
for dependency in appyml['metadata']['dependencies']:
if dependency not in apps and dependency not in ["bitcoind", "lnd", "electrum"]:
print("WARNING: App '{}' has unknown dependency '{}'".format(app, dependency))
apps.remove(app)
should_continue=False
if dependency == app:
print("WARNING: App '{}' depends on itself".format(app))
apps.remove(app)
should_continue=False
if not should_continue:
continue
for container in appyml['containers']:
if 'permissions' in container:
for permission in container['permissions']:
if permission not in appyml['metadata']['dependencies'] and permission not in ["root", "hw"]:
print("WARNING: App {}'s container '{}' requires the '{}' permission, but the app doesn't list it in it's dependencies".format(app, container['name'], permission))
apps.remove(app)
# Skip to the next iteration of the loop
continue
return apps return apps