Commit Graph

18 Commits

Author SHA1 Message Date
Jimi
daed2cbc01
Update source/utils/Subtitles.brs
Co-authored-by: Neil Burrows <neil@pawprint.co.uk>
2022-07-01 06:43:18 -06:00
Jimi
349c5894bc Crash when trying to read subtitle track for live tv. 2022-06-25 15:48:19 -06:00
Charles Ewert
9dabf4891b Add missing commas 2022-05-30 08:59:24 -04:00
cthelight
7ee5411095 Subtitles: Search by URL not assumed index
Currently, when populating subtitleTracks, we assume that the ordering
and list of populated subtitle tracks will not change when Roku moves
the list into availableSubtitleTracks. This causes an issue with some
videos as it is not always consistent.

This patch modifies the logic to no-longer inject assumed final indices
into our list of text-based subtitles, but instead search through the
availableSubtitleTracks array and locate the actual subtitle that
refers to the same URL as in our list. In this way we are guaranteed
to always tell Roku to play the subtitle we want, no matter how re-
ordered the options get.

NOTE: The URL gets mildly mangled in the process of copying from
subtitleTracks to availableSubtitleTracks, so we need so search via
substring, rather than doing a full string comparison.
2022-05-22 17:54:56 -05:00
cthelight
39dad7666c Subtitles: Auto-select default option
On other players (web/andriod app) the user perferences for
subtitle behavior are taken into account, and used to make an
assumption about subtitle behavior.

This patch ports most of that logic here. "Smart" selection is not
yet fully-featured, as it requires additional knowledge about audio
language preferences. Rather it uses the fallback mechanism, which
emulates the "Default" subtitle option.

The logic for the different options was based on the main jellyfin
repo (specifically sha 49d5fdb33fc9792147c1df03e1d1b051e6b7ec79 in
file Emby.Server.Implementations/Library/MediaStreamSelector.cs)

Additionally, this implementation specifically prefers text-based
subtitles (assuming they match the user's preference) as they are
the only ones natively supported by Roku.

Also, the subtitle changing mechanism is reworked slightly to make
use of the new implementation herein
2022-05-22 17:08:54 -05:00
Jimi
1e1b396f85 Fix to alternate version playback 2022-03-13 08:22:55 -06:00
Neil Burrows
96bd2ccada Get correct video node now that it is nested 2021-12-23 07:51:53 +00:00
Bronley
43b4ac3fc9 Format all brs files 2021-07-28 06:51:15 -04:00
Anthony Lavado
ec4177eaa3
Remove then from IF line 2021-06-28 20:17:34 -04:00
Anthony Lavado
ba1a8f649d
Merge branch 'master' into add-brightscript-linter 2021-06-28 20:15:34 -04:00
Neil Burrows
6d757653da Linter: Consistent IF statement format
No parentheses.  Use THEN if it's a one line statement.  Don't use THEN if it's a block statement
2021-06-26 14:52:16 +01:00
Neil Burrows
579475a34c Linter: Code style: remove parenthesis around conditions 2021-06-26 11:24:38 +01:00
Neil Burrows
da54bc86fe Linter: Change any function that doesn't return a value to a sub 2021-06-26 11:18:09 +01:00
Neil Burrows
38fa383b4d Linter Warnings
Variable Capitalization, Unused Variables, Unreachable Code
2021-06-26 11:04:32 +01:00
Neil Burrows
2bc6c7923d Correct typo in variable name 2021-06-26 08:09:59 +01:00
Neil Burrows
b4c09a6700 Fix incorrect selection when pressing back in subtitle dialog 2021-06-12 16:30:32 +01:00
Neil Burrows
2fd45dddc9 Move subtitle code to Subtitle.brs file 2021-06-12 16:09:41 +01:00
thomabx
14f680fb71 Allow user to change subtitle track during playback 2020-03-28 13:04:57 -07:00