Commit Graph

448 Commits

Author SHA1 Message Date
cthelight
7ee5411095 Subtitles: Search by URL not assumed index
Currently, when populating subtitleTracks, we assume that the ordering
and list of populated subtitle tracks will not change when Roku moves
the list into availableSubtitleTracks. This causes an issue with some
videos as it is not always consistent.

This patch modifies the logic to no-longer inject assumed final indices
into our list of text-based subtitles, but instead search through the
availableSubtitleTracks array and locate the actual subtitle that
refers to the same URL as in our list. In this way we are guaranteed
to always tell Roku to play the subtitle we want, no matter how re-
ordered the options get.

NOTE: The URL gets mildly mangled in the process of copying from
subtitleTracks to availableSubtitleTracks, so we need so search via
substring, rather than doing a full string comparison.
2022-05-22 17:54:56 -05:00
cthelight
39dad7666c Subtitles: Auto-select default option
On other players (web/andriod app) the user perferences for
subtitle behavior are taken into account, and used to make an
assumption about subtitle behavior.

This patch ports most of that logic here. "Smart" selection is not
yet fully-featured, as it requires additional knowledge about audio
language preferences. Rather it uses the fallback mechanism, which
emulates the "Default" subtitle option.

The logic for the different options was based on the main jellyfin
repo (specifically sha 49d5fdb33fc9792147c1df03e1d1b051e6b7ec79 in
file Emby.Server.Implementations/Library/MediaStreamSelector.cs)

Additionally, this implementation specifically prefers text-based
subtitles (assuming they match the user's preference) as they are
the only ones natively supported by Roku.

Also, the subtitle changing mechanism is reworked slightly to make
use of the new implementation herein
2022-05-22 17:08:54 -05:00
Neil Burrows
5251c46270
Merge branch 'master' into add-screen-events 2022-05-19 21:41:29 +01:00
Nick Wallace
1a1fd242f3
Favorite a Live TV Channel (#584) 2022-05-14 11:13:28 +01:00
candry7731
91ed00dd41
Add Series, Season and episode navigation (#557) 2022-05-12 19:11:59 +01:00
Neil Burrows
fac1b95497 Ensure Movie Details focus returns to button row after popup 2022-05-10 08:04:23 +01:00
Neil Burrows
ab6dc6fe39 Fix maxWidth property on ScrollingLabel 2022-05-02 07:40:00 +01:00
Neil Burrows
395b6153bb Move MPEG 2 support from system setting to user setting, and into new setting screen 2022-05-01 11:53:39 +01:00
Neil Burrows
2cf45677c6 User setting screen 2022-05-01 11:51:28 +01:00
Jimi
dde60c9fd0 Prevent crashes. 2022-04-30 07:02:03 -06:00
Jimi
10cfcabea7 Merge branch 'master' into feature/jf-478-audio-track-for-tv-shows 2022-04-26 06:27:43 -06:00
whiteowl3
be1d4a579c
Support strms (#548)
Authored-by: @whiteowl3
2022-04-26 09:12:00 +01:00
Jimi
5ffa09f602 Allow selection of different audio tracks for tv shows 2022-04-24 09:10:18 -06:00
whiteowl3
dbf2c3c5c5
add profile for .sub subtitles
otherwise they are encoded into directstreams
2022-03-29 15:54:46 -04:00
whiteowl3
1c268ff2a7 check if we can decode hevc before we say we can 2022-03-29 02:21:02 +01:00
whiteowl3
cdc7939a09
add h265/hevc to deviceCapabilities.tsVideoCodecs
fixes #513
2022-03-28 15:40:34 -04:00
Jimi
1cf1af8bc0 Formatting (gets me everytime) 2022-03-13 08:24:08 -06:00
Jimi
1e1b396f85 Fix to alternate version playback 2022-03-13 08:22:55 -06:00
Jimi
129be19a07 Merge branch 'master' into feature/531-mulitple-movie-video-streams 2022-03-13 05:49:36 -06:00
debmint
0f18add523
Movie extras (#520) 2022-03-13 08:46:03 +00:00
Jimi
ecde74cd3e Implement Version selection for Movies 2022-03-12 18:10:50 -07:00
Jimi
2d79b74fcc Merge branch 'master' into feature/211-Support-For-Photos 2022-02-13 13:53:50 -07:00
Jimi
68df29c6ca Hide overhang when viewing photos. 2022-02-06 15:37:40 -07:00
Jimi
593f863949 Cleanup and stubbed out shuffle option 2022-02-06 10:10:29 -07:00
Jimi
bc5c61a519 Initial support for photo viewing 2022-02-06 08:37:02 -07:00
Jimi
ce7e30b873 Add video and audio codec info to TV show details 2022-02-04 18:53:54 -07:00
Neil Burrows
4b87511372
Merge branch 'master' into feature/jf-roku-404-record-livetv 2022-01-20 17:41:58 +00:00
Neil Burrows
06186d8cf5
Merge branch 'master' into audio-track-selection-2 2022-01-15 17:03:01 +00:00
Neil Burrows
6525bcf83c Set appropriate Audio Stream to use for Direct Play 2022-01-15 17:02:43 +00:00
Neil Burrows
f6d9695761 Revert "Merge pull request #504 from neilsb/set-mediasourceid-correctly"
This reverts commit 0e2d621263, reversing
changes made to d5c316586b.
2022-01-09 15:55:31 +00:00
jimiatnymbl
6290a9e407 Formatting 2022-01-09 07:56:52 -07:00
jimiatnymbl
572963e28f Don't show buttons when user doesn't have access. 2022-01-08 23:31:27 -07:00
jimiatnymbl
76c96ab1e7 WIP 2022-01-08 22:43:17 -07:00
Neil Burrows
0921e26114
Merge branch 'master' into feature/save-servers 2022-01-02 16:25:42 +00:00
jimiatnymbl
611e19e030 Formatting 2021-12-29 20:55:02 -07:00
jimiatnymbl
1876dd29bd Working with new checkbox 2021-12-29 20:51:39 -07:00
jimiatnymbl
32cfd72d44 WIP 2021-12-29 18:00:13 -07:00
jimiatnymbl
450448ac96 Efficient stuff 2021-12-26 14:03:59 -07:00
jimiatnymbl
897338b9dc Fix formatting 2021-12-26 13:41:32 -07:00
jimiatnymbl
a0feb86bbf Working version 2021-12-26 13:25:58 -07:00
jimiatnymbl
2aece6ef5d WIP (added server name to saved list) 2021-12-26 11:52:43 -07:00
Cody Robibero
718ea567b8
Merge branch 'master' into feature/save-servers 2021-12-24 04:22:20 +00:00
jimiatnymbl
48c81f97d7 Formatting 2021-12-23 21:08:43 -07:00
jimiatnymbl
6a38b7b598 Working version 2021-12-23 21:07:35 -07:00
Anthony Lavado
5fedcb4fdb
Merge branch 'master' into feature/482-add-livetv-onnow 2021-12-23 18:52:25 -05:00
jimiatnymbl
c3cb43ad4d Working v1 (no username or pass) 2021-12-23 15:17:38 -07:00
Neil Burrows
a7eadeb42b Fix case of AND in IF statement 2021-12-23 07:56:57 +00:00
Neil Burrows
0aff3c46f6 Remove rale tracker comment (commited in error) 2021-12-23 07:54:46 +00:00
Neil Burrows
96bd2ccada Get correct video node now that it is nested 2021-12-23 07:51:53 +00:00
jimiatnymbl
b56bc03d90 Working v1 2021-12-17 23:03:33 -07:00