From 6d66b61f7852fb3555779b5cca393f4f30ca63ee Mon Sep 17 00:00:00 2001 From: sevenrats Date: Sat, 4 Feb 2023 13:25:39 -0500 Subject: [PATCH 1/7] adjust playback settings --- locale/en_US/translations.ts | 24 ++++++++--------- settings/settings.json | 52 ++++++++++++++++++------------------ 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/locale/en_US/translations.ts b/locale/en_US/translations.ts index 60213edb..93d50f7e 100644 --- a/locale/en_US/translations.ts +++ b/locale/en_US/translations.ts @@ -1022,28 +1022,28 @@ If enabled, the star and community rating for episodes of a TV show will be removed. This is to prevent spoilers of an upcoming good/bad episode. - Playback Bitrate Limits - Playback Bitrate Limits + Configure the maximum playback bitrate. + Configure the maximum playback bitrate. - Set limits for how high playback bitrates are allowed to be. - Set limits for how high playback bitrates are allowed to be. + Enable Limit + Enable Limit - Limits Enabled - Limits Enabled + Enable or disable the bitrate limit. + Enable or disable the bitrate limit. - If enabled, playback bitrates will be limited based on the 'Playback Bitrate Limit' setting. - If enabled, playback bitrates will be limited based on the 'Playback Bitrate Limit' setting. + Bitrate Limit + Bitrate Limit - Playback Bitrate Limit - Playback Bitrate Limit + Maximum Bitrate + Maximum Bitrate - Max bitrate (Mbps) allowed if limits are enabled. Set to 0 to use Roku's specifications. - Max bitrate (Mbps) allowed if limits are enabled. Set to 0 to use Roku's specifications. + Must be enabled to take effect. Set to 0 to use Roku's specifications. + Must be enabled to take effect. Set to 0 to use Roku's specifications. Libraries diff --git a/settings/settings.json b/settings/settings.json index 6d4b2084..26647726 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -4,15 +4,28 @@ "description": "Settings relating to playback and supported codec and media types.", "children": [ { - "title": "Cinema Mode", - "description": "Cinema Mode brings the theater experience straight to your living room with the ability to play custom intros before the main feature.", - "settingName": "playback.cinemamode", - "type": "bool", - "default": "false" + "title": "Bitrate Limit", + "description": "Configure the maximum playback bitrate.", + "children": [ + { + "title": "Enable Limit", + "description": "Enable or disable the bitrate limit.", + "settingName": "playback.bitrate.maxlimited", + "type": "bool", + "default": "true" + }, + { + "title": "Maximum Bitrate", + "description": "Must be enabled to take effect. Set to 0 to use Roku's specifications.", + "settingName": "playback.bitrate.limit", + "type": "integer", + "default": "0" + } + ] }, { "title": "Codec Support", - "description": "Enable or disable Direct Play support for certain codecs", + "description": "Enable or disable Direct Play support for certain codecs.", "children": [ { "title": "AV1", @@ -37,26 +50,6 @@ } ] }, - { - "title": "Playback Bitrate Limits", - "description": "Set limits for how high playback bitrates are allowed to be.", - "children": [ - { - "title": "Limits Enabled", - "description": "If enabled, playback bitrates will be limited based on the 'Playback Bitrate Limit' setting.", - "settingName": "playback.bitrate.maxlimited", - "type": "bool", - "default": "true" - }, - { - "title": "Playback Bitrate Limit", - "description": "Max bitrate (Mbps) allowed if limits are enabled. Set to 0 to use Roku's specifications.", - "settingName": "playback.bitrate.limit", - "type": "integer", - "default": "0" - } - ] - }, { "title": "Profile Level Support", "description": "Attempt Direct Play of potentially unsupported profile levels", @@ -77,6 +70,13 @@ } ] }, + { + "title": "Cinema Mode", + "description": "Cinema Mode brings the theater experience straight to your living room with the ability to play custom intros before the main feature.", + "settingName": "playback.cinemamode", + "type": "bool", + "default": "false" + }, { "title": "Text Subtitles Only", "description": "Only display text subtitles to minimize transcoding.", From 13ec580c20b230472801939c3ab2df70ed2ee3bd Mon Sep 17 00:00:00 2001 From: sevenrats Date: Sat, 4 Feb 2023 13:42:52 -0500 Subject: [PATCH 2/7] use imperative. --- locale/en_US/translations.ts | 4 ++-- settings/settings.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/locale/en_US/translations.ts b/locale/en_US/translations.ts index 93d50f7e..46f458e5 100644 --- a/locale/en_US/translations.ts +++ b/locale/en_US/translations.ts @@ -736,8 +736,8 @@ Option Title in user setting screen - Hides all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect. - Hides all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect. + Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect. + Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect. Settings Menu - Description for option diff --git a/settings/settings.json b/settings/settings.json index 26647726..595a2ed0 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -96,7 +96,7 @@ "children": [ { "title": "Hide Clock", - "description": "Hides all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect.", + "description": "Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect.", "settingName": "ui.design.hideclock", "type": "bool", "default": "false" From 7f9c56fe08eb17b7552a6a556c41d8b9eec776f2 Mon Sep 17 00:00:00 2001 From: sevenrats Date: Sat, 4 Feb 2023 14:09:34 -0500 Subject: [PATCH 3/7] more imperatives --- locale/en_US/translations.ts | 16 ++++++++-------- settings/settings.json | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/locale/en_US/translations.ts b/locale/en_US/translations.ts index 46f458e5..ce717d02 100644 --- a/locale/en_US/translations.ts +++ b/locale/en_US/translations.ts @@ -675,13 +675,13 @@ Settings Menu - Title for option - If enabled, selecting a TV series with only one season will go straight to the episode list rather than the show details and season list. - If enabled, selecting a TV series with only one season will go straight to the episode list rather than the show details and season list. + Go directly to the episode list if a TV series has only one season. + Go directly to the episode list if a TV series has only one season. Settings Menu - Description for option - If enabled, images of unwatched episodes will be blurred. - If enabled, images of unwatched episodes will be blurred. + Blur images of unwatched episodes. + Blur images of unwatched episodes. Screensaver @@ -726,8 +726,8 @@ Settings Menu - Title for option - Cinema Mode brings the theater experience straight to your living room with the ability to play custom intros before the main feature. - Cinema Mode brings the theater experience straight to your living room with the ability to play custom intros before the main feature. + Bring the theater experience straight to your living room with the ability to play custom intros before the main feature. + Bring the theater experience straight to your living room with the ability to play custom intros before the main feature. Settings Menu - Description for option @@ -1018,8 +1018,8 @@ Disable Community Rating for Episodes - If enabled, the star and community rating for episodes of a TV show will be removed. This is to prevent spoilers of an upcoming good/bad episode. - If enabled, the star and community rating for episodes of a TV show will be removed. This is to prevent spoilers of an upcoming good/bad episode. + Hide the star and community rating for episodes of a TV show. This is to prevent spoilers of an upcoming good/bad episode. + Hide the star and community rating for episodes of a TV show. This is to prevent spoilers of an upcoming good/bad episode. Configure the maximum playback bitrate. diff --git a/settings/settings.json b/settings/settings.json index 595a2ed0..e19be1c2 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -72,7 +72,7 @@ }, { "title": "Cinema Mode", - "description": "Cinema Mode brings the theater experience straight to your living room with the ability to play custom intros before the main feature.", + "description": "Bring the theater experience straight to your living room with the ability to play custom intros before the main feature.", "settingName": "playback.cinemamode", "type": "bool", "default": "false" @@ -218,21 +218,21 @@ "children": [ { "title": "Blur Unwatched Episodes", - "description": "If enabled, images of unwatched episodes will be blurred.", + "description": "Blur images of unwatched episodes.", "settingName": "ui.tvshows.blurunwatched", "type": "bool", "default": "false" }, { "title": "Skip Details for Single Seasons", - "description": "If enabled, selecting a TV series with only one season will go straight to the episode list rather than the show details and season list.", + "description": "Go directly to the episode list if a TV series has only one season.", "settingName": "ui.tvshows.goStraightToEpisodeListing", "type": "bool", "default": "false" }, { "title": "Disable Community Rating for Episodes", - "description": "If enabled, the star and community rating for episodes of a TV show will be removed. This is to prevent spoilers of an upcoming good/bad episode.", + "description": "Hide the star and community rating for episodes of a TV show. This is to prevent spoilers of an upcoming good/bad episode.", "settingName": "ui.tvshows.disableCommunityRating", "type": "bool", "default": "false" From 6e42b1b53e0468a3a5a1682eca450142ae02c996 Mon Sep 17 00:00:00 2001 From: sevenrats Date: Sat, 4 Feb 2023 14:10:06 -0500 Subject: [PATCH 4/7] alphabetize --- settings/settings.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/settings/settings.json b/settings/settings.json index e19be1c2..a1be24fd 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -224,16 +224,16 @@ "default": "false" }, { - "title": "Skip Details for Single Seasons", - "description": "Go directly to the episode list if a TV series has only one season.", - "settingName": "ui.tvshows.goStraightToEpisodeListing", + "title": "Disable Community Rating for Episodes", + "description": "Hide the star and community rating for episodes of a TV show. This is to prevent spoilers of an upcoming good/bad episode.", + "settingName": "ui.tvshows.disableCommunityRating", "type": "bool", "default": "false" }, { - "title": "Disable Community Rating for Episodes", - "description": "Hide the star and community rating for episodes of a TV show. This is to prevent spoilers of an upcoming good/bad episode.", - "settingName": "ui.tvshows.disableCommunityRating", + "title": "Skip Details for Single Seasons", + "description": "Go directly to the episode list if a TV series has only one season.", + "settingName": "ui.tvshows.goStraightToEpisodeListing", "type": "bool", "default": "false" } From 07e17eeb63e7b26be3ac321fa8c21c8b946e94da Mon Sep 17 00:00:00 2001 From: sevenrats Date: Sat, 4 Feb 2023 14:21:59 -0500 Subject: [PATCH 5/7] correct ambuguous bitrate unit --- locale/en_US/translations.ts | 4 ++-- settings/settings.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/locale/en_US/translations.ts b/locale/en_US/translations.ts index ce717d02..3a400e61 100644 --- a/locale/en_US/translations.ts +++ b/locale/en_US/translations.ts @@ -1042,8 +1042,8 @@ Maximum Bitrate - Must be enabled to take effect. Set to 0 to use Roku's specifications. - Must be enabled to take effect. Set to 0 to use Roku's specifications. + Set the maximum bitrate in Mbps. Set to 0 to use Roku's specifications. This setting must be enabled to take effect. + Set the maximum bitrate in Mbps. Set to 0 to use Roku's specifications. This setting must be enabled to take effect. Libraries diff --git a/settings/settings.json b/settings/settings.json index a1be24fd..6ddd1702 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -16,7 +16,7 @@ }, { "title": "Maximum Bitrate", - "description": "Must be enabled to take effect. Set to 0 to use Roku's specifications.", + "description": "Set the maximum bitrate in Mbps. Set to 0 to use Roku's specifications. This setting must be enabled to take effect.", "settingName": "playback.bitrate.limit", "type": "integer", "default": "0" From d9b7f81b5d709acae99bd43410aa3cd730b0e765 Mon Sep 17 00:00:00 2001 From: sevenrats Date: Sat, 4 Feb 2023 14:25:04 -0500 Subject: [PATCH 6/7] clarify enable limit description --- locale/en_US/translations.ts | 4 ++-- settings/settings.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/locale/en_US/translations.ts b/locale/en_US/translations.ts index 3a400e61..f10189bf 100644 --- a/locale/en_US/translations.ts +++ b/locale/en_US/translations.ts @@ -1030,8 +1030,8 @@ Enable Limit - Enable or disable the bitrate limit. - Enable or disable the bitrate limit. + Enable or disable the 'Maximum Bitrate' setting. + Enable or disable the 'Maximum Bitrate' setting. Bitrate Limit diff --git a/settings/settings.json b/settings/settings.json index 6ddd1702..cf807782 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -9,7 +9,7 @@ "children": [ { "title": "Enable Limit", - "description": "Enable or disable the bitrate limit.", + "description": "Enable or disable the 'Maximum Bitrate' setting.", "settingName": "playback.bitrate.maxlimited", "type": "bool", "default": "true" From d54b524d7ecfc030ff892f842993ac97dfca6f7e Mon Sep 17 00:00:00 2001 From: sevenrats Date: Wed, 29 Mar 2023 13:54:10 -0400 Subject: [PATCH 7/7] remove unused string and a grammar fix --- locale/en_US/translations.ts | 8 ++------ settings/settings.json | 3 +-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/locale/en_US/translations.ts b/locale/en_US/translations.ts index 3b1f7ef4..5770a363 100644 --- a/locale/en_US/translations.ts +++ b/locale/en_US/translations.ts @@ -736,8 +736,8 @@ Option Title in user setting screen - Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect. - Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect. + Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for changes to take effect. + Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for changes to take effect. Settings Menu - Description for option @@ -1036,10 +1036,6 @@ Biographical information for this person is not currently available. Biographical information for this person is not currently available. - - Playback Bitrate Limits - Playback Bitrate Limits - Enable Limit Enable Limit diff --git a/settings/settings.json b/settings/settings.json index 48024c09..0bebb738 100644 --- a/settings/settings.json +++ b/settings/settings.json @@ -92,7 +92,6 @@ "default": "30" }, { - "title": "Text Subtitles Only", "description": "Only display text subtitles to minimize transcoding.", "settingName": "playback.subs.onlytext", @@ -111,7 +110,7 @@ "children": [ { "title": "Hide Clock", - "description": "Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for change to take effect.", + "description": "Hide all clocks in Jellyfin. Jellyfin will need to be closed and reopened for changes to take effect.", "settingName": "ui.design.hideclock", "type": "bool", "default": "false"