lgladsden/jf-roku
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix maxPages off-by-one bug (#50)

Browse Source 
The `pager.maxPages` calculation currently handles the case where there
are fewer than `page_size` items to display but will cut off the final
page for any page count larger than one. This change makes the page size
the ceiling of the calculation in all cases.
This commit is contained in:
Jon Banafato 2019-07-13 00:10:54 -04:00 committed by Nick Bisby
parent 498440f2c5
commit accf8ecfa3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/ShowScenes.brs
View File

@ -243,7 +243,7 @@ sub ShowMovieOptions(library)
pager = scene.findNode("pager")
pager.currentPage = page_num
pager.maxPages = item_list.TotalRecordCount / page_size
if pager.maxPages = 0 then pager.maxPages = 1
if item_list.TotalRecordCount mod page_size > 0 then pager.maxPages += 1
pager.observeField("escape", port)
pager.observeField("pageSelected", port)
@ -403,7 +403,7 @@ sub ShowTVShowOptions(library)
pager = scene.findNode("pager")
pager.currentPage = page_num
pager.maxPages = item_list.TotalRecordCount / page_size
if pager.maxPages = 0 then pager.maxPages = 1
if item_list.TotalRecordCount mod page_size > 0 then pager.maxPages += 1
pager.observeField("escape", port)
pager.observeField("pageSelected", port)
@ -577,7 +577,7 @@ sub ShowCollections(library)
pager = scene.findNode("pager")
pager.currentPage = page_num
pager.maxPages = item_list.TotalRecordCount / page_size
if pager.maxPages = 0 then pager.maxPages = 1
if item_list.TotalRecordCount mod page_size > 0 then pager.maxPages += 1
pager.observeField("escape", port)
pager.observeField("pageSelected", port)