lgladsden/jf-roku
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1742 from 1hitsong/ellipsisTextUnify

Browse Source 
Update ellipsis text to use translation. Remove leading space
This commit is contained in:
1hitsong 2024-03-12 08:04:21 -04:00 committed by GitHub
commit 98d6c551aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
components/music/AlbumView.bs
View File

@ -14,6 +14,7 @@ sub init()
m.songList.observeField("doneLoading", "onDoneLoading")
m.dscr = m.top.findNode("overview")
m.dscr.ellipsisText = tr("... (Press * to read more)")
createDialogPallete()
end sub

2
components/music/AlbumView.xml
View File

@ -13,7 +13,7 @@
<JFButton id="instantMix" minChars="8" text="Instant Mix"></JFButton>
</LayoutGroup>
<LayoutGroup id="infoGroup" layoutDirection="vert" itemSpacings="[15]">
<Label id="overview" wrap="true" height="310" width="1250" ellipsisText=" ... (Press * to read more)" />
<Label id="overview" wrap="true" height="310" width="1250" />
<Rectangle id='songListRect' translation="[-30, 0]" width="1260" height="510" color="0x202020ff">
<AlbumTrackList itemComponentName="SongItem" id="songList" translation="[45, 25]" itemSize="[1170,60]" numRows="7" />
</Rectangle>

1
components/music/ArtistView.bs
View File

@ -39,6 +39,7 @@ sub init()
m.backDrop = m.top.findNode("backdrop")
m.artistImage = m.top.findNode("artistImage")
m.dscr = m.top.findNode("overview")
m.dscr.ellipsisText = tr("... (Press * to read more)")
m.dscr.observeField("isTextEllipsized", "onEllipsisChanged")
createDialogPallete()
end sub

2
components/music/ArtistView.xml
View File

@ -8,7 +8,7 @@
<LayoutGroup id="toplevel" layoutDirection="vert" itemSpacings="[75]">
<LayoutGroup id="main_group" layoutDirection="horiz" itemSpacings="[125]">
<LayoutGroup layoutDirection="vert" itemSpacings="[75]">
<Label id="overview" wrap="true" lineSpacing="25" maxLines="6" width="1080" ellipsisText=" ... (Press * to read more)" />
<Label id="overview" wrap="true" lineSpacing="25" maxLines="6" width="1080" />
<ButtonGroupHoriz id="buttons" itemSpacings="[20]">
<IconButton id="play" background="#070707" focusBackground="#00a4dc" padding="35" icon="pkg:/images/icons/play.png" text="Play" height="85" width="150" />
<IconButton id="instantMix" background="#070707" focusBackground="#00a4dc" padding="35" icon="pkg:/images/icons/instantMix.png" text="Instant Mix" height="85" width="150" />

1
components/music/PlaylistView.bs
View File

@ -13,6 +13,7 @@ sub init()
m.songList.observeField("doneLoading", "onDoneLoading")
m.dscr = m.top.findNode("overview")
m.dscr.ellipsisText = tr("... (Press * to read more)")
createDialogPallete()
end sub

2
components/music/PlaylistView.xml
View File

@ -12,7 +12,7 @@
<JFButton id="playAll" minChars="8" text="Play All"></JFButton>
</LayoutGroup>
<LayoutGroup id="infoGroup" layoutDirection="vert" itemSpacings="[15]">
<Label id="overview" wrap="true" height="310" width="1250" ellipsisText=" ... (Press * to read more)" />
<Label id="overview" wrap="true" height="310" width="1250" />
<Rectangle id='songListRect' translation="[-30, 0]" width="1260" height="510" color="0x202020ff">
<AlbumTrackList itemComponentName="SongItem" id="songList" translation="[45, 25]" itemSize="[1170,60]" numRows="7" />
</Rectangle>

2
components/tvshows/TVShowDetails.bs
View File

@ -14,7 +14,7 @@ sub init()
m.seasons = m.top.findNode("seasons")
m.overview = m.top.findNode("overview")
m.overview.ellipsisText = tr(" ... (Press * to read more)")
m.overview.ellipsisText = tr("... (Press * to read more)")
end sub
sub itemContentChanged()

4
locale/en_US/translations.ts
View File

@ -1252,8 +1252,8 @@
<extracomment>General use word when we want to randomize data</extracomment>
</message>
<message>
<source> ... (Press * to read more)</source>
<translation> ... (Press * to read more)</translation>
<source>... (Press * to read more)</source>
<translation>... (Press * to read more)</translation>
<extracomment>Ellipsis Text for when text overflows its container</extracomment>
</message>
</context>