From 0bee595dc3375a78aab14ffa6e80d04831cfb341 Mon Sep 17 00:00:00 2001 From: Jinho Kim Date: Thu, 26 Jan 2023 19:12:52 -0500 Subject: [PATCH] Replace global caption with JF video caption --- source/utils/Subtitles.brs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/source/utils/Subtitles.brs b/source/utils/Subtitles.brs index 4be995a5..dc153330 100644 --- a/source/utils/Subtitles.brs +++ b/source/utils/Subtitles.brs @@ -76,7 +76,8 @@ end function function setupSubtitle(video, subtitles, subtitle_idx = -1) as integer if subtitle_idx = -1 ' If we are not using text-based subtitles, turn them off - video.globalCaptionMode = "Off" + ' Turn captions on by default + video.captionVisible = True return -1 end if @@ -87,10 +88,11 @@ function setupSubtitle(video, subtitles, subtitle_idx = -1) as integer if selectedSubtitle.IsEncoded ' With encoded subtitles, turn off captions - video.globalCaptionMode = "Off" + video.captionVisible = False else ' If this is a text-based subtitle, set relevant settings for roku captions - video.globalCaptionMode = "On" + video.captionVisible = True + video.subtitleTrack = video.availableSubtitleTracks[availSubtitleTrackIdx(video, subtitleSelIdx)].TrackName end if @@ -165,8 +167,9 @@ sub changeSubtitleDuringPlayback(newid) video.control = "play" else ' Switching from text to text (or none to text) does not require stopping playback - video.globalCaptionMode = "On" video.subtitleTrack = video.availableSubtitleTracks[availSubtitleTrackIdx(video, newid)].TrackName + video.captionVisible = True + end if video.SelectedSubtitle = newid @@ -177,7 +180,7 @@ sub turnoffSubtitles() video = m.scene.focusedChild.focusedChild current = video.SelectedSubtitle video.SelectedSubtitle = -1 - video.globalCaptionMode = "Off" + video.captionVisible = False m.device.EnableAppFocusEvent(false) ' Check if Enoded subtitles are being displayed, and turn off if current > -1 and video.Subtitles[current].IsEncoded